When a command is sent as part of the error handling there
is not point whatsoever to start EH escalation when that
command fails; we are _already_ in the error handler,
and the escalation is about to commence anyway.
So just call 'scsi_try_to_abort_cmd()' to abort outstanding
commands and let the
scsi_eh_scmd_add() currently only will fail if no
error handler thread is started (which will never be the
case) or if the state machine encounters an illegal transition.
But if we're encountering an invalid state transition
chances is we cannot fixup things with the error handler.
So better add a
Hi all,
here's a small patchset for cleaning up SCSI EH.
Primary goal is to make asynchronous aborts mandatory; there hasn't
been a single report so far where asynchronous abort won't work, so
the 'no_async_abort' flag has never been used and will be removed
with this patchset.
Additionally there'
There hasn't been any reports for HBAs where asynchronous abort
would not work, so we should make it mandatory and remove
the fallback.
Signed-off-by: Hannes Reinecke
---
Documentation/scsi/scsi_eh.txt | 28 +++
drivers/scsi/scsi_error.c | 81
To detect if a failed command has been retried we must not
clear scmd->eh_eflags when EH finishes.
The flag should be persistent throughout the lifetime
of the command.
Signed-off-by: Hannes Reinecke
---
Documentation/scsi/scsi_eh.txt | 3 ---
drivers/scsi/scsi_error.c | 4 ++--
include/scs
From: Christoph Hellwig
We now first try to call ->eh_abort_handler from a work queue, but libsas
was always failing that for no good reason. Allow async aborts.
Reviewed-by: Hannes Reinecke
Signed-off-by: Christoph Hellwig
---
drivers/scsi/libsas/sas_scsi_host.c | 3 ---
1 file changed, 3 d
With commit 83ea0e5e3501 these variables became obsolete,
but weren't removed.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/device_handler/scsi_dh_alua.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c
b/drivers/scsi/device_handler/scsi_dh_alua
From: Dan Carpenter
The "> MAX_CONTEXT" should be ">= MAX_CONTEXT". Otherwise we go one
step beyond the end of the cfg->ctx_tbl[] array.
Signed-off-by: Dan Carpenter
Reviewed-by: Manoj Kumar
Acked-by: Matthew R. Ochs
Signed-off-by: Matthew R. Ochs
---
This patch was originally sent by Dan C
Hello Johannes,
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Wednesday, December 2, 2015 1:42 AM
> To: Raghava Aditya Renukunta; jbottom...@parallels.com; linux-
> s...@vger.kernel.org
> Cc: Mahesh Rajashekhara; Murthy Bhat; Santosh Akula; Gana Sridar
Hello Johannes,
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Wednesday, December 2, 2015 2:27 AM
> To: Raghava Aditya Renukunta; jbottom...@parallels.com; linux-
> s...@vger.kernel.org
> Cc: Mahesh Rajashekhara; Murthy Bhat; Santosh Akula; Gana Sridar
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
head: 54210dc420589ed7b101a6a5edcea9d9ee651512
commit: b840c3627b6f4f856b333a14a72f8ed86da2f86c [119/125] mpt3sas: Add dummy
Kconfig option for backwards compatibility
config: openrisc-allmodconfig (attached as .confi
On Tue, 2015-12-01 at 21:20 +0100, Andrea Gelmini wrote:
> Hi everybody,
>and thanks a lot for your work.
>
>As soon as I plugged an external WD USB hard drive (details in the
> attached file)
>into USB3 port, I've got this (much more info in the attached files).
>Using commit 225
Hello Johannes,
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Wednesday, December 2, 2015 2:14 AM
> To: Raghava Aditya Renukunta; jbottom...@parallels.com; linux-
> s...@vger.kernel.org
> Cc: Mahesh Rajashekhara; Murthy Bhat; Santosh Akula; Gana Sridar
Hello Johannes,
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Wednesday, December 2, 2015 2:01 AM
> To: Raghava Aditya Renukunta; jbottom...@parallels.com; linux-
> s...@vger.kernel.org
> Cc: Mahesh Rajashekhara; Murthy Bhat; Santosh Akula; Gana Sridar
> "Anil" ==writes:
Anil> Please apply the following patches to the scsi tree, misc branch
Anil> at your earliest convenience.
Series applied to 4.5/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> "Hannes" == Hannes Reinecke writes:
Hannes> Hi all, here's the first part of my ALUA device handler update.
Hannes> It's mainly bugfixes and minor improvements; the two important
Hannes> things are the addition of VPD parsing functions
Hannes> scsi_vpd_lun_id() and scsi_vpd_tpg_id(). This
Hello Johannes,
> Hi Raghava,
> On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> > From: Raghava Aditya Renukunta
> >
> > During EEH PCI hotplug activity kernel unloads and loads the driver,
> > causing character device to be unregistered(aac_remove_one).When the
> > driver i
> "James" == James Bottomley writes:
>> warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct
>> dependencies (SCSI_LOWLEVEL && PCI && SCSI)
James> That's unfortunate. The problem is that select and depend don't
James> interact because Kconfig doesn't have a SAT solver, so dep
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
head: 54210dc420589ed7b101a6a5edcea9d9ee651512
commit: b840c3627b6f4f856b333a14a72f8ed86da2f86c [119/125] mpt3sas: Add dummy
Kconfig option for backwards compatibility
config: mips-allyesconfig (attached as .config)
r
On Thu, 2015-12-03 at 05:02 +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git fixes
> head: 136dc13bf2988d987682e60558bb9b9873215f29
> commit: b840c3627b6f4f856b333a14a72f8ed86da2f86c [16/18] mpt3sas: Add dummy
> Kconfig option for backwards
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git fixes
head: 136dc13bf2988d987682e60558bb9b9873215f29
commit: b840c3627b6f4f856b333a14a72f8ed86da2f86c [16/18] mpt3sas: Add dummy
Kconfig option for backwards compatibility
config: mips-allyesconfig (attached as .config)
reprod
The suggestions look reasonable to me too.
>Arvind, since I was originally just resending your patch, do you want
>to make the changes Johannes suggests, or should I proceed with that?
> josh
Hi Josh,
Feel free to send out the updated patch if you would like.
Thanks!
Arvind
On Wed, Dec 2, 2015 at 3:42 AM, Johannes Thumshirn wrote:
> Hi Josh,
>
> On Tue, 2015-12-01 at 11:34 -0500, Josh Boyer wrote:
>> The driver is missing calls to pci_dma_mapping_error() after
>> performing the DMA mapping, which caused DMA-API warning to
>> show up in dmesg's output. Though that hap
https://bugzilla.kernel.org/show_bug.cgi?id=108771
Bug ID: 108771
Summary: scsi: ses: kasan: ses_enclosure_data_process use after
free on boot SAS2X28
Product: SCSI Drivers
Version: 2.5
Kernel Version: 4.3
Hardware: x86
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> The method to allocate and free FIB's in the present code utilizes
> spinlocks.Multiple IO's have to wait on the spinlock to acquire or
> free fibs creating a performance bottleneck.
>
> An al
Hi Raghava,
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> During EEH recovery number of online CPU's might change thereby changing
> the number of MSIx vectors. Since each fib is allocated to a vector,
> changes in the number of vectors c
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> Updated diver version to 41052
>
> Signed-off-by: Raghava Aditya Renukunta
> ---
> drivers/scsi/aacraid/aacraid.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dr
Hi Raghava,
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> During EEH PCI hotplug activity kernel unloads and loads the driver,
> causing character device to be unregistered(aac_remove_one).When the
> driver is loaded back using aac_probe_
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> Added module parameter that disables device ID wild card binding.
>
> Signed-off-by: Raghava Aditya Renukunta
> ---
> drivers/scsi/aacraid/aachba.c | 5 +
> drivers/scsi/aacraid/aacraid
Hi Raghava,
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> while driver removal is in progress or PCI shutdown is invoked, driver
> kills AIF aacraid thread, but IOCTL requests from the management tools
> re-start AIF thread leading to IOP
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> Series 7 does not support PCI hot reset used by EEH.
>
> Enabled fundamental reset only for Series 7
>
> Signed-off-by: Raghava Aditya Renukunta
> ---
> drivers/scsi/aacraid/linit.c | 6 +++
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> aac_fib_map_free() calls pci_free_consistent() without checking that
> dev->hw_fib_va is not NULL and dev->max_fib_size is not zero.If they
> are indeed NULL/0, this will result in a hang as pc
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> Added support for PCI EEH(extended error handling).
>
> Signed-off-by: Raghava Aditya Renukunta
> ---
> drivers/scsi/aacraid/aacraid.h | 1 +
> drivers/scsi/aacraid/linit.c | 138
> +
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> The driver utilizes an array of atomic variables to keep track of
> IO submissions to each vector. To submit an IO multiple threads
> iterate through the array to find a vector which has empty
Hi Raghava,
On Tue, 2015-12-01 at 04:39 -0800, Raghava Aditya Renukunta wrote:
> From: Raghava Aditya Renukunta
>
> During EEH PCI hotplug activity kernel unloads and loads the driver,
> causing character device to be unregistered(aac_remove_one).When the
> driver is loaded back using aac_probe_o
Hi Josh,
On Tue, 2015-12-01 at 11:34 -0500, Josh Boyer wrote:
> The driver is missing calls to pci_dma_mapping_error() after
> performing the DMA mapping, which caused DMA-API warning to
> show up in dmesg's output. Though that happens only when
> DMA_API_DEBUG option is enabled. This change fixes
36 matches
Mail list logo
