RE: [PATCH 09/15] megaraid_sas: Dual Queue depth support

2016-01-26 Thread Sumit Saxena
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Wednesday, January 27, 2016 7:32 AM > To: Tomas Henzl > Cc: Sumit Saxena; jbottom...@parallels.com; h...@infradead.org; > martin.peter...@oracle.com; linux-scsi@vger.kernel.org; Kashyap Desai > Subje

Re: [PATCH-v2 12/12] xen-scsiback: Convert to TARGET_SCF_ACK_KREF I/O krefs

2016-01-26 Thread Nicholas A. Bellinger
On Tue, 2016-01-26 at 10:49 +0100, Juergen Gross wrote: > On 25/01/16 09:11, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Cc: Juergen Gross > > Cc: Hannes Reinecke > > Cc: David Vrabel > > Signed-off-by: Nicholas Bellinger > > --- > > drivers/xen/xen-scsiback.c | 53 > >

Re: [PATCH-v2 11/12] xen-scsiback: Convert to percpu_ida tag allocation

2016-01-26 Thread Nicholas A. Bellinger
On Tue, 2016-01-26 at 10:45 +0100, Juergen Gross wrote: > On 25/01/16 09:11, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Cc: Juergen Gross > > Cc: Hannes Reinecke > > Cc: David Vrabel > > Signed-off-by: Nicholas Bellinger > > --- > > drivers/xen/xen-scsiback.c | 163 >

RE: [PATCH v3] mptlan: add checks for dma mapping errors

2016-01-26 Thread Sathya Prakash
There is no fusion based network card and resources exists today in Avago(LSI) to test this patch so we prefer to leave it as is. We would like to prevent any new changes on MPT (FC/SCSI/SAS/LAN) drivers as we don't have support for those cards anymore, is there a way we could remove those drivers

Re: [PATCH V3 7/9] aacraid: Fix AIF triggered IOP_RESET

2016-01-26 Thread Martin K. Petersen
> "Tomas" == Tomas Henzl writes: >> 2.Since commands are sync , place a check in aac_fib_send to block >> commands once adapter_shutdown is set(only shutdown command will be >> sent thru) Tomas> This option looks better but I guess you still can find a tiny Tomas> race window. What do you t

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-01-26 Thread Martin K. Petersen
> "Johannes" == Johannes Thumshirn writes: Johannes> This removes a redundant code block that will either be Johannes> executed if the ENABLE_FCP_RING_POLLING flag is set in Johannes> phba->cfg_poll or not. The code is just duplicated in both Johannes> cases, hence we unify it again. Johanne

Re: [PATCH v3] mptlan: add checks for dma mapping errors

2016-01-26 Thread Martin K. Petersen
> "Tomas" == Tomas Henzl writes: Tomas> Other than that - previous patch for this driver came in in 2010 Tomas> - six years ago and the driver seems unmaintained now. I'm not Tomas> sure if we should fix hw we can't test and when there is not an Tomas> user bug report. This example nicely sh

Re: [PATCH] hisi_sas: fix v1 hw check for slot error

2016-01-26 Thread Martin K. Petersen
> "John" == John Garry writes: John> Completion header bit CMPLT_HDR_RSPNS_XFRD flags whether the John> response frame is received into host memory, and not whether the John> response frame has an error. As such, change the decision on John> whether a slot has an error. Also redundant check

Re: [PATCH] hisi_sas: add dependency for HAS_IOMEM

2016-01-26 Thread Martin K. Petersen
> "John" == John Garry writes: John> Not every arch has io, so fix build by adding necessary John> dependency. Ignore previous mail. Will apply this... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body o

Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs

2016-01-26 Thread Martin K. Petersen
> "John" == John Garry writes: John> We can just add HAS_IOMEM dependency on the scsi fixes branch, ok? Yes, please submit a patch against 4.5/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the bod

Re: [PATCH, RESEND 3] qla2xxx: Remove use of 'struct timeval'

2016-01-26 Thread Martin K. Petersen
> "Arnd" == Arnd Bergmann writes: Arnd> struct register_host_info stores a 64-bit UTC system time Arnd> timestamp. This patch removes the use of 'struct timeval' to Arnd> obtain that timestamp as its tv_sec value will overflow on 32-bit Arnd> systems in year 2038 beyond. The patch uses Arnd

Re: [PATCH] scsi: export function scsi_scan.c:sanitize_inquiry_string

2016-01-26 Thread Martin K. Petersen
> "Don" == Don Brace writes: Don> It was pointed out to me by Kevin Barnett that I should also add a Don> prototype in scsi.h. Yes, please. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message

Re: [PATCH 09/15] megaraid_sas: Dual Queue depth support

2016-01-26 Thread Martin K. Petersen
> "Tomas" == Tomas Henzl writes: >> Yes this is already covered internally, there would be perf penalty >> with VDs in configuration but this feature will be turned on based on >> firmware settings and that specific firmware deployment has primary >> purpose of increasing JBOD performance. Th

Re: [PATCH 00/11] qla2xxx: Patches for scsi "misc" branch.

2016-01-26 Thread Martin K. Petersen
> "Himanshu" == Himanshu Madhani writes: Himanshu> Please apply following patches to the scsi tree, misc branch Himanshu> at your earliest convenience. Please fix kbuild warnings and repost. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send

Re: [PATCH] be2iscsi: add checks for dma mapping errors

2016-01-26 Thread Martin K. Petersen
> "Alexey" == Alexey Khoroshilov writes: Alexey> hwi_write_buffer() does not check if mapping dma memory succeed. Alexey> The patch adds the check and failure handling. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the

Re: [PATCH v4 00/17] be2iscsi: driver update 11.0.0.0

2016-01-26 Thread Martin K. Petersen
> "Jitendra" == Jitendra Bhivare writes: Applied to 4.6/scsi-queue. PATCH 12/17: "be2iscsi: Fix IOPOLL implementation" conflicted with Christoph's irq_poll changes. I fixed it up but please verify: http://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/commit/?h=4.6/scsi-queue&id=fa512e1a

Re: [PATCH] SCSI: fix crashes in sd and sr runtime PM

2016-01-26 Thread Erich Schubert
Hello Alan, Thank you: The patch appears to work for me, too. Applied on top of Debian kernel "4.4-1~exp1" I finally have a kernel boot again! (And maybe this will also make the Intel ( i7-2677M IGP) video bugs disappear...) Best regards, Erich On Wed, Jan 20, 2016 at 5:26 PM, Alan Stern wrote

RE: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

2016-01-26 Thread Seymour, Shane M
Hi Emmanuel, > Hmm in fact if we keep using MB we'll be stuck when tapes reach ~2 PB > which leaves some time to think about it, until LTO-15 circa 2036 :) There will be other issues to solve before then (by LTO-9 2 with compression or LTO-10 without compression and we're at LTO-7 now). Take tar

[Bug 111341] New: Firmware loader

2016-01-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=111341 Bug ID: 111341 Summary: Firmware loader Product: SCSI Drivers Version: 2.5 Kernel Version: 4.5_rc1 Hardware: x86-64 OS: Linux Tree: Mainline Statu

Re: mm: VM_BUG_ON_PAGE(PageTail(page)) in mbind

2016-01-26 Thread Vlastimil Babka
On 26.1.2016 21:28, Kirill A. Shutemov wrote: > From 396ad132be07a2d2b9ec5d1d6ec9fe2fffe8105e Mon Sep 17 00:00:00 2001 > From: "Kirill A. Shutemov" > Date: Tue, 26 Jan 2016 22:59:16 +0300 > Subject: [PATCH] sg: mark VMA as VM_IO to prevent migration > > Reduced testcase: > > #include >

Re: mm: VM_BUG_ON_PAGE(PageTail(page)) in mbind

2016-01-26 Thread Kirill A. Shutemov
On Tue, Jan 26, 2016 at 12:48:23PM -0800, Andrew Morton wrote: > On Tue, 26 Jan 2016 22:28:29 +0200 "Kirill A. Shutemov" > wrote: > > > The patch below fixes the issue for me, but this bug makes me wounder how > > many bugs like this we have in kernel... :-/ > > > > Looks like we are too permis

Re: mm: VM_BUG_ON_PAGE(PageTail(page)) in mbind

2016-01-26 Thread Kirill A. Shutemov
On Tue, Jan 26, 2016 at 12:49:16PM -0800, Andrew Morton wrote: > On Tue, 26 Jan 2016 22:28:29 +0200 "Kirill A. Shutemov" > wrote: > > > Let's mark the VMA as VM_IO to indicate to mm core that the VMA is > > migratable. > > > > ... > > > > --- a/drivers/scsi/sg.c > > +++ b/drivers/scsi/sg.c > >

Re: mm: VM_BUG_ON_PAGE(PageTail(page)) in mbind

2016-01-26 Thread Andrew Morton
On Tue, 26 Jan 2016 22:28:29 +0200 "Kirill A. Shutemov" wrote: > Let's mark the VMA as VM_IO to indicate to mm core that the VMA is > migratable. > > ... > > --- a/drivers/scsi/sg.c > +++ b/drivers/scsi/sg.c > @@ -1261,7 +1261,7 @@ sg_mmap(struct file *filp, struct vm_area_struct *vma) >

Re: mm: VM_BUG_ON_PAGE(PageTail(page)) in mbind

2016-01-26 Thread Andrew Morton
On Tue, 26 Jan 2016 22:28:29 +0200 "Kirill A. Shutemov" wrote: > The patch below fixes the issue for me, but this bug makes me wounder how > many bugs like this we have in kernel... :-/ > > Looks like we are too permissive about which VMA is migratable: > vma_migratable() filters out VMA by VM_

Re: mm: VM_BUG_ON_PAGE(PageTail(page)) in mbind

2016-01-26 Thread Kirill A. Shutemov
On Tue, Jan 26, 2016 at 01:52:31PM +0100, Dmitry Vyukov wrote: > Hello, > > The following program triggers the following bug: > > page:eab82240 count:0 mapcount:1 mapping:dead > index:0x0 compound_mapcount: 0 > flags: 0x1fffc00() > page dumped because: VM_BUG_ON_PAGE(P

Re: [PATCH 07/11] qla2xxx: Avoid side effects when using endianizer macros.

2016-01-26 Thread kbuild test robot
Hi Joe, [auto build test WARNING on scsi/for-next] [also build test WARNING on v4.5-rc1 next-20160125] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Madhani/qla2xxx-Remove-unneeded-l

Re: [PATCH 07/11] qla2xxx: Avoid side effects when using endianizer macros.

2016-01-26 Thread kbuild test robot
Hi Joe, [auto build test WARNING on scsi/for-next] [also build test WARNING on v4.5-rc1 next-20160125] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Madhani/qla2xxx-Remove-unneeded-l

[PATCH 00/11] qla2xxx: Patches for scsi "misc" branch.

2016-01-26 Thread Himanshu Madhani
Hi James, Martin, Please apply following patches to the scsi tree, misc branch at your earliest convenience. Thanks, - Himanshu Chad Dupuis (2): qla2xxx: Remove unneeded link offline message. qla2xxx: Set relogin flag when we fail to queue login requests. Harish Zunjarrao (2): qla2xxx: A

[PATCH 08/11] qla2xxx: Provide mbx info in BBCR data after mbx failure

2016-01-26 Thread Himanshu Madhani
From: Harish Zunjarrao Signed-off-by: Harish Zunjarrao Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_bsg.c |9 +++-- drivers/scsi/qla2xxx/qla_bsg.h |4 +++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/

[PATCH 09/11] qla2xxx: Enable T10-DIF for ISP27XX

2016-01-26 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_os.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index d94a236..fa017e9 100644 --- a/drivers/scsi/qla2xxx/qla

[PATCH 10/11] qla2xxx: Set relogin flag when we fail to queue login requests.

2016-01-26 Thread Himanshu Madhani
From: Chad Dupuis If we fail to queue an srb for an async login we should set the relogin flag so it will be retried as the reason for the queuing failure was most likely transient. Failure to do this can lead to failed paths as login is never retried if the relogin flag is not set. Signed-off-

[PATCH 07/11] qla2xxx: Avoid side effects when using endianizer macros.

2016-01-26 Thread Himanshu Madhani
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c |4 +- drivers/scsi/qla2xxx/qla_dbg.c| 141 - drivers/scsi/qla2xxx/qla_init.c | 16 ++-- drivers/scsi/qla2xxx/qla_inline.h |

[PATCH 01/11] qla2xxx: Remove unneeded link offline message.

2016-01-26 Thread Himanshu Madhani
From: Chad Dupuis Signed-off-by: Chad Dupuis Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c |1 + drivers/scsi/qla2xxx/qla_isr.c |4 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c i

[PATCH 02/11] qla2xxx: Seed init-cb login timeout from nvram exclusively.

2016-01-26 Thread Himanshu Madhani
From: Joe Carnuccio Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 52a8765..a663ff6 100644 --- a/

[PATCH 04/11] qla2xxx: Add support for online flash update for ISP27XX.

2016-01-26 Thread Himanshu Madhani
From: Sawan Chandak Signed-off-by: Sawan Chandak Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 12 - drivers/scsi/qla2xxx/qla_bsg.c | 80 ++ drivers/scsi/qla2xxx/qla_bsg.h |7 +++ drivers/scsi/qla2xxx/qla_dbg.c |2 +- d

[PATCH 03/11] qla2xxx: Allow fw to hold status before sending ABTS response.

2016-01-26 Thread Himanshu Madhani
Set bit 12 of additional firmware options 3 to let firmware hold status IOCB until ABTS response is received from Target. Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_gbl.h |1 + drivers/scsi/qla2xxx/qla_init.c | 11 ++- drivers/sc

[PATCH 11/11] qla2xxx: Update driver version to 8.07.00.33-k

2016-01-26 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 6d31faa..0bc93fa 100644 --- a/drivers/scsi/qla2xxx/qla_version.h +++ b/dr

[PATCH 06/11] qla2xxx: Add support for Private link statistics counters.

2016-01-26 Thread Himanshu Madhani
From: Harish Zunjarrao Signed-off-by: Harish Zunjarrao Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c |6 ++- drivers/scsi/qla2xxx/qla_bsg.c | 61 +++ drivers/scsi/qla2xxx/qla_bsg.h |1 + drivers/scsi/qla2xxx/qla_dbg.c |

[PATCH 05/11] qla2xxx: Add support for buffer to buffer credit value for ISP27XX.

2016-01-26 Thread Himanshu Madhani
From: Sawan Chandak Signed-off-by: Sawan Chandak Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_bsg.c | 55 drivers/scsi/qla2xxx/qla_bsg.h | 24 + drivers/scsi/qla2xxx/qla_def.h |2 + drivers/scsi/qla2xxx/qla_fw.h

Re: [PATCH-v2 3/3] target: Fix TAS handling for multi-session se_node_acls

2016-01-26 Thread Christoph Hellwig
> - if ((tmr_nacl && (tmr_nacl != cmd->se_sess->se_node_acl)) && tas) { > + if ((tmr_sess && (tmr_sess != cmd->se_sess)) && tas) { Care to drop the pointless braces here if you touch this anyway? if (tmr_sess && tmr_sess != cmd->se_sess && tas) Otherwise this looks fine to me: R

[PATCH] hisi_sas: fix v1 hw check for slot error

2016-01-26 Thread John Garry
Completion header bit CMPLT_HDR_RSPNS_XFRD flags whether the response frame is received into host memory, and not whether the response frame has an error. As such, change the decision on whether a slot has an error. Also redundant check on CMPLT_HDR_CMD_CMPLT_MSK is removed. Fixes: 27a3f229 ("hisi

Re: [PATCH-v2 2/3] target: Fix LUN_RESET active TMR descriptor handling

2016-01-26 Thread Christoph Hellwig
> + sess = cmd->se_sess; > + if (WARN_ON_ONCE(!sess)) > + continue; > + > + spin_lock(&sess->sess_cmd_lock); > spin_lock(&cmd->t_state_lock); > if (!(cmd->transport_state & CMD_T_ACTIVE)) { > s

Re: [PATCH-v2 1/3] target: Fix LUN_RESET active I/O handling for ACK_KREF

2016-01-26 Thread Christoph Hellwig
> +static bool __target_check_io_state(struct se_cmd *se_cmd) > +{ > + struct se_session *sess = se_cmd->se_sess; > + > + assert_spin_locked(&se_session->sess_cmd_lock); > + WARN_ON_ONCE(!irqs_disabled()); Btw, I looked a the code and can't really see what sess_cmd_lock is supposed to

Re: [PATCH v3] mptlan: add checks for dma mapping errors

2016-01-26 Thread Tomas Henzl
On 25.1.2016 19:02, Alexey Khoroshilov wrote: > mpt_lan_sdu_send() and mpt_lan_post_receive_buckets() do not check > if mapping dma memory succeed. > The patch adds the checks and failure handling. > > v3: Fix resource deallocation (reported by Tomas Henzl). > > Found by Linux Driver Verification p

[PATCH] hisi_sas: add dependency for HAS_IOMEM

2016-01-26 Thread John Garry
Not every arch has io, so fix build by adding necessary dependency. Signed-off-by: John Garry Suggested-by: Richard Weinberger diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig index b676618..d1dd161 100644 --- a/drivers/scsi/hisi_sas/Kconfig +++ b/drivers/scsi/hisi_sas

Re: [PATCH v4 34/78] atari_NCR5380: Use arbitration timeout

2016-01-26 Thread Geert Uytterhoeven
Hi Finn, On Tue, Jan 26, 2016 at 1:18 AM, Finn Thain wrote: > On Mon, 25 Jan 2016, Geert Uytterhoeven wrote: >> > In principle I think that Linux drivers should not carry workarounds >> > for emulators. >> >> Please consider ARAnyM is the current m68k workhorse, so it would be >> nice to handle t

Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs

2016-01-26 Thread John Garry
On 26/01/2016 10:31, Richard Weinberger wrote: Am 26.01.2016 um 11:15 schrieb John Garry: On 25/01/2016 22:24, Richard Weinberger wrote: Not every arch has io or DMA memory. So, unbreak the build by fixing the dependencies. Signed-off-by: Richard Weinberger --- drivers/scsi/hisi_sas/Kconfi

Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs

2016-01-26 Thread Richard Weinberger
Am 26.01.2016 um 11:15 schrieb John Garry: > On 25/01/2016 22:24, Richard Weinberger wrote: >> Not every arch has io or DMA memory. >> So, unbreak the build by fixing the dependencies. >> >> Signed-off-by: Richard Weinberger >> --- >> drivers/scsi/hisi_sas/Kconfig | 1 + >> 1 file changed, 1 in

Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs

2016-01-26 Thread John Garry
On 25/01/2016 22:24, Richard Weinberger wrote: Not every arch has io or DMA memory. So, unbreak the build by fixing the dependencies. Signed-off-by: Richard Weinberger --- drivers/scsi/hisi_sas/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/hisi_sas/Kconfig b/driver

Re: [PATCH-v2 12/12] xen-scsiback: Convert to TARGET_SCF_ACK_KREF I/O krefs

2016-01-26 Thread Juergen Gross
On 25/01/16 09:11, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Cc: Juergen Gross > Cc: Hannes Reinecke > Cc: David Vrabel > Signed-off-by: Nicholas Bellinger > --- > drivers/xen/xen-scsiback.c | 53 > +++--- > 1 file changed, 26 insert

Re: [PATCH-v2 02/12] target: Convert demo-mode only drivers to target_alloc_session

2016-01-26 Thread Juergen Gross
On 25/01/16 09:10, Nicholas A. Bellinger wrote: > From: Christoph Hellwig > > Cc: Christoph Hellwig > Cc: Hannes Reinecke > Cc: Chris Boot > Cc: Sebastian Andrzej Siewior > Cc: Andrzej Pietrasiewicz > Cc: Juergen Gross > Signed-off-by: Nicholas Bellinger > --- > drivers/target/loopback/tc

Re: [PATCH-v2 11/12] xen-scsiback: Convert to percpu_ida tag allocation

2016-01-26 Thread Juergen Gross
On 25/01/16 09:11, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Cc: Juergen Gross > Cc: Hannes Reinecke > Cc: David Vrabel > Signed-off-by: Nicholas Bellinger > --- > drivers/xen/xen-scsiback.c | 163 > - > 1 file changed, 87 insert