Re: [LSF/MM ATTEND] Online Logical Head Depop and SMR disks chunked writepages

2016-02-22 Thread Damien Le Moal
>On 02/22/16 18:56, Damien Le Moal wrote: >> 2) Write back of dirty pages to SMR block devices: >> >> Dirty pages of a block device inode are currently processed using the >> generic_writepages function, which can be executed simultaneously >> by multiple contexts (e.g sync, fsync, msync,

Re: [LSF/MM ATTEND] Online Logical Head Depop and SMR disks chunked writepages

2016-02-22 Thread Bart Van Assche
On 02/22/16 18:56, Damien Le Moal wrote: 2) Write back of dirty pages to SMR block devices: Dirty pages of a block device inode are currently processed using the generic_writepages function, which can be executed simultaneously by multiple contexts (e.g sync, fsync, msync, sync_file_range,

Re: why is blk-mq requeue foricbly kicking stopped queues? [was: Re: dm-multipath test scripts]

2016-02-22 Thread Junichi Nomura
On 02/23/16 00:09, Mike Snitzer wrote: > I should note that I applied this patch for 4.6: > https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.6=7db905b3d4294e5db4c2938fb7d0e5ba4bd798d6 > > (but it was purely a fallout of code-review, and looking at the nvme's

Re: [Announce] sg3_utils-1.42 available

2016-02-22 Thread Bart Van Assche
On 02/18/2016 11:52 AM, Douglas Gilbert wrote: On 16-02-17 11:59 PM, Douglas Gilbert wrote: sg3_utils is a package of command line utilities for sending SCSI and some ATA commands to devices. This package targets the Linux 4, 3, 2.6 and 2.4 kernel series. It has ports to FreeBSD, Tru64,

Re: NULL pointer dereference: IP: [] sr_runtime_suspend+0xc/0x20 [sr_mod]

2016-02-22 Thread Alexandre Rossi
Hello, >> > As this is Linux 4.3 and not 4.4, I guess this is a different problem >> > though. Alexandre, where you able to capture the stack trace? I’d submit >> > a new bug report with this. >> >> Here is a photo. Please ping me if you need to test some debugging patches. > > It looks like the

[PATCH 2/6] ncr5380: Dont release lock for PIO transfer

2016-02-22 Thread Finn Thain
The calls to NCR5380_transfer_pio() for DATA IN and DATA OUT phases will modify cmd->SCp.this_residual, cmd->SCp.ptr and cmd->SCp.buffer. That works as long as EH does not intervene, which became possible in atari_NCR5380.c when I changed the locking to bring it closer to NCR5380.c. If error

[PATCH 3/6] ncr5380: Dont re-enter NCR5380_select()

2016-02-22 Thread Finn Thain
Calling NCR5380_select() from the abort handler causes various problems. Firstly, it means potentially re-entering NCR5380_select(). Secondly, it means that the lock is released, which permits the EH handlers to be re-entered. The combination results in crashes. Don't do it. Fixes: 8b00c3d5d40d

[PATCH 4/6] ncr5380: Forget aborted commands

2016-02-22 Thread Finn Thain
The list structures and related logic used in the NCR5380 driver mean that a command cannot be queued twice (i.e. can't appear on more than one queue and can't appear on the same queue more than once). The abort handler must forget the command so that the mid-layer can re-use it. E.g. the ML may

[PATCH 1/6] ncr5380: Correctly clear command pointers and lists after bus reset

2016-02-22 Thread Finn Thain
Commands subject to exception handling are to be returned to the scsi mid-layer. Make sure that the various command pointers and command lists in the low-level driver are correctly cleansed of affected commands. This fixes some bugs that I accidentally introduced in v4.5-rc1 including the removal

[PATCH 0/6] ncr5380: Exception handling fixes for v4.5

2016-02-22 Thread Finn Thain
These patches fix some exception handling and autosense bugs that I accidentally introduced in v4.5-rc1. The error recovery and autosense code in these drivers has been unstable for a long time. Despite that, v4.5-rc1 shows a regression in as much as it exposes a bug in the aranym emulator. This

[PATCH 5/6] ncr5380: Fix NCR5380_select() EH checks and result handling

2016-02-22 Thread Finn Thain
Add missing checks for EH abort during arbitration and selection. Rework the handling of NCR5380_select() result to improve clarity. Fixes: 707d62b37fbb ("ncr5380: Fix EH during arbitration and selection") Tested-by: Michael Schmitz Signed-off-by: Finn Thain

[PATCH 6/6] ncr5380: Call scsi_eh_prep_cmnd() and scsi_eh_restore_cmnd() as and when appropriate

2016-02-22 Thread Finn Thain
This bug causes the wrong command to have its sense pointer overwritten, which sometimes leads to a NULL pointer deref. Fix this by checking which command is being requeued before restoring the scsi_eh_save data. It turns out that some targets will disconnect a REQUEST SENSE command. The

Re: [PATCH] ncr5380: Don't re-enter NCR5380_select() when aborting a command

2016-02-22 Thread Finn Thain
Please ignore this patch. It isn't sufficient to fix the problem. I'll send another patch that does fix it. On Tue, 26 Jan 2016, Finn Thain wrote: > Fixes: 707d62b37fbb ("ncr5380: Fix EH during arbitration and selection") > Signed-off-by: Finn Thain > > --- >

Re: [PATCHv8 20/23] scsi: Add 'access_state' attribute

2016-02-22 Thread Bart Van Assche
On 02/21/16 22:59, Hannes Reinecke wrote: The main reason why I need the 'access_state' attribute is to decouple the multipath daemon; at the moment the multipath daemon has to issue REPORT TARGET PORT GROUPS frequently to figure out the status, which is causing quite some load on the target.

why is blk-mq requeue foricbly kicking stopped queues? [was: Re: dm-multipath test scripts]

2016-02-22 Thread Mike Snitzer
On Mon, Feb 22 2016 at 4:51am -0500, Junichi Nomura wrote: > On 02/20/16 15:12, Mike Snitzer wrote: > > On Fri, Feb 19 2016 at 2:42pm -0500, Mike Snitzer > > wrote: > >> Have you been running with blk-mq? > >> Either by setting CONFIG_DM_MQ_DEFAULT

[v2 PATCH 3/3] scsi:stex.c Add S3/S4 support

2016-02-22 Thread Charles Chiou
From: Charles Add S3/S4 support, add .suspend and .resume function in pci_driver. In .suspend handler, driver send S3/S4 signal to the device. Signed-off-by: Charles Chiou Reviewed-by: Johannes Thumshirn ---

[v2 PATCH 2/3] scsi:stex.c Add hotplug support

2016-02-22 Thread Charles Chiou
From: Charles 1. Add hotplug support. Pegasus support surprise removal. To this end, I use return_abnormal_state function to return DID_NO_CONNECT for all commands which sent to driver. 2. Remove stex_hba_stop in stex_remove because we cannot send command

[v2 PATCH 1/3] scsi:stex.c Support to Pegasus series.

2016-02-22 Thread Charles Chiou
From: Charles Pegasus is a high performace hardware RAID solution designed to unleash the raw power of Thunderbolt technology. 1. Add code to distinct SuperTrack and Pegasus series by sub device ID. It should support backward compatibility. 2. Change the driver

RE: [PATCH 0/2][RESEND] scsi_transport_fc: LUN masking

2016-02-22 Thread Seymour, Shane M
Hi Hannes, How do you know that a request for an async scan is complete (I'm assuming that you get add or change udev events)? Assuming that someone has manually started a scan on something (e.g. some newly presented devices after boot) and all scans are going to be async how do you when it is

RE: [Bug 111441] New: iscsi fails to attach to targets

2016-02-22 Thread Serguei Bezverkhi (sbezverk)
Hello Hannes, Thank you for your reply. I am on 4.4.2 kernel, is there any chance to commit it in 4.4 as well? If not, could you send me diff for 4.4 kernel. Best regards Serguei Serguei Bezverkhi, TECHNICAL LEADER.SERVICES Global SP Services sbezv...@cisco.com Phone: +1 416 306 7312 Mobile: 

[Bug 111441] iscsi fails to attach to targets

2016-02-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=111441 --- Comment #18 from Serguei Bezverkhi --- Hello Hannes, Thank you for your reply. I am on 4.4.2 kernel, is there any chance to commit it in 4.4 as well? If not, could you send me diff for 4.4 kernel. Best regards Serguei

Re: [PATCH 5/6] hisi_sas: add hisi_sas_slave_configure()

2016-02-22 Thread John Garry
I would like to make another point about why I am making this change in case it is not clear. The queue full events are form TRANS_TX_CREDIT_TIMEOUT_ERR and TRANS_TX_CLOSE_NORMAL_ERR errors in the slot: I want the slot retried when this occurs, so I set status as SAS_QUEUE_FULL just so we will

Re: dm-multipath test scripts

2016-02-22 Thread Junichi Nomura
On 02/20/16 15:12, Mike Snitzer wrote: > On Fri, Feb 19 2016 at 2:42pm -0500, Mike Snitzer wrote: >> Have you been running with blk-mq? >> Either by setting CONFIG_DM_MQ_DEFAULT or: >> echo Y > /sys/module/dm_mod/parameters/use_blk_mq >> >> I'm seeing test_02_sdev_delete fail