Re: [LSF/MM TOPIC] multiqueue and interrupt assignment

On Wed, Feb 3, 2016 at 11:03 PM, Hannes Reinecke wrote: > On 02/03/2016 02:32 PM, Sagi Grimberg wrote: >> >>> Indeed, something like this. >>> Quite some issues would be solved if we could push a hctx mapping >>> into blk-mq, instead of having it assign its own made-up one. >> >>

Re: [PATCH v5 04/15] scsi: ufs: verify hba controller hce reg value

On 03/01/2016 09:32 PM, yga...@codeaurora.org wrote: >> On 02/28/2016 09:32 PM, Yaniv Gardi wrote: >>> Sometimes due to hw issues it takes some time to the >>> host controller register to update. In order to verify the register >>> has updated, a polling is done until its value is set. >>> >>> In

Re: [PATCH v5 03/15] scsi: ufs: implement scsi host timeout handler

On 03/01/2016 09:25 PM, yga...@codeaurora.org wrote: >> On 02/28/2016 09:32 PM, Yaniv Gardi wrote: >>> A race condition exists between request requeueing and scsi layer >>> error handling: >>> When UFS driver queuecommand returns a busy status for a request, >>> it will be requeued and its tag

[PATCHv2 6/6] scsi_sysfs: call 'device_add' after attaching device handler

'device_add' will be evaluating the 'is_visible' callback when creating the sysfs attributes. As by this time the device handler has not been attached the 'access_state' attribute will never be visible. This patch moves the code around so that the device handler is present by the time

[PATCHv2 3/6] scsi_dh_alua: update 'access_state' field

Track attached SCSI devices and update the 'access_state' field whenever an ALUA state change has been detected. Reviewed-by: Bart Van Assche Reviewed-by: Ewan Milne Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke

[PATCHv2 0/6] SCSI 'access_state' attribute

Hi all, here's the patchset to add an 'access_state' and 'preferred_path' attribute. It will display the access state of a path if a hardware handler is attached. The access_state is given in terms of SCSI ALUA, and the vendor-specific access state (eg for rdac or alua) are mapped onto the ALUA

[PATCHv2 5/6] scsi_dh_emc: update 'access_state' field

Update the 'access_state' field of the SCSI device whenever the path state changes. Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_emc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCHv2 4/6] scsi_dh_rdac: update 'access_state' field

Track attached SCSI devices and update the 'access_state' whenever the path state of the device changes. Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_rdac.c | 38 -- 1 file changed,

[PATCHv2 2/6] scsi_dh_alua: use common definitions for ALUA state

scsi_proto.h now contains definitions for the ALUA state, so we don't have to carry them in the device handler. Reviewed-by: Bart van Assche Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke ---

[PATCHv2 1/6] scsi: Add 'access_state' and 'preferred_path' attribute

Add an 'access_state' field to struct scsi_device and display them in sysfs as 'access_state' and 'preferred_path' attribute. Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_sysfs.c | 74

[PATCHv2] scsi_sysfs: add 'is_bin_visible' callback

Add 'is_bin_visible' callback to blank out unsupported vpd pages. Reviewed-by: Shane Seymour Reviewed-by: Johannes Thumshirn Signed-off-by: Hannes Reinecke diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index

[PATCH] sg: fix dxferp in from_to case

This patch is in response to this report: http://www.spinics.net/lists/linux-scsi/msg93456.html One of the strange things that the original sg driver did was let the user provide both a data-out buffer (it followed the sg_header+cdb) _and_ specify a reply length greater than zero. What

[added to the 3.18 stable tree] qla2xxx: Use pci_enable_msix_range() instead of pci_enable_msix()

From: Quinn Tran This patch has been added to the 3.18 stable tree. If you have any objections, please let us know. === [ Upstream commit 84e32a06f4f8756ce9ec3c8dc7e97896575f0771 ] As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix()

[added to the 4.1 stable tree] qla2xxx: Use pci_enable_msix_range() instead of pci_enable_msix()

From: Quinn Tran This patch has been added to the 4.1 stable tree. If you have any objections, please let us know. === [ Upstream commit 84e32a06f4f8756ce9ec3c8dc7e97896575f0771 ] As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix()

Re: [PATCH v9 3/3] add support for DWC UFS Host Controller

On Wednesday 02 March 2016 16:46:47 Joao Pinto wrote: > On 2/19/2016 3:03 PM, Arnd Bergmann wrote: > > On Thursday 18 February 2016 17:20:27 Joao Pinto wrote: > >> diff --git a/Documentation/devicetree/bindings/ufs/ufs-dwc.txt > >> b/Documentation/devicetree/bindings/ufs/ufs-dwc.txt > > Please

Re: aicasm: fix kbuild for separated build directories

On Wed, 2016-03-02 at 17:25 +0100, Michal Marek wrote: > On 2016-03-02 17:17, James Bottomley wrote: > > On Thu, 2016-02-18 at 00:46 +0100, Michal Marek wrote: > > > On Fri, Feb 12, 2016 at 02:42:26PM -0800, James Bottomley wrote: > > > > I've recently been experimenting with building in emulated

Re: [PATCH v9 3/3] add support for DWC UFS Host Controller

Hi Arnd, On 2/19/2016 3:03 PM, Arnd Bergmann wrote: > On Thursday 18 February 2016 17:20:27 Joao Pinto wrote: >> >> Documentation/devicetree/bindings/ufs/ufs-dwc.txt | 19 + >> MAINTAINERS | 6 + >> drivers/scsi/ufs/Kconfig | 51

Re: aicasm: fix kbuild for separated build directories

On 2016-03-02 17:17, James Bottomley wrote: > On Thu, 2016-02-18 at 00:46 +0100, Michal Marek wrote: >> On Fri, Feb 12, 2016 at 02:42:26PM -0800, James Bottomley wrote: >>> I've recently been experimenting with building in emulated >>> architecture containers which allow me to build natively on

Re: aicasm: fix kbuild for separated build directories

On Thu, 2016-02-18 at 00:46 +0100, Michal Marek wrote: > On Fri, Feb 12, 2016 at 02:42:26PM -0800, James Bottomley wrote: > > I've recently been experimenting with building in emulated > > architecture containers which allow me to build natively on my > > laptop a kernel for any architecture

[PATCH 00/14] drivers: use __maybe_unused to hide pm functions

I found many variations of the bug in these device drivers (and some USB drivers I already send patches for in a separate series). In each case, the power management operations structure conditionally references suspend/resume functions, but the functions are hidden in an incorrect #ifdef or not

[PATCH 08/14] scsi: mvumi: use __maybe_unused to hide pm functions

The mvumi scsi hides the references to its suspend/resume functions in an #ifdef but does not hide the implementation the same way: drivers/scsi/mvumi.c:2632:12: error: 'mvumi_suspend' defined but not used [-Werror=unused-function] drivers/scsi/mvumi.c:2651:12: error: 'mvumi_resume' defined but

Re: [RFC 24/34] iscsi-target: validate conn operational parameters

On Tue, Mar 01, 2016 at 08:33:18PM +0530, Christoph Hellwig wrote: > On Sun, Feb 14, 2016 at 11:15:31PM +0530, Varun Prakash wrote: > > call validate params function if registered > > by transport driver before starting negotiation, > > so that transport driver can validate and update > > the

Re: [RFC 21/34] iscsi-target: release transport driver resources

On Tue, Mar 01, 2016 at 08:29:53PM +0530, Christoph Hellwig wrote: > On Sun, Feb 14, 2016 at 11:12:15PM +0530, Varun Prakash wrote: > > transport driver may allocate resources for an > > iSCSI cmd, to free that resources iscsi target > > must call release function registered by transport > >

Re: [RFC 15/34] iscsi-target: export symbols from iscsi_target.c

On Tue, Mar 01, 2016 at 08:19:48PM +0530, Christoph Hellwig wrote: > On Sun, Feb 14, 2016 at 11:12:09PM +0530, Varun Prakash wrote: > > export symbols from iscsi_target.c for > > ISCSI_TCP_CXGB4 transport driver. > > What exactly is the reason for the split between this and the previous > patch?

Re: [RFC 14/34] iscsi-target: export symbols

On Tue, Mar 01, 2016 at 08:19:21PM +0530, Christoph Hellwig wrote: > This looks like pretty random exports and not something like a well > defined interface to me :( I have exported functions which works on iscsi-target data structures and can be reused by offload drivers. -- To unsubscribe from

Re: [RFC 13/34] iscsi-target: add new transport type

On Tue, Mar 01, 2016 at 08:18:48PM +0530, Christoph Hellwig wrote: > This really looks like an odd interface. I think everyone will > be much happpier in the long run if you do a generic offload interface > instead of special casing each possible driver. Common offload transport type is a better

Re: [RFC 12/34] cxgb4: update Kconfig and Makefile

On Tue, Mar 01, 2016 at 08:17:06PM +0530, Christoph Hellwig wrote: > > +config CHELSIO_T4_UWIRE > > + bool "Unified Wire Support for Chelsio T5 cards" > > + default n > > + depends on CHELSIO_T4 > > + ---help--- > > + Enable unified-wire offload features. > > + Say Y here if you

[patch] tcm_loop: use after free on error

We dereference "tl_nexus" to get the error code. Fixes: 1b418a8fcbc0 ('target: Convert demo-mode only drivers to target_alloc_session') Signed-off-by: Dan Carpenter diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c index

Re: [PATCH 1/2] scsi_transport_fc: implement 'disable_target_scan' module parameter

On 03/02/2016 05:18 PM, Christoph Hellwig wrote: > On Wed, Mar 02, 2016 at 01:59:39PM +0800, Hannes Reinecke wrote: >> Main reasons being that >> a) it's most commonly on FC where you end up having thousands of LUNs; >> SAS domains are of finite size and you'd need to string quite a few SAS >>

Re: [PATCH][RESEND] scsi_sysfs: add 'is_bin_visible' callback

On 03/02/2016 05:19 PM, Christoph Hellwig wrote: > On Wed, Mar 02, 2016 at 03:33:14PM +0800, Hannes Reinecke wrote: + rcu_read_lock(); + if (attr == _attr_vpd_pg80 && + !rcu_dereference(sdev->vpd_pg80)) { + rcu_read_unlock(); + return 0; + }

Re: [PATCH v1 2/3] PM / sleep: try to runtime suspend for direct complete

On 2 March 2016 at 09:31, dbasehore . wrote: > > On Mar 1, 2016 12:41, "Ulf Hansson" wrote: >> >> On 25 February 2016 at 01:11, Derek Basehore >> wrote: >> > This tries to runtime suspend devices that are still active for

Re: [PATCH][RESEND] scsi_sysfs: add 'is_bin_visible' callback

On Wed, Mar 02, 2016 at 03:33:14PM +0800, Hannes Reinecke wrote: > >> + rcu_read_lock(); > >> + if (attr == _attr_vpd_pg80 && > >> + !rcu_dereference(sdev->vpd_pg80)) { > >> + rcu_read_unlock(); > >> + return 0; > >> + } > >> + if (attr == _attr_vpd_pg83 && > >> +

Re: [PATCH 1/2] scsi_transport_fc: implement 'disable_target_scan' module parameter

On Wed, Mar 02, 2016 at 01:59:39PM +0800, Hannes Reinecke wrote: > Main reasons being that > a) it's most commonly on FC where you end up having thousands of LUNs; > SAS domains are of finite size and you'd need to string quite a few SAS > expanders together to achieve a similar setup. And iSCSI

Re: [PATCH] snic: correctly check for array overrun on overly long version number

On 26/02/16 4:28 am, "Colin King" wrote: >From: Colin Ian King > >The snic version number is expected to be 4 decimals in the form like >a netmask string with each number stored in an element in array v. >However, there is an off-by-one check