CISCO IP PHONES AND CPU's

2016-03-23 Thread Inc
Hi, Our Stock list. Brand NEW 96 x Cisco 7900 IP Phone 87 x Unified IP Phone 6900 12 x Unified IP Phone 8900 76 x Unified IP Phone 9900 55 x Unified IP Phone 8800 67 x Cisco 1921 67 x Cisco 1941 56 x Cisco CP-7961G 7961G 34 x Cisco CP-7971G-GE 7971G 19 x Cisco Unified IP Conference Station 7937G

Re: [PATCHv3] scsi: disable automatic target scan

2016-03-23 Thread Laurence Oberman
Hello Tested Hannes's scan disable patch (subject above) with hpsa module patch below. Because of the way the hpsa works I created a module that will force the scan when all scans are manual. I also tested Hannes's patch with boot-from-san via F/C and validated the patch in subject using

Re: [BUG] mpt2sas: driver init fails on kernel >=4.2 for 9211-8i IT

2016-03-23 Thread Matthias Prager
Hi Sreekanth, I have bisected the issue down to commit "x86/MSI: Use hierarchical irqdomains to manage MSI interrupts". The timeout happens reliably after two warm boots

[PATCH] ibft: Expose iBFT acpi header via sysfs

2016-03-23 Thread David Bond
Some ethernet adapter vendors are supplying products which support optional (payed license) features. On some adapters this includes a hardware iscsi initiator. The same adapters in a normal (no extra licenses) mode of operation can be used as a software iscsi initiator. In addition, software

Re: [PATCH 2/2] cxlflash: Move to exponential back-off when cmd_room is not available

2016-03-23 Thread Matthew R. Ochs
> On Mar 23, 2016, at 2:50 PM, Uma Krishnan wrote: > > From: "Manoj N. Kumar" > > While profiling the cxlflash_queuecommand() path under a heavy load it > was found that number of retries to find cmd_room was fairly high. > > There are two

Re: [PATCH 1/2] cxlflash: Fix regression issue with re-ordering patch

2016-03-23 Thread Matthew R. Ochs
> On Mar 23, 2016, at 2:50 PM, Uma Krishnan wrote: > > From: "Manoj N. Kumar" > > While running 'sg_reset -H' back to back the following exception was seen: > > [ 735.115695] Faulting instruction address: 0xd98c0864 > cpu 0x0:

Re: UFS V11 patch-set

2016-03-23 Thread Martin K. Petersen
> "Joao" == Joao Pinto writes: Joao, Joao> Isn't it possible to be merged into a ufs-dwc branch in the SCSI Joao> Git tree that could be pulled later, like Bjorn did in the PCIe Joao> RC? I just started 4.7/scsi-queue so now is a good time to resubmit. Thanks! --

Re: [PATCH] scsi: vpd pages are mandatory for SPC-2

2016-03-23 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> VPD pages 0x0 and 0x83 are mandatory even for SPC-2, so we Hannes> should be lowering the restriction to avoid having to whitelist Hannes> every SPC-2 compliant device. You forgot to properly submit the patch that moves the vpd

Re: [PATCH v4 00/23] ncr5380: Eliminate macros, reduce code duplication, fix bugs etc

2016-03-23 Thread Martin K. Petersen
> "Finn" == Finn Thain writes: Finn, Finn> This patch series has been tested on several platforms. I tested Finn> the dmx3191d and mac_scsi modules on suitable hardware, Michael Finn> tested atari_scsi on an Atari Falcon and Ondrej has tested Finn> g_NCR5380 and

Re: [PATCH v3 0/3] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k

2016-03-23 Thread Martin K. Petersen
> "Rasmus" == Rasmus Villemoes writes: Rasmus> This is mostly identical to v2 sent in November, rebased Rasmus> (cleanly) to current mainline. The only change is that I've this Rasmus> time also updated the Kconfig help text in 3/3, since the 75 KB Rasmus> was a bit

Re: [PATCH] megaraid_sas: fix missing { }, nullify kbuff_arr[i] only when necessary

2016-03-23 Thread Martin K. Petersen
> "Colin" == Colin King writes: Colin, Colin> Fix missing { } on if statement, this change will nullify Colin> kbuff_arr[i] only where necessary as the code intended. Arnd beat you to it. We already have a patch for this. Thanks! -- Martin K. Petersen

Re: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization

2016-03-23 Thread Martin K. Petersen
> "Calvin" == Calvin Owens writes: Calvin> In _base_make_ioc_operational(), we walk ioc->reply_queue_list Calvin> and pull a pointer out of successive elements of Calvin> ioc->reply_post[] for each entry in that list if RDPQ is Calvin> enabled. Calvin> Since the code

[PATCH 2/2] cxlflash: Move to exponential back-off when cmd_room is not available

2016-03-23 Thread Uma Krishnan
From: "Manoj N. Kumar" While profiling the cxlflash_queuecommand() path under a heavy load it was found that number of retries to find cmd_room was fairly high. There are two problems with the current back-off: a) It starts with a udelay of 0 b) It backs-off linearly

[PATCH 1/2] cxlflash: Fix regression issue with re-ordering patch

2016-03-23 Thread Uma Krishnan
From: "Manoj N. Kumar" While running 'sg_reset -H' back to back the following exception was seen: [ 735.115695] Faulting instruction address: 0xd98c0864 cpu 0x0: Vector: 300 (Data Access) at [c00afa80] pc: d98c0864:

[PATCH 0/2] Fix regression and performance issue in cxlflash

2016-03-23 Thread Uma Krishnan
This series has a couple of patches in cxlflash. The first patch is critical as it fixes a regression that was introduced by Commit 6ded8b3cbd9a ("cxlflash: Unmap problem state area before detaching master context") as part of the first SCSI push for v4.6. The second patch addresses a

Re: BUG: broken support on discard (max_discard_bytes) with uas

2016-03-23 Thread Tom Yan
It seems like this is because the uas driver queues the UNMAP commands. After some test I am no longer sure that it has nothing to do with my hardware at all. Still I have doubt on the uas driver. Like, is queuing UNMAP commands the right thing to do? Or is the uas driver wrongly queuing too many

[linux-next:master 13412/13590] drivers/scsi/qla2xxx/qla_attr.o: warning: objtool: qla2x00_get_fc_host_stats()+0x0: duplicate frame pointer save

2016-03-23 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 288a3fcc138e8e1a1ad7eb8c0cd9bd5944d366ff commit: fabd593b4d211fd8a21af7b2f928385e803a05e7 [13412/13590] Merge remote-tracking branch 'scsi/for-next' config: x86_64-randconfig-s5-03231738 (attached as

[PATCH v4 06/23] ncr5380: Remove PSEUDO_DMA macro

2016-03-23 Thread Finn Thain
For those wrapper drivers which only implement Programmed IO, have NCR5380_dma_xfer_len() evaluate to zero. That allows PDMA to be easily disabled at run-time and so the PSEUDO_DMA macro is no longer needed. Also remove the spin counters used for debugging pseudo DMA drivers. Signed-off-by: Finn

[PATCH v4 10/23] ncr5380: Merge DMA implementation from atari_NCR5380 core driver

2016-03-23 Thread Finn Thain
Adopt the DMA implementation from atari_NCR5380.c. This means that atari_scsi and sun3_scsi can make use of the NCR5380.c core driver and the atari_NCR5380.c driver fork can be made redundant. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke

[PATCH v4 04/23] atari_NCR5380: Remove DMA_MIN_SIZE macro

2016-03-23 Thread Finn Thain
Only the atari_scsi and sun3_scsi drivers define DMA_MIN_SIZE. Both drivers also define NCR5380_dma_xfer_len, which means DMA_MIN_SIZE can be removed from the core driver. This removes another discrepancy between the two core drivers. Signed-off-by: Finn Thain

[PATCH v4 07/23] ncr5380: Remove BOARD_REQUIRES_NO_DELAY macro

2016-03-23 Thread Finn Thain
The io_recovery_delay macro is intended to insert a microsecond delay between the chip register accesses that begin a DMA operation. This is reportedly needed for some ISA boards. Reverse the sense of the macro test so that in the common case, where no delay is required, drivers need not define

[PATCH v4 08/23] ncr5380: Use DMA hooks for PDMA

2016-03-23 Thread Finn Thain
Those wrapper drivers which use DMA define the REAL_DMA macro and those which use pseudo DMA define PSEUDO_DMA. These macros need to be removed for a number of reasons, not least of which is to have drivers share more code. Redefine the PDMA send and receive hooks as DMA setup hooks, so that the

[PATCH v4 03/23] ncr5380: Remove REAL_DMA and REAL_DMA_POLL macros

2016-03-23 Thread Finn Thain
For the NCR5380.c core driver, these macros are never used. If REAL_DMA were to be defined, compilation would fail. For the atari_NCR5380.c core driver, REAL_DMA is always defined. Hence these macros are pointless. Signed-off-by: Finn Thain Reviewed-by: Hannes

[PATCH v4 01/23] g_ncr5380: Remove CONFIG_SCSI_GENERIC_NCR53C400

2016-03-23 Thread Finn Thain
This change brings a number of improvements: fewer macros, better test coverage, simpler code and sane Kconfig options. The downside is a small chance of incompatibility (which seems unavoidable). CONFIG_SCSI_GENERIC_NCR53C400 exists to enable or inhibit pseudo DMA transfers when the driver is

[PATCH v4 09/23] ncr5380: Adopt uniform DMA setup convention

2016-03-23 Thread Finn Thain
Standardize the DMA setup hooks so that the DMA implementation in atari_NCR5380.c can be reconciled with pseudo DMA implementation in NCR5380.c. Calls to NCR5380_dma_recv_setup() and NCR5380_dma_send_setup() return a negative value on failure, zero on PDMA transfer success and a positive byte

[PATCH v4 05/23] ncr5380: Disable the DMA errata workaround flag by default

2016-03-23 Thread Finn Thain
The only chip that needs the workarounds enabled is an early NMOS device. That means that the common case is to disable them. Unfortunately the sense of the flag is such that it has to be set for the common case. Rename the flag so that zero can be used to mean "no errata workarounds needed".

[PATCH v4 20/23] atari_scsi: Set a reasonable default for cmd_per_lun

2016-03-23 Thread Finn Thain
This setting does not need to be conditional on Atari ST or TT. Signed-off-by: Finn Thain Tested-by: Michael Schmitz Reviewed-by: Hannes Reinecke --- Changed since v1: - Set the default cmd_per_lun to 4 based on test results.

[PATCH v4 15/23] dmx3191d: Drop max_sectors limit

2016-03-23 Thread Finn Thain
The dmx3191d driver is not capable of DMA or PDMA so all transfers use PIO. Now that large slow PIO transfers periodically stop and call cond_resched(), the max_sectors limit can go away. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke ---

[PATCH v4 23/23] ncr5380: Call complete_cmd() for disconnected commands on bus reset

2016-03-23 Thread Finn Thain
I'm told that some targets are liable to disconnect a REQUEST SENSE command. Theoretically this would cause a command undergoing autosense to be moved onto the disconnected list. The bus reset handler must call complete_cmd() for these commands, otherwise the hostdata->sensing pointer will not get

[PATCH v4 19/23] ncr5380: Update usage documentation

2016-03-23 Thread Finn Thain
Update kernel parameter documentation for atari_scsi, mac_scsi and g_NCR5380 drivers. Remove duplication. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke --- Documentation/scsi/g_NCR5380.txt | 17 ++-

[PATCH v4 12/23] sun3_scsi: Adopt NCR5380.c core driver

2016-03-23 Thread Finn Thain
Add support for the custom Sun 3 DMA logic to the NCR5380.c core driver. This code is copied from atari_NCR5380.c. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke Tested-by: Michael Schmitz Tested-by: Ondrej Zary

[PATCH v4 14/23] ncr5380: Reduce max_lun limit

2016-03-23 Thread Finn Thain
The driver has a limit of eight LUs because of the byte-sized bitfield that is used for busy flags. That means the maximum LUN is 7. The default is 8. Signed-off-by: Finn Thain Tested-by: Michael Schmitz Tested-by: Ondrej Zary

[PATCH v4 21/23] atari_scsi: Allow can_queue to be increased for Falcon

2016-03-23 Thread Finn Thain
The benefit of limiting can_queue to 1 is that atari_scsi shares the ST DMA chip more fairly with other drivers (e.g. falcon-ide). Unfortunately, this can limit SCSI bus utilization. On systems without IDE, atari_scsi should issue SCSI commands whenever it can arbitrate for the bus. Make that

[PATCH v4 16/23] ncr5380: Fix register decoding for debugging

2016-03-23 Thread Finn Thain
Decode all bits in the chip registers. They are all useful at times. Fix printk severity so that this output can be suppressed along with the other debugging output. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke Tested-by: Michael Schmitz

[PATCH v4 11/23] atari_scsi: Adopt NCR5380.c core driver

2016-03-23 Thread Finn Thain
Add support for the Atari ST DMA chip to the NCR5380.c core driver. This code is copied from atari_NCR5380.c. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke Tested-by: Michael Schmitz Tested-by: Ondrej Zary

[PATCH v4 13/23] ncr5380: Remove disused atari_NCR5380.c core driver

2016-03-23 Thread Finn Thain
Now that atari_scsi and sun3_scsi have been converted to use the NCR5380.c core driver, remove atari_NCR5380.c. Also remove the last vestiges of its Tagged Command Queueing implementation from the wrapper drivers. The TCQ support in atari_NCR5380.c is abandoned by this patch. It is not merged

[PATCH v4 18/23] ncr5380: Remove DONT_USE_INTR and AUTOPROBE_IRQ macros

2016-03-23 Thread Finn Thain
Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke Tested-by: Michael Schmitz Tested-by: Ondrej Zary --- drivers/scsi/NCR5380.c | 12 +--- drivers/scsi/NCR5380.h |4

[PATCH v4 17/23] ncr5380: Remove remaining register storage qualifiers

2016-03-23 Thread Finn Thain
Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke Tested-by: Michael Schmitz Tested-by: Ondrej Zary --- drivers/scsi/NCR5380.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH v4 22/23] mac_scsi: Fix pseudo DMA implementation

2016-03-23 Thread Finn Thain
Fix various issues: Comments about bus errors are incorrect. The PDMA asm must return the size of the memory access that faulted so the transfer count can be adjusted accordingly. A phase change may cause a bus error but should not be treated as failure. A bus error does not always imply a phase

[PATCH v4 02/23] ncr5380: Remove FLAG_NO_PSEUDO_DMA where possible

2016-03-23 Thread Finn Thain
Drivers that define PSEUDO_DMA also define NCR5380_dma_xfer_len. The core driver must call NCR5380_dma_xfer_len which means FLAG_NO_PSEUDO_DMA can be eradicated from the core driver. dmx3191d doesn't define PSEUDO_DMA and has no use for FLAG_NO_PSEUDO_DMA, so remove it there also. Signed-off-by:

[PATCH v4 00/23] ncr5380: Eliminate macros, reduce code duplication, fix bugs etc

2016-03-23 Thread Finn Thain
This patch series has more macro elimination and some tweaks to the DMA hooks so that all the wrapper drivers can share the same core DMA algorithm. This resolves the major discrepancies between the two core drivers, which relate to code conditional on the REAL_DMA and PSEUDO_DMA macros. After

RE: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization

2016-03-23 Thread Chaitra Basappa
Hi, Please consider this patch as Ack-by: Chaitra P B Thanks, Chaitra -Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: Tuesday, March 22, 2016 6:00 AM To: Calvin Owens Cc: Sathya Prakash; Chaitra P B; Suganath Prabu

Re: [PATCH v2 0/5] mempool based chained scatterlist alloc/free api

2016-03-23 Thread Christoph Hellwig
On Tue, Mar 22, 2016 at 03:03:11PM -0700, Ming Lin wrote: > From: Ming Lin > > The fist 4 patches make the SG related definitions/structs/functions > in SCSI code generic and the last patch move it to lib/sg_pool.c. > > I still keep the macro "SG_MEMPOOL_NR" since it's

Re: [PATCH v3 0/3] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k

2016-03-23 Thread Christoph Hellwig
Thanks Rasmus, the whole series looks good to me: Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 23/23] ncr5380: Call complete_cmd() for disconnected commands on bus reset

2016-03-23 Thread Hannes Reinecke
On 03/21/2016 03:32 AM, Finn Thain wrote: > I'm told that some targets are liable to disconnect a REQUEST SENSE > command. Theoretically this would cause a command undergoing autosense to > be moved onto the disconnected list. The bus reset handler must call > complete_cmd() for these commands,

Re: [PATCH v3 20/23] atari_scsi: Set a reasonable default for cmd_per_lun

2016-03-23 Thread Hannes Reinecke
On 03/21/2016 03:32 AM, Finn Thain wrote: > This setting does not need to be conditional on Atari ST or TT. > > Signed-off-by: Finn Thain > Tested-by: Michael Schmitz > > --- > > Changed since v1: > - Set the default cmd_per_lun to 4 based on

Re: [PATCH v3 14/23] ncr5380: Reduce max_lun limit

2016-03-23 Thread Hannes Reinecke
On 03/21/2016 03:32 AM, Finn Thain wrote: > The driver has a limit of eight LUs because of the byte-sized bitfield > that is used for busy flags. That means the maximum LUN is 7. The default > is 8. > > Signed-off-by: Finn Thain > Tested-by: Michael Schmitz

Re: [PATCH v3 04/23] atari_NCR5380: Remove DMA_MIN_SIZE macro

2016-03-23 Thread Hannes Reinecke
On 03/21/2016 03:31 AM, Finn Thain wrote: > Only the atari_scsi and sun3_scsi drivers define DMA_MIN_SIZE. > Both drivers also define NCR5380_dma_xfer_len, which means > DMA_MIN_SIZE can be removed from the core driver. > > This removes another discrepancy between the two core drivers. > >