Re: [PATCH RFC 1/2] scatterlist: add mempool based chained SG alloc/free api

2016-04-07 Thread Ming Lin
On Thu, Apr 7, 2016 at 9:43 AM, Ming Lin wrote: > On Thu, Apr 7, 2016 at 7:56 AM, Bart Van Assche > wrote: >> On 03/15/16 15:39, Ming Lin wrote: >>> >>> +static void sg_mempoll_free(struct scatterlist *sgl, unsigned int nents) >> >> >> Please change

Re: Cant write to max_sectors_kb on 4.5.0 SRP target

2016-04-07 Thread Nicholas A. Bellinger
Hi Laurence, On Thu, 2016-04-07 at 17:15 -0400, Laurence Oberman wrote: > Hello > > I have been testing the SRP initiator code to an LIO array here and > part of the testing requires me to set the max_sectors_kb size to get > 4k I/O's. > This has been due to me having to debug various sg_map

Re: Cant write to max_sectors_kb on 4.5.0 SRP target

2016-04-07 Thread Martin K. Petersen
> "Laurence" == Laurence Oberman writes: Laurence, The target is reporting inconsistent values here: > [root@srptest queue]# sg_inq --p 0xb0 /dev/sdb > VPD INQUIRY: Block limits page (SBC) > Maximum compare and write length: 1 blocks > Optimal transfer length

Re: Cant write to max_sectors_kb on 4.5.0 SRP target

2016-04-07 Thread Bart Van Assche
On 04/07/16 14:16, Laurence Oberman wrote: I have been testing the SRP initiator code to an LIO array here and > part of the testing requires me to set the max_sectors_kb size to > get 4k I/O's. . Hello Laurence, Have you

[no subject]

2016-04-07 Thread contact
nd of smlast -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem

2016-04-07 Thread Winkler, Tomas
On Wed, 2016-04-06 at 09:51 +0100, Joao Pinto wrote: > Hi! > > On 4/4/2016 12:11 PM, Tomas Winkler wrote: > > Register UFS RPMB LUN with the RPMB subsystem and provide > > implementation for the RPMB access operations. RPMB partition is > > accessed via a sequence of security protocol in and

Cant write to max_sectors_kb on 4.5.0 SRP target

2016-04-07 Thread Laurence Oberman
Hello I have been testing the SRP initiator code to an LIO array here and part of the testing requires me to set the max_sectors_kb size to get 4k I/O's. This has been due to me having to debug various sg_map issues. Linux srptest 4.5.0 #2 SMP Thu Apr 7 16:14:38 EDT 2016 x86_64 x86_64 x86_64

[PATCH v3] mvsas: Generalize Marvell 9485 in pci_device_id

2016-04-07 Thread Leonid Moiseichuk
For generic subvendor has sense to use generic subdevice. If subdevice ID not equal to 0x9480/0x9485 mvsas will be not activated. Tested on ASUS P9A-I/C2550/SAS/4L which uses vendor-specific 1043:8635. v3: add comment and changelog according to Andy's findings v2: re-phrased commit message

[Bug 114401] crash dump aic94xx

2016-04-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=114401 --- Comment #3 from bastienphilb...@gmail.com --- That seems to be due to a WARN_ON that only triggers once. Does this work OK now besides the warning. -- You are receiving this mail because: You are watching the assignee of the bug. -- To

Re: [PATCH v2] mvsas: Generalize Marvell 9485 in pci_device_id

2016-04-07 Thread Andy Shevchenko
On Thu, Apr 7, 2016 at 8:06 PM, Leonid Moiseichuk wrote: > For generic subvendor has sense to use generic subdevice. > If subdevice ID not equal to 0x9480/0x9485 mvsas will be not activated. > > Tested on ASUS P9A-I/C2550/SAS/4L which uses vendor-specific 1043:8635.

[PATCH v2] mvsas: Generalize Marvell 9485 in pci_device_id

2016-04-07 Thread Leonid Moiseichuk
For generic subvendor has sense to use generic subdevice. If subdevice ID not equal to 0x9480/0x9485 mvsas will be not activated. Tested on ASUS P9A-I/C2550/SAS/4L which uses vendor-specific 1043:8635. Signed-off-by: Leonid Moiseichuk ---

[Bug 114401] crash dump aic94xx

2016-04-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=114401 Bulanov Maxim changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH v12 8/9] add TC G210 platform driver

2016-04-07 Thread Rob Herring
On Mon, Apr 04, 2016 at 11:48:23AM +0100, Joao Pinto wrote: > > Hi Rob, > > On 4/4/2016 6:15 AM, Rob Herring wrote: > > On Thu, Mar 31, 2016 at 07:57:21PM +0100, Joao Pinto wrote: > >> This patch adds a glue platform driver for the Synopsys G210 Test Chip. > >> > >> Signed-off-by: Joao Pinto

Re: [PATCH RFC 1/2] scatterlist: add mempool based chained SG alloc/free api

2016-04-07 Thread Ming Lin
On Thu, Apr 7, 2016 at 7:56 AM, Bart Van Assche wrote: > On 03/15/16 15:39, Ming Lin wrote: >> >> +static void sg_mempoll_free(struct scatterlist *sgl, unsigned int nents) > > > Please change mempoll into mempool. Good catch. Thanks Bart! -- To unsubscribe from this

Re: LSF/MM Schedule and improving discard support

2016-04-07 Thread James Bottomley
On Thu, 2016-04-07 at 08:39 -0700, Bart Van Assche wrote: > Hello James, > > Some time ago I proposed to discuss how to improve discard support > during the LSF/MM (http://thread.gmane.org/gmane.linux.scsi/110048). > I would appreciate it if this would be added to the LSF/MM agenda > since

LSF/MM Schedule and improving discard support

2016-04-07 Thread Bart Van Assche
Hello James, Some time ago I proposed to discuss how to improve discard support during the LSF/MM (http://thread.gmane.org/gmane.linux.scsi/110048). I would appreciate it if this would be added to the LSF/MM agenda since there has been no progress yet for the patch series I posted in December

Re: [RFC PATCH 0/4] dm mpath: vastly improve blk-mq IO performance

2016-04-07 Thread Mike Snitzer
On Thu, Apr 07 2016 at 10:58am -0400, Hannes Reinecke wrote: > On 03/31/2016 10:04 PM, Mike Snitzer wrote: > > I developed these changes some weeks ago but have since focused on > > regression and performance testing on larger NUMA systems. > > > > For regression testing I've been

Re: [RFC PATCH 3/4] dm mpath: move trigger_event member to the end of 'struct multipath'

2016-04-07 Thread Hannes Reinecke
On 03/31/2016 10:04 PM, Mike Snitzer wrote: > Allows the 'work_mutex' member to no longer cross a cacheline. > > Signed-off-by: Mike Snitzer > --- > drivers/md/dm-mpath.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/md/dm-mpath.c

Re: [RFC PATCH 4/4] dm mpath: eliminate use of spinlock in IO fast-paths

2016-04-07 Thread Hannes Reinecke
On 03/31/2016 10:04 PM, Mike Snitzer wrote: > The primary motivation of this commit is to improve the scalability of > DM multipath on large NUMA systems where m->lock spinlock contention has > been proven to be a serious bottleneck on really fast storage. > > The ability to atomically read a

Re: [RFC PATCH 2/4] dm mpath: use atomic_t for counting members of 'struct multipath'

2016-04-07 Thread Hannes Reinecke
On 03/31/2016 10:04 PM, Mike Snitzer wrote: > The use of atomic_t for nr_valid_paths, pg_init_in_progress and > pg_init_count will allow relaxing the use of the m->lock spinlock. > > Suggested-by: Hannes Reinecke > Signed-off-by: Mike Snitzer > --- >

Re: [RFC PATCH 1/4] dm mpath: switch to using bitops for state flags

2016-04-07 Thread Hannes Reinecke
On 03/31/2016 10:04 PM, Mike Snitzer wrote: > Mechanical change that doesn't make any real effort to reduce the use of > m->lock; that will come later (once atomics are used for counters, etc). > > Suggested-by: Hannes Reinecke > Signed-off-by: Mike Snitzer >

Re: [RFC PATCH 0/4] dm mpath: vastly improve blk-mq IO performance

2016-04-07 Thread Hannes Reinecke
On 03/31/2016 10:04 PM, Mike Snitzer wrote: > I developed these changes some weeks ago but have since focused on > regression and performance testing on larger NUMA systems. > > For regression testing I've been using mptest: > https://github.com/snitm/mptest > > For performance testing I've been

Re: [PATCH RFC 1/2] scatterlist: add mempool based chained SG alloc/free api

2016-04-07 Thread Bart Van Assche
On 03/15/16 15:39, Ming Lin wrote: +static void sg_mempoll_free(struct scatterlist *sgl, unsigned int nents) Please change mempoll into mempool. Thanks, Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 4/5] bnx2fc: Check sc_cmd device and host pointer before returning the command to the mid-layer.

2016-04-07 Thread Johannes Thumshirn
On Donnerstag, 7. April 2016 09:07:59 CEST Chad Dupuis wrote: > When we are in connection recovery and the internal command timer on a > request pops, either the scsi_cmnd->device or scsi_cmnd->device->host back > pointers may be NULL as the device that the command that the request was > submitted

Re: [PATCH v2 5/5] bnx2fc: Update version number to 2.10.3.

2016-04-07 Thread Johannes Thumshirn
On Donnerstag, 7. April 2016 09:08:00 CEST Chad Dupuis wrote: > Signed-off-by: Chad Dupuis > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH v2 3/5] bnx2fc: Print netdev device name when FCoE is successfully initialized.

2016-04-07 Thread Johannes Thumshirn
On Donnerstag, 7. April 2016 09:07:58 CEST Chad Dupuis wrote: > Signed-off-by: Chad Dupuis > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH v2 2/5] bnx2fc: Print when we send a fip keep alive.

2016-04-07 Thread Johannes Thumshirn
On Donnerstag, 7. April 2016 09:07:57 CEST Chad Dupuis wrote: > Signed-off-by: Chad Dupuis > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH v2 1/5] bnx2fc: Add driver tunables.

2016-04-07 Thread Johannes Thumshirn
On Donnerstag, 7. April 2016 09:07:56 CEST Chad Dupuis wrote: > From: Joe Carnuccio > > Per customer request, add the following driver tunables: > > o devloss_tmo > o max_luns > o queue_depth > o tm_timeout > > tm_timeout is set per scsi_host in

[PATCH v2 5/5] bnx2fc: Update version number to 2.10.3.

2016-04-07 Thread Chad Dupuis
Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b/drivers/scsi/bnx2fc/bnx2fc.h index 106788f..fdd4eb4 100644 --- a/drivers/scsi/bnx2fc/bnx2fc.h +++

[PATCH v2 4/5] bnx2fc: Check sc_cmd device and host pointer before returning the command to the mid-layer.

2016-04-07 Thread Chad Dupuis
When we are in connection recovery and the internal command timer on a request pops, either the scsi_cmnd->device or scsi_cmnd->device->host back pointers may be NULL as the device that the command that the request was submitted on may have been subsequently reaped due to the connection recovery.

[PATCH v2 2/5] bnx2fc: Print when we send a fip keep alive.

2016-04-07 Thread Chad Dupuis
Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index b0305b0..365101a 100644 ---

[PATCH v2 0/5] bnx2fc: Update driver to version 2.10.3.

2016-04-07 Thread Chad Dupuis
Hi James, Martin, Please apply the patch series for the next merge window at your earliest convenience. V2 changes: - Made netdev device name print pr_info instead of pr_err. - Made TMF timeout settable via sysfs node instead of modparam. Thanks, Chad Chad Dupuis (4): bnx2fc: Print when we

[PATCH v2 3/5] bnx2fc: Print netdev device name when FCoE is successfully initialized.

2016-04-07 Thread Chad Dupuis
Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index 365101a..a188199 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c +++

Re: [PATCH 10/12] Limit bio_endio recursion

2016-04-07 Thread Ming Lei
On Thu, Apr 7, 2016 at 1:44 PM, Ming Lei wrote: > On Thu, 7 Apr 2016 11:54:49 +0800 > Ming Lei wrote: > > @@ -1737,6 +1739,46 @@ static inline bool bio_remaining_done(struct bio *bio) > return false; > } > > +/* disable local irq when