Re: [PATCH v4 1/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state

ET_REMOVE && > + starget->state != STARGET_CREATED); #modprobe scsi_debug #modprobe -r scsi_debug always triggers this BUG_ON in linux-next-20160411 printk says starget->state is _RUNNING > starget->state = STARGET_DEL; > transport_destroy_devic

Re: [PATCH v3 4/5] scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS

On 04/11/16 15:04, Ming Lin wrote: On Mon, Apr 11, 2016 at 2:34 PM, Martin K. Petersen wrote: "Ming" == Ming Lin writes: Ming> Are we ready to merge it? We're still missing an ack from Sagi. Thought we already had a ack from Bart. OK, let's

Re: [PATCH 1/1] scsi: add Synology DSM 6.0 and higher to 1024 sector blacklist

> "Michel" == Michel Meyers writes: Michel> SYNOLOGY iSCSI devices do not work with large I/O and SYNOLOGY Michel> changed the identifier of the devices Shouldn't we just quirk SYNOLOGY, then? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: [PATCH] drivers/scsi/fnic/fnic_scsi.c: Deinline fnic_queue_abort_io_req, save 1792 bytes

> "Denys" == Denys Vlasenko writes: Denys> This function compiles to 511 bytes of machine code. Abort Denys> commands are not time-critical at all. Satish, please review. https://patchwork.kernel.org/patch/8785281/ -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/5] hisi_sas: v2 hw SATA fixes

> "John" == John Garry writes: John> This patchset introduces SATA support fixes for the HiSilicon v2 John> hw SAS controller. Somebody please review. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] zfcp: Revert to original scanning behaviour

> "Hannes" == Hannes Reinecke writes: Hannes> zfcp has its own mechanism for selective scanning, so revert to Hannes> the original scanning behaviour to not confuse users. Benjamin? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send

Re: [PATCH v3] mvsas: Generalize Marvell 9485 in pci_device_id

> "Leonid" == Leonid Moiseichuk writes: Leonid> For generic subvendor has sense to use generic subdevice. If Leonid> subdevice ID not equal to 0x9480/0x9485 mvsas will be not Leonid> activated. Applied to 4.7/scsi-queue. Thank you! -- Martin K. Petersen

Re: [4.5-rc4 Regression] qla2xxx: Add irq affinity notification

On 04/11/2016 05:28 PM, Quinn Tran wrote: > Joe, > > I see the crash point. We’re accessing Null pointer. The adapter in use is > an older 4G adapter, where it does not have MSIX support. We’re tripping > over the same shared code segment. The following is the propose fix. Let me > know if

Re: fnic: Using rport->dd_data to check rport online instead of rport_lookup.

> "Dan" == Dan Carpenter writes: Dan> The patch ce4b9e8980fa: "fnic: Using rport->dd_data to check rport Dan> online instead of rport_lookup." from Mar 18, 2016, leads to the Dan> following Smatch complaint: Dan> drivers/scsi/fnic/fnic_scsi.c:457

Re: [PATCH 1/2] scsi: add a max_segment_size limitation to struct Scsi_Host

Thanks Bart Good catch, I completely missed it. Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Bart Van Assche" To: "Christoph Hellwig" , linux-r...@vger.kernel.org,

Re: [PATCH 1/2] scsi: add a max_segment_size limitation to struct Scsi_Host

On Mon, Apr 11, 2016 at 04:32:16PM -0700, Bart Van Assche wrote: > Since Scsi_Host.max_segment_size is initialized to zero, shouldn't min() be > changed into min_not_zero()? It probably should. Thanks for catching this. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 1/2] scsi: add a max_segment_size limitation to struct Scsi_Host

On 04/11/2016 03:47 PM, Christoph Hellwig wrote: diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 8106515..04c660d 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -2120,7 +2120,8 @@ static void __scsi_init_queue(struct Scsi_Host *shost, struct

Re: [PATCH 1/2] scsi: add a max_segment_size limitation to struct Scsi_Host

This looks fine to me. I am pulling this in to my SRP initiator and target testing ongoing at the moment so will be testing. Up to now this has likely not affected me but I am pulling in all RDMA patches to test. Reviewed-by: Laurence Oberman Laurence Oberman Principal

[PATCH 2/2] IB/iser: set max_segment_size

So that we don't overflow the number of MR segments allocated because we have to split on SGL segment into multiple MR segments. Signed-off-by: Christoph Hellwig --- drivers/infiniband/ulp/iser/iscsi_iser.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v3 4/5] scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS

On Mon, Apr 11, 2016 at 2:34 PM, Martin K. Petersen wrote: >> "Ming" == Ming Lin writes: > > Ming> Are we ready to merge it? > > We're still missing an ack from Sagi. Thought we already had a ack from Bart. OK, let's get one more from Sagi. -- To

Re: [PATCH v2 0/5] bnx2fc: Update driver to version 2.10.3.

> "Chad" == Chad Dupuis writes: Chad> Please apply the patch series for the next merge window at your Chad> earliest convenience. Applied to 4.7/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [PATCH v3 4/5] scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS

> "Ming" == Ming Lin writes: Ming> Are we ready to merge it? We're still missing an ack from Sagi. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: Cant write to max_sectors_kb on 4.5.0 SRP target

> "Ewan" == Ewan D Milne writes: Ewan> In the upstream kernel queue_max_sectors_store() does not permit Ewan> you to set a value larger than the device-imposed limit. This Ewan> value, stored in q->limits.max_dev_sectors, is not visible via the Ewan> block queue sysfs

Re: [4.5-rc4 Regression] qla2xxx: Add irq affinity notification

Joe, I see the crash point. We’re accessing Null pointer. The adapter in use is an older 4G adapter, where it does not have MSIX support. We’re tripping over the same shared code segment. The following is the propose fix. Let me know if it works. I’ll will follow up with a patch for

Re: [PATCH 2/2] scsi: vpd pages are mandatory for SPC-2

> "Hannes" == Hannes Reinecke writes: Hannes> VPD pages 0x0 and 0x83 are mandatory even for SPC-2, so we Hannes> should be lowering the restriction to avoid having to whitelist Hannes> every SPC-2 compliant device. Linus took patch 1/2 for 4.6rc3 so I have rebased

Re: [4.5-rc4 Regression] qla2xxx: Add irq affinity notification

On 04/11/2016 01:48 PM, Quinn Tran wrote: > Joe, > > How do I get access to this specific Ubuntu kernel where the bug is found? > Is there stack trace/bug report that you could share? Any data would be > helpful. Thanks. The git tree for the specific Ubuntu kernel that exhibits this bug can

Re: [4.5-rc4 Regression] qla2xxx: Add irq affinity notification

Joe, How do I get access to this specific Ubuntu kernel where the bug is found? Is there stack trace/bug report that you could share? Any data would be helpful. Thanks. In the mean time, I will download 4.5 rc4 to re-verify. Regards, Quinn Tran -Original Message- From: Joseph

Re: [PATCH v2 08/16] iscsi-target: add void (*iscsit_get_r2t_ttt)()

On Sun, Apr 10, 2016 at 08:51:44PM +0300, Sagi Grimberg wrote: > > >Add void (*iscsit_get_r2t_ttt)() to > >struct iscsit_transport, iscsi-target > >uses this callback to get > >r2t->targ_xfer_tag. > > Your driver allocates ttt's? That looks like bad > layering to me. This definitely deserves an

Re: [PATCH v2 07/16] iscsi-target: add int (*iscsit_validate_params)()

On Sun, Apr 10, 2016 at 08:50:23PM +0300, Sagi Grimberg wrote: > > >Add int (*iscsit_validate_params)() to > >struct iscsit_transport, iscsi-target > >uses this callback for validating > >conn operational parameters. > > Again, why is this needed? This is for updating the value of

[4.5-rc4 Regression] qla2xxx: Add irq affinity notification

Hello Quinn, A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug: commit cdb898c52d1dfad4b4800b83a58b3fe5d352edde Author: Quinn Tran Date: Thu Dec 17 14:57:05 2015 -0500

Re: [PATCH v2 04/16] iscsi-target: add void (*iscsit_release_cmd)()

On Sun, Apr 10, 2016 at 08:42:44PM +0300, Sagi Grimberg wrote: > > >Add void (*iscsit_release_cmd)() to > >struct iscsit_transport, iscsi-target > >uses this callback to release transport > >driver resources associated with an iSCSI cmd. > > I'd really like to see some reasoning on why you add >

Re: [PATCH v2 03/16] iscsi-target: add int (*iscsit_xmit_datain_pdu)()

On Sun, Apr 10, 2016 at 08:38:03PM +0300, Sagi Grimberg wrote: > > > On 09/04/16 16:11, Varun Prakash wrote: > >Add int (*iscsit_xmit_datain_pdu)() to > >struct iscsit_transport, iscsi-target > >uses this callback to transmit a DATAIN > >iSCSI PDU. > > > >Signed-off-by: Varun Prakash

Re: Cant write to max_sectors_kb on 4.5.0 SRP target

As a follow up to this issue. I looked at modifying the LIO target code to allow a larger max_sectors_kb exported to the initiator for the nvme devices but had some issues. In the end I created 15 fileio devices using 200GB of ramdisk and exported those so I could test 4MB I/O from the

Re: [PATCH v2 01/16] iscsi-target: add callback to alloc and free PDU

On Sun, Apr 10, 2016 at 08:33:53PM +0300, Sagi Grimberg wrote: > > > On 09/04/16 16:11, Varun Prakash wrote: > >Add two callbacks to struct iscsit_transport - > > > >1. void *(*iscsit_alloc_pdu)() > >iscsi-target uses this callback for > >iSCSI PDU allocation. > > > >2. void

UFS patch

Hi Martin, I would like to know what are your plans regarding the UFS patches. Sending the URLS for the last patch set version: [PATCH v13 0/9] add support for DWC UFS Controller https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1115046.html [PATCH v13 1/9] fixed typo in

Re: [alsa-devel] [PATCH 2/4] sound: isa: sscape: Use correct format identifier for size_t

On Mon, 11 Apr 2016 15:25:52 +0200, William Breathitt Gray wrote: > > The 'size' member of a struct firmware is passed to snd_printk with a > respective format string using the %d identifier. The 'size' member is > of type size_t, but format identifier %d indicates a signed int data > type. This

Re: [PATCH v2 6/8] tools rpmb: add RPBM access tool

Hi Tomas, On Mon, Apr 04, 2016 at 02:11:22PM +0300, Tomas Winkler wrote: > Add simple RPMB host testing tool. It can be used > to program key, write and read data block, and retrieve > write counter. > > Signed-off-by: Tomas Winkler > --- > V2: resend > MAINTAINERS

[PATCH 2/4] sound: isa: sscape: Use correct format identifier for size_t

The 'size' member of a struct firmware is passed to snd_printk with a respective format string using the %d identifier. The 'size' member is of type size_t, but format identifier %d indicates a signed int data type. This patch replaces the %d format identifier with the correct %zu format

[PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option

This patchset is based on top of commit 3a3a5fece6f2 ("fs: kernfs: Replace CURRENT_TIME by current_fs_time()") of the driver-core-testing branch of the driver-core repository. The introduction of the ISA_BUS option in commit b3c1be1b789c ("base: isa: Remove X86_32 dependency") blocks the

[PATCH 3/4] scsi: ultrastor: Use correct format identifier for kernel pointer

The 'bios_segment' member of a struct ultrastor_config is passed to the sprintf function with a respective %05X format identifier. The 'bio_segment' member is a kernel pointer, but the %X format identifier expects an int data type. A cast to int is correctly used to satisfy the format identifier,

[PATCH 4/4] isa: Remove the ISA_BUS Kconfig option

The introduction of the ISA_BUS option blocks the compilation of ISA drivers on non-x86 platforms. The ISA_BUS configuration option should not be necessary if the X86_32 dependency can be decoupled from the ISA configuration option. This patch both removes the ISA_BUS configuration option entirely

[PATCH 1/4] pnp: pnpbios: Add explicit X86_32 dependency to PNPBIOS

The PNPBIOS driver requires preprocessor defines (located in include/asm/segment.h) only declared if the architecture is set to X86_32. If the architecture is set to X86_64, the PNPBIOS driver will not build properly. The X86 dependecy for the PNPBIOS configuration option is changed to an explicit

Re: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

Hi Chaitra, while discussing this patch with Ewan, I realized that cancel_pending_work is unused as well. I can send a v2 with that and the associated kerneldoc update. Do we know why f1c35e6aea579 "mpt2sas: RESCAN Barrier work is added in case of HBA reset" was unneeded for the mpt3

RE: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

Hi, Please consider this patch as Ack-by: Chaitra P B Thanks, Chaitra -Original Message- From: Sathya Prakash [mailto:sathya.prak...@broadcom.com] Sent: Saturday, April 02, 2016 1:45 AM To: emi...@redhat.com; Joe Lawrence Cc: linux-scsi@vger.kernel.org;

Re: [PATCH v2 6/8] tools rpmb: add RPBM access tool

On Tue, 2016-04-05 at 20:16 +0800, kbuild test robot wrote: > Hi Tomas, > > [auto build test ERROR on char-misc/char-misc-testing] > [also build test ERROR on v4.6-rc2 next-20160405] > [if your patch is applied to the wrong git tree, please drop us a > note to help improving the system] > > url: 

Re: [PATCH] arm64: dts: apm: Fix compatible string for X-Gene 2 SATA controller DTS node

Hi Olof, On Wed, Mar 30, 2016 at 12:41 AM, Duc Dang wrote: > > On Tue, Mar 29, 2016 at 2:54 AM, Rameshwar Prasad Sahu wrote: > > Fix X-Gene SATA controller compatible string for Merlin board. > > > > Signed-off-by: Rameshwar Prasad Sahu > >

[-next] BUG_ON in scsi_target_destroy()

Hello, commit 7b106f2de6938c31ce5e9c86bc70ad3904666b96 Author: Johannes Thumshirn <jthumsh...@suse.de> Date: Tue Apr 5 11:50:44 2016 +0200 scsi: Add intermediate STARGET_REMOVE state to scsi_target_state BUG_ON()s (next-20160411) each time I remove a usb flash [ 49.

[PATCH 1/1] scsi: add Synology DSM 6.0 and higher to 1024 sector blacklist

From: Michel Meyers SYNOLOGY iSCSI devices do not work with large I/O and SYNOLOGY changed the identifier of the devices starting with version 6.0 of their OS ("DSM"). (The large I/O problem persists in that release.) This patch adds the new identifier to the 1024 sector