Re: [PATCH] mptsas: fix checks for dma mapping errors

2016-04-27 Thread Martin K. Petersen
> "Alexey" == Alexey Khoroshilov writes: Alexey> mptsas_smp_handler() checks for dma mapping errors by comparison Alexey> returned address with zero, while pci_dma_mapping_error() should Alexey> be used. Broadcom folks, please review! -- Martin K. Petersen Oracle Linux Engineering --

Re: [PATCH 0/5] mpt3sas: driver update for Phase12

2016-04-27 Thread Martin K. Petersen
> "Chaitra" == Chaitra P B writes: > Here is the change list: > * Updated MPI version and MPI header files. > * Handle active cable exception event for Intruder/Cutlass HBAs. > * Use scsi_prot_ref_tag()API to fill reference tag field in the CDB. > * Set maximum transfer length per IO on RAID

我的相片在

2016-04-27 Thread 我的相片在
你的朋友给你分享了一个支付宝红包口令:加群有红包赶快打开支付宝APP,输入红包口令,抢红包,手慢无。

Re: [SCSI] pm80xx: Phy settings support for motherboard controller.

2016-04-27 Thread Martin K. Petersen
> "Jack" == Jack Wang writes: Jack> 2016-04-13 13:24 GMT+02:00 Dan Carpenter Jack> : >> Hello Anand Kumar Santhanam, >> >> The patch 279094079a44: "[SCSI] pm80xx: Phy settings support for >> motherboard controller." from Sep 18, 2013, leads to the following >> static checker warning: >> >>

Notes from the four separate IO track sessions at LSF/MM

2016-04-27 Thread James Bottomley
This year, we only had two scribes from LWN.net, not three, so there won't be any coverage of the IO track when we split into three tracks. To cover for that, here are my notes of the four separated sessions === Multiqueue Interrupt and Queue Assignment; Hannes Reinecke

Re: [PATCH 08/12] scsi_debug: rework resp_report_luns

2016-04-27 Thread Bart Van Assche
On 04/25/2016 09:16 AM, Douglas Gilbert wrote: + /* can produce response with up to 16k luns (lun 0 to lun 16383) */ + arr = kzalloc((tlun_cnt * sizeof(lun_p->scsi_lun)) + 8, GFP_ATOMIC); kzalloc() allocates contiguous memory. There is no guarantee that a large contiguous region wi

[PATCH 7/7] hpsa: update driver version

2016-04-27 Thread Don Brace
Reviewed-by: Gerry Morong Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 0d286e4..011fb8e 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -60,7 +60,7 @@ * HPSA

[PATCH 5/7] hpsa: correct ioaccel2 error procecssing.

2016-04-27 Thread Don Brace
set offload_to_be_enabled to 0 when an ioaccel2 error is processed. Before, an ioaccel completion error would turn of ioaccel but a rescan would turn it back on again. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 +++- 1 file chang

[PATCH 6/7] hpsa: correct handling of HBA device removal

2016-04-27 Thread Don Brace
Need to report HBA device removal faster than the event handler polling interval. Stop I/O to the removed disk and wait for all I/O operations to flush before removing the device. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 89 ++

[PATCH 2/7] hpsa: add sas_address to sysfs device attibute

2016-04-27 Thread Don Brace
From: Joseph T Handzik There have been companies requesting a sysfs entry to obtain the sas address of device. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 25 + 1 file changed, 25 insertions(+) diff --git a/

[PATCH 4/7] hpsa: correct ioaccel state change operation

2016-04-27 Thread Don Brace
offload_to_be_enabled also needs to be set to 0 during a state change. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index f

[PATCH 3/7] hpsa: add timeouts for driver initiated commands

2016-04-27 Thread Don Brace
faulty drives can cause the driver to hang during a scan operation. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 42 +++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/drivers/scs

[PATCH 1/7] hpsa: correct initialization order issue

2016-04-27 Thread Don Brace
The driver was calling scsi_scan_host before enabling interrupts. This has gone unnoticed except for customers running in intx mode. Calling scsi_scan_host before interrupts are enabled causes "irq XX: nobody cared" messages and the driver to hang. This patch enables interrupts before the call to

[PATCH 0/7] hpsa driver updates

2016-04-27 Thread Don Brace
These patches are based on Linus's tree The changes are: - move call to scsi_scan_host below where interrupts are enabled - add in timouts for driver initiated commands. - some faulty disks caused initialization hangs. - correct ioaccel change events - correct ioaccel error checking - enha

Re: [PATCH, RFT] byteswap: try to avoid __builtin_constant_p gcc bug

2016-04-27 Thread Josh Poimboeuf
On Thu, Apr 28, 2016 at 12:00:36AM +0200, Arnd Bergmann wrote: > This is another attempt to avoid a regression in wwn_to_u64() > after that started using get_unaligned_be64(), which in turn > ran into a bug on gcc-4.9 through 6.1. > > As part of the problem is how __builtin_constant_p gets evaluat

[PATCH, RFT] byteswap: try to avoid __builtin_constant_p gcc bug

2016-04-27 Thread Arnd Bergmann
This is another attempt to avoid a regression in wwn_to_u64() after that started using get_unaligned_be64(), which in turn ran into a bug on gcc-4.9 through 6.1. As part of the problem is how __builtin_constant_p gets evaluated on an argument passed by reference into an inline function, this avoid

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-27 Thread Arnd Bergmann
On Wednesday 27 April 2016 13:05:03 Martin Jambor wrote: > On Tue, Apr 26, 2016 at 05:58:20PM +0200, Arnd Bergmann wrote: > > On Tuesday 26 April 2016 09:06:54 Martin K. Petersen wrote: > > > > "Arnd" == Arnd Bergmann writes: > > > > > > Arnd> I don't think we can realistically blacklist gcc-

Re: [PATCH v5] qla1280: Don't allocate 512kb of host tags

2016-04-27 Thread James Bottomley
On Wed, 2016-04-27 at 12:39 +0200, Hannes Reinecke wrote: > On 04/27/2016 10:48 AM, Johannes Thumshirn wrote: > > The qla1280 driver sets the scsi_host_template's can_queue field to > > 0xf > > which results in an allocation failure when allocating the block > > layer tags > > for the driver's

RE: [PATCH 09/10] aacraid: Fix for KDUMP driver hang

2016-04-27 Thread Raghava Aditya Renukunta
Hello Johannes, > -Original Message- > From: Johannes Thumshirn [mailto:jthmsh...@suse.de] > Sent: Wednesday, April 27, 2016 2:30 AM > To: Raghava Aditya Renukunta > Cc: jbottom...@odin.com; linux-scsi@vger.kernel.org; > martin.peter...@oracle.com; aacr...@pmc-sierra.com; Gana Sridaran; Sc

RE: [PATCH 08/10] aacraid: Remove code to needlessly complete fib

2016-04-27 Thread Raghava Aditya Renukunta
Hello Johannes, > -Original Message- > From: Johannes Thumshirn [mailto:jthmsh...@suse.de] > Sent: Wednesday, April 27, 2016 2:24 AM > To: Raghava Aditya Renukunta > Cc: jbottom...@odin.com; linux-scsi@vger.kernel.org; > martin.peter...@oracle.com; aacr...@pmc-sierra.com; Gana Sridaran; S

Re: [PATCH 07/12] scsi_debug: use likely hints on fast path

2016-04-27 Thread Bart Van Assche
On 04/26/16 22:25, Douglas Gilbert wrote: On 2016-04-26 06:14 PM, Bart Van Assche wrote: On 04/25/2016 09:16 AM, Douglas Gilbert wrote: -if ((SDEBUG_OPT_MEDIUM_ERR & sdebug_opts) && -(lba <= (OPT_MEDIUM_ERR_ADDR + OPT_MEDIUM_ERR_NUM - 1)) && -((lba + num) > OPT_MEDIUM_ERR_AD

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-27 Thread Martin Jambor
Hi, On Tue, Apr 26, 2016 at 05:58:20PM +0200, Arnd Bergmann wrote: > On Tuesday 26 April 2016 09:06:54 Martin K. Petersen wrote: > > > "Arnd" == Arnd Bergmann writes: > > > > Arnd> I don't think we can realistically blacklist gcc-4.9.{0,1,2,3}, > > Arnd> gcc-5.{0,1,2,3}.* and gcc-6.0 and req

Re: [PATCH v5] qla1280: Don't allocate 512kb of host tags

2016-04-27 Thread Hannes Reinecke
On 04/27/2016 10:48 AM, Johannes Thumshirn wrote: > The qla1280 driver sets the scsi_host_template's can_queue field to 0xf > which results in an allocation failure when allocating the block layer tags > for the driver's queues. This was introduced with the change for host wide > tags in commit

Re: [PATCH 06/10] aacraid: Fix for aac_command_thread hang

2016-04-27 Thread Johannes Thumshirn
On Mon, Apr 25, 2016 at 11:31:57PM -0700, Raghava Aditya Renukunta wrote: > Typically under error conditions, it is possible for aac_command_thread() > to miss the wakeup from kthread_stop() and go back to sleep, causing it > to hang aac_shutdown. > > In the observed scenario, the adapter is not f

Re: [PATCH 04/10] aacraid: Relinquish CPU during timeout wait

2016-04-27 Thread Johannes Thumshirn
On Mon, Apr 25, 2016 at 11:31:26PM -0700, Raghava Aditya Renukunta wrote: > aac_fib_send has a special function case for initial commands during > driver initialization using wait < 0(pseudo sync mode). In this case, > the command does not sleep but rather spins checking for timeout.This > loop is

Re: [PATCH 10/10] aacraid: Update driver version

2016-04-27 Thread Johannes Thumshirn
On Mon, Apr 25, 2016 at 11:32:44PM -0700, Raghava Aditya Renukunta wrote: > Signed-off-by: Raghava Aditya Renukunta > Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE

Re: [PATCH 09/10] aacraid: Fix for KDUMP driver hang

2016-04-27 Thread Johannes Thumshirn
On Mon, Apr 25, 2016 at 11:32:37PM -0700, Raghava Aditya Renukunta wrote: > When KDUMP is triggered the driver first talks to the firmware in INTX > mode, but the adapter firmware is still in MSIX mode. Therefore the first > driver command hangs since the driver is waiting for an INTX response and

Re: [PATCH 08/10] aacraid: Remove code to needlessly complete fib

2016-04-27 Thread Johannes Thumshirn
On Mon, Apr 25, 2016 at 11:32:26PM -0700, Raghava Aditya Renukunta wrote: > Currently driver completes double completed or spurious interrupted fibs. > This is not necessary and causes the SCSI mid layer to issue aborts and > resets, since completing a fib prematurely might trigger a race conditi

Re: [PATCH 07/10] aacraid: Log firmware AIF messages

2016-04-27 Thread Johannes Thumshirn
On Mon, Apr 25, 2016 at 11:32:09PM -0700, Raghava Aditya Renukunta wrote: > Firmware AIF messages about cache loss and data recovery are being missed > by the driver since currently they are not captured but rather let go. > This patch to capture those messages and log them for the user. > > Signe

Re: [PATCH 05/10] aacraid: Disable MSI mode for series 6, 7, 8 cards

2016-04-27 Thread Johannes Thumshirn
On Mon, Apr 25, 2016 at 11:31:43PM -0700, Raghava Aditya Renukunta wrote: > As the firmware for series 6, 7, 8 cards does not support msi, remove it > in the driver > > Signed-off-by: Raghava Aditya Renukunta > Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH 02/10] aacraid: Fix incorrectly named MACRO

2016-04-27 Thread Johannes Thumshirn
On Mon, Apr 25, 2016 at 11:31:03PM -0700, Raghava Aditya Renukunta wrote: > Suggested-by: Seymour, Shane M > Signed-off-by: Raghava Aditya Renukunta > Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH 03/10] aacraid: Start adapter after updating number of MSIX vectors

2016-04-27 Thread Johannes Thumshirn
On Mon, Apr 25, 2016 at 11:31:12PM -0700, Raghava Aditya Renukunta wrote: > The adapter has to be started after updating the number of MSIX Vectors > > Fixes: ecc479e00db8 (aacraid: Set correct MSIX count for EEH recovery) > Cc: sta...@vger.kernel.org > > Signed-off-by: Raghava Aditya Renukunta

[PATCH v5] qla1280: Don't allocate 512kb of host tags

2016-04-27 Thread Johannes Thumshirn
The qla1280 driver sets the scsi_host_template's can_queue field to 0xf which results in an allocation failure when allocating the block layer tags for the driver's queues. This was introduced with the change for host wide tags in commit 64d513ac31b - "scsi: use host wide tags by default". Red