Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread Wei Fang
On 2016/6/2 10:37, Wei Fang wrote: > Hi, Kevin, > > On 2016/6/1 22:36, Kevin Groeneveld wrote: >>> Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of >>> ->host_failed >> >> I wonder if this could be related to >> http://www.spinics.net/lists/linux-scsi/msg86808.html? >>

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread Wei Fang
Hi, Kevin, On 2016/6/1 22:36, Kevin Groeneveld wrote: >> Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of >> ->host_failed > > I wonder if this could be related to > http://www.spinics.net/lists/linux-scsi/msg86808.html? > > I never did get to the bottom of that. If I

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread Wei Fang
Hi, James, On 2016/6/1 22:06, James Bottomley wrote: > On Tue, 2016-05-31 at 16:38 +0800, Wei Fang wrote: >> sas_ata_strategy_handler() adds the works of the ata error handler >> to system_unbound_wq. This workqueue asynchronously runs work items, >> so the ata error handler will be performed conc

spoluprace=

2016-06-01 Thread Pbert
Jsem zastupujicí investicní zajem ze strany Dubaji, pro ktere hledáme vasi ucast. Odpoved na e-mailu nize v pripade zajmu. E-mail: pbrt...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo in

Re: [PATCH v4 0/8] Replay Protected Memory Block (RPMB) subsystem

2016-06-01 Thread Arve Hjønnevåg
On Wed, Jun 1, 2016 at 2:41 PM, Tomas Winkler wrote: > Few storage technology such is EMMC, UFS, and NVMe support RPMB > hardware partition with common protocol and frame layout. > The RPMB partition cannot be accessed via standard block layer, but > by a set of specific commands: WRITE, READ, GET

Re: [PATCH] sd: Fix rw_max for devices that report an optimal xfer size

2016-06-01 Thread Andrew Patterson
On 06/01/2016 01:52 AM, Christoph Hellwig wrote: > Looks fine, > > Reviewed-by: Christoph Hellwig > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.ht

[PATCH v4 0/8] Replay Protected Memory Block (RPMB) subsystem

2016-06-01 Thread Tomas Winkler
Few storage technology such is EMMC, UFS, and NVMe support RPMB hardware partition with common protocol and frame layout. The RPMB partition cannot be accessed via standard block layer, but by a set of specific commands: WRITE, READ, GET_WRITE_COUNTER, and PROGRAM_KEY. Such a partition provides aut

[PATCH v4 1/8] rpmb: add Replay Protected Memory Block (RPMB) subsystem

2016-06-01 Thread Tomas Winkler
Few storage technologies such is EMMC, UFS, and NVMe support RPMB hardware partition with common protocol and frame layout. The RPMB partition cannot be accessed via standard block layer, but by a set of specific commands: WRITE, READ, GET_WRITE_COUNTER, and PROGRAM_KEY. Such a partition provides a

[PATCH v4 4/8] char: rpmb: provide user space interface

2016-06-01 Thread Tomas Winkler
The user space API is achieved via single synchronous IOCTL. The request is submitted in in_frames_ptr pointer and received in out_frames_ptr. V2: use memdup_user V3: commit message fix V4: resend Signed-off-by: Tomas Winkler --- Documentation/ioctl/ioctl-number.txt | 1 + MAINTAINERS

[PATCH v4 5/8] char: rpmb: add RPMB simulation device

2016-06-01 Thread Tomas Winkler
This is a simple platform device used for testing the rpmb subsystem. The module currently supports two configuration options: 1. max_wr_blks: for specifying max blocks that can be written in a single command 2. daunits: used to set storage capacity in 128K units. V2: remove .owner setting, it i

[PATCH v4 3/8] char: rpmb: add device attributes

2016-06-01 Thread Tomas Winkler
Add attribute type that displays underlay storage type technology EMMC, UFS, and attribute id, that displays underlay storage device id. For EMMC this would be content of CID and for UFS serial number from the device descriptor. V2: resend V3: set the kernel version to 4.7 V4: set the kernel versi

[PATCH v4 2/8] char: rpmb: add sysfs-class ABI documentation

2016-06-01 Thread Tomas Winkler
V2: resend V3: add more verbose description V4: update kernel version to 4.8 Signed-off-by: Tomas Winkler --- Documentation/ABI/testing/sysfs-class-rpmb | 20 MAINTAINERS| 1 + 2 files changed, 21 insertions(+) create mode 100644 Documentati

[PATCH v4 6/8] tools rpmb: add RPBM access tool

2016-06-01 Thread Tomas Winkler
Add simple RPMB host testing tool. It can be used to program key, write and read data block, and retrieve write counter. V2: resend V3: fix missing objtool V4: add verbose option Signed-off-by: Tomas Winkler --- MAINTAINERS | 1 + tools/Makefile| 14 +- tools/rpmb/.gitignor

[PATCH 12/14] target/sbc: Convert sbc_ops->execute_write_same to target_iostate

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts IBLOCK + FILEIO for sbc_ops->execute_write_same() to accept struct target_iostate, and pass a new get_sectors() function pointer used to decode a command set specific number of logical blocks (NoLB). Cc: Jens Axboe Cc: Christoph Hellwig Cc: Martin P

[PATCH 07/14] target/sbc: Convert sbc_ops->execute_rw to target_iostate

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Convert IBLOCK, FILEIO and RD to use target_iostate. This includes converting sbc_ops->execute_rw() to accept a function pointer callback: void (*t_comp_func)(struct target_iostate *, u16)) As well as a 'bool fua_write' flag for signaling forced unit-access to IBLO

[PATCH 06/14] target: Convert se_cmd->execute_cmd to target_iostate

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts the se_cmd->execute_cmd() caller to accept target_iostate, and updates existing users tree-wide. Cc: Jens Axboe Cc: Christoph Hellwig Cc: Martin Petersen Cc: Sagi Grimberg Cc: Hannes Reinecke Cc: Mike Christie Signed-off-by: Nicholas Bellinger

[PATCH 00/14] target: Allow backends to operate independent of se_cmd

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi Jens, HCH & Co, This series introduces target_iostate and target_iomem descriptors that abstract what existing target backend drivers require in order to process I/O, sync_cache, write_same and unmap via sbc_ops. The purpose is to allow existing target backend driver

[PATCH 01/14] target: Fix for hang of Ordered task in TCM

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger If a command with a Simple task attribute is failed due to a Unit Attention, then a subsequent command with an Ordered task attribute will hang forever. The reason for this is that the Unit Attention status is checked for in target_setup_cmd_from_cdb, before the call to

[PATCH 04/14] target: Add target_complete_ios wrapper

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds a basic target_complete_ios() wrapper to dereference struct se_cmd from struct target_iostate, and invoke existing target_complete_cmd() code. It also includes PSCSI + TCMU backend driver conversions. Cc: Jens Axboe Cc: Christoph Hellwig Cc: Martin Pet

[PATCH 08/14] target/sbc: Convert sbc_dif_copy_prot to target_iostate

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts sbc_dif_copy_prot() to use struct target_iomem for existing T10-PI scatterlist memory and scatterlist count dereferences. Also convert the single external user in rd_do_prot_rw() code. Cc: Jens Axboe Cc: Christoph Hellwig Cc: Martin Petersen Cc: S

[PATCH 03/14] target: Add target_iostate descriptor

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch introduces a new struct target_iostate descriptor containing logical block address, length in bytes, data_direction, T10-PI, and target_iostate completion callback. This includes: - t_task_* // Used for LBA + Number of LBAs - data_* // Used for length

[PATCH 05/14] target: Setup target_iostate memory in __target_execute_cmd

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch sets up the required target_iostate pointers to se_cmd->execute_cmd() via existing sbc_ops. This includes: - struct se_device, - struct target_iomem, - and ->t_comp_func() callback. Cc: Jens Axboe Cc: Christoph Hellwig Cc: Martin Petersen Cc: Sag

[PATCH 14/14] target: Make sbc_ops accessable via target_backend_ops

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch allows backend driver sbc_ops function pointers to be accessed externally, so external target consumers can perform target_iostate + target_iomem I/O submission outside of /sys/kernel/config/target/$FABRIC/ users. Specifically, IBLOCK, FILEIO, and RAMDISK have

[PATCH 11/14] target/sbc: Convert sbc_ops->execute_sync_cache to target_iostate

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch convert IBLOCK + FILEIO for sbc_ops->execute_sync_cache() to accept struct target_iostate, and avoid backend driver sync_cache SCSI CDB decoding for immediate as reported by HCH. Reported-by: Christoph Hellwig Cc: Jens Axboe Cc: Martin Petersen Cc: Sagi Gri

[PATCH 13/14] target/sbc: Convert sbc_ops->execute_unmap to target_iostate

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts IBLOCK + FILEIO for sbc_ops->execute_unmap() to accept struct target_iostate. Cc: Jens Axboe Cc: Christoph Hellwig Cc: Martin Petersen Cc: Sagi Grimberg Cc: Hannes Reinecke Cc: Mike Christie Signed-off-by: Nicholas Bellinger --- drivers/target

[PATCH 09/14] target/file: Convert sbc_dif_verify to target_iostate

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts sbc_dif_verify() and associated existing T10-PI FILEIO driver to use target_iostate Also add FIXMEs for target_*_prot_action for target_iostate + target_iomem so this logic can eventually used by external drivers doing TARGET_PROT_DOUT_INSERT + TARGET

[PATCH 02/14] target: Add target_iomem descriptor

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch introduces a new struct target_iomem descriptor containing scatterlist memory + scatterlist counts within existing struct se_cmd. This includes: - t_data_* // Used to store READ/WRITE payloads - t_data_*_orig // Used to store COMPARE_AND_WRITE payload

[PATCH 10/14] target/iblock: Fold iblock_req into target_iostate

2016-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch folks the two existing iblock_req members into target_iostate, and updates associated sbc_ops iblock_execute_rw() iblock_execute_write_same() callbacks. Also, go ahead and drop target_iostate->priv now that it's unused. Cc: Jens Axboe Cc: Christoph Hellwig

[PATCH v4 7/8] mmc: block: register RPMB partition with the RPMB subsystem

2016-06-01 Thread Tomas Winkler
Register eMMC RPMB partition with the RPMB subsystem and provide implementation for the RPMB access operations abstracting actual multi step process. V2: resend V3: commit message fix V4: Kconfig: use select RPMB to ensure valid configuration Switch back to main area after RPMB access Signed-

[PATCH v4 8/8] scsi: ufs: connect to RPMB subsystem

2016-06-01 Thread Tomas Winkler
Register UFS RPMB LUN with the RPMB subsystem and provide implementation for the RPMB access operations. RPMB partition is accessed via a sequence of security protocol in and security protocol out commands with UFS specific parameters. This multi step process is abstracted into 4 basic RPMB command

Re: Performance degradation on 4.6

2016-06-01 Thread Nicholas A. Bellinger
Hi Robert, Adding HCH + Sagi CC, as there have been significant changes made in RDMA for v4.6 code. On Tue, 2016-05-31 at 17:46 -0600, Robert LeBlanc wrote: > I've been working with iSER trying to maximize performance. I have two > FDR Infiniband cards (three ports total) and I've created multipl

Re: [target:queue 6/14] drivers/target/target_core_sbc.c:384:19: error: assignment from incompatible pointer type

2016-06-01 Thread Nicholas A. Bellinger
On Wed, 2016-06-01 at 17:41 +0800, kbuild test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git queue > head: 4d13930836b3a61c70603178d8a3c60e633e40f1 > commit: 39a54101d1cc581dbf494b0964537e795466e0d4 [6/14] target: Convert > se_cmd->execute_cmd t

Re: [target:queue 3/14] include/trace/events/target.h:131:1: error: 'struct se_cmd' has no member named 'data_length'

2016-06-01 Thread Nicholas A. Bellinger
On Wed, 2016-06-01 at 17:32 +0800, kbuild test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git queue > head: 4d13930836b3a61c70603178d8a3c60e633e40f1 > commit: 11a5da226987da220b750fc40b039936ff6fe5ae [3/14] target: Add > target_iostate descriptor

[PATCH 1/2] lpfc: support for CPU phys_id and core_id on PowerPC64

2016-06-01 Thread Mauricio Faria de Oliveira
ent with large steps on some systems). While in there, include the CPU number in the debug message, which helps reading it on systems with many CPUs. This depends on commit 'powerpc: export cpu_to_core_id()' (submitted to the linuxppc-dev mailing list). Tested on next-20160601 w/ com

[PATCH 0/2] lpfc: PowerPC64 topology information, and per-core scheduling

2016-06-01 Thread Mauricio Faria de Oliveira
(topology information), which has server processors with many cores/threads and per-core caches. Although the series include bits for PowerPC64, the per-core scheduling patch is architecture independent. Tested on next-20160601 (with an extra commit for patch 1/2, see commit msg). Mauricio Faria de

[PATCH 2/2] lpfc: add option for lpfc_fcp_io_sched (LPFC_FCP_SCHED_BY_CPU_CORE)

2016-06-01 Thread Mauricio Faria de Oliveira
Tested on next-20160601. Signed-off-by: Mauricio Faria de Oliveira --- drivers/scsi/lpfc/lpfc_attr.c | 8 +-- drivers/scsi/lpfc/lpfc_hw4.h | 1 + drivers/scsi/lpfc/lpfc_init.c | 54 ++- drivers/scsi/lpfc/lpfc_scsi.c | 3 ++- 4 files changed, 62 insert

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread James Bottomley
On Wed, 2016-06-01 at 08:29 -0700, Bart Van Assche wrote: > On 06/01/2016 07:36 AM, Kevin Groeneveld wrote: > > > Subject: [PATCH v2 1/2] scsi: fix race between simultaneous > > > decrements of ->host_failed > > > > I wonder if this could be related to > > http://www.spinics.net/lists/linux-scsi/

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread Bart Van Assche
On 06/01/2016 07:36 AM, Kevin Groeneveld wrote: Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed I wonder if this could be related to http://www.spinics.net/lists/linux-scsi/msg86808.html? I never did get to the bottom of that. If I have time I hope to

RE: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread Kevin Groeneveld
> Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of > ->host_failed I wonder if this could be related to http://www.spinics.net/lists/linux-scsi/msg86808.html? I never did get to the bottom of that. If I have time I hope to retest my scsi hang issue with this patch.

Re: unexpected sync delays in dpkg for small pre-allocated files on ext4

2016-06-01 Thread Theodore Ts'o
On Wed, Jun 01, 2016 at 03:17:14PM +0200, Gernot Hillier wrote: > I repeated the discussed tests and found comparable results on this machine: > > - 3 seconds dpkg install time on ext3 vs. 80 seconds for ext4 > on same partition for same package > - 40 ms for fallocate+write+sync_file_range for

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread James Bottomley
On Tue, 2016-05-31 at 16:38 +0800, Wei Fang wrote: > sas_ata_strategy_handler() adds the works of the ata error handler > to system_unbound_wq. This workqueue asynchronously runs work items, > so the ata error handler will be performed concurrently on different > CPUs. In this case, ->host_failed w

Re: unexpected sync delays in dpkg for small pre-allocated files on ext4

2016-06-01 Thread Gernot Hillier
On 01.06.2016 11:44, Gernot Hillier wrote: > Hi! > > On 31.05.2016 02:21, Dave Chinner wrote: >> On Mon, May 30, 2016 at 10:27:52AM +0200, Gernot Hillier wrote: >>> Hi! >>> >>> On 25.05.2016 01:13, Theodore Ts'o wrote: On Tue, May 24, 2016 at 07:07:41PM +0200, Gernot Hillier wrote: > We e

Re: unexpected sync delays in dpkg for small pre-allocated files on ext4

2016-06-01 Thread Gernot Hillier
Hi! On 31.05.2016 02:21, Dave Chinner wrote: > On Mon, May 30, 2016 at 10:27:52AM +0200, Gernot Hillier wrote: >> Hi! >> >> On 25.05.2016 01:13, Theodore Ts'o wrote: >>> On Tue, May 24, 2016 at 07:07:41PM +0200, Gernot Hillier wrote: We experience strange delays with kernel 4.1.18 during dpkg

[target:queue 6/14] drivers/target/target_core_sbc.c:384:19: error: assignment from incompatible pointer type

2016-06-01 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git queue head: 4d13930836b3a61c70603178d8a3c60e633e40f1 commit: 39a54101d1cc581dbf494b0964537e795466e0d4 [6/14] target: Convert se_cmd->execute_cmd to target_iostate config: sh-allyesconfig (attached as .config) compile

[target:queue 3/14] include/trace/events/target.h:131:1: error: 'struct se_cmd' has no member named 'data_length'

2016-06-01 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git queue head: 4d13930836b3a61c70603178d8a3c60e633e40f1 commit: 11a5da226987da220b750fc40b039936ff6fe5ae [3/14] target: Add target_iostate descriptor config: tile-allyesconfig (attached as .config) compiler: tilegx-linu

Re: [PATCH 3/5] scsi: Use pci_(request|release)_mem_regions

2016-06-01 Thread Johannes Thumshirn
On Wed, Jun 01, 2016 at 12:59:29AM -0700, Christoph Hellwig wrote: > On Tue, May 31, 2016 at 02:05:11PM +0200, Johannes Thumshirn wrote: > > Now that we do have pci_request_mem_regions() and pci_release_mem_regions() > > at > > hand, use it in the lpfc driver. > > This should read lpfc instead of

Re: [PATCH 3/5] scsi: Use pci_(request|release)_mem_regions

2016-06-01 Thread Christoph Hellwig
On Tue, May 31, 2016 at 02:05:11PM +0200, Johannes Thumshirn wrote: > Now that we do have pci_request_mem_regions() and pci_release_mem_regions() at > hand, use it in the lpfc driver. This should read lpfc instead of scsi in the subject line. Also the request side of the patch seems to be missing

Re: [PATCH] sd: Fix rw_max for devices that report an optimal xfer size

2016-06-01 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html