Re: [PATCH-v2 16/16] target/iblock: Convert to inline bio/bvec + blk_poll

Hi, [auto build test ERROR on target/master] [also build test ERROR on v4.7-rc2 next-20160606] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nicholas-A-Bellinger/target-Allow-backends

Re: [PATCH v3 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed

On 2016/6/7 11:22, Martin K. Petersen wrote: >> "Wei" == Wei Fang writes: > > Wei, > > Wei> Update the new rules of ->host_failed. > > Are you going to incorporate the amendment from James? > Yes, I'll send the patch soon. Thanks, Wei -- To unsubscribe from this

[PATCH-v2 14/16] target: Make sbc_ops accessable via target_backend_ops

From: Nicholas Bellinger This patch allows backend driver sbc_ops function pointers to be accessed externally, so external target consumers can perform target_iostate + target_iomem I/O submission outside of /sys/kernel/config/target/$FABRIC/ users. Specifically, IBLOCK,

[PATCH-v2 08/16] target/sbc: Convert sbc_dif_copy_prot to target_iostate

From: Nicholas Bellinger This patch converts sbc_dif_copy_prot() to use struct target_iomem for existing T10-PI scatterlist memory and scatterlist count dereferences. Also convert the single external user in rd_do_prot_rw() code. Cc: Jens Axboe Cc:

[PATCH-v2 05/16] target: Setup target_iostate memory in __target_execute_cmd

From: Nicholas Bellinger This patch sets up the required target_iostate pointers to se_cmd->execute_cmd() via existing sbc_ops. This includes: - struct se_device, - struct target_iomem, - and ->t_comp_func() callback. Cc: Jens Axboe Cc: Christoph

[PATCH-v2 16/16] target/iblock: Convert to inline bio/bvec + blk_poll

From: Nicholas Bellinger This patch converts IBLOCK to use inline_bio and inline_bvec as part of target_iostate, and converts iblock_execute_rw() and iblock_execute_write_same() accordingly. Also, it follows nvme-target/io-cmd code and uses blk_poll() for both cases with

[PATCH-v2 02/16] target: Add target_iomem descriptor

From: Nicholas Bellinger This patch introduces a new struct target_iomem descriptor containing scatterlist memory + scatterlist counts within existing struct se_cmd. This includes: - t_data_* // Used to store READ/WRITE payloads - t_data_*_orig // Used to store

[PATCH-v2 03/16] target: Add target_iostate descriptor

From: Nicholas Bellinger This patch introduces a new struct target_iostate descriptor containing logical block address, length in bytes, data_direction, T10-PI, and target_iostate completion callback. This includes: - t_task_* // Used for LBA + Number of LBAs -

[PATCH-v2 11/16] target/sbc: Convert sbc_ops->execute_sync_cache to target_iostate

From: Nicholas Bellinger This patch convert IBLOCK + FILEIO for sbc_ops->execute_sync_cache() to accept struct target_iostate, and avoid backend driver sync_cache SCSI CDB decoding for immediate as reported by HCH. Reported-by: Christoph Hellwig Cc: Jens

[PATCH-v2 07/16] target/sbc: Convert sbc_ops->execute_rw to target_iostate

From: Nicholas Bellinger Convert IBLOCK, FILEIO and RD to use target_iostate. This includes converting sbc_ops->execute_rw() to accept a function pointer callback: void (*t_comp_func)(struct target_iostate *, u16)) As well as a 'bool fua_write' flag for signaling

[PATCH-v2 06/16] target: Convert se_cmd->execute_cmd to target_iostate

From: Nicholas Bellinger This patch converts the se_cmd->execute_cmd() caller to accept target_iostate, and updates existing users tree-wide. Cc: Jens Axboe Cc: Christoph Hellwig Cc: Martin Petersen Cc: Sagi

[PATCH-v2 15/16] target/sbc: Convert ->execute_unmap to __blkdev_issue_discard

From: Nicholas Bellinger As prep for nvme-target, this patch converts sbc_ops->execute_unmap() usage in existing target_core_sbc.c, IBLOCK and FILEIO backend drivers to use __blkdev_issue_discard() with async completion. Also, propigate struct bio ** as a new

[PATCH-v2 12/16] target/sbc: Convert sbc_ops->execute_write_same to target_iostate

From: Nicholas Bellinger This patch converts IBLOCK + FILEIO for sbc_ops->execute_write_same() to accept struct target_iostate, and pass a new get_sectors() function pointer used to decode a command set specific number of logical blocks (NoLB). Cc: Jens Axboe

[PATCH-v2 09/16] target/file: Convert sbc_dif_verify to target_iostate

From: Nicholas Bellinger This patch converts sbc_dif_verify() and associated existing T10-PI FILEIO driver to use target_iostate Also add FIXMEs for target_*_prot_action for target_iostate + target_iomem so this logic can eventually used by external drivers doing

[PATCH-v2 13/16] target/sbc: Convert sbc_ops->execute_unmap to target_iostate

From: Nicholas Bellinger This patch converts IBLOCK + FILEIO for sbc_ops->execute_unmap() to accept struct target_iostate. Cc: Jens Axboe Cc: Christoph Hellwig Cc: Martin Petersen Cc: Sagi Grimberg

[PATCH-v2 04/16] target: Add target_complete_ios wrapper

From: Nicholas Bellinger This patch adds a basic target_complete_ios() wrapper to dereference struct se_cmd from struct target_iostate, and invoke existing target_complete_cmd() code. It also includes PSCSI + TCMU backend driver conversions. Cc: Jens Axboe

[PATCH-v2 01/16] target: Fix for hang of Ordered task in TCM

From: Nicholas Bellinger If a command with a Simple task attribute is failed due to a Unit Attention, then a subsequent command with an Ordered task attribute will hang forever. The reason for this is that the Unit Attention status is checked for in

[PATCH-v2 00/16] target: Allow backends to operate independent of se_cmd

From: Nicholas Bellinger Hi Jens, HCH & Co, This -v2 series introduces target_iostate + target_iomem descriptors that abstract what existing target backend drivers require in order to process I/O, sync_cache, write_same and unmap via sbc_ops. The purpose is to allow

[PATCH-v2 10/16] target/iblock: Fold iblock_req into target_iostate

From: Nicholas Bellinger This patch folks the two existing iblock_req members into target_iostate, and updates associated sbc_ops iblock_execute_rw() iblock_execute_write_same() callbacks. Also, go ahead and drop target_iostate->priv now that it's unused. Cc: Jens Axboe

Re: [PATCH] bnx2i: fix spelling mistake "complection" -> "completion"

> "Colin" == Colin King writes: Colin> trivial fix to spelling mistake in printk message Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a

Re: [PATCH] sd: remove redundant check for BLK_DEF_MAX_SECTORS

> "Long" == Long Li writes: Long, Long> The reason is that, max_sectors already has value at this point, Long> the default value is SCSI_DEFAULT_MAX_SECTORS Long> (include/scsi/scsi_host.h). The lower layer host driver can change Long> this value in its template. The

Re: [PATCH v3 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed

> "Wei" == Wei Fang writes: Wei, Wei> Update the new rules of ->host_failed. Are you going to incorporate the amendment from James? Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi"

Re: [PATCH v2] scsi_debug: fix sleep in invalid context

> "Doug" == Douglas Gilbert writes: Doug> In this post: Doug> http://www.spinics.net/lists/linux-scsi/msg97124.html the author Doug> shows some kernel infrastructure complaining about a sleep in an Doug> invalid context. Remove offending call to vmalloc(). Instead of

Re: [PATCH 0/3] hisi_sas: v2 hw ACPI support and fix lock

> "John" == John Garry writes: John> This patchset introduces 2 separate features/fixes: - v2 hw ACPI John> support: implemented the same as v1 hw - fix inconsistent lock: John> remove unnecessary spinlock_irqsave() in broadcast interrupt John> handler Applied to

[target:nvmet-configfs-ng 20/49] ERROR: "__udivdi3" [drivers/nvme/target/nvmet.ko] undefined!

tree: https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git nvmet-configfs-ng head: 4b4848d0251cd5c5f21fe67564ec8e85803f89e0 commit: c69865ef813e970b248b7b06ba9d027db862771f [20/49] nvmet: add a generic NVMe target config: i386-allmodconfig (attached as .config) compiler:

Re: linux-next: Tree for Jun 6 (scsi_debug.c)

On 06/05/16 21:20, Stephen Rothwell wrote: > Hi all, > > Changes since 20160603: on x86_64: ERROR: "ip_compute_csum" [drivers/scsi/scsi_debug.ko] undefined! CONFIG_GENERIC_CSUM doesn't seem to exist for x86, so lib/checksum.o is not built. -- ~Randy -- To unsubscribe from this list: send

Re: [PATCH 2/4] Add bio/request flags for using ZBC/ZAC commands

On Mon, Jun 6, 2016 at 10:39 AM, Shaun Tancheff wrote: > > T10 ZBC and T13 ZAC specify operations for Zoned devices. > > To be able to access the zone information and open and close zones > adding flags for the report zones command (REQ_REPORT_ZONES) and for > Open and Close

ATTENTION ! ATTENTION !! ATTENTION !!!

Greetings Dear Friend, I never want to disturb you at all but will like you give me your attention. I need a matured and capable hand in a business deal of $8, 500, 000.00 (Eight Million Five Hundred Thousand USA Dollars).I belief you are suitable to handle such project perfectly .I will

[PATCH] Add support for SCT Write Same

SATA drives may support write same via SCT. This is useful for setting the drive contents to a specific pattern (0's). Signed-off-by: Shaun Tancheff --- drivers/ata/libata-scsi.c | 31 + drivers/scsi/sd.c | 25 +++-

[PATCH] Add support for Write Same via SCT

At some point the method of issuing Write Same for ATA drives changed. Currently write same is commonly available via SCT so expose the SCT capabilities and use SCT Write Same if available. This is useful for zoned based media that prefers to support discard with lbprz set, aka discard zeroes

Re: [PATCH 2/4] Add bio/request flags for using ZBC/ZAC commands

Hi, [auto build test WARNING on scsi/for-next] [also build test WARNING on v4.7-rc2 next-20160606] [cannot apply to block/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Shaun-Tancheff

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

On 06/06/2016 17:47, John Snow wrote: > > > Various downstreams may have backported the VPD fix to older versions, > > > we need to be careful not to block those, too ... so targeting the core > > > behavior seems like the more strictly correct, easily maintainable > > > solution. > > > > I

[PATCH 1/4] Add support for SCT Write Same

SATA drives may support write same via SCT. This is useful for setting the drive contents to a specific pattern (0's). Signed-off-by: Shaun Tancheff --- block/blk-core.c | 17 ++--- block/blk-merge.c| 2 +- block/blk-mq.c | 2

[PATCH 4/4] Add ata pass-through path for ZAC commands.

The current generation of HBA SAS adapters support connecting SATA drives and perform SCSI<->ATA translations in hardware. Unfortunately the ZBC commands are not being translate (yet). Currently users of SAS controllers can only send ZAC commands via ata pass-through. This method overloads the

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

On 06/06/2016 17:41, John Snow wrote: > On 06/06/2016 11:05 AM, Paolo Bonzini wrote: >> For ATAPI, you have to blacklist all versions up to 2.2 inclusive. >> >> This gives: >> >> - QEMU / QEMU CD-ROM / 0.8.(this is IDE and SCSI) >> - QEMU / QEMU CD-ROM / 0.9.(this is IDE and SCSI) >> -

Re: [PATCH 28/45] target: use bio op accessors

On 06/06/2016 05:40 PM, Mike Christie wrote: On 06/06/2016 01:46 AM, Hannes Reinecke wrote: On 06/05/2016 09:32 PM, mchri...@redhat.com wrote: From: Mike Christie Separate the op from the rq_flag_bits and have the target layer set/get the bio using

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

On 06/06/2016 11:43 AM, Paolo Bonzini wrote: > > > On 06/06/2016 17:41, John Snow wrote: >> On 06/06/2016 11:05 AM, Paolo Bonzini wrote: >>> For ATAPI, you have to blacklist all versions up to 2.2 inclusive. >>> >>> This gives: >>> >>> - QEMU / QEMU CD-ROM / 0.8.(this is IDE and SCSI) >>>

[PATCH 2/4] Add bio/request flags for using ZBC/ZAC commands

T10 ZBC and T13 ZAC specify operations for Zoned devices. To be able to access the zone information and open and close zones adding flags for the report zones command (REQ_REPORT_ZONES) and for Open and Close zone (REQ_OPEN_ZONE and REQ_CLOSE_ZONE) can be added for use by struct bio's bi_rw and

[PATCH 3/4] Add ioctl to issue ZBC/ZAC commands via block layer

Add New ioctl types BLKREPORT- Issue Report Zones to device. BLKOPENZONE - Issue an Zone Action: Open Zone command. BLKCLOSEZONE - Issue an Zone Action: Close Zone command. BLKRESETZONE - Issue an Zone Action: Reset Zone command. Signed-off-by: Shaun Tancheff

[PATCH 0/4] Block layer support ZAC/ZBC commands

As Host Aware drives are becoming available we would like to be able to make use of such drives. This series is also intended to be suitable for use by Host Managed drives. ZAC/ZBC drives add new commands for discovering and working with Zones. This extends the ZAC/ZBC support up to the block

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

On 06/06/2016 11:05 AM, Paolo Bonzini wrote: > > > On 06/06/2016 16:22, Hannes Reinecke wrote: >> So either we dig into what went wrong with qemu 0.8, or we figure out >> from which qemu version things start to behave nicely, and blacklist >> earlier versions. >> Either way, this patch is

Re: [PATCH 28/45] target: use bio op accessors

On 06/06/2016 01:46 AM, Hannes Reinecke wrote: > On 06/05/2016 09:32 PM, mchri...@redhat.com wrote: >> From: Mike Christie >> >> Separate the op from the rq_flag_bits and have the target layer >> set/get the bio using bio_set_op_attrs/bio_op. >> >> Signed-off-by: Mike

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

On 06/06/2016 16:22, Hannes Reinecke wrote: > So either we dig into what went wrong with qemu 0.8, or we figure out > from which qemu version things start to behave nicely, and blacklist > earlier versions. > > > > Either way, this patch is wrong. > > > > If we can identify which versions

[Bug 118621] After upgrading from ubuntu 15.10 to 16.04 CD-R's won't mount, others mount just fine

https://bugzilla.kernel.org/show_bug.cgi?id=118621 --- Comment #2 from albapom...@gmail.com --- After looking for more information, I found this comment on a forum. Hi, this must be a new bug with Linux kernel or udev. A significant difference between CD TAO and CD SAO at

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

On 06/06/2016 04:11 PM, Ewan D. Milne wrote: > > > On Mon, 2016-06-06 at 09:34 +0200, Hannes Reinecke wrote: >> On 05/31/2016 03:42 PM, Ewan D. Milne wrote: >>> Linux fails to boot as a guest with a QEMU CD-ROM: >>> >>> [4.439488] ata2.00: ATAPI: QEMU CD-ROM, 0.8.2, max UDMA/100 >>> [

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

On Mon, 2016-06-06 at 09:34 +0200, Hannes Reinecke wrote: > On 05/31/2016 03:42 PM, Ewan D. Milne wrote: > > Linux fails to boot as a guest with a QEMU CD-ROM: > > > > [4.439488] ata2.00: ATAPI: QEMU CD-ROM, 0.8.2, max UDMA/100 > > [4.443649] ata2.00: configured for MWDMA2 > > [

RE: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

-Original Message- From: Wei Fang [mailto:fangw...@huawei.com] Sent: June-01-16 10:37 PM >The concurrently decrements of host_failed only lead to abnormal of >host_failed, host_busy will be zero after error handler, and >the result may >be host_failed > host_busy forever. But in your

Re: [PATCH v2 3/6] lpfc: Use pci_(request|release)_mem_regions

On Thu, Jun 02, 2016 at 07:57:43AM -0400, Dick Kennedy wrote: > Thanks Johannes, it looks good. Hi Dick, Can I use this as an Acked-by in the next submission? Thanks, Johannes > > On Thu, Jun 2, 2016 at 3:30 AM, Johannes Thumshirn > wrote: > > > Now that we do

[PATCH] scsi:stex.c Support Pegasus 3 product

From: Charles Pegasus series is a RAID support product by using Thunderbolt technology. The newest product, Pegasus 3 is support Thunderbolt 3 technology with another chip. 1.Change driver version. 2.Add Pegasus 3 VID, DID and define it's device address.

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

On 05/31/2016 03:42 PM, Ewan D. Milne wrote: > Linux fails to boot as a guest with a QEMU CD-ROM: > > [4.439488] ata2.00: ATAPI: QEMU CD-ROM, 0.8.2, max UDMA/100 > [4.443649] ata2.00: configured for MWDMA2 > [4.450267] scsi 1:0:0:0: CD-ROMQEMU QEMU CD-ROM 0.8. >

[PATCH 1/3] driver-core: Implement device_match_always()

From: Thierry Reding This is a helper function that can be used in iterators, such as bus_find_device(), and will always match. This is useful to implement a custom iterator interface on top of bus_find_device() or to check if any devices have been registered at all.

[PATCH 2/3] PCI: Use device_match_always()

From: Thierry Reding There is now a common implementation for a match function that will always match, so the PCI-specific implementation can be removed. Signed-off-by: Thierry Reding --- drivers/pci/probe.c | 7 +-- 1 file changed, 1 insertion(+),

[PATCH 3/3] scsi: Use device_match_always()

From: Thierry Reding There is now a common implementation for a match function that will always match, so the SCSI-specific implementation can be removed. Signed-off-by: Thierry Reding --- drivers/scsi/scsi_proc.c | 7 +-- 1 file changed, 1

Re: [PATCH 42/45] block, fs, drivers: remove REQ_OP compat defs and related code

On 06/05/2016 09:32 PM, mchri...@redhat.com wrote: > From: Mike Christie > > This patch drops the compat definition of req_op where it matches > the rq_flag_bits definitions, and drops the related old and compat > code that allowed users to set either the op or flags for the

Re: [PATCH 40/45] block: move bio io prio to a new field

On 06/05/2016 09:32 PM, mchri...@redhat.com wrote: > From: Mike Christie > > In the next patch, we move drop the compat code and make > the op a separate value that is hidden in bi_rw. To give > the op and rq bits flags room to grow this moves prio to > its own field. > >

Re: [PATCH 41/45] block, drivers, fs: shrink bi_rw from long to int

On 06/05/2016 09:32 PM, mchri...@redhat.com wrote: > From: Mike Christie > > We don't need bi_rw to be so large on 64 bit archs, so > reduce it to unsigned int. > > Signed-off-by: Mike Christie > --- > block/blk-core.c | 2 +- >

Re: [PATCH 37/45] drivers: use req op accessor

On 06/05/2016 09:32 PM, mchri...@redhat.com wrote: > From: Mike Christie > > The req operation REQ_OP is separated from the rq_flag_bits > definition. This converts the block layer drivers to > use req_op to get the op from the request struct. > > Signed-off-by: Mike

Re: [PATCH 28/45] target: use bio op accessors

On 06/05/2016 09:32 PM, mchri...@redhat.com wrote: > From: Mike Christie > > Separate the op from the rq_flag_bits and have the target layer > set/get the bio using bio_set_op_attrs/bio_op. > > Signed-off-by: Mike Christie > --- >

Re: [PATCH 25/45] bcache: use bio op accessors

On 06/05/2016 09:32 PM, mchri...@redhat.com wrote: > From: Mike Christie > > Separate the op from the rq_flag_bits and have bcache > set/get the bio using bio_set_op_attrs/bio_op. > > Signed-off-by: Mike Christie > --- > drivers/md/bcache/btree.c

Re: [PATCH 24/45] dm: use bio op accessors

On 06/05/2016 09:32 PM, mchri...@redhat.com wrote: > From: Mike Christie > > Separate the op from the rq_flag_bits and have dm > set/get the bio using bio_set_op_attrs/bio_op. > > Signed-off-by: Mike Christie > Reviewed-by: Hannes Reinecke

Re: [PATCH 09/45] block discard: use bio set op accessor

On 06/05/2016 09:31 PM, mchri...@redhat.com wrote: > From: Mike Christie > > This converts the block issue discard helper and users to use > the bio_set_op_attrs accessor and only pass in the operation flags > like REQ_SEQURE. > > Signed-off-by: Mike Christie

Re: [PATCH 08/45] block, fs, mm, drivers: use bio set/get op accessors

On 06/05/2016 09:31 PM, mchri...@redhat.com wrote: > From: Mike Christie > > This patch converts the simple bi_rw use cases in the block, > drivers, mm and fs code to set/get the bio operation using > bio_set_op_attrs/bio_op > > These should be simple one or two liner

Re: [PATCH 07/45] bcache: use op_is_write instead of checking for REQ_WRITE

On 06/05/2016 09:31 PM, mchri...@redhat.com wrote: > From: Mike Christie > > We currently set REQ_WRITE/WRITE for all non READ IOs > like discard, flush, writesame, etc. In the next patches where we > no longer set up the op as a bitmap, we will not be able to > detect a

Re: [PATCH 06/45] dm: use op_is_write instead of checking for REQ_WRITE

On 06/05/2016 09:31 PM, mchri...@redhat.com wrote: > From: Mike Christie > > We currently set REQ_WRITE/WRITE for all non READ IOs > like discard, flush, writesame, etc. In the next patches where we > no longer set up the op as a bitmap, we will not be able to > detect a

Re: [PATCH 02/45] block: add REQ_OP definitions and helpers

On 06/05/2016 09:31 PM, mchri...@redhat.com wrote: > From: Mike Christie > > The following patches separate the operation (WRITE, READ, DISCARD, > etc) from the rq_flag_bits flags. This patch adds definitions for > request/bio operations (REQ_OPs) and adds request/bio

Re: [PATCH 05/45] block, drivers, cgroup: use op_is_write helper instead of checking for REQ_WRITE

On 06/05/2016 09:31 PM, mchri...@redhat.com wrote: > From: Mike Christie > > We currently set REQ_WRITE/WRITE for all non READ IOs > like discard, flush, writesame, etc. In the next patches where we > no longer set up the op as a bitmap, we will not be able to > detect a

Re: [PATCH 01/45] block/fs/drivers: remove rw argument from submit_bio

On 06/05/2016 09:31 PM, mchri...@redhat.com wrote: > From: Mike Christie > > This has callers of submit_bio/submit_bio_wait set the bio->bi_rw > instead of passing it in. This makes that use the same as > generic_make_request and how we set the other bio fields. > >