Re: [PATCH v2 0/7] lib: string: add functions to case-convert strings

On 5 July 2016 at 15:56, Joe Perches wrote: > On Tue, 2016-07-05 at 15:36 -0700, Markus Mayer wrote: >> On 5 July 2016 at 15:14, Joe Perches wrote: >> > On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote: >> > > This series introduces a family of generic

Re: [PATCH v2 0/7] lib: string: add functions to case-convert strings

On Tue, 2016-07-05 at 15:36 -0700, Markus Mayer wrote: > On 5 July 2016 at 15:14, Joe Perches wrote: > > On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote: > > > This series introduces a family of generic string case conversion > > > functions. This kind of functionality is

Re: [PATCH v2 1/2] libata-scsi: improve TRIM translation

On Wed, Jul 06, 2016 at 03:10:51AM +0800, Tom Yan wrote: > Well it is exactly what the patch does. We no longer do the "divide it > by 8" thing each time we want to know the now defined TRIM_RANGE_NUM. > > ata_set_lba_range_entries() has only been used by > ata_scsi_write_same_xlat() >

Re: [PATCH v2 2/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

Hello, On Wed, Jul 06, 2016 at 03:13:31AM +0800, Tom Yan wrote: > I just thought that such a minor change in a comment can fit in the > same patch where the issue was first noticed. Anyway, will split them > if I am going to send a v3 set. > > On 5 July 2016 at 19:08, Sergei Shtylyov >

Re: [PATCH v2 0/7] lib: string: add functions to case-convert strings

On 5 July 2016 at 15:14, Joe Perches wrote: > On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote: >> This series introduces a family of generic string case conversion >> functions. This kind of functionality is needed in several places in >> the kernel. Right now, everybody

Re: [PATCH v2 0/7] lib: string: add functions to case-convert strings

On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote: > This series introduces a family of generic string case conversion > functions. This kind of functionality is needed in several places in > the kernel. Right now, everybody seems to be implementing their own > copy of this functionality. > >

Re: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

On Thu, May 26, 2016 at 9:58 PM, Varun Prakash wrote: > Hi Or, Nicholas and Steve > Thank you for the feedback and apologies for the delay in my response. > On Wed, May 25, 2016 at 09:55:04PM -0700, Nicholas A. Bellinger wrote: >> Varun + Co have made common improvements

Unsupported ISP 2432 SSVID/SSDID (0x103C,0x7041)

I just got a HP Proliant DL360G6 with a PCI-E FC card from HP and got this warning during driver initialization: [4.166160] qla2xxx [:00:00.0]-0005: : QLogic Fibre Channel HBA Driver: 8.07.00.33-k. [4.166633] qla2xxx [:07:00.0]-001d: : Found an ISP2432 irq 48 iobase

UBSAN warning from qla2xxx

I tried UBSAN on one of my servers with QLogic FC adapter and got the following UBSAN warning on x86-64: [4.250370] [4.250692] UBSAN: Undefined behaviour in drivers/scsi/qla2xxx/qla_isr.c:2500:14 [

[PATCH v2 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower()

After introducing generic strtolower(), iscsi_initiatorname_tolower() is no longer needed. Signed-off-by: Markus Mayer --- drivers/target/iscsi/iscsi_target_nego.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git

[PATCH v2 1/7] lib: string: add functions to case-convert strings

Add a collection of generic functions to convert strings to lowercase or uppercase. Changing the case of a string (with or without copying it first) seems to be a recurring requirement in the kernel that is currently being solved by several duplicated implementations doing the same thing. This

[PATCH v2 0/7] lib: string: add functions to case-convert strings

This series introduces a family of generic string case conversion functions. This kind of functionality is needed in several places in the kernel. Right now, everybody seems to be implementing their own copy of this functionality. Based on the discussion of the previous version of this series[1]

Re: Reported regressions for 4.7 as of Sunday, 2016-06-19

> "Linus" == Linus Torvalds writes: Linus> It's not in my tree, at least. Not in scsi-fixes either. I have been waiting for a "real" patch submission with one or more Tested-by: tags. I generally don't queue something that comes with a "try this untested

Re: [PATCH v2 2/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

I just thought that such a minor change in a comment can fit in the same patch where the issue was first noticed. Anyway, will split them if I am going to send a v3 set. On 5 July 2016 at 19:08, Sergei Shtylyov wrote: > On 7/5/2016 9:45 AM, tom.t...@gmail.com

Re: [PATCH v2 1/2] libata-scsi: improve TRIM translation

Well it is exactly what the patch does. We no longer do the "divide it by 8" thing each time we want to know the now defined TRIM_RANGE_NUM. ata_set_lba_range_entries() has only been used by ata_scsi_write_same_xlat() (http://lxr.free-electrons.com/ident?i=ata_set_lba_range_entries, although the

Re: Reported regressions for 4.7 as of Sunday, 2016-06-19

On 05.07.2016 19:32, Linus Torvalds wrote: > On Tue, Jul 5, 2016 at 9:30 AM, Josh Boyer wrote: >> On Wed, Jun 22, 2016 at 11:57 AM, Quinn Tran wrote: >>> >>> - if (rsp->msix->cpuid != smp_processor_id()) { >>> + if (rsp->msix &&

Re: Reported regressions for 4.7 as of Sunday, 2016-06-19

On Tue, Jul 5, 2016 at 9:30 AM, Josh Boyer wrote: > On Wed, Jun 22, 2016 at 11:57 AM, Quinn Tran wrote: >> >> - if (rsp->msix->cpuid != smp_processor_id()) { >> + if (rsp->msix && (rsp->msix->cpuid != smp_processor_id())) { > > Did

[PATCH 4/4 v2] scsi: bnx2fc: convert bnx2fc_l2_rcv_thread() to worker

This is not driven by the hotplug conversation but while I am at it looks like a good candidate. Converting the thread to a kworker user removes also the kthread member from struct fcoe_percpu_s. This driver uses the struct fcoe_percpu_s but it does not need the crc_eof_page member, only the work

[PATCH 3/4] scsi: bnx2fc: annoate unlock + release for sparse

The caller of bnx2fc_abts_cleanup() holds the tgt->tgt_lock lock and it is expected to release the lock during wait_for_completion() and acquire the lock afterwards. This patch was only compile-tested due to -ENODEV. Cc: qlogic-storage-upstr...@qlogic.com Cc: Christoph Hellwig

[PATCH 1/4] scsi: bnx2fc: convert per-CPU thread to kworker

The driver creates its own per-CPU threads which are updated based on CPU hotplug events. It is also possible to use kworkers and remove some of the infrastructure get the same job done while saving a few lines of code. bnx2fc_percpu_io_thread() becomes bnx2fc_percpu_io_work() which is mostly the

[PATCH 2/4] scsi: bnx2fc: clean up header definitions

- All symbols which are only used within one .c file are marked static and removed from the bnx2fc.h file if possible. - the declarion of bnx2fc_percpu is moved into the header file This patch was only compile-tested due to -ENODEV. Cc: qlogic-storage-upstr...@qlogic.com Cc: Christoph Hellwig

Re: [PATCH] lpfc: Fix possible NULL pointer dereference

On Tue, Jun 28, 2016 at 01:28:19PM -0700, Tyrel Datwyler wrote: > On 06/15/2016 06:00 AM, Johannes Thumshirn wrote: > > Check for the existance of pciob->vport before accessing it. > > piocb mispelled. Oops > > > > > Signed-off-by: Johannes Thumshirn > > --- > >

Re: [PATCH v2 2/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

On 7/5/2016 9:45 AM, tom.t...@gmail.com wrote: From: Tom Yan It does not make sense and is confusing to respond with "Invalid field in CDB" while we have no support at all implemented for FORMAT UNIT. It is decent to let it go to the default, which will respond with

Re: [PATCH v2 1/2] libata-scsi: improve TRIM translation

Hello. On 7/5/2016 9:45 AM, tom.t...@gmail.com wrote: From: Tom Yan Define TRIM_RANGE_SIZE and TRIM_RANGE_NUM so that the corresponding functions can be more generalized. Also, conform to SBC by rejecting WRITE SAME (16) commands with number of blocks that exceeds the

[PATCH v2 1/2] libata-scsi: improve TRIM translation

From: Tom Yan Define TRIM_RANGE_SIZE and TRIM_RANGE_NUM so that the corresponding functions can be more generalized. Also, conform to SBC by rejecting WRITE SAME (16) commands with number of blocks that exceeds the limit that is defined in the SATL. Signed-off-by: Tom Yan

[PATCH v2 2/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

From: Tom Yan It does not make sense and is confusing to respond with "Invalid field in CDB" while we have no support at all implemented for FORMAT UNIT. It is decent to let it go to the default, which will respond with "Invalid command operation code" instead.