Re: [Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-07 Thread Viswas G
Patch set for pm80xx is pending for the last 3 quarters. We will submit those soon with all the buf fixes and performance tuning changes. Regards, Viswas G On Thu, Jul 7, 2016 at 10:04 PM, wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=121531 > > --- Comment #14 from Jack Wang --- > The

Re: [PATCH v2 1/7] lib: string: add functions to case-convert strings

2016-07-07 Thread Rasmus Villemoes
On Tue, Jul 05 2016, Markus Mayer wrote: > Add a collection of generic functions to convert strings to lowercase > or uppercase. > > Changing the case of a string (with or without copying it first) seems > to be a recurring requirement in the kernel that is currently being > solved by several dup

RE: Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c

2016-07-07 Thread David Carroll
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Pengfei Wang > Sent: Thursday, July 07, 2016 7:00 AM > To: linux-scsi@vger.kernel.org > Subject: Re: Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c > Hi, >

Re: [RFC] libata-scsi: introducing SANITIZE translation

2016-07-07 Thread James Bottomley
On Fri, 2016-07-08 at 00:32 +0800, tom.t...@gmail.com wrote: > From: Tom Yan > > With this patch, users can make use of the SANITIZE DEVICE feature > set through utility like sg_sanitize. > > Support for BLOCK ERASE, CRYPTOGRAPHIC ERASE and EXIT FAILURE MODE > has been implemented. Support for O

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #14 from Jack Wang --- The changes are huge, hard to do it, without help from MicroSemi/PMCs side. And I don't have hardware to test. I've asked developer from MicroSemi to upsteam their changes, but sadly no reply. 2016-07-07 17:36

[RFC] libata-scsi: introducing SANITIZE translation

2016-07-07 Thread tom . ty89
From: Tom Yan With this patch, users can make use of the SANITIZE DEVICE feature set through utility like sg_sanitize. Support for BLOCK ERASE, CRYPTOGRAPHIC ERASE and EXIT FAILURE MODE has been implemented. Support for OVERWRITE that involves a parameter list has been left out for now. Further

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #13 from Martin von Wittich --- Yup, the Debian installation worked and seems to work fine so far. I manually installed the pm80xx-1.4.0-11068-debian64.deb package in the target system while I was still in the installer by chrooting t

Re: [PATCH trivial] fcoe: use defines from ethtool for 20Gbit and 40Gbit speeds

2016-07-07 Thread Laurence Oberman
- Original Message - > From: "Johannes Thumshirn" > To: "Martin K . Petersen" , "James Bottomley" > , "Jiri Kosina" > > Cc: "Linux SCSI Mailinglist" , > fcoe-de...@open-fcoe.org, "Johannes Thumshirn" > > Sent: Thursday, July 7, 2016 9:41:58 AM > Subject: [PATCH trivial] fcoe: use def

[PATCH trivial] fcoe: use defines from ethtool for 20Gbit and 40Gbit speeds

2016-07-07 Thread Johannes Thumshirn
Use defines from ethtool for 20Gbit and 40Gbit speeds instead of magic numbers. Signed-off-by: Johannes Thumshirn --- drivers/scsi/fcoe/fcoe_transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.

Re: [PATCH 2/2] libata-scsi: do not return t10 designator if drive has WWN

2016-07-07 Thread Tom Yan
Yeah it said "One identification descriptor..." but not "Only one identification descriptor...". So I suppose it is *alright* to also return t10 designator in addition to the WWN. It's just redundunt and unnecessary (and that's why I sent the patch), since we only need one LU name (either derive fr

Re: Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c

2016-07-07 Thread Pengfei Wang
Hi, Will anyone bother to confirm and fix this problem I reported last time? From the point of view of security, I think it should be fixed. I have discovered several cases of the same kind and all have been fixed by the maintainers. Thanks! Pengfei 在 2016年4月26日,下午5:00,Pengfei Wang 写道: Hi,

Re: [PATCH 2/2] libata-scsi: better style in ata_msense_caching()

2016-07-07 Thread Sergei Shtylyov
On 07/07/2016 03:44 PM, Tom Yan wrote: Sorry I am a bit new in this. Does that mean I should also use {} for the if clause even it has only one line of statement, because I (needed to) use that for the else clause? So it should be like: if ... { ... } else { ... ... } Exactl

Re: [PATCH 2/2] libata-scsi: do not return t10 designator if drive has WWN

2016-07-07 Thread Hannes Reinecke
On 07/07/2016 02:40 PM, Tom Yan wrote: > Well, udev uses its own `ata_id` (which issues IDENTIFY DEVICE through > ATA PASS-THROUGH) though. > > Anyway I expected the reasoning you gave and I can't really argue with > you. It's just personally I still prefer a cleaner SATL implementation > (conside

Re: [PATCH 2/2] libata-scsi: better style in ata_msense_caching()

2016-07-07 Thread Tom Yan
Sorry I am a bit new in this. Does that mean I should also use {} for the if clause even it has only one line of statement, because I (needed to) use that for the else clause? So it should be like: if ... { ... } else { ... ... } On 7 July 2016 at 18:55, Sergei Shtylyov wrote: > >

Re: [PATCH 2/2] libata-scsi: do not return t10 designator if drive has WWN

2016-07-07 Thread Tom Yan
Well, udev uses its own `ata_id` (which issues IDENTIFY DEVICE through ATA PASS-THROUGH) though. Anyway I expected the reasoning you gave and I can't really argue with you. It's just personally I still prefer a cleaner SATL implementation (considering Linux is open source and can be deemed as some

Re: [PATCH] xen-scsiback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Juergen Gross
On 07/07/16 10:01, Jan Beulich wrote: > Only a positive return value indicates success. > > Signed-off-by: Jan Beulich Acked-by: Juergen Gross > --- > drivers/xen/xen-scsiback.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- 4.7-rc6-xenbus_scanf.orig/drivers/xen/xen-s

Re: [PATCH] xen-scsifront: correct return value checks on xenbus_scanf()

2016-07-07 Thread Juergen Gross
On 07/07/16 10:01, Jan Beulich wrote: > Only a positive return value indicates success. > > Signed-off-by: Jan Beulich Acked-by: Juergen Gross > --- > drivers/scsi/xen-scsifront.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- 4.7-rc6-xenbus_scanf.orig/drivers/scsi/xe

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #12 from Martin von Wittich --- @Jack: No, I hadn't tried that yet, but I will now: I downloaded the driver from the homepage and installed the adaptec/debian_7.4/x64/pm80xx-1.4.0-11068-debian64.deb package on our dev server. After D

Re: [PATCH v2 1/7] lib: string: add functions to case-convert strings

2016-07-07 Thread Eric Engestrom
On Tue, Jul 05, 2016 at 01:47:05PM -0700, Markus Mayer wrote: > All functions return a pointer to the terminating '\0' character in the > modified string ("dst" or "s", respectively). I think this is going to be confusing. From the man: The strcpy() and strncpy() functions return a pointe

Re: [PATCH 2/2] libata-scsi: do not return t10 designator if drive has WWN

2016-07-07 Thread Hannes Reinecke
On 07/07/2016 12:12 AM, tom.t...@gmail.com wrote: > From: Tom Yan > > SAT (as of sat4r05f.pdf) only requires the t10 designator if the > drive does not support/have WWN. Besides, we already have the ATA > information VPD. > > Signed-off-by: Tom Yan > > diff --git a/drivers/ata/libata-scsi.c b/

Re: [PATCH 2/2] libata-scsi: better style in ata_msense_caching()

2016-07-07 Thread Sergei Shtylyov
On 7/7/2016 4:43 AM, tom.t...@gmail.com wrote: From: Tom Yan Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index bfec66f..e3f5751 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -2424,10 +2424,12 @@ static void modecpy(u8

Re: [PATCH 2/2] libata-scsi: do not return t10 designator if drive has WWN

2016-07-07 Thread Sergei Shtylyov
Hello. On 7/7/2016 1:12 AM, tom.t...@gmail.com wrote: From: Tom Yan SAT (as of sat4r05f.pdf) only requires the t10 designator if the drive does not support/have WWN. Besides, we already have the ATA information VPD. Signed-off-by: Tom Yan diff --git a/drivers/ata/libata-scsi.c b/drivers/at

Re: how to test pscsi with vhost

2016-07-07 Thread Zhangfei Gao
Hi, Lingshan On Mon, Jul 4, 2016 at 10:02 PM, Zhu Lingshan wrote: > Hi Zhangfei, > > I am also interested in pscsi, you can try kvm, seems you can create a > virtualized pscsi device in kvm / virt-manager. I haven't tried that yet, > hope this can help. > Somehow I failed to setup virt-manager

[patch] fnic: pci_dma_mapping_error() doesn't return an error code

2016-07-07 Thread Dan Carpenter
pci_dma_mapping_error() returns true on error and false on success. Fixes: fd6ddfa4c1dd ('fnic: check pci_map_single() return value') Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c index 67669a9..f3a3331 100644 --- a/drivers/scsi/fnic/fnic_f

[PATCH] xen-scsiback: prefer xenbus_write() over xenbus_printf() where possible

2016-07-07 Thread Jan Beulich
... as being the simpler variant. Signed-off-by: Jan Beulich --- drivers/xen/xen-scsiback.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 4.7-rc6-prefer-xenbus_write.orig/drivers/xen/xen-scsiback.c +++ 4.7-rc6-prefer-xenbus_write/drivers/xen/xen-scsiback.c @@ -1260,8 +1260,8

[PATCH] xen-scsifront: correct return value checks on xenbus_scanf()

2016-07-07 Thread Jan Beulich
Only a positive return value indicates success. Signed-off-by: Jan Beulich --- drivers/scsi/xen-scsifront.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 4.7-rc6-xenbus_scanf.orig/drivers/scsi/xen-scsifront.c +++ 4.7-rc6-xenbus_scanf/drivers/scsi/xen-scsifront.c @@ -1000,14 +

[PATCH] xen-scsiback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Jan Beulich
Only a positive return value indicates success. Signed-off-by: Jan Beulich --- drivers/xen/xen-scsiback.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 4.7-rc6-xenbus_scanf.orig/drivers/xen/xen-scsiback.c +++ 4.7-rc6-xenbus_scanf/drivers/xen/xen-scsiback.c @@ -1071,7 +1071,7

Re: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

2016-07-07 Thread Or Gerlitz
On Wed, Jul 6, 2016 at 8:17 PM, Varun Prakash wrote: > On Wed, Jul 06, 2016 at 12:24:43AM +0300, Or Gerlitz wrote: >> On Thu, May 26, 2016 at 9:58 PM, Varun Prakash wrote: >> >> > Hi Or, Nicholas and Steve >> > Thank you for the feedback and apologies for the delay in my response. >> >> > I agree