Re: [PATCH 2/3] xen-scsiback: One function call less in scsiback_device_action() after error detection

2016-07-17 Thread Juergen Gross
On 16/07/16 22:23, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Jul 2016 21:42:42 +0200 > > The kfree() function was called in one case by the > scsiback_device_action() function during error handling > even if the passed variable "tmr" contained

Re: [PATCH 3/3] xen-scsiback: Pass a failure indication as a constant

2016-07-17 Thread Juergen Gross
On 16/07/16 22:24, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Jul 2016 21:55:01 +0200 > > Pass the constant "FAILED" in a function call directly instead of > using an intialisation for a local variable. > > Signed-off-by: Markus Elfring

Re: [PATCH 1/3] xen-scsiback: Delete an unnecessary check before the function call "kfree"

2016-07-17 Thread Juergen Gross
On 16/07/16 22:22, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Jul 2016 21:21:05 +0200 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was

Re: [PATCH v2] cxl: remove dead Kconfig options

2016-07-17 Thread Andrew Donnellan
On 18/07/16 14:52, Andrew Donnellan wrote: Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they were only needed to coordinate the merging of the cxlflash driver. Also remove the stub implementation of cxl_perst_reloads_same_image() in cxlflash which is only used if CXL_EEH isn't

[PATCH v2] cxl: remove dead Kconfig options

2016-07-17 Thread Andrew Donnellan
Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they were only needed to coordinate the merging of the cxlflash driver. Also remove the stub implementation of cxl_perst_reloads_same_image() in cxlflash which is only used if CXL_EEH isn't defined (i.e. never). Suggested-by: Ian Munsie

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

2016-07-17 Thread Feng Li
Hi Sumit, I have tested and the oops is disappeared. Could you double check if you have patched successfully? This stack is still the same. The place is 0x01f8. gdb> p (int)&((struct iscsi_session*)0)->se_sess $3 = 0x1f8 2016-07-14 17:59 GMT+08:00 Sumit Rai