Re: dm-mq and end_clone_request()

2016-08-02 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: "Mike Snitzer" > Cc: "Bart Van Assche" , dm-de...@redhat.com, > linux-scsi@vger.kernel.org > Sent: Tuesday, August 2, 2016 10:18:30 PM > Subject: Re: dm-mq and end_clone_request() > > > > - Original Message - > > From: "M

Re: [PATCH 1/5] bfa: mark symbols static where possible

2016-08-02 Thread kbuild test robot
Hi Arnd, [auto build test ERROR on scsi/for-next] [also build test ERROR on v4.7 next-20160802] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/bfa-fix-W-1-build-warnings/20160803

[ANNOUNCE]: SCST 3.2 pre-release freeze

2016-08-02 Thread Vladislav Bolkhovitin
Hi All, I'm glad to announce SCST 3.2 pre-release code freeze in the SCST SVN branch 3.2.x. You can get it by command: $ svn co https://scst.svn.sourceforge.net/svnroot/scst/branches/3.2.x It is going to be released after few weeks of testing, if no significant issues found. SCST is alternat

Re: dm-mq and end_clone_request()

2016-08-02 Thread Laurence Oberman
- Original Message - > From: "Mike Snitzer" > To: "Laurence Oberman" > Cc: "Bart Van Assche" , dm-de...@redhat.com, > linux-scsi@vger.kernel.org > Sent: Tuesday, August 2, 2016 10:10:12 PM > Subject: Re: dm-mq and end_clone_request() > > On Tue, Aug 02 2016 at 9:33pm -0400, > Laurenc

Re: dm-mq and end_clone_request()

2016-08-02 Thread Mike Snitzer
On Tue, Aug 02 2016 at 9:33pm -0400, Laurence Oberman wrote: > Hi Bart > > I simplified the test to 2 simple scripts and only running against one XFS > file system. > Can you validate these and tell me if its enough to emulate what you are > doing. > Perhaps our test-suite is too simple. > >

Re: dm-mq and end_clone_request()

2016-08-02 Thread Laurence Oberman
Hi Bart I simplified the test to 2 simple scripts and only running against one XFS file system. Can you validate these and tell me if its enough to emulate what you are doing. Perhaps our test-suite is too simple. Start the test # cat run_test.sh #!/bin/bash logger "Starting Bart's test" #for i

Re: [PATCH v6 0/2] Block layer support ZAC/ZBC commands

2016-08-02 Thread Damien Le Moal
Hannes, Shaun, Let me add some more comments. > On Aug 2, 2016, at 23:35, Hannes Reinecke wrote: > > On 08/01/2016 07:07 PM, Shaun Tancheff wrote: >> On Mon, Aug 1, 2016 at 4:41 AM, Christoph Hellwig wrote: >>> >>> Can you please integrate this with Hannes series so that it uses >>> his cache

My Email Again

2016-08-02 Thread Paul Karn
I am yet to get a respose from you based on your promise -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: dm-mq and end_clone_request()

2016-08-02 Thread Mike Snitzer
On Tue, Aug 02 2016 at 8:19pm -0400, Bart Van Assche wrote: > On 08/02/2016 10:45 AM, Mike Snitzer wrote: > > Please do these same tests against a v4.7 kernel with the 4 patches from > > this branch applied (no need for your other debug patches): > > https://git.kernel.org/cgit/linux/kernel/git/

Re: [PATCH 5/5] nvme-fabrics: Add FC LLDD loopback driver to test FC host and target transport

2016-08-02 Thread J Freyensee
On Fri, 2016-07-22 at 17:23 -0700, James Smart wrote: A couple comments. > Add FC LLDD loopback driver to test FC host and target transport > within > nvme-fabrics > > To aid in the development and testing of the lower-level api of the > FC > transport, this loopback driver has been created to a

Re: dm-mq and end_clone_request()

2016-08-02 Thread Bart Van Assche
On 08/02/2016 10:45 AM, Mike Snitzer wrote: > Please do these same tests against a v4.7 kernel with the 4 patches from > this branch applied (no need for your other debug patches): > https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-4.7-mpath-fixes > > I've had good

Re: dm-mq and end_clone_request()

2016-08-02 Thread Mike Snitzer
On Mon, Aug 01 2016 at 6:41pm -0400, Bart Van Assche wrote: > On 08/01/2016 01:46 PM, Mike Snitzer wrote: > > Please retry both variant (CONFIG_DM_MQ_DEFAULT=y first) with this patch > > applied. Interested to see if things look better for you (WARN_ON_ONCEs > > added just to see if we hit the

[RFC PATCH] blk-mq: Prevent round-robin from scheduling dead cpus

2016-08-02 Thread Gabriel Krisman Bertazi
Hi, I'm not completely sure I got the cause for this one completely right. Still, it does looks like the correct fix and a good improvement in the overall, so I'm making it an RFC for now to gather some feedback. Let me hear your thoughts. -- >8 -- When notifying blk-mq about CPU removals while

[PATCH 0675/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

[PATCH 1/5] bfa: mark symbols static where possible

2016-08-02 Thread Arnd Bergmann
We get 128 warnings about global functions without a declaration in the bfa scsi driver when building with W=1, more than any other driver, e.g. bfa/bfad.c:1502:1: error: no previous prototype for 'restart_bfa' bfa/bfad_attr.c:447:1: error: no previous prototype for 'bfad_im_issue_fc_host_lip' bf

Re: [PATCH v6 0/2] Block layer support ZAC/ZBC commands

2016-08-02 Thread Hannes Reinecke
On 08/01/2016 07:07 PM, Shaun Tancheff wrote: > On Mon, Aug 1, 2016 at 4:41 AM, Christoph Hellwig wrote: >> >> Can you please integrate this with Hannes series so that it uses >> his cache of the zone information? > > Adding Hannes and Damien to Cc. > > Christoph, > > I can make a patch the mar

[PATCH 4/5] bfa: remove unused functions from fbbuild.c

2016-08-02 Thread Arnd Bergmann
A significant chunk of the functions in the bfa_fcbuild.c file are never called, this removes them. I've split this out from the patch to remove other unused functions, as we are removing half the file here, and this seems to be intended as a generic library. We could mark them as 'static __maybe_

[PATCH 5/5] bfa: remove more unused functions

2016-08-02 Thread Arnd Bergmann
This is a collection of additional functions that are not called anywhere in the driver, all being removed in this patch. Alternatively, we could mark them as 'static __maybe_unused', to leave the implementation around but not cause them to end up in the object code. Signed-off-by: Arnd Bergmann

[PATCH 2/5] bfa: remove unused variables

2016-08-02 Thread Arnd Bergmann
Building with W=1 shows some warnings about local variables that are initialized but never used: bfa/bfad_attr.c: In function 'bfad_im_vport_delete': bfa/bfad_attr.c:490:22: error: variable 'port' set but not used bfa/bfa_fcs_rport.c: In function 'bfa_fcs_rport_process_adisc': bfa/bfa_fcs_rport.c:

[PATCH 3/5] bfa: rename some global variables

2016-08-02 Thread Arnd Bergmann
The global "supported_fc4s" and "max_xfer_size" variables have rather generic names that might conflict with the same identifiers used in other drivers, and we cannot make them 'static' because they are both used across multiple files. This adds a 'bfa_' prefix to ensure the identifiers are global

[PATCH 0/5] bfa: fix W=1 build warnings

2016-08-02 Thread Arnd Bergmann
I tried to build an allmodconfig kernel with W=1, and the bfa driver stuck out for having the most warnings in one file, so I decided to send patches for all of these and make the driver build cleanly with the extra warnings enabled. As most warnings were for functions that lacked a 'static', I ma

[PATCH 0906/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

[PATCH 0905/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

[PATCH 0913/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

[PATCH 0910/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

[PATCH 0908/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

[PATCH 0912/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

[PATCH 0907/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

[PATCH 0917/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

[PATCH 0911/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

[PATCH 0916/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

[PATCH 0915/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread James Bottomley
On Tue, 2016-08-02 at 18:39 +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access > permission. As we know, these numeric value for access permission > have had the corresponding macro, and th

[PATCH 0909/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

[PATCH 0914/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Laurence Oberman
- Original Message - > From: "Baole Ni" > To: "don brace" , "len brown" , > pa...@ucw.cz, > gre...@linuxfoundation.org, h...@zytor.com, x...@kernel.org > Cc: "iss storagedev" , "esc storagedev" > , > linux-scsi@vger.kernel.org, linux-ker...@vger.kernel.org, "chuansheng liu" > , "baole

[PATCH 1035/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

[PING / RESEND] handling reservation conflicts in dm-mpath

2016-08-02 Thread Christoph Hellwig
Hannes sent this patch a bit more than a year ago, but it got silently dropped. When using the pNFS SCSI layout we can easily hit a failover "livelock" without it as the reservation conflicts on a newly detected device that doesn't have layouts yet, or after a fency will keep failing over from one

[PATCH] dm-mpath: always return reservation conflict

2016-08-02 Thread Christoph Hellwig
From: Hannes Reinecke If dm-mpath encounters an reservation conflict it should not fail the path (as communication with the target is not affected) but should rather retry on another path. However, in doing so we might be inducing a ping-pong between paths, with no guarantee of any forward progre

[PATCH 0082/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of

Re: [PATCH -next] fcoe: Use kfree_skb() instead of kfree()

2016-08-02 Thread Johannes Thumshirn
On Mon, Jul 25, 2016 at 07:00:33AM +, Wei Yongjun wrote: > Use kfree_skb() instead of kfree() to free sk_buff. > > Signed-off-by: Wei Yongjun Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-08-02 Thread Johannes Thumshirn
On Tue, Jul 12, 2016 at 10:24:36AM +0200, Oliver Neukum wrote: > Some SATA to USB bridges fail to cooperate with some > drives resulting in no cache being present being reported > to the host. That causes the host to skip sending > a command to synchronize caches. That causes data loss > when the d