Re: Time to make dynamically allocated devt the default for scsi disks?

On Fri, Aug 12, 2016 at 5:29 PM, Dan Williams wrote: > On Fri, Aug 12, 2016 at 5:17 PM, James Bottomley > wrote: >> On Fri, 2016-08-12 at 14:29 -0700, Dan Williams wrote: >>> Before spending effort trying to flush the destruction

Re: Time to make dynamically allocated devt the default for scsi disks?

On Fri, Aug 12, 2016 at 5:17 PM, James Bottomley wrote: > On Fri, 2016-08-12 at 14:29 -0700, Dan Williams wrote: >> Before spending effort trying to flush the destruction of old bdi >> instances before new ones are registered, is it rather time to >>

Re: Time to make dynamically allocated devt the default for scsi disks?

On Fri, 2016-08-12 at 14:29 -0700, Dan Williams wrote: > Before spending effort trying to flush the destruction of old bdi > instances before new ones are registered, is it rather time to > complete the conversion of sd to only use dynamically allocated devt? Do we have to go that far? Surely

Re: Time to make dynamically allocated devt the default for scsi disks?

On Fri, Aug 12, 2016 at 2:35 PM, Bart Van Assche wrote: > On 08/12/2016 02:29 PM, Dan Williams wrote: >> >> ...or, for that matter, any block device driver on a bus that supports >> hotplug? >> >> In 4.8 Jens merged the following fix for a crash that was triggered by

[PATCH] scsi: blacklist all RDAC devices for BLIST_NO_ULD_ATTACH

"Universal Xport" LUN is used for in-band storage array management. Cc: Sean Stewart Cc: Christophe Varoqui Cc: James E.J. Bottomley Cc: Martin K. Petersen Cc: SCSI ML

Re: Time to make dynamically allocated devt the default for scsi disks?

On 08/12/2016 02:29 PM, Dan Williams wrote: ...or, for that matter, any block device driver on a bus that supports hotplug? In 4.8 Jens merged the following fix for a crash that was triggered by repeatedly reconfiguring a libnvdimm namespace causing it to destroy and create disks (rapid

[PATCH v2] scsi: fix upper bounds check of sense key in scsi_sense_key_string()

Commit 655ee63cf371 added a "Completed" sense string with key 0xF to snstext[], but failed to updated the upper bounds check of the sense key in scsi_sense_key_string(). Fixes: 655ee63cf371 ("[SCSI] scsi constants: command, sense key + additional sense strings") Signed-off-by: Tyrel Datwyler

Re: [RFC] libata-scsi: make sure Maximum Write Same Length is not too large

> "Shaun" == Shaun Tancheff writes: Shaun, Shaun> Ah, I think I am understanding now. When the sector size is 4K Shaun> the minimum page sent with WRITE SAME will be 4K. Correct. We'll always transfer one logical block of data as required by the spec. --

Re: [RFC] libata-scsi: make sure Maximum Write Same Length is not too large

On Fri, Aug 12, 2016 at 3:56 PM, Martin K. Petersen wrote: >> "Tom" == Tom Yan writes: > > Tom, > >>> put_unaligned_be64(65535 * ATA_MAX_TRIM_RNUM / (sector_size / 512), >>> [36]); > > How many 8-byte ranges fit in a 4096-byte sector? > > Tom>

Re: [PATCH v2 2/2] sd: check BLK_DEF_MAX_SECTORS against max_dev_sectors

> "Tom" == tom ty89 writes: Tom, Tom> The SCSI disk driver sets max_sectors to BLK_DEF_MAX_SECTORS when Tom> the device does not report Optimal Transfer Length. However, it Tom> checks only whether it is smaller than max_hw_sectors, but not Tom> max_dev_sectors. It

Time to make dynamically allocated devt the default for scsi disks?

...or, for that matter, any block device driver on a bus that supports hotplug? In 4.8 Jens merged the following fix for a crash that was triggered by repeatedly reconfiguring a libnvdimm namespace causing it to destroy and create disks (rapid hotplug). df08c32ce3be block: fix bdi vs gendisk

Re: [PATCH] scsi: bnx2i: convert to kworker

> "Sebastian" == Sebastian Andrzej Siewior writes: Sebastian> On 2016-07-04 19:40:37 [+0200], To linux-scsi@vger.kernel.org wrote: >> The driver creates its own per-CPU threads which are updated based on >> CPU hotplug events. It is also possible to use kworkers and

Re: [PATCH v2 2/2] libata-core: do not set dev->max_sectors for LBA48 devices

> "Alan" == One Thousand Gnomes writes: Alan, Alan> For older SCSI and especially ATA drives (and it wouldn't surprise Alan> me if it is true of modern ones) there are also huge latency Alan> tradeoffs. Absolutely. Alan> Before you jump up and down about

Re: [PATCH v2 2/2] libata-core: do not set dev->max_sectors for LBA48 devices

> "Tom" == Tom Yan writes: Tom, Tom> Sounds like libata-scsi is doing something wrong then. It should Tom> not set max_hw_sectors to dev->max_sectors that is set by Tom> libata-core: Tom> but instead it should report it as Maximum Transfer Length and let Tom> sd set it

Re: [RFC] libata-scsi: make sure Maximum Write Same Length is not too large

> "Tom" == Tom Yan writes: Tom, >> put_unaligned_be64(65535 * ATA_MAX_TRIM_RNUM / (sector_size / 512), >> [36]); How many 8-byte ranges fit in a 4096-byte sector? Tom> So were you trying to pointing out something I am still missing, or Tom> were you merely confirming

Re: [PATCH 2/2] be2iscsi: Fix some error messages

Le 12/08/2016 à 12:30, Julia Lawall a écrit : On Fri, 12 Aug 2016, Christophe JAILLET wrote: This fixes: - missing spaces in string split on several lines - extra spaces after ':' - missing '\n' at the end of some messages - too long lines I think that the strings should be

Re: [RFC] sd: dynamically adjust SD_MAX_WS16_BLOCKS as per the actual logical block size

> "Tom" == Tom Yan writes: Tom, Tom> I don't really follow. What would this BLK_MAX_BIO_SECTORS be? It Tom> doesn't appear to me that a static value is going to address the Tom> problem I am addressing in this patch. 0x7f, the maximum number of block layer sectors

Re: [PATCH 00/10] zfcp fixes

> "Steffen" == Steffen Maier writes: Steffen> Hi all, here is a series of zfcp fixes all marked for stable. Steffen> They apply to the fixes branch of James' scsi.git or to Steffen> v4.8-rc1. Patches 1-3 are important functional bugfixes. Steffen> Patches 4-10 are

Re: [PATCH] mpt3sas: Fix resume on WarpDrive flash cards

> "Greg" == Greg Edwards writes: Greg> mpt3sas crashes on resume after suspend with WarpDrive flash Greg> cards. The reply_post_host_index array is not set back up after Greg> the resume, and we deference a stale pointer in _base_interrupt(). Applied to

Re: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

> "Don" == Don Brace writes: Don> Great. So we are good to go? I applied the driver to 4.9/scsi-queue. You'll need to come up with a migration approach for patch 2. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [PATCH V4 2/2] aacraid: remove wildcard for series 9 controllers

> "Don" == Don Brace writes: Don, Don> Depends on smartpqi driver adoption -{ 0x9005, 0x028f, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 65 }, /* Adaptec PMC Series 9 */ How are people that load aacraid in their initrd going to boot after this? -- Martin K. Petersen

Re: [RFC PATCH] blk-mq: Prevent round-robin from scheduling dead cpus

Gabriel Krisman Bertazi writes: > Hi, > > I'm not completely sure I got the cause for this one completely right. > Still, it does looks like the correct fix and a good improvement in the > overall, so I'm making it an RFC for now to gather some feedback. > > Let me

Re: [PATCH] ses: Fix racy cleanup of /sys in remove_dev()

On Thu, 2016-07-28 at 21:23 -0400, Martin K. Petersen wrote: > > > > > > "Calvin" == Calvin Owens writes: > > > > Any thoughts? Squinting at this more it still seems racy, but a > > > narrow race is surely better than just blatantly freeing > > > everything > > > while the

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

On Fri, Aug 12, 2016 at 07:54:03AM -0700, James Bottomley wrote: > On Fri, 2016-08-12 at 16:39 +0200, Hannes Reinecke wrote: > > On 08/12/2016 04:34 PM, James Bottomley wrote: > > > On Fri, 2016-08-12 at 15:11 +0200, Johannes Thumshirn wrote: > > > > On Fri, Aug 12, 2016 at 12:08:54PM +0200,

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

On Fri, 2016-08-12 at 16:39 +0200, Hannes Reinecke wrote: > On 08/12/2016 04:34 PM, James Bottomley wrote: > > On Fri, 2016-08-12 at 15:11 +0200, Johannes Thumshirn wrote: > > > On Fri, Aug 12, 2016 at 12:08:54PM +0200, Johannes Thumshirn > > > wrote: > > > > Ok, we can't use the rphy because of

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

On 08/12/2016 04:34 PM, James Bottomley wrote: > On Fri, 2016-08-12 at 15:11 +0200, Johannes Thumshirn wrote: >> On Fri, Aug 12, 2016 at 12:08:54PM +0200, Johannes Thumshirn wrote: >>> Ok, we can't use the rphy because of wide-ports. We can't fix it to >>> an end device either, as this makes some

Re: [PATCH 1/2] libata-scsi: use dev->max_sectors from libata-core appropriately

On 12 August 2016 at 21:42, Sergei Shtylyov wrote: > On 08/12/2016 02:56 PM, tom.t...@gmail.com wrote: > >> From: Tom Yan >> >> Currently we use dev->max_sectors to set max_hw_sectors, which >> is actually supposed to be a host controller

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

On Fri, 2016-08-12 at 15:11 +0200, Johannes Thumshirn wrote: > On Fri, Aug 12, 2016 at 12:08:54PM +0200, Johannes Thumshirn wrote: > > Ok, we can't use the rphy because of wide-ports. We can't fix it to > > an end device either, as this makes some peoples systems > > unbootable. Now let's find a

[PATCH v2 1/2] libata-scsi: use dev->max_sectors from libata-core appropriately

From: Tom Yan Currently we use dev->max_sectors to set max_hw_sectors, which is actually supposed to be a host controller limit (that get set by the host controller driver like ahci, and if not it would be the fallback SCSI_DEFAULT_MAX_SECTORS). That means we have been doing

[PATCH v2 2/2] sd: check BLK_DEF_MAX_SECTORS against max_dev_sectors

From: Tom Yan The SCSI disk driver sets max_sectors to BLK_DEF_MAX_SECTORS when the device does not report Optimal Transfer Length. However, it checks only whether it is smaller than max_hw_sectors, but not max_dev_sectors. Signed-off-by: Tom Yan diff

Re: [PATCH 1/2] libata-scsi: use dev->max_sectors from libata-core appropriately

On 12 August 2016 at 19:56, wrote: > > Also note that ATA_HORKAGE_MAX_SEC_LBA48 is not supposed to work > automatically anyway, even when max_hw_sectors is as high as 65535, > since the effective max_sectors will be set by the SCSI disk driver. > I missed the fact that

Re: [PATCH 1/2] libata-scsi: use dev->max_sectors from libata-core appropriately

On 08/12/2016 02:56 PM, tom.t...@gmail.com wrote: From: Tom Yan Currently we use dev->max_sectors to set max_hw_sectors, which is actually supposed to be a host controller limit (that get set Gets. by the host controller driver like ahci, and if not it would be the

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

On Fri, Aug 12, 2016 at 12:08:54PM +0200, Johannes Thumshirn wrote: > On Thu, Aug 11, 2016 at 11:00:07AM -0700, James Bottomley wrote: > > On Thu, 2016-08-11 at 18:43 +0200, Johannes Thumshirn wrote: > > > On Thu, Aug 11, 2016 at 08:09:35AM -0700, James Bottomley wrote: > > > > On Thu, 2016-08-11

A potential data race in drivers/scsi/mvumi.ko

Hi! There is a potential data race in drivers/scsi/mvumi.ko. Regard such case: Thread 1Thread 2 ... -> mvumi_reset_host_9500 - is called without any locking -> mvumi_wait_for_outstanding ->mvumi_start ->mvumi_check_handshake ->

[PATCH 2/2] sd: check BLK_DEF_MAX_SECTORS against max_dev_sectors

From: Tom Yan The SCSI disk driver sets max_sector to BLK_DEF_MAX_SECTORS when the device does not report Optimal Transfer Length. However, it checks only whether it is smaller than max_hw_sectors, but not max_dev_sectors. Signed-off-by: Tom Yan diff

[PATCH 1/2] libata-scsi: use dev->max_sectors from libata-core appropriately

From: Tom Yan Currently we use dev->max_sectors to set max_hw_sectors, which is actually supposed to be a host controller limit (that get set by the host controller driver like ahci, and if not it would be the fallback SCSI_DEFAULT_MAX_SECTORS). That means we have been doing

Re: [PATCH] scsi: bnx2i: convert to kworker

On 2016-07-04 19:40:37 [+0200], To linux-scsi@vger.kernel.org wrote: > The driver creates its own per-CPU threads which are updated based on CPU > hotplug events. It is also possible to use kworkers and remove some of the > infrastructure get the same job done while saving a few lines of code.

Re: [PATCH 1/4] scsi: bnx2fc: convert per-CPU thread to kworker

On 2016-07-05 18:08:46 [+0200], To linux-scsi@vger.kernel.org wrote: > The driver creates its own per-CPU threads which are updated based on CPU > hotplug events. It is also possible to use kworkers and remove some of the > infrastructure get the same job done while saving a few lines of code.

A potential race in drivers/scsi/megaraid.ko

Hi! There is a potential data race in drivers/scsi/megaraid.ko Regards such case: Thread 1Thread 2 ... ... -> megaraid_probe_one -> request_irq- now an interrupt may arise

Re: [PATCH 2/2] be2iscsi: Fix some error messages

On Fri, 12 Aug 2016, Christophe JAILLET wrote: > This fixes: >- missing spaces in string split on several lines >- extra spaces after ':' >- missing '\n' at the end of some messages >- too long lines I think that the strings should be concatenated, even if they go past 80 chars.

[PATCH 1/2] be2iscsi: Fix error return code

We know that 'ret' is not an error code because it has been tested a few lines above. So, if one of these function fails, 0 will be returned instead of an error code. Return -ENOMEM instead. Signed-off-by: Christophe JAILLET --- drivers/scsi/be2iscsi/be_main.c |

[PATCH 2/2] be2iscsi: Fix some error messages

This fixes: - missing spaces in string split on several lines - extra spaces after ':' - missing '\n' at the end of some messages - too long lines Signed-off-by: Christophe JAILLET --- drivers/scsi/be2iscsi/be_main.c | 83

Re: [PATCH] SAS: use sas_rphy instead of sas_end_device to obtain address.

On Thu, Aug 11, 2016 at 11:00:07AM -0700, James Bottomley wrote: > On Thu, 2016-08-11 at 18:43 +0200, Johannes Thumshirn wrote: > > On Thu, Aug 11, 2016 at 08:09:35AM -0700, James Bottomley wrote: > > > On Thu, 2016-08-11 at 09:59 +0200, Johannes Thumshirn wrote: > > > > Since commit 3f8d6f2a0

Re: [PATCH 13/14] lpfc: Fix lost target in pt-to-pt connect

On Thu, Aug 11, 2016 at 11:36:00AM -0700, James Smart wrote: > > Fix lost target in pt-to-pt connect > > Change reject code to something that allows a retry > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by:

Re: [PATCH 14/14] lpfc: lpfc version change to 11.2.0.2

On Thu, Aug 11, 2016 at 11:36:01AM -0700, James Smart wrote: > > lpfc version change to 11.2.0.2 > > Note: expects to be on top of prior lpfc 11.2.0.0. rev and not on > top of lpfc rev 11.2.0.1 which has fc-nvme mods as well. The patches in > this set should apply to 11.2.0.1, excepting this

Re: [PATCH 09/14] lpfc: Code cleanup for lpfc_max_scsicmpl_time parameter

On Thu, Aug 11, 2016 at 11:35:56AM -0700, James Smart wrote: > > Code cleanup for lpfc_max_scsicmpl_time parameter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Johannes Thumshirn --

Re: [PATCH 12/14] lpfc: Revise strings with full lpfc parameter name

On Thu, Aug 11, 2016 at 11:35:59AM -0700, James Smart wrote: > > Revise strings with full lpfc parameter name > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Johannes Thumshirn --

Re: [PATCH 11/14] lpfc: Fix crash on adapter reinit

On Thu, Aug 11, 2016 at 11:35:58AM -0700, James Smart wrote: > > Fix crash on adapter reinit > > Had unset fields passed to pci_pool_destroy() on teardown. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- >

Re: [PATCH 10/14] lpfc: Code cleanup for lpfc_sriov_nr_virtfn parameter

On Thu, Aug 11, 2016 at 11:35:57AM -0700, James Smart wrote: > > Code cleanup for lpfc_sriov_nr_virtfn parameter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Johannes Thumshirn --

Re: [PATCH 08/14] lpfc: Code cleanup for lpfc_topology parameter

On Thu, Aug 11, 2016 at 11:35:55AM -0700, James Smart wrote: > > Code cleanup for lpfc_topology parameter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Johannes Thumshirn -- Johannes

Re: [PATCH 07/14] lpfc: Code cleanup for lpfc_aer_support parameter

On Thu, Aug 11, 2016 at 11:35:54AM -0700, James Smart wrote: > > Code cleanup for lpfc_aer_support parameter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Johannes Thumshirn --

Re: [PATCH v2 2/2] libata-core: do not set dev->max_sectors for LBA48 devices

> Tom> is totally irrational for a general default. I mean, given that it > Tom> was 1024 (512k), try to double it? Fine. Try to quadruple it? > Tom> Alright. We'll need to deal with some alignment / boundary issue > Tom> (like the typical 65535 vs 65536 case)? Okay let's do it. But > Tom> what's

Re: [PATCH 06/14] lpfc: Code cleanup for lpfc_enable_rrq parameter

On Thu, Aug 11, 2016 at 11:35:53AM -0700, James Smart wrote: > > Code cleanup for lpfc_enable_rrq parameter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Johannes Thumshirn --

Re: [PATCH 05/14] lpfc: Code clean up for lpfc_iocb_cnt parameter

On Thu, Aug 11, 2016 at 11:35:52AM -0700, James Smart wrote: > > Code clean up for lpfc_iocb_cnt parameter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Johannes Thumshirn -- Johannes

Re: [PATCH 05/14] lpfc: Code clean up for lpfc_iocb_cnt parameter

On Thu, Aug 11, 2016 at 11:35:52AM -0700, James Smart wrote: > > Code clean up for lpfc_iocb_cnt parameter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Johannes Thumshirn -- Johannes

Re: [PATCH 04/14] lpfc: Make lpfc_prot_mask and lpfc_prot_guard per hba parameters

On Thu, Aug 11, 2016 at 11:35:51AM -0700, James Smart wrote: > > Make lpfc_prot_mask and lpfc_prot_guard per hba parameters > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Johannes Thumshirn

Re: [PATCH 03/14] lpfc: Set driver environment data on adapter

On Thu, Aug 11, 2016 at 11:35:50AM -0700, James Smart wrote: > > Set driver environment data on adapter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Johannes Thumshirn -- Johannes

Re: [PATCH 02/14] lpfc: Fix sg_reset on SCSI device causing kernel crash

On Thu, Aug 11, 2016 at 11:35:49AM -0700, James Smart wrote: > > Fix sg_reset on SCSI device causing kernel crash > > Driver could reference stale node pointers in task mgmt call. > Changed to use resetting cmd and look up node pointer in task mgmt > function. > > Signed-off-by: Dick Kennedy

RE: [PATCH 02/28] be2iscsi: Replace _bh with _irqsave/irqrestore

> -Original Message- > From: Jitendra Bhivare [mailto:jitendra.bhiv...@broadcom.com] > Sent: Thursday, August 11, 2016 11:12 AM > To: 'Mike Christie'; 'Martin K. Petersen' > Cc: 'linux-scsi@vger.kernel.org' > Subject: RE: [PATCH 02/28] be2iscsi: Replace _bh with _irqsave/irqrestore > > > >

Re: [PATCH 01/14] lpfc: Double WQ element count to keep iops up

On Thu, Aug 11, 2016 at 11:35:48AM -0700, James Smart wrote: > > Double WQ element count to keep iops up > > On embedded io queues, use the default element count, which is twice the > size of the default large WQE element count. > > Signed-off-by: Dick Kennedy >

Re: [PATCH v2 2/2] libata-core: do not set dev->max_sectors for LBA48 devices

On 12 August 2016 at 13:18, Tom Yan wrote: > On 12 August 2016 at 10:01, Martin K. Petersen > wrote: >> >> Again, the point of max_hw_sectors and max_dev_sectors is to enforce the >> hard limits of controller and device respectively. Nothing else.

RE: [PATCH 02/28] be2iscsi: Replace _bh with _irqsave/irqrestore

> -Original Message- > From: Jitendra Bhivare [mailto:jitendra.bhiv...@broadcom.com] > Sent: Friday, August 12, 2016 1:26 PM > To: 'Mike Christie'; 'Martin K. Petersen' > Cc: 'linux-scsi@vger.kernel.org' > Subject: RE: [PATCH 02/28] be2iscsi: Replace _bh with _irqsave/irqrestore > > > > >

[Bug 151661] Adaptec 3805 prints "AAC: Host adapter dead -1" every 10 seconds but works fine anyway

https://bugzilla.kernel.org/show_bug.cgi?id=151661 --- Comment #5 from Arkadiusz Miskiewicz --- Had the same error after upgrading from 3.14.X kernel to 4.4.15 [ 59.713349] AAC: Host adapter dead -1 [ 69.713352] AAC: Host adapter dead -1 [ 79.713347] AAC: Host adapter dead

Re: [PATCH 3/5] sd: Implement support for ZBC devices

On Tue, Jul 19, 2016 at 8:25 AM, Hannes Reinecke wrote: > Implement ZBC support functions to read in the zone information > and setup the zone tree. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/Kconfig | 8 + > drivers/scsi/Makefile | 1 + >