Re: [PATCH v1 1/8] ufs: add some vendor specific operations

On 2016-10-06 22:04, Kiwoong Kim wrote: Hi, Subhash. Hi Kim, On 2016-10-06 18:38, Kiwoong Kim wrote: > Hi, Subhash. > > Thank for your comments. > I added my opinions below. > > Regards > >> Hi Kim, >> >> >> On 2016-10-06 01:17, Kiwoong Kim wrote: >> > Some UFS host controller may need to

RE: [PATCH v1 1/8] ufs: add some vendor specific operations

Hi, Subhash. > Hi Kim, > > On 2016-10-06 18:38, Kiwoong Kim wrote: > > Hi, Subhash. > > > > Thank for your comments. > > I added my opinions below. > > > > Regards > > > >> Hi Kim, > >> > >> > >> On 2016-10-06 01:17, Kiwoong Kim wrote: > >> > Some UFS host controller may need to require some

Re: [PATCH v1 1/8] ufs: add some vendor specific operations

Hi Kim, On 2016-10-06 18:38, Kiwoong Kim wrote: Hi, Subhash. Thank for your comments. I added my opinions below. Regards Hi Kim, On 2016-10-06 01:17, Kiwoong Kim wrote: > Some UFS host controller may need to require some sequences before > used clocks are turned on or off. > e.g) control

[RESEND PATCH v3] scsi: ufshcd: fix possible unclocked register access

Vendor specific setup_clocks callback may require the clocks managed by ufshcd driver to be ON. So if the vendor specific setup_clocks callback is called while the required clocks are turned off, it could result into unclocked register access. To prevent possible unclock register access, this

[PATCH v3] scsi: ufshcd: fix possible unclocked register access

Vendor specific setup_clocks callback may require the clocks managed by ufshcd driver to be ON. So if the vendor specific setup_clocks callback is called while the required clocks are turned off, it could result into unclocked register access. To prevent possible unclock register access, this

RE: [PATCH v1 1/8] ufs: add some vendor specific operations

Hi, Subhash. Thank for your comments. I added my opinions below. Regards > Hi Kim, > > > On 2016-10-06 01:17, Kiwoong Kim wrote: > > Some UFS host controller may need to require some sequences before > > used clocks are turned on or off. > > e.g) control internal gates in UFS host > > > I

Re: [PATCH v2] scsi: ufshcd: fix possible unclocked register access

On 2016-10-06 18:16, Kiwoong Kim wrote: Hi, Subhash. Thanks Kim for the response. On 2016-10-06 03:28, Kiwoong Kim wrote: > Hi, Subhash. > > Some UFS host controllers may need to call the vendor specific > callback before and after controlling by clock control framework, > regardless of

RE: [PATCH v1 0/8] Support for Exynos specific UFS driver

Hi, Subhash You're right. I submitted one of patches first to link to the previous summary mail thread, but it failed. I'll try it again. Thank you Regards > Hi Kim, > > > On 2016-10-06 01:12, Kiwoong Kim wrote: > > This series of patches introduce support for Exynos specific UFS > > driver.

[PATCH] scsi: ufs: fix race between clock gating and devfreq scaling work

UFS devfreq clock scaling work may require clocks to be ON if it need to execute some UFS commands hence it may request for clock hold before issuing the command. But if UFS clock gating work is already running in parallel, ungate work would end up waiting for the clock gating work to finish and

RE: [PATCH v2] scsi: ufshcd: fix possible unclocked register access

Hi, Subhash. > Thanks Kim for the response. > > On 2016-10-06 03:28, Kiwoong Kim wrote: > > Hi, Subhash. > > > > Some UFS host controllers may need to call the vendor specific > > callback before and after controlling by clock control framework, > > regardless of whether available clocks are

[PATCH v2 09/12] scsi/ncr5380: Pass hostdata pointer to register polling routines

Pass a NCR5380_hostdata struct pointer to the board-specific routines instead of a Scsi_Host struct pointer. This reduces pointer chasing in the PIO and PDMA fast paths. The old way was a mistake because it is slow and the board-specific code is not concerned with the mid-layer. Signed-off-by:

[PATCH v2 06/12] scsi/ncr5380: Improve hostdata struct member alignment and cache-ability

Re-order struct members so that hot data lies at the beginning of the struct and cold data at the end. Improve the comments while we're here. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke --- drivers/scsi/NCR5380.h | 40

[PATCH v2 07/12] scsi/ncr5380: Store IO ports and addresses in host private data

The various 5380 drivers inconsistently store register pointers either in the Scsi_Host struct "legacy crap" area or in special, board-specific members of the NCR5380_hostdata struct. Uniform use of the latter struct makes for simpler and faster code (see the following patches) and helps to reduce

[PATCH v2 11/12] scsi/ncr5380: Use correct types for DMA routines

Apply prototypes to get consistent function signatures for the DMA functions implemented in the board-specific drivers. To avoid using macros to alter actual parameters, some of those functions are reworked slightly. This is a step toward the goal of passing the board-specific routines to the

[PATCH v2 10/12] scsi/ncr5380: Expedite register polling

Avoid the call to NCR5380_poll_politely2() when possible. The call is easily short-circuited on the PIO fast path, using the inline wrapper. This requires that the NCR5380_read macro be made available before any #include "NCR5380.h" so a few declarations have to be moved too. Signed-off-by: Finn

[PATCH v2 12/12] scsi/ncr5380: Suppress unhelpful "interrupt without IRQ bit" message

If a NCR5380 host instance ends up on a shared interrupt line then this printk will be a problem. It is already a problem on some Mac models: when testing mac_scsi on a PowerBook 180 I found that PDMA transfers (but not PIO transfers) cause the message to be logged. These spurious interrupts

[PATCH v2 05/12] scsi/ncr5380: Increase register polling limit

If NCR5380_poll_politely() is called under irq lock, the polling time limit is clamped to avoid a spike in interrupt latency. When not under irq lock, the same polling time limit acts as the worst case delay between schedule() calls. During PDMA (under irq lock) I've found that the 10 ms time

[PATCH v2 02/12] scsi/cumana_1: Remove unused cumanascsi_setup() function

Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke --- drivers/scsi/arm/cumana_1.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/arm/cumana_1.c b/drivers/scsi/arm/cumana_1.c index 8e9cfe8..f616756 100644 ---

[PATCH v2 01/12] scsi/g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio drivers

From: Ondrej Zary Merge the port-mapped IO and memory-mapped IO support (with the help of ioport_map) into the g_NCR5380 module and delete g_NCR5380_mmio. Signed-off-by: Ondrej Zary Signed-off-by: Finn Thain

[PATCH v2 08/12] scsi/ncr5380: Use correct types for device register accessors

For timeout values adopt unsigned long, which is the type of jiffies etc. For chip register values and bit masks pass u8, which is the return type of readb, inb etc. For device register offsets adopt unsigned int, as it is suitable for adding to base addresses. Pass the NCR5380_hostdata pointer

[PATCH v2 04/12] scsi/ncr5380: Simplify register polling limit

When polling a device register under irq lock the polling loop terminates after a given number of jiffies. Make this timeout independent of the HZ setting. All 5380 drivers benefit from this patch, which optimizes the PIO fast path, because they all use PIO transfers (for phases other than DATA

[PATCH v2 03/12] scsi/atari_scsi: Make device register accessors re-enterant

This patch fixes an old bug: accesses to device registers from the interrupt handler (after reselection, DMA completion etc.) could mess up a device register access elsewhere, if the latter takes place outside of an irq lock (during selection etc.). Signed-off-by: Finn Thain

[PATCH v2 00/12] Fixes, cleanup and g_NCR5380_mmio/g_NCR5380 merger

This patch series has fixes for compatibility, reliability and performance issues and some cleanup. It also includes a new version of Ondrej Zary's patch that merges g_NCR5380_mmio into g_NCR5380. I've tested this patch series on a Powerbook 180. If someone would test some of the other platforms

Re: [PATCH v1 0/8] Support for Exynos specific UFS driver

Hi Kim, On 2016-10-06 01:12, Kiwoong Kim wrote: This series of patches introduce support for Exynos specific UFS driver. An original version of this has been applied on mass production of commercial mobile devices. Documentation/devicetree/bindings/ufs/ufs-exynos.txt | 93 +

[PATCH] scsi: fcoe: fix off-by-one array size comparison

From: Colin Ian King Fix an off-by-one array size comparison that is comparing one too many items in an array and hence will causing an out-of-bounds array read on array fcoe_port_speed_mapping. Signed-off-by: Colin Ian King ---

[Bug 176701] New: hdparm security erase gets aborted by SML

https://bugzilla.kernel.org/show_bug.cgi?id=176701 Bug ID: 176701 Summary: hdparm security erase gets aborted by SML Product: SCSI Drivers Version: 2.5 Kernel Version: 4.4 Hardware: All OS: Linux Tree:

Donation of £1.5 Million Pounds!!

My wife and I have awarded you with a donation of £1.5 million Pounds from part of our Jackpot Lottery of 161,653,000 Million Pounds, send your name,address, phone for claims. View http://www.bbc.co.uk/news/uk-scotland-glasgow-west-18801698 We await your earliest response and God Bless you.

RE: [PATCH v2] scsi: ufshcd: fix possible unclocked register access

Hi, Subhash. Some UFS host controllers may need to call the vendor specific callback before and after controlling by clock control framework, regardless of whether available clocks are turned on or off. Is there any special reason to limit to invoke the callback only when the clocks are turned

[PATCH v1 0/8] Support for Exynos specific UFS driver

This series of patches introduce support for Exynos specific UFS driver. An original version of this has been applied on mass production of commercial mobile devices. Documentation/devicetree/bindings/ufs/ufs-exynos.txt | 93 + drivers/scsi/ufs/Kconfig |

[PATCH v1 1/8] ufs: add some vendor specific operations

Some UFS host controller may need to require some sequences before used clocks are turned on or off. e.g) control internal gates in UFS host Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 15 +-- drivers/scsi/ufs/ufshcd.h | 37

[GIT PULL] first round of SCSI updates for the 4.8+ merge window

This update includes the usual round of major driver updates (hpsa, be2iscsi, hisi_sas, zfcp, cxlflash). There's a new incarnation of hpsa called smartpqi for which a driver is added, there's some cleanup work of the ibm vscsi target and updates to libfc, plus a whole host of minor fixes and