Caching Mode Page and DPOFUA bit handling in sd

Hi all, I would like to raise some concern over how the SCSI disk driver handles Caching Mode Page and DPOFUA bit. The first thing is what the driver assumes when no Caching Mode Page is found. By default it "assumes write through", which means it assumes that the disk has no Caching Mode Page

Re: [PATCH v1 12/12] scsi: ufs: Improve fatal error logs

On 2016-12-12 17:19, Joe Perches wrote: On Mon, 2016-12-12 at 16:56 -0800, Subhash Jadavani wrote: Errors such as UIC error, illegal OCS values, and others may require more information for debugging. Such information could be hibern8 events, events sequences, recoverable errors, error

[PATCH v4] scsi: avoid a permanent stop of the scsi device's request queue

A race between scanning and fc_remote_port_delete() may result in a permanent stop if the device gets blocked before scsi_sysfs_add_sdev() and unblocked after. The reason is that blocking a device sets both the SDEV_BLOCKED state and the QUEUE_FLAG_STOPPED. However, scsi_sysfs_add_sdev()

Re: [PATCH v1 12/12] scsi: ufs: Improve fatal error logs

On Mon, 2016-12-12 at 16:56 -0800, Subhash Jadavani wrote: > Errors such as UIC error, illegal OCS values, and others may require > more information for debugging. Such information could be hibern8 events, > events sequences, recoverable errors, error history, and more. [] > diff --git

Re: [PATCH v3] scsi: avoid a permanent stop of the scsi device's request queue

Hi, James, Ewan, On 2016/12/13 0:43, James Bottomley wrote: > On Mon, 2016-12-12 at 11:23 -0500, Ewan D. Milne wrote: >> On Mon, 2016-12-12 at 10:20 +0800, Wei Fang wrote: >>> A race between scanning and fc_remote_port_delete() may result in a >>> permanent stop if the device gets blocked before

[PATCH v1 11/12] scsi: ufs: add trace event for ufs commands

From: Lee Susman Use the ftrace infrastructure to conditionally trace ufs command events. New trace event is created, which samples the following ufs command data: - device name - optional identification string - task tag - doorbell register - number of transfer bytes -

[PATCH v1 12/12] scsi: ufs: Improve fatal error logs

From: Dolev Raviv Errors such as UIC error, illegal OCS values, and others may require more information for debugging. Such information could be hibern8 events, events sequences, recoverable errors, error history, and more. This patch improves tracking of important errors

[PATCH v1 10/12] scsi: ufs: add time profiling support

This patch adds the profiling support for some of the time critical operations like hibern8 enter/exit, clock gating & clock scaling. Reviewed-by: Venkat Gopalakrishnan Signed-off-by: Subhash Jadavani --- drivers/scsi/ufs/ufshcd.c | 24

[PATCH v1 09/12] scsi: ufs: fix setting init power mode

Immediately after successful UFS link startup, UFS link power mode would be in PWM-G1, 1-lane, SLOW-AUTO mode. But currently we are doing few of the DME local/peer attributes access before setting the "hba->pwr_info" to default power mode. If we are doing link startup as part of error recovery

[PATCH v1 08/12] scsi: ufs: add capability to keep auto bkops always enabled

UFS device requires to perform bkops (back ground operations) periodically but host can control (via auto-bkops parameter of device) when device can perform bkops based on its performance requirements. In general, host would like to enable the device's auto-bkops only when it's not doing any

[PATCH v1 07/12] scsi: ufs: add option to change default UFS power management level

UFS device and link can be put in multiple different low power modes hence UFS driver supports multiple different low power modes. By default UFS driver selects the default (optimal) low power mode (which gives moderate power savings and have relatively less enter and exit latencies) but we might

[PATCH v1 05/12] scsi: ufs: Add sysfs node to dynamically control clock scaling

From: Sahitya Tummala Provide an option to enable/disable clock scaling during runtime. Write 1/0 to "clkscale_enable" sysfs node to enable/disable clock scaling. Signed-off-by: Sahitya Tummala Signed-off-by: Subhash Jadavani

[PATCH v1 04/12] scsi: ufs: Add sysfs node to dynamically control clock gating

From: Sahitya Tummala Provide an option to enable/disable clock gating during runtime. Write 1 or 0 to "clkgate_enable" sysfs node to enable/disable clock gating. Signed-off-by: Sahitya Tummala Signed-off-by: Subhash Jadavani

[PATCH v1 06/12] scsi: ufs: provide sysfs attribute to select the PM level

This patch provides the sysfs attribute to choose the power management level for UFS runtime and system suspend. Reviewed-by: Sujit Reddy Thumma Signed-off-by: Subhash Jadavani --- drivers/scsi/ufs/ufshcd.c | 122

[PATCH v1 02/12] scsi: ufs: add tracing support

This change adds the ftrace support for following: 1. UFS initialization time 2. Clock gating states 3. Clock scaling states 4. Power management APIs latency 5. BKOPs enable/disable Usage: echo 1 > /sys/kernel/debug/tracing/events/ufs/enable cat

[PATCH v1 03/12] scsi: ufs: fix multiple ufs spec violation

From: Dolev Raviv When a command to a W-LU is timed out via scsi, error handling will treat it as any other LU and send commands such as START_STOP with wrong format or task abort. Those commands are illegal for W-LU according to the UFS spec. To solve it, when an error is

[PATCH v1 01/12] scsi: ufs: dump debug info during failures

From: Dolev Raviv Inserts driver dumps for UFS Host Controller registers, Transfer Requests and Task Management Requests. The dumps will occur on driver initialization failure, ufshcd_abort() and on error handling path. Signed-off-by: Dolev Raviv

[PATCH v1 00/12] scsi: ufs: add trace/debug support, sysfs controls and few fixes

This patch series adds following things: - ftrace support to trace important events in UFS driver. - debug dumps following failures to ease the debugging - sysfs node to control clock gating, clock scaling and PM - few fixes Dolev Raviv (3): scsi: ufs: dump debug info during failures

[PATCH v2] mpt3sas: Recognize and act on iopriority info

From: Adam Manzanares This patch adds support for request iopriority handling in the mpt3sas layer. This works only when a ATA device is behind the SATL. The ATA device also has to indicate that it supports command priorities in the identify information that is pulled

Re: iscsi_trx going into D state

Nicholas, After lots of set backs and having to give up trying to get kernel dumps on our "production" systems, I've been able to work out the issues we had with kdump and replicate the issue on my dev boxes. I have dumps from 4.4.30 and 4.9-rc8 (makedumpfile would not dump, so it is a straight

Re: [PATCH 00/22] qla2xxx: Target code enhancemets and feature update

Hi Nic, On 12/6/16, 12:30 PM, "Himanshu Madhani" wrote: >Hi Nic, > >Please consider this series for target-pending. This series is based on >scsi-misc series that was submitted earlier today. > >Here's link for that series >

[PATCH v5 4/5] qla2xxx: Add Block Multi Queue functionality.

From: Michael Hernandez Tell the SCSI layer how many hardware queues we have based on the number of max queue pairs created. The number of max queue pairs created will depend on number of MSI-X vector count. This feature can be turned on via CONFIG_SCSI_MQ_DEFAULT

[PATCH v5 5/5] qla2xxx: Fix Target mode handling with Multiqueue changes.

From: Quinn Tran - Fix race condition between dpc_thread accessing Multiqueue resources and qla2x00_remove_one thread trying to free resource. - Fix out of order free for Multiqueue resources. Also, Multiqueue interrupts needs a workqueue. Interrupt needed to stop

[PATCH v5 3/5] qla2xxx: Add multiple queue pair functionality.

From: Michael Hernandez Replaced existing multiple queue functionality with framework that allows for the creation of pairs of request and response queues, either at start of day or dynamically. Queue pair creation depend on module parameter "ql2xmqsupport", which

[PATCH v5 2/5] qla2xxx: Utilize pci_alloc_irq_vectors/pci_free_irq_vectors calls.

From: Michael Hernandez Replaces the old pci_enable_msi[x]* and pci_disable_msi[x] calls. Signed-off-by: Michael Hernandez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 2 +-

[PATCH v5 1/5] qla2xxx: Only allow operational MBX to proceed during RESET.

This patch is allowing only ROM mailbox command which are necessary to initialize chip after a reset has been issued. In a target environment, there could be a user space daemon which can issue statistics and other management mailbox command which are non-critical. This patch will timeout non

[PATCH v5 0/5] qla2xxx: Feature updaes for driver.

Hi Martin, Please consider this revised series for inclusion into scsi-misc. This series has incorporated partial changes based on review comments from Christoph and Hannes. Changes from v4 -> v5 o Dropped patch addressing mailbox starvation from current series. We'll work on alternate

Re: [PATCH v3] scsi: avoid a permanent stop of the scsi device's request queue

On Mon, 2016-12-12 at 11:23 -0500, Ewan D. Milne wrote: > On Mon, 2016-12-12 at 10:20 +0800, Wei Fang wrote: > > A race between scanning and fc_remote_port_delete() may result in a > > permanent stop if the device gets blocked before > > scsi_sysfs_add_sdev() > > and unblocked after. The reason

Re: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > Detect sequential IO streams and pass those IOs directly to FW. > > This patch is depending on patch 3 > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi/megaraid/megaraid_sas.h| 5 +- >

Re: [PATCH v3] scsi: avoid a permanent stop of the scsi device's request queue

On Mon, 2016-12-12 at 10:20 +0800, Wei Fang wrote: > A race between scanning and fc_remote_port_delete() may result in a > permanent stop if the device gets blocked before scsi_sysfs_add_sdev() > and unblocked after. The reason is that blocking a device sets both > the SDEV_BLOCKED state and the

RE: [PATCH v2] scsi: hpsa: remove memory allocate failure message

> -Original Message- > From: kushwah...@samsung.com [mailto:kushwah...@samsung.com] > Sent: Monday, December 12, 2016 5:04 AM > To: Don Brace; j...@linux.vnet.ibm.com > Cc: linux-scsi@vger.kernel.org; akkushwaha9...@gmail.com; > vidushi.k...@samsung.com > Subject: [PATCH v2] scsi: hpsa:

[PATCH v2] scsi: hpsa: remove memory allocate failure message

From: Amit Kushwaha This patch cleanup warning reported by checkpatch.pl WARNING: Possible unnecessary 'out of memory' message With no available memory, a warn on message already gets printed by page alloc apis and modified goto use if memory unallocated. Signed-off-by: