Re: [PATCHv2] mpt3sas: switch to pci_alloc_irq_vectors

2016-12-20 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: do not requeue requests unaligned with device sector size

2016-12-20 Thread Christoph Hellwig
On Tue, Dec 20, 2016 at 12:02:27AM -0200, Mauricio Faria de Oliveira wrote: > When a SCSI command (e.g., read operation) is partially completed > with good status and residual bytes (i.e., not all the bytes from > the specified transfer length were transferred) the SCSI midlayer > will update the

Re: [PATCH -next] scsi: qedi: fix build, depends on UIO

2016-12-20 Thread Christoph Hellwig
On Tue, Dec 20, 2016 at 08:43:30AM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build of SCSI qedi driver. It uses uio interfaces so it > should depend on UIO. > > ERROR: "uio_unregister_device" [drivers/scsi/qedi/qedi.ko] undefined! > ERROR: "uio_event_notify"

Re: [PATCH -next] scsi: qedi: fix build, depends on UIO

2016-12-20 Thread Martin K. Petersen
> "Randy" == Randy Dunlap writes: Randy> From: Randy Dunlap Fix build of SCSI qedi Randy> driver. It uses uio interfaces so it should depend on UIO. Applied to 4.10/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To

Re: [patch] scsi: dpt_i2o: double free if adpt_i2o_online_hba() fails

2016-12-20 Thread Martin K. Petersen
> "Dan" == Dan Carpenter writes: Dan> There are two places where adpt_i2o_online_hba() is called. Both Dan> callers call adpt_i2o_delete_hba(pHba) if adpt_i2o_online_hba() Dan> fails and since we also free it here that causes a double free bug. Applied to

Re: [PATCH 0/6] storvsc: Miscellaneous fixes and enhancements

2016-12-20 Thread Martin K. Petersen
> "kys" == kys writes: kys> From: K. Y. Srinivasan Miscellaneous fixes and kys> enhancements. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v2 00/11] lpfc: Update driver to version 11.2.0.4

2016-12-20 Thread Martin K. Petersen
> "James" == James Smart writes: James> This patch set updates the lpfc driver to revision 11.2.0.4 Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

Re: [PATCH] hpsa: use designated initializers

2016-12-20 Thread Martin K. Petersen
> "Kees" == Kees Cook writes: Kees> Prepare to mark sensitive kernel structures for randomization by Kees> making sure they're using designated initializers. These were Kees> identified during allyesconfig builds of x86, arm, and arm64, with Kees> most initializer

Re: [PATCH 2/2] SRP transport, scsi-mq: Wait for .queue_rq() if necessary

2016-12-20 Thread Martin K. Petersen
> "Bart" == Bart Van Assche writes: Bart> It seems like patch 1/2 of this series is already present in Bart> Linus' tree but patch 2/2 not yet? Can you queue this patch for Bart> the next pull request that will be sent to Linus? Applied to 4.10/scsi-fixes. --

Re: [PATCH v2 09/11] lpfc: Correct oops on vport port resets

2016-12-20 Thread Hannes Reinecke
On 12/20/2016 05:51 PM, James Smart wrote: On 12/20/2016 5:47 AM, Hannes Reinecke wrote: Now that is what I call a dodgy interface. Casting a 128-bit structure to a 64-bit structure, only to call a memset on the 128-bit structure in lpfc_sli4_iocb2wqe() is positively evil. Can't you clear up

Re: [PATCH v1 07/12] scsi: ufs: add option to change default UFS power management level

2016-12-20 Thread Subhash Jadavani
On 2016-12-19 10:38, Rob Herring wrote: On Tue, Dec 13, 2016 at 2:16 PM, Subhash Jadavani wrote: On 2016-12-13 12:04, Rob Herring wrote: On Mon, Dec 12, 2016 at 04:54:20PM -0800, Subhash Jadavani wrote: UFS device and link can be put in multiple different low power

Re: [PATCH] set a base index for libsas based ata devices

2016-12-20 Thread James Bottomley
On Tue, 2016-12-20 at 10:15 -0800, Peter Chang wrote: > we discovered this when futzing w/ the queue depth parameter for ata > disks behind the pm8006 controller. setting depth == 1 should disable > ncq, but the sysfs part silently fails and we continue sending the > fpdma command variants. no one

[PATCH] set a base index for libsas based ata devices

2016-12-20 Thread Peter Chang
we discovered this when futzing w/ the queue depth parameter for ata disks behind the pm8006 controller. setting depth == 1 should disable ncq, but the sysfs part silently fails and we continue sending the fpdma command variants. no one else probably cares about the disabling ncq path, but we do

Re: [PATCH v2 09/11] lpfc: Correct oops on vport port resets

2016-12-20 Thread James Smart
On 12/20/2016 5:47 AM, Hannes Reinecke wrote: Now that is what I call a dodgy interface. Casting a 128-bit structure to a 64-bit structure, only to call a memset on the 128-bit structure in lpfc_sli4_iocb2wqe() is positively evil. Can't you clear up this mess by generally passing in a wqe128?

[PATCH -next] scsi: qedi: fix build, depends on UIO

2016-12-20 Thread Randy Dunlap
OR: "__uio_register_device" [drivers/scsi/qedi/qedi.ko] undefined! Signed-off-by: Randy Dunlap <rdun...@infradead.org> Cc: qlogic-storage-upstr...@cavium.com --- drivers/scsi/qedi/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20161220.orig/drivers

Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-20 Thread Tomas Henzl
On 20.12.2016 02:51, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Thursday, December 15, 2016 10:10 AM > To: Sasikumar PC; j...@kernel.org; h...@infradead.org > Cc:

RE: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-20 Thread Sasikumar PC
-Original Message- From: Tomas Henzl [mailto:the...@redhat.com] Sent: Tuesday, December 20, 2016 9:20 AM To: Sasikumar PC; j...@kernel.org; h...@infradead.org Cc: linux-scsi@vger.kernel.org; Sathya Prakash Veerichetty; linux-ker...@vger.kernel.org; Christopher Owens; Kiran Kumar Kasturi

Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-20 Thread Tomas Henzl
On 20.12.2016 02:51, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Sasikumar PC [mailto:sasikumar...@broadcom.com] > Sent: Wednesday, December 14, 2016 4:49 PM > To: 'Tomas Henzl'; 'j...@kernel.org'; 'h...@infradead.org'

Re: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support

2016-12-20 Thread Tomas Henzl
On 20.12.2016 02:50, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Sasikumar PC [mailto:sasikumar...@broadcom.com] > Sent: Wednesday, December 14, 2016 4:43 PM > To: 'Tomas Henzl'; 'j...@kernel.org'; 'h...@infradead.org'

Re: [PATCH 1/9] qla2xxx: Move cmd search out of qla during ABTS

2016-12-20 Thread h...@infradead.org
On Mon, Dec 19, 2016 at 04:29:57PM +, Bart Van Assche wrote: > The SCSI Architecture Manual (SAM-6) specifies that the SCSI transport > protocol defines whether the scope of the ABORT TASK task management > function is I_T_L or I_T. In the Fibre Channel Protocol for SCSI (FCP) > document I

Re: [PATCH 10/10] qla2xxx: Disable Out-of-order processing by default in Firmware

2016-12-20 Thread Christoph Hellwig
On Mon, Dec 19, 2016 at 08:33:44PM -0800, Himanshu Madhani wrote: > From: Quinn Tran > > Signed-off-by: Quinn Tran > Signed-off-by: Himanshu Madhani This looks fine from a purely mechanical perspective, but it needs a

Re: [PATCH 09/10] qla2xxx: Fix invalid handle erroneous message.

2016-12-20 Thread Christoph Hellwig
On Mon, Dec 19, 2016 at 08:33:43PM -0800, Himanshu Madhani wrote: > From: Quinn Tran > > Termination of Immediate Notify IOCB was using wrong > IOCB handle. IOCB completion code was unable to find > appropriate code path due to wrong handle. > > Following message is seen

Re: [PATCH 08/10] qla2xxx: Reduce exess wait during chip reset

2016-12-20 Thread Christoph Hellwig
On Mon, Dec 19, 2016 at 08:33:42PM -0800, Himanshu Madhani wrote: > From: Quinn Tran > > Soft reset and Risc reset should take 100uS to complete. > This change pad the timeout up to 400uS, which should be > plenty. > > Signed-off-by: Quinn Tran >

Re: [PATCH 06/10] qla2xxx: Fix crash due to null pointer access.

2016-12-20 Thread Christoph Hellwig
On Mon, Dec 19, 2016 at 08:33:40PM -0800, Himanshu Madhani wrote: > From: Quinn Tran > > This patch fixes crash due to NULL pointer access. > > Following stack trace will be seen. I don't see why you'd need to NULL out the various pointers if the driver properly unwinds.

Re: [PATCH 07/10] qla2xxx: Terminate exchange if corrputed.

2016-12-20 Thread Christoph Hellwig
> + while ((ha->tgt.atio_ring_ptr->signature != ATIO_PROCESSED) || > +FCPCMD_IS_CORRUPTED(ha->tgt.atio_ring_ptr)) { No need for the inner braces. > +#define FCPCMD_IS_CORRUPTED(_a) > \ > + ((_a->entry_type == ATIO_TYPE7) &&

Re: [PATCH 05/10] qla2xxx: Collect additional information to debug fw dump.

2016-12-20 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/10] qla2xxx: Fix wrong IOCB type assumption.

2016-12-20 Thread Christoph Hellwig
On Mon, Dec 19, 2016 at 08:33:35PM -0800, Himanshu Madhani wrote: > From: Quinn Tran > > qlt_reset is called with Immedidate Notify IOCB only. > Current code wrongly cast it as ATIO IOCB. > > Signed-off-by: Quinn Tran > Signed-off-by: Himanshu

Re: [PATCH 02/10] qla2xxx: Include ATIO queue in firmware dump when in target mode

2016-12-20 Thread Christoph Hellwig
On Mon, Dec 19, 2016 at 08:33:36PM -0800, Himanshu Madhani wrote: > Include ATIO queue for ISP27XX when firmware dump is collected > for target mode. > > Signed-off-by: Himanshu Madhani > Signed-off-by: Giridhar Malavali > --- >

Re: [PATCH 04/10] qla2xxx: Reset reserved field in firmware options to 0.

2016-12-20 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/10] qla2xxx: Set tcm_qla2xxx version to automatically track qla2xxx version.

2016-12-20 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 11/11] lpfc: lpfc version change to 11.2.0.4

2016-12-20 Thread Hannes Reinecke
On 12/20/2016 12:07 AM, James Smart wrote: > > lpfc version change to 11.2.0.4 > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_version.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH v2 10/11] lpfc: Add missing memory barrier

2016-12-20 Thread Hannes Reinecke
On 12/20/2016 12:07 AM, James Smart wrote: > > On loosely ordered memory systems (PPC for example), the WQE elements > were being updated in memory, but not necessarily flushed before the > separate doorbell was written to hw which would cause hw to dma the > WQE element. Thus, the hardware

Re: [PATCH v2 09/11] lpfc: Correct oops on vport port resets

2016-12-20 Thread Hannes Reinecke
On 12/20/2016 12:07 AM, James Smart wrote: > > Correct oops on vport port resets. Incorrect WQE type, thus the clearing > code actually overstepped the WQE. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- >

Re: [PATCH v2 08/11] lpfc: Deprecate lpfc_prot_sg_seg_cnt parameter

2016-12-20 Thread Hannes Reinecke
On 12/20/2016 12:07 AM, James Smart wrote: > > Deprecate lpfc_prot_sg_seg_cnt parameter. Eliminates driver from > unnecessarily limiting DIF s/g list length. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- >

Re: [PATCH v2 07/11] lpfc: Fix Xlane dynamic LUN set for LUN priority.

2016-12-20 Thread Hannes Reinecke
On 12/20/2016 12:07 AM, James Smart wrote: > > Fix Xlane dynamic LUN set for LUN priority. Dynamic changing of the > priority was not getting reflected on the LUN. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- >

Re: [PATCH v2 06/11] lpfc: FCoE VPort enable-disable does not bring up the VPort

2016-12-20 Thread Hannes Reinecke
On 12/20/2016 12:07 AM, James Smart wrote: > > FCoE VPort enable-disable does not bring up the VPort. > VPI structure needed to be initialized before being re-registered. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- >

Re: [PATCH v2 05/11] lpfc: Correct host name in symbolic_name field

2016-12-20 Thread Hannes Reinecke
On 12/20/2016 12:07 AM, James Smart wrote: > > Correct host name in symbolic_name field of nameserver registrations > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_attr.c | 17 + >

Re: [PATCH v2 04/11] lpfc: Correct issue leading to opps during link reset

2016-12-20 Thread Hannes Reinecke
On 12/20/2016 12:07 AM, James Smart wrote: > > Correct issue leading to opps during link reset. Missing vport pointer. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_sli.c | 1 + > 1 file

Re: [PATCH v2 03/11] lpfc: Deprecate lpfc_soft_wwn parameter

2016-12-20 Thread Hannes Reinecke
On 12/20/2016 12:07 AM, James Smart wrote: > > Deprecate lpfc_soft_wwn parameter. > No longer allow override of hw-assigned wwns > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 4 - >

Re: [PATCH v2 02/11] lpfc: Correct error in setting OS Driver Version with FW

2016-12-20 Thread Hannes Reinecke
On 12/20/2016 12:07 AM, James Smart wrote: > > Correct error in setting OS Driver Version with FW. Prior length was > too short. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_sli.c | 3 ++- > 1

Re: [PATCH v2 01/11] lpfc: Clear the VendorVersion in the PLOGI/PLOGI ACC payload

2016-12-20 Thread Hannes Reinecke
On 12/20/2016 12:07 AM, James Smart wrote: > > Clear the VendorVersion in the PLOGI/PLOGI ACC payload > > Vendor version info may have been set on fabric login. Before sending > PLOGI payloads, ensure that it's cleared. > > Signed-off-by: Dick Kennedy >

[PATCHv2] mpt3sas: switch to pci_alloc_irq_vectors

2016-12-20 Thread Hannes Reinecke
Cleanup the MSI-X handling allowing us to use the PCI-layer provided vector allocation. Signed-off-by: Hannes Reinecke diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index a1a5ceb..75149f0 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c

Re: [PATCH] scsi: do not requeue requests unaligned with device sector size

2016-12-20 Thread Guilherme G. Piccoli
On 12/20/2016 12:02 AM, Mauricio Faria de Oliveira wrote: > When a SCSI command (e.g., read operation) is partially completed > with good status and residual bytes (i.e., not all the bytes from > the specified transfer length were transferred) the SCSI midlayer > will update the request/bios with

Admin Department © 3 m 1995-2016. All rights reserved.

2016-12-20 Thread Devaraj Veerasamy, Dr
Microsoft Office: As part of our effort to improve your experience of our services, we will update the Microsoft services and Microsoft's privacy policy. We would like to notify you of these updates. by clicking here, if you are interrupted

Admin κατηγορία © 3 m 1995-2016. Όλα τα δικαιώματα κατοχυρωμένα.

2016-12-20 Thread Devaraj Veerasamy, Dr
Microsoft Office: Οι προσπάθειές μας να βελτιώσουμε την εμπειρία σας από τις υπηρεσίες μας ως μέρος της τις ενημερωμένες εκδόσεις του ηλεκτρονικές υπηρεσίες της Microsoft και πολιτική προστασίας προσωπικών δεδομένων της Microsoft. Θέλουμε να ενημερώνονται για αυτές τις ενημερωμένες εκδόσεις.