Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Thu, Dec 22, 2016 at 12:22:27PM -0800, Hugh Dickins wrote: > On Wed, 21 Dec 2016, Linus Torvalds wrote: > > On Wed, Dec 21, 2016 at 9:13 PM, Dave Chinner wrote: > > > I unmounted the fs, mkfs'd it again, ran the > > > workload again and about a minute in this fired: > > >

Re: [PATCH V6 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

Hi Sasikumar, [auto build test WARNING on scsi/for-next] [also build test WARNING on next-20161223] [cannot apply to v4.9] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: JMS56x not working reliably with uas driver

Hi Alan, On Friday 23 December 2016 04:14 AM, Alan Stern wrote: On Wed, 21 Dec 2016, George Cherian wrote: Hi Oliver, I was working with this JMicron device and using the uas driver. I am seeing the following 2 issues. 1) On connect I see the following messages. xhci_hcd :00:11.0:

[PATCH v3 08/12] scsi: ufs: add capability to keep auto bkops always enabled

UFS device requires to perform bkops (back ground operations) periodically but host can control (via auto-bkops parameter of device) when device can perform bkops based on its performance requirements. In general, host would like to enable the device's auto-bkops only when it's not doing any

[PATCH v3 11/12] scsi: ufs: add trace event for ufs commands

From: Lee Susman Use the ftrace infrastructure to conditionally trace ufs command events. New trace event is created, which samples the following ufs command data: - device name - optional identification string - task tag - doorbell register - number of transfer bytes -

[PATCH v3 04/12] scsi: ufs: Add sysfs node to dynamically control clock gating

From: Sahitya Tummala Provide an option to enable/disable clock gating during runtime. Write 1 or 0 to "clkgate_enable" sysfs node to enable/disable clock gating. Signed-off-by: Sahitya Tummala Signed-off-by: Subhash Jadavani

[PATCH v3 09/12] scsi: ufs: fix setting init power mode

Immediately after successful UFS link startup, UFS link power mode would be in PWM-G1, 1-lane, SLOW-AUTO mode. But currently we are doing few of the DME local/peer attributes access before setting the "hba->pwr_info" to default power mode. If we are doing link startup as part of error recovery

[PATCH v3 10/12] scsi: ufs: add time profiling support

This patch adds the profiling support for some of the time critical operations like hibern8 enter/exit, clock gating & clock scaling. Reviewed-by: Venkat Gopalakrishnan Signed-off-by: Subhash Jadavani --- drivers/scsi/ufs/ufshcd.c | 24

[PATCH v3 05/12] scsi: ufs: Add sysfs node to dynamically control clock scaling

From: Sahitya Tummala Provide an option to enable/disable clock scaling during runtime. Write 1/0 to "clkscale_enable" sysfs node to enable/disable clock scaling. Signed-off-by: Sahitya Tummala Signed-off-by: Subhash Jadavani

[PATCH v3 07/12] scsi: ufs: set default UFS power management level

UFS device and link can be put in multiple different low power modes hence UFS driver supports multiple different low power modes. This change sets the default UFS power management level which should put the link hibernate state and device in sleep state. This default power management level gives

[PATCH v3 12/12] scsi: ufs: Improve fatal error logs

From: Dolev Raviv Errors such as UIC error, illegal OCS values, and others may require more information for debugging. Such information could be hibern8 events, events sequences, recoverable errors, error history, and more. This patch improves tracking of important errors

[PATCH v3 06/12] scsi: ufs: provide sysfs attribute to select the PM level

This patch provides the sysfs attribute to choose the power management level for UFS runtime and system suspend. Reviewed-by: Sujit Reddy Thumma Signed-off-by: Subhash Jadavani --- drivers/scsi/ufs/ufshcd.c | 144

[PATCH v3 03/12] scsi: ufs: fix multiple ufs spec violation

From: Dolev Raviv When a command to a W-LU is timed out via scsi, error handling will treat it as any other LU and send commands such as START_STOP with wrong format or task abort. Those commands are illegal for W-LU according to the UFS spec. To solve it, when an error is

[PATCH v3 02/12] scsi: ufs: add tracing support

This change adds the ftrace support for following: 1. UFS initialization time 2. Clock gating states 3. Clock scaling states 4. Power management APIs latency 5. BKOPs enable/disable Usage: echo 1 > /sys/kernel/debug/tracing/events/ufs/enable cat

[PATCH v3 01/12] scsi: ufs: dump debug info during failures

From: Dolev Raviv Inserts driver dumps for UFS Host Controller registers, Transfer Requests and Task Management Requests. The dumps will occur on driver initialization failure, ufshcd_abort() and on error handling path. Signed-off-by: Dolev Raviv

[PATCH v3 00/12] scsi: ufs: add trace/debug support, sysfs controls and few fixes

This patch series adds following things: - ftrace support to trace important events in UFS driver. - debug dumps following failures to ease the debugging - sysfs node to control clock gating, clock scaling and PM - few fixes --- Changes from v2 -> v3: 1. Patch #2: Used TRACE_DEFINE_ENUM to

[PATCH V6 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers

An UNMAP command on a PI formatted device will leave the Logical Block Application Tag and Logical Block Reference Tag as all F's (for those LBAs that are unmapped). To avoid IO errors if those LBAs are subsequently read before they are written with valid tag fields, the MPI SCSI IO requests

[PATCH V6 02/11] megaraid_sas: 128 MSIX Support

SAS3.5 Generic Megaraid based Controllers will have the support for 128 MSI-X vectors, resulting in the need to support 128 reply queues This patch is depending on patch 1 and same as V5 Signed-off-by: Sasikumar Chandrasekaran ---

[PATCH V6 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers

This patch contains new pci device ids for SAS3.5 Generic Megaraid Controllers This Pacth is Same as V5 Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas.h| 12 +---

[PATCH V6 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities

The Megaraid driver has to support the SAS3.5 Generic Megaraid Controllers Firmware functionality. This patch is depending on patch 6 and same as V5 Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl ---

[PATCH V6 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes

To improve RAID 1/10 Write performance, OS drivers need to issue the required Write IOs as Fast Path IOs (after the appropriate checks allowing Fast Path to be used) to the appropriate physical drives (translated from the OS logical IO) and wait for all Write IOs to complete. If any of the

[PATCH V6 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap to have different sizes for different number of supported VDs. This patch is depending on patch 5 80 chars per line limit is taken care around VD_EXT_DEBUG macro. NULL pointer check for desc_table has been removed. Few code

[PATCH V6 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

Detect sequential IO streams and pass those IOs directly to FW. This patch is depending on patch 3 Few code indentation issues fixed Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas.h

[PATCH V6 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

Large SEQ IO workload should sent as non fast path commands This patch is depending on patch 7 80 chars per line limit is taken care around VD_EXT_DEBUG macro. Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 8 +

[PATCH V6 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path

ldio outstanding variable needs to be decremented in io completion path for iMR dual queue depth This patch is depending on patch 8 and same as V5 Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl ---

[PATCH V6 11/11] megaraid_sas: driver version upgrade

Upgrade driver version. This patch is depending on patch 10 and same as V5 Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH V6 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers

Update Linux driver to use new pdTargetId field for JBOD target ID This patch is depending on patch 9 and same as V5 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 105 +---

[PATCH V6 00/11] megaraid_sas: Updates for scsi-next

Sasikumar Chandrasekaran (11): megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers megaraid_sas: 128 MSIX Support megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Fri, Dec 23, 2016 at 07:53:50AM +0800, Ming Lei wrote: > On Fri, Dec 23, 2016 at 2:50 AM, Chris Leech wrote: > > I'm not reproducing any problems with xfstests running over iscsi_tcp > > right now. Two 10G luns exported from an LIO target, attached directly > > to a test VM

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Fri, Dec 23, 2016 at 2:50 AM, Chris Leech wrote: > On Thu, Dec 22, 2016 at 05:50:12PM +1100, Dave Chinner wrote: >> On Wed, Dec 21, 2016 at 09:46:37PM -0800, Linus Torvalds wrote: >> > On Wed, Dec 21, 2016 at 9:13 PM, Dave Chinner wrote: >> > > >> > >

Re: JMS56x not working reliably with uas driver

On Wed, 21 Dec 2016, George Cherian wrote: > Hi Oliver, > > I was working with this JMicron device and using the uas driver. > I am seeing the following 2 issues. > > 1) On connect I see the following messages. > xhci_hcd :00:11.0: ERROR Transfer event for disabled endpoint or > incorrect

Re: [PATCH v2 03/11] lpfc: Deprecate lpfc_soft_wwn parameter

James Smart wrote: > Deprecate lpfc_soft_wwn parameter. > No longer allow override of hw-assigned wwns > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart Any reason to remove this functionality? I was actually using it. Sebastian

Re: [PATCH ] tcm_qla2xxx - Enhancements to the tcm_debug jammer code to jam only data movement commands

- Original Message - > From: "Bart Van Assche" > To: "himanshu madhani" , lober...@redhat.com, > n...@daterainc.com > Cc: linux-scsi@vger.kernel.org > Sent: Thursday, December 22, 2016 4:54:30 PM > Subject: Re: [PATCH ]

Re: [PATCH ] tcm_qla2xxx - Enhancements to the tcm_debug jammer code to jam only data movement commands

On Thu, 2016-12-22 at 16:46 -0500, Laurence Oberman wrote: > Added the possibility of blocking only specific SCSI data movement commands > but allowing TUR'S to pass. > This has been helpful for debugging many driver/array interoperabilty > issues. Hello Laurence, Your work is appreciated and

[PATCH ] tcm_qla2xxx - Enhancements to the tcm_debug jammer code to jam only data movement commands

Hello Himanshu and Nicholas, Was going over my patches and remembered this one got lost. Himanshu, you acked this already at some point. Nicholas can we get this on next submission maybe. Thanks Laurence Added the possibility of blocking only specific SCSI data movement commands but allowing

[GIT PULL] final round of SCSI updates for the 4.9+ merge window

This is mostly stuff which missed the initial pull. There's a new driver: qedi, some ufs, ibmvscsis and ncr5380 updates plus some assorted driver fixes and also a fix for the bug where if a device goes into a blocked state between configuration and sysfs device add (which can be a long time under

[Bug 176951] boot fails unless acpi=off Acer Travelmate X-349

https://bugzilla.kernel.org/show_bug.cgi?id=176951 --- Comment #10 from mus@gmail.com --- Created attachment 248381 --> https://bugzilla.kernel.org/attachment.cgi?id=248381=edit Kernel Panic Arch Linux x64 kernel 4.9 Attached is a kernel panic I get with Arch Linux x64 and kernel 4.9.

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Wed, 21 Dec 2016, Linus Torvalds wrote: > On Wed, Dec 21, 2016 at 9:13 PM, Dave Chinner wrote: > > > > There may be deeper issues. I just started running scalability tests > > (e.g. 16-way fsmark create tests) and about a minute in I got a > > directory corruption reported

Re: block: add back plugging in __blkdev_direct_IO

Hi Christoph, [auto build test ERROR on linus/master] [also build test ERROR on next-20161222] [cannot apply to v4.9] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Christoph-Hellwig/block-add

Re: block: add back plugging in __blkdev_direct_IO

Hi Christoph, [auto build test ERROR on linus/master] [also build test ERROR on next-20161222] [cannot apply to v4.9] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Christoph-Hellwig/block-add

Hello

Hello, Complement of the Season, I'M Anessa female 25 years old single, I am contacting you because I will be relocating to your country. I will send you my photos and also tell you much about my self. Thanks. Sincerely yours Anessa. -- To unsubscribe from this list: send the line

Re: iscsi_trx going into D state

On 12/21/2016 6:39 PM, Robert LeBlanc wrote: > I hit a new backtrace today, hopefully it adds something. > > # cat /proc/19659/stack > [] iscsit_stop_session+0x1b1/0x1c0 > [] iscsi_check_for_session_reinstatement+0x1e2/0x270 > [] iscsi_target_check_for_existing_instances+0x30/0x40 > []

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Thu, Dec 22, 2016 at 05:50:12PM +1100, Dave Chinner wrote: > On Wed, Dec 21, 2016 at 09:46:37PM -0800, Linus Torvalds wrote: > > On Wed, Dec 21, 2016 at 9:13 PM, Dave Chinner wrote: > > > > > > There may be deeper issues. I just started running scalability tests > > >

Re: Testing latest linux-next 4.9 ib_srp and ib_srpt sees I/O capped at 1MB and no merging

- Original Message - > From: "Christoph Hellwig" > To: "Laurence Oberman" > Cc: "Christoph Hellwig" , "Bart Van Assche" > , > linux-r...@vger.kernel.org, linux-scsi@vger.kernel.org > Sent:

Re: [PATCH v2 00/10] qla2xxx: Bug fixes for driver.

Hi Bart, On 12/22/16, 9:02 AM, "Bart Van Assche" wrote: >On Thu, 2016-12-22 at 16:44 +, Madhani, Himanshu wrote: >> Do you want me to send series updating Reviewed-by Tag or would you be able >> to update >> while applying to target-pending tree? > >Hello

Re: [PATCH v2 00/10] qla2xxx: Bug fixes for driver.

On Thu, 2016-12-22 at 16:44 +, Madhani, Himanshu wrote: > Do you want me to send series updating Reviewed-by Tag or would you be able > to update > while applying to target-pending tree? Hello Himanshu, The past three days I have been busy with rewriting the blk-mq-sched code so I have

Re: [PATCH v2 00/10] qla2xxx: Bug fixes for driver.

On 12/22/16, 1:25 AM, "Christoph Hellwig" wrote: >The whole series looks fine: > >Reviewed-by: Christoph Hellwig > >(not sure why you dropped my Reviewed-by: tags for all the previously >reviewed patches, though) Thanks for the review. Looks like oversight

Re: Testing latest linux-next 4.9 ib_srp and ib_srpt sees I/O capped at 1MB and no merging

Hi Laurance, please try the patch below: --- >From 69febe1cfb55844862f768447432249781001f9c Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Thu, 22 Dec 2016 16:38:29 +0100 Subject: block: add back plugging in __blkdev_direct_IO This allows sending larger than 1 MB requess

Re: Testing latest linux-next 4.9 ib_srp and ib_srpt sees I/O capped at 1MB and no merging

Hello Christoph, apologies, here is a clear summary of the issue. During testing of the latest linux-next with rc-10 block layer changes I noticed that I/O was being capped at 1MB size and no merging was seen. The issue was not apparent on 4.8.0-rc8 or earlier. dd if=/dev/sdw bs=4096k

Re: [PATCH v2 12/13] be2iscsi: Add warning message for unsupported adapter

On 12/13/2016 11:26 AM, Jitendra Bhivare wrote: From: Ketan Mukadam Add a warning message to indicate obsolete/unsupported BE2 Adapter Family devices Signed-off-by: Ketan Mukadam Signed-off-by: Jitendra Bhivare

Re: [PATCH v2 13/13] be2iscsi: Update driver version

On 12/13/2016 11:26 AM, Jitendra Bhivare wrote: Version 11.2.1.0 Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_main.h

Re: [PATCH v2 11/13] be2iscsi: Reinit SGL handle, CID tables after TPE

On 12/13/2016 11:26 AM, Jitendra Bhivare wrote: After TPE recovery, CID table needs to be repopulated as per CIDs in WRBQ creation responses. SGL handles table needs to be recreated for posting and its indices need to be resetted. This is achieved by calling beiscsi_cleanup_port when disabling

Re: [PATCH v2 10/13] be2iscsi: Add checks to validate CID alloc/free

On 12/13/2016 11:26 AM, Jitendra Bhivare wrote: Set CID slot to 0x to indicate empty. Check if connection already exists in conn_table before binding. Check if endpoint already NULL before putting back CID. Break ep->conn link in free_ep to ignore completions after freeing. Signed-off-by:

Re: [PATCH v2 09/13] be2iscsi: Remove wq_name from beiscsi_hba

On 12/13/2016 11:26 AM, Jitendra Bhivare wrote: wq_name is used only to set WQ name when its being allocated. Remove it from beiscsi_hba structure and define locally. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_main.c | 9 +

Re: [PATCH v2 08/13] be2iscsi: Remove unused struct members

On 12/13/2016 11:26 AM, Jitendra Bhivare wrote: Fix errors reported in static analysis. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be.h | 3 -- drivers/scsi/be2iscsi/be_cmds.c | 8 +++--- drivers/scsi/be2iscsi/be_cmds.h | 17 ++--

Re: [PATCH v2 07/13] be2iscsi: Remove redundant receive buffers posting

On 12/13/2016 11:26 AM, Jitendra Bhivare wrote: This duplicate code got added during manual merging. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_main.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.c

Re: [PATCH v2 06/13] be2iscsi: Fix iSCSI cmd cleanup IOCTL

On 12/13/2016 11:25 AM, Jitendra Bhivare wrote: Prepare the IOCTL with appropriate sizes of buffers of V0 and V1. Set missing chute number in V1 IOCTL. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_cmds.c | 33 ++---

Re: [PATCH v2 05/13] be2iscsi: Add checks to validate completions

On 12/13/2016 11:25 AM, Jitendra Bhivare wrote: Added check in beiscsi_process_cq for pio_handle. pio_handle is cleared in beiscsi_put_wrb_handle. This catches any case where task gets cleaned up just before completion. Use back_lock before accessing pio_handle. Signed-off-by: Jitendra Bhivare

Re: [PATCH v2 04/13] be2iscsi: Set WRB invalid bit for SkyHawk

On 12/13/2016 11:25 AM, Jitendra Bhivare wrote: invalid bit in WRB indicates to FW that IO was invalidated before WRB was fetched from host memory. For SkyHawk, this invalid bit in WRB is at a different offset. Use amap_iscsi_wrb_v2 to mark invalid bit for SkyHawk. Signed-off-by: Jitendra

Re: [PATCH v2 03/13] be2iscsi: Take iscsi_task ref in abort handler

On 12/13/2016 11:25 AM, Jitendra Bhivare wrote: Hold the reference of iscsi_task till invalidation completes. This prevents use of ICD when invalidation of that ICD is being processed. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_main.c | 45

Re: [PATCH v2 02/13] be2iscsi: Fix for crash in beiscsi_eh_device_reset

On 12/13/2016 11:25 AM, Jitendra Bhivare wrote: System crashes when sg_reset is executed in a loop. CPU: 13 PID: 7073 Comm: sg_reset Tainted: GE 4.8.0-rc1+ #4 RIP: 0010:[] [] beiscsi_eh_device_reset+0x160/0x520 [be2iscsi] Call Trace: [] ? scsi_host_alloc_command+0x47/0xc0 []

Re: [PATCH v2 01/13] be2iscsi: Fix use of invalidate command table req

On 12/13/2016 11:25 AM, Jitendra Bhivare wrote: Remove shared structure inv_tbl in phba for all sessions to post invalidation IOCTL. Always allocate and then free the table after use in reset handler. Abort handler needs just one instance so define it on stack. Add checks for

[PATCH v2] scsi: qla4xxx: Use dma_pool_zalloc

We should use dma_pool_zalloc instead of dma_pool_alloc/memset Signed-off-by: Souptick joarder --- v2 changes: - Address comment from Nilesh to make same change in all applicable places inside qla4xxx source drivers/scsi/qla4xxx/ql4_mbx.c | 6 ++

Re: [PATCH] scsi/qla4: comments correction

On 19/12/16, 11:50 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Cao jin" wrote: >Signed-off-by: Cao jin >--- > drivers/scsi/qla4xxx/ql4_os.c | 6 +++--- > 1 file changed, 3 insertions(+), 3

Re: JMS56x not working reliably with uas driver

On Thu, 2016-12-22 at 15:43 +0530, George Cherian wrote: > dmesg with the patch applied Hi, did you apply both patches, yours and the one I posted? And did you physically disconnect your device? Regards Oliver -- To unsubscribe from this list: send the line

Re: JMS56x not working reliably with uas driver

dmesg with the patch applied [root@localhost ~]# dmesg [ 108.575683] usb 4-1.3: new SuperSpeed USB device number 3 using xhci_hcd [ 108.596485] usb 4-1.3: New USB device found, idVendor=152d, idProduct=9561 [ 108.603350] usb 4-1.3: New USB device strings: Mfr=1, Product=2, SerialNumber=5 [

Re: [PATCH v2 00/10] qla2xxx: Bug fixes for driver.

The whole series looks fine: Reviewed-by: Christoph Hellwig (not sure why you dropped my Reviewed-by: tags for all the previously reviewed patches, though) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] scsi: qedi: return via va_end to match corresponding va_start

On 16/12/16 7:40 PM, "Colin King" wrote: >From: Colin Ian King > >Although on most systems va_end is a no-op, it is good practice >to use va_end on the function return path, especially since the >va_start documenation states: > > "Each