Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 06:22 PM, Jens Axboe wrote: > On 01/26/2017 06:15 PM, Bart Van Assche wrote: >> On Thu, 2017-01-26 at 17:41 -0700, Jens Axboe wrote: >>> On 01/26/2017 05:38 PM, Bart Van Assche wrote: I see similar behavior with the blk-mq-sched branch of git://git.kernel.dk/linux-block.git

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 06:15 PM, Bart Van Assche wrote: > On Thu, 2017-01-26 at 17:41 -0700, Jens Axboe wrote: >> On 01/26/2017 05:38 PM, Bart Van Assche wrote: >>> I see similar behavior with the blk-mq-sched branch of >>> git://git.kernel.dk/linux-block.git (git commit ID 0efe27068ecf): >>> booting

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On Thu, 2017-01-26 at 17:41 -0700, Jens Axboe wrote: > On 01/26/2017 05:38 PM, Bart Van Assche wrote: > > I see similar behavior with the blk-mq-sched branch of > > git://git.kernel.dk/linux-block.git (git commit ID 0efe27068ecf): > > booting happens much slower than usual and I/O hangs if I run

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 05:38 PM, Bart Van Assche wrote: > On Thu, 2017-01-26 at 16:50 -0700, Jens Axboe wrote: >> Clearly we are missing some requests. How do I setup dm similarly to >> you? >> >> Does it reproduce without Christoph's patchset? > > Hello Jens, > > I see similar behavior with the

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On Thu, 2017-01-26 at 16:50 -0700, Jens Axboe wrote: > Clearly we are missing some requests. How do I setup dm similarly to > you? > > Does it reproduce without Christoph's patchset? Hello Jens, I see similar behavior with the blk-mq-sched branch of git://git.kernel.dk/linux-block.git (git

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 04:50 PM, Jens Axboe wrote: > On 01/26/2017 04:47 PM, Bart Van Assche wrote: >> On Thu, 2017-01-26 at 16:26 -0700, Jens Axboe wrote: >>> What device is stuck? Is it running with an mq scheduler attached, or >>> with "none"? >>> >>> Would also be great to see the output of

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 04:47 PM, Bart Van Assche wrote: > On Thu, 2017-01-26 at 16:26 -0700, Jens Axboe wrote: >> What device is stuck? Is it running with an mq scheduler attached, or >> with "none"? >> >> Would also be great to see the output of /sys/block/*/mq/*/tags and >> sched_tags so we can see if

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On Thu, 2017-01-26 at 16:26 -0700, Jens Axboe wrote: > What device is stuck? Is it running with an mq scheduler attached, or > with "none"? > > Would also be great to see the output of /sys/block/*/mq/*/tags and > sched_tags so we can see if they have anything pending. > > From a quick look at

Re: [PATCH 04/18] block: simplify blk_init_allocated_queue

On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > Return an errno value instead of the passed in queue so that the callers > don't have to keep track of two queues, and move the assignment of the > request_fn and lock to the caller as passing them as argument doesn't > simplify

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 04:14 PM, Bart Van Assche wrote: > On Thu, 2017-01-26 at 14:51 -0700, Jens Axboe wrote: >> That is exactly what it means, looks like that one path doesn't handle >> that. You'd have to exhaust the pool with atomic allocs for this to >> trigger, we don't do that at all in the normal

Re: [PATCH 03/18] block: fix elevator init check

On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > We can't initalize the elevator fields for flushes as flush share space > in struct request with the elevator data. But currently we can't > commnicate that a request is a flush through blk_get_request as we > can only pass READ or

Re: [PATCH 02/18] md: cleanup bio op / flags handling in raid1_write_request

On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > No need for the local variables, the bio is still live and we can just > assigned the bits we want directly. Make me wonder why we can't assign > all the bio flags to start with. I assume that you ment "assign" in the patch

Re: [PATCH 01/18] block: add a op_is_flush helper

On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > This centralizes the checks for bios that needs to be go into the flush > state machine. Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of

Re: [PATCH v2 2/2] virtio_scsi: Implement fc_host

On Thu, Jan 26, 2017 at 11:41:09AM +0800, Fam Zheng wrote: > This implements the VIRTIO_SCSI_F_FC_HOST feature by reading the config > fields and presenting them as sysfs fc_host attributes. The config > change handler is added here because primary_active will toggle during > migration. Looks

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 02:47 PM, Bart Van Assche wrote: > (gdb) list *(blk_mq_sched_get_request+0x310) > 0x8132dcf0 is in blk_mq_sched_get_request (block/blk-mq-sched.c:136). > 131 rq->rq_flags |= RQF_QUEUED; > 132 } else > 133

Re: [PATCH v2 1/2] virtio_scsi: Add fc_host definitions

On Thu, Jan 26, 2017 at 11:41:08AM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- I pefer combining this with implementation, hard to reason about interface alone. > include/uapi/linux/virtio_scsi.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On Thu, 2017-01-26 at 14:12 -0700, Jens Axboe wrote: > On 01/26/2017 02:01 PM, Bart Van Assche wrote: > > On Thu, 2017-01-26 at 13:54 -0700, Jens Axboe wrote: > > > Your call path has blk_get_request() in it, I don't have > > > that in my tree. Is it passing in the right mask? > > > > Hello Jens,

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 02:01 PM, Bart Van Assche wrote: > On Thu, 2017-01-26 at 13:54 -0700, Jens Axboe wrote: >> Your call path has blk_get_request() in it, I don't have >> that in my tree. Is it passing in the right mask? > > Hello Jens, > > There is only one blk_get_request() call in

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On Thu, 2017-01-26 at 13:54 -0700, Jens Axboe wrote: > Your call path has blk_get_request() in it, I don't have > that in my tree. Is it passing in the right mask? Hello Jens, There is only one blk_get_request() call in drivers/md/dm-mpath.c and it looks as follows: clone =

RE: [PATCH V2 05/24] aacraid: Retrieve and update the device types

> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Raghava Aditya Renukunta > Sent: Thursday, January 26, 2017 10:44 AM > To: Johannes Thumshirn > Cc: j...@linux.vnet.ibm.com;

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 01:47 PM, Bart Van Assche wrote: > On 01/26/2017 11:01 AM, Jens Axboe wrote: >> On 01/26/2017 11:59 AM, h...@lst.de wrote: >>> On Thu, Jan 26, 2017 at 11:57:36AM -0700, Jens Axboe wrote: It's against my for-4.11/block, which you were running under Christoph's patches. Maybe

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 11:01 AM, Jens Axboe wrote: > On 01/26/2017 11:59 AM, h...@lst.de wrote: >> On Thu, Jan 26, 2017 at 11:57:36AM -0700, Jens Axboe wrote: >>> It's against my for-4.11/block, which you were running under Christoph's >>> patches. Maybe he's using an older version? In any case, should be

Re: split scsi passthrough fields out of struct request V2

On 01/26/2017 11:59 AM, h...@lst.de wrote: > On Thu, Jan 26, 2017 at 11:57:36AM -0700, Jens Axboe wrote: >> It's against my for-4.11/block, which you were running under Christoph's >> patches. Maybe he's using an older version? In any case, should be >> pretty trivial for you to hand apply. Just

Re: [PATCH 15/16] block: split scsi_request out of struct request

On 01/26/2017 12:37 PM, Christoph Hellwig wrote: > On Thu, Jan 26, 2017 at 11:12:51AM -0800, Bart Van Assche wrote: >> Where does the '* 3' come from? I think that deserves a comment. >> Additionally, this patch introduces a new warning when building with W=1: > > It's a magic factor copied from

Re: [PATCH 15/16] block: split scsi_request out of struct request

On Thu, Jan 26, 2017 at 11:12:51AM -0800, Bart Van Assche wrote: > Where does the '* 3' come from? I think that deserves a comment. > Additionally, this patch introduces a new warning when building with W=1: It's a magic factor copied from the old code :( That beeing said I really wonder if we

Re: [PATCH 15/16] block: split scsi_request out of struct request

On 01/23/2017 07:29 AM, Christoph Hellwig wrote: > +int scsi_cmd_buf_len(struct request *rq) > +{ > + return scsi_req(rq)->cmd_len * 3; > +} > +EXPORT_SYMBOL(scsi_cmd_buf_len); Hello Christoph, Where does the '* 3' come from? I think that deserves a comment. Additionally, this patch

RE: [PATCH V2 05/24] aacraid: Retrieve and update the device types

> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Thursday, January 26, 2017 1:00 AM > To: Raghava Aditya Renukunta > > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- > s...@vger.kernel.org; Dave

Re: split scsi passthrough fields out of struct request V2

On Thu, Jan 26, 2017 at 11:57:36AM -0700, Jens Axboe wrote: > It's against my for-4.11/block, which you were running under Christoph's > patches. Maybe he's using an older version? In any case, should be > pretty trivial for you to hand apply. Just ensure that .flags is set to > 0 for the common

Re: split scsi passthrough fields out of struct request V2

On 01/26/2017 11:52 AM, Bart Van Assche wrote: > On Thu, 2017-01-26 at 11:44 -0700, Jens Axboe wrote: >> I think this may be my bug - does the below help? > > Hello Jens, > > What tree has that patch been generated against? It does not apply > cleanly on top of Christoph's tree: > > $ git

RE: [PATCH V2 06/24] aacraid: Reworked scsi command submission path

Hi Johannes, > -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Thursday, January 26, 2017 1:06 AM > To: Raghava Aditya Renukunta > > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- >

Re: split scsi passthrough fields out of struct request V2

On Thu, 2017-01-26 at 11:44 -0700, Jens Axboe wrote: > I think this may be my bug - does the below help? Hello Jens, What tree has that patch been generated against? It does not apply cleanly on top of Christoph's tree: $ git checkout hch-block-pc-refactor $ patch -p1 --dry-run -f -s <

Re: split scsi passthrough fields out of struct request V2

On 01/26/2017 11:29 AM, Bart Van Assche wrote: > On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: >> Hi all, >> >> this series splits the support for SCSI passthrough commands from the >> main struct request used all over the block layer into a separate >> scsi_request structure that

RE: [PATCH V2 04/24] aacraid: Added sa firmware support

> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Thursday, January 26, 2017 12:55 AM > To: Raghava Aditya Renukunta > > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- > s...@vger.kernel.org; Dave

RE: [PATCH V2 03/24] aacraid: added support for init_struct_8

> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Thursday, January 26, 2017 12:37 AM > To: Raghava Aditya Renukunta > > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- > s...@vger.kernel.org; Dave

Re: [PATCH v2] mpt3sas: Force request partial completion alignment

On 01/26/2017 03:02 PM, Ram Pai wrote: > On Thu, Jan 26, 2017 at 11:31:53AM -0200, Guilherme G. Piccoli wrote: >> On 01/25/2017 09:46 PM, Martin K. Petersen wrote: "Guilherme" == Guilherme G Piccoli writes: >>> >>> Hi Guilherme, >> >> Hi Martin,

[PATCH v3] mpt3sas: Force request partial completion alignment

From: Ram Pai The firmware or device, possibly under a heavy I/O load, can return on a partial unaligned boundary. Scsi-ml expects these requests to be completed on an alignment boundary. Scsi-ml blindly requeues the I/O without checking the alignment boundary of the I/O

Re: split scsi passthrough fields out of struct request V2

On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > Hi all, > > this series splits the support for SCSI passthrough commands from the > main struct request used all over the block layer into a separate > scsi_request structure that drivers that want to support SCSI passthough > need to

Re: [PATCH v2] mpt3sas: Force request partial completion alignment

On Thu, Jan 26, 2017 at 11:31:53AM -0200, Guilherme G. Piccoli wrote: > On 01/25/2017 09:46 PM, Martin K. Petersen wrote: > >> "Guilherme" == Guilherme G Piccoli > >> writes: > > > > Hi Guilherme, > > Hi Martin, thanks for the review! > > > > > > diff

Re: [PATCH] Revert "sd: remove __data_len hack for WRITE SAME"

On 01/25/2017 07:56 PM, Martin K. Petersen wrote: >> "Christoph" == Christoph Hellwig writes: > > Christoph> Thanks Bart, and sorry for messing this up. Acked-by: > Christoph> Christoph Hellwig > > Jens: Since this came in via your tree would you mind reverting

Re: [PATCH] scsi: srp_transport: Fix 'always false comparison' in srp_tmo_valid()

On Thu, 2017-01-26 at 11:17 +, Augusto Mecking Caringi wrote: > In a 64bit system (where long is 64bit wide), even dividing LONG_MAX by > HZ will always be bigger than the max value that an int variable can > hold. > > This has been detected by building the driver with W=1: > >

Re: [PATCH v2 0/2] scsi: storvsc: Add support for FC lightweight host.

On Thu, Jan 26, 2017 at 08:38:58AM -0500, Cathy Avery wrote: > Included in the current storvsc driver for Hyper-V is the ability > to access luns on an FC fabric via a virtualized fiber channel > adapter exposed by the Hyper-V host. This was done to provide an > interface for existing customer

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

On Wed, Jan 25, 2017 at 03:47:20PM +, Bart Van Assche wrote: > = > BUG kmalloc-16 (Not tainted): Redzone overwritten > - > > Disabling lock

[PATCH v2 1/2] scsi: scsi_transport_fc: Provide a lightweight option for Virtual FC Hosts.

This patch provides a means to offer a lightweight option to the current FC transport class. This new transport option is more suitable for FC transports running on a VM that virtualizes their FCs and that do not possess rports or vports whereas the heavyweight option maintains the standard

[PATCH v2 0/2] scsi: storvsc: Add support for FC lightweight host.

This patch set is based on the following patch submission and email exchange: [PATCH 1/1] scsi: storvsc: Support manual scan of FC hosts on Hyper-V K. Y. Srinivasan kys at microsoft.com Sat Mar 12 21:52:48 UTC 2016

[PATCH v2 2/2] scsi: storvsc: Add support for FC lightweight host.

Included in the current storvsc driver for Hyper-V is the ability to access luns on an FC fabric via a virtualized fiber channel adapter exposed by the Hyper-V host. This was done to provide an interface for existing customer tools that was more consistent with a conventional FC device. The driver

Re: [PATCH v2] mpt3sas: Force request partial completion alignment

On 01/25/2017 09:46 PM, Martin K. Petersen wrote: >> "Guilherme" == Guilherme G Piccoli writes: > > Hi Guilherme, Hi Martin, thanks for the review! > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > index

Re: mvsas escalated kernel crash and ata mapping mvsas driver question

2017-01-26 12:53 GMT+01:00 Jelle de Jong : > Beste Jack, > > I set the queue_depth to 1 and timeout to 300 for all SATA disk connected to > the mvsas controller [ARC-1300ix-16]. > > Does this mean that ata21 is mapped to /dev/sdq! > > root@sweeney:~# dmesg | grep ata21 |

Re: mvsas escalated kernel crash and ata mapping mvsas driver question

Beste Jack, I set the queue_depth to 1 and timeout to 300 for all SATA disk connected to the mvsas controller [ARC-1300ix-16]. Does this mean that ata21 is mapped to /dev/sdq! root@sweeney:~# dmesg | grep ata21 | grep device [4.788568] sas: ata21: end_device-0:0:26: dev error handler

[PATCH] scsi: srp_transport: Fix 'always false comparison' in srp_tmo_valid()

In a 64bit system (where long is 64bit wide), even dividing LONG_MAX by HZ will always be bigger than the max value that an int variable can hold. This has been detected by building the driver with W=1: drivers/scsi/scsi_transport_srp.c: In function ‘srp_tmo_valid’:

Re: mvsas escalated kernel crash and ata mapping mvsas driver question

2017-01-26 10:51 GMT+01:00 Jelle de Jong : > Hello everybody, > > I got a server that seemingly random gets kernel crashes, due to an > escalation of events from most likely the mvsas based disk controller. > > The harddisk should be okay, I replaced a whole bunch to be

mvsas escalated kernel crash and ata mapping mvsas driver question

Hello everybody, I got a server that seemingly random gets kernel crashes, due to an escalation of events from most likely the mvsas based disk controller. The harddisk should be okay, I replaced a whole bunch to be sure, but the server does not get stable. I can not seem to figure out how

Re: [PATCH V2 07/24] aacraid: Process Error for response I/O

On Wed, Jan 25, 2017 at 10:00:54AM -0800, Raghava Aditya Renukunta wrote: > Make sure that the driver processes error conditions even in the fast > response path for response from the adapter. > > Signed-off-by: Raghava Aditya Renukunta > > Signed-off-by:

Re: [PATCH V2 06/24] aacraid: Reworked scsi command submission path

On Wed, Jan 25, 2017 at 10:00:53AM -0800, Raghava Aditya Renukunta wrote: > Moved the READ and WRITE switch cases to the top. Added a default > case to the switch case and replaced duplicate scsi result value with a > macro. Can you please explain why you did the changes as well? -- Johannes

[PATCH] scsi_debug: Add OPTIMAL TRANSFER LENGTH GRANULARITY option.

Signed-off-by: Lukas Herbolt --- drivers/scsi/scsi_debug.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index cf04a36..6910ea1 100644 --- a/drivers/scsi/scsi_debug.c +++

Re: [PATCH V2 05/24] aacraid: Retrieve and update the device types

On Wed, Jan 25, 2017 at 10:00:52AM -0800, Raghava Aditya Renukunta wrote: > This patch adds support to retrieve the type of each adapter connected > device. Applicable to HBA1000 and SmartIOC2000 products > > Signed-off-by: Raghava Aditya Renukunta > >

Re: [PATCH v2 2/2] virtio_scsi: Implement fc_host

/20170126-114655 config: i386-randconfig-h0-01261251 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> ERROR: "fc_release_transpo

Re: [PATCH V2 04/24] aacraid: Added sa firmware support

On Wed, Jan 25, 2017 at 10:00:51AM -0800, Raghava Aditya Renukunta wrote: > sa_firmware adds the capability to differentiate the new SmartIOC family > of adapters from the series 8 and below. > > Signed-off-by: Raghava Aditya Renukunta > > Signed-off-by:

Re: [PATCH V2 03/24] aacraid: added support for init_struct_8

On Wed, Jan 25, 2017 at 10:00:50AM -0800, Raghava Aditya Renukunta wrote: > This patch lays the groundwork for supporting the new HBA-1000 controller > family.A new INIT structure INIT_STRUCT_8 has been added which allows for a > variable size for MSI-x vectors among other things, and is used

Re: [PATCH v2 2/2] virtio_scsi: Implement fc_host

On Thu, Jan 26, 2017 at 11:41:09AM +0800, Fam Zheng wrote: > This implements the VIRTIO_SCSI_F_FC_HOST feature by reading the config > fields and presenting them as sysfs fc_host attributes. The config > change handler is added here because primary_active will toggle during > migration. This

Re: [PATCH V2 02/24] aacraid: Added aacraid.h include guard

On Wed, Jan 25, 2017 at 10:00:49AM -0800, Raghava Aditya Renukunta wrote: > Added aacraid.h include guard > > Signed-off-by: Raghava Aditya Renukunta > > Signed-off-by: Dave Carroll > > --- Reviewed-by: Johannes Thumshirn

Re: [PATCH V2 01/24] aacraid: Remove duplicate irq management code

On Wed, Jan 25, 2017 at 10:00:48AM -0800, Raghava Aditya Renukunta wrote: > Removed duplicate code that for acquiring and releasing irqs > > Signed-off-by: Raghava Aditya Renukunta > > Signed-off-by: Dave Carroll > > --- One

Re: [PATCH] SCSI core: Fix WRITE SAME handling

On Wed, Jan 25, 2017 at 10:44:41PM +, Bart Van Assche wrote: > On Wed, 2017-01-25 at 11:37 +0100, Christoph Hellwig wrote: > > > Fixes: f80de881d8df ("sd: remove __data_len hack for WRITE SAME") > > > > I think the better fix is to simply revert this commit. > > Hello Christoph, > > Do you

Re: [PATCH v3 1/4] mpt3sas: Added print to notify cable running at a degraded speed.

On Mon, Jan 23, 2017 at 03:26:07PM +0530, Chaitra P B wrote: > Driver processes the event MPI26_EVENT_ACTIVE_CABLE_DEGRADED > when a cable is present and is running at a degraded speed > (below the SAS3 12 Gb/s rate). Prints added > to inform the user that the cable is not running at > optimal

Re: [PATCH v3 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices.

On Mon, Jan 23, 2017 at 03:26:08PM +0530, Chaitra P B wrote: > Small glitch/degraded performance in Crusader is improved with SAS > drives by removing unnecessary spinlocks while clearing scsi command > in drivers internal lookup table. > > Signed-off-by: Chaitra P B

[Bug 176951] boot fails unless acpi=off Acer Travelmate X-349

https://bugzilla.kernel.org/show_bug.cgi?id=176951 --- Comment #19 from Dmitry Sysoletin --- (In reply to Zhang Rui from comment #11) > please check if the latest upstream kernel works for you or not. > If yes, I will close this bug as the original bug has been fixed

[Bug 176951] boot fails unless acpi=off Acer Travelmate X-349

https://bugzilla.kernel.org/show_bug.cgi?id=176951 --- Comment #18 from Dmitry Sysoletin --- Created attachment 253191 --> https://bugzilla.kernel.org/attachment.cgi?id=253191=edit Stacktrace screenshot 2 Another 4.10.0-rc5 fail -- You are receiving this mail

[Bug 176951] boot fails unless acpi=off Acer Travelmate X-349

https://bugzilla.kernel.org/show_bug.cgi?id=176951 Dmitry Sysoletin changed: What|Removed |Added CC|