Re: [PATCHv2 0/5] SCSI EH cleanup

2017-02-23 Thread Hannes Reinecke
On 02/24/2017 05:01 AM, Bart Van Assche wrote: > On Wed, 2017-02-22 at 17:07 +0100, Hannes Reinecke wrote: >> Primary goal is to make asynchronous aborts mandatory; there hasn't >> been a single report so far where asynchronous abort won't work, so >> the 'no_async_abort' flag has never been used

Re: [PATCHv2 0/5] SCSI EH cleanup

2017-02-23 Thread Bart Van Assche
On Wed, 2017-02-22 at 17:07 +0100, Hannes Reinecke wrote: > Primary goal is to make asynchronous aborts mandatory; there hasn't > been a single report so far where asynchronous abort won't work, so > the 'no_async_abort' flag has never been used and will be removed > with this patchset. Hello

Re: [PATCH] target/user: Add daynmic growing data area featuresupport

2017-02-23 Thread Xiubo Li
When N is bigger, the ratio will be smaller. If N >= 1, the ratio will be [15/1024, 4/1024), for this the ratio 15 : 1024 will be enough. But maybe some iscsi cmds has no datas, N == 0. So the ratio should be bigger. For now we will increase the data area size to 1G, and the cmd area size to

Re: [PATCH] libiscsi: add lock around task lists to fix list corruption regression

2017-02-23 Thread Chris Leech
Yikes, my git-send-email settings suppressed the important CCs. Sorry! Guilherme and Ilkka, can you comment about your testing results or review please? - Chris Leech - Original Message - > There's a rather long standing regression from commit > 659743b [SCSI] libiscsi: Reduce locking

Re: [PATCH] scsi/mac_scsi: Fix MAC_SCSI=m option when SCSI=m

2017-02-23 Thread Martin K. Petersen
> "Finn" == Finn Thain writes: Finn> The mac_scsi driver still gets disabled when SCSI=m. This should Finn> have been fixed back when I enabled the tristate but I didn't see Finn> the bug. Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux

Re: [PATCH] libiscsi: add lock around task lists to fix list corruption regression

2017-02-23 Thread Martin K. Petersen
> "Chris" == Chris Leech writes: Chris> There's a rather long standing regression from commit 659743b Chris> [SCSI] libiscsi: Reduce locking contention in fast path Chris> Depending on iSCSI target behavior, it's possible to hit the case Chris> in iscsi_complete_task

Re: [PATCH] cciss: correct check map error.

2017-02-23 Thread Martin K. Petersen
> "Don" == Don Brace writes: Don> remove device driver failed to check map error messages Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qla2xxx: fix spelling mistake: "seperator" -> "separator"

2017-02-23 Thread Martin K. Petersen
> "Colin" == Colin King writes: Colin> trivial fix to spelling mistake in pr_err message Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCHv4 01/12] mpt3sas: switch to pci_alloc_irq_vectors

2017-02-23 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> Cleanup the MSI-X handling allowing us to use the PCI-layer Hannes> provided vector allocation. Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] aacraid: Fixed expander hotplug for SMART family

2017-02-23 Thread Martin K. Petersen
> "Raghava" == Raghava Aditya Renukunta > writes: Raghava> Current driver Hotplug processing code skips over Enclosure Raghava> channel, therefore any addition/removal of expander enclosure Raghava> is not processed. Additionally device addition

Re: [PATCH] qedf: fixup compilation warning about atomic_t usage

2017-02-23 Thread Martin K. Petersen
> "Chad" == Dupuis, Chad writes: Chad> The driver didn't follow the atomic_t vs refcount_t change, and Chad> anyway one should be using kref_read() instead of accessing the Chad> counter inside an kref. Applied to 4.11/scsi-fixes. Thanks! -- Martin K. Petersen

Re: sense handling improvements, part 2

2017-02-23 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> No real changes, but I did an explicit rebase against the Christoph> 4.11/scsi-fixes branch. Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

RE: [PATCH] aacraid: Fixed expander hotplug for SMART family

2017-02-23 Thread Dave Carroll
> -Original Message- > From: Raghava Aditya Renukunta > [mailto:raghavaaditya.renuku...@microsemi.com] > Sent: Wednesday, February 22, 2017 8:23 AM > To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- > s...@vger.kernel.org > Cc: Dave Carroll; Gana Sridaran; Scott Benesh >

RE: [PATCH] qla2xxx: fix spelling mistake: "seperator" -> "separator"

2017-02-23 Thread Madhani, Himanshu
> -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Thursday, February 23, 2017 2:57 AM > To: qla2xxx-upstr...@qlogic.com; James E . J . Bottomley > ; Martin K . Petersen > ; linux-scsi@vger.kernel.org >

RE:

2017-02-23 Thread Qin's Yanjun
How are you today and your family? I require your attention and honest co-operation about some issues which i will really want to discuss with you which. Looking forward to read from you soon. Qin's __ Sky Silk, http://aknet.kz

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Joe Perches
On Thu, 2017-02-23 at 17:41 +, Emil Velikov wrote: > On 23 February 2017 at 17:18, Joe Perches wrote: > > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: > > > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > > > > There are ~4300 uses of

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Emil Velikov
On 23 February 2017 at 17:18, Joe Perches wrote: > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: >> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: >> > There are ~4300 uses of pr_warn and ~250 uses of the older >> > pr_warning in the kernel source

Re: [PATCH] target: Fix NULL dereference during LUN lookup + active I/O shutdown

2017-02-23 Thread Bryant G. Ly
From: Nicholas Bellinger When transport_clear_lun_ref() is shutting down a se_lun via configfs with new I/O in-flight, it's possible to trigger a NULL pointer dereference in transport_lookup_cmd_lun() due to the fact percpu_ref_get() doesn't do any __PERCPU_REF_DEAD

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Joe Perches
On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > > There are ~4300 uses of pr_warn and ~250 uses of the older > > pr_warning in the kernel source tree. > > > > Make the use of pr_warn consistent across all kernel

Re: [PATCH] lpfc: add missing Kconfig NVME dependencies

2017-02-23 Thread James Smart
On 2/23/2017 2:09 AM, Christoph Hellwig wrote: On Wed, Feb 22, 2017 at 08:20:47AM -0800, James Smart wrote: add missing Kconfig NVME dependencies Can't believe I missed posting this Oh. I'm not sure everyone is happy having to drag in the whole nvme and nvme target stack when building lpfc.

[PATCH 2/2] scsi: remove scsi_execute_req_flags

2017-02-23 Thread Christoph Hellwig
And switch all callers to use scsi_execute instead. Signed-off-by: Christoph Hellwig --- drivers/scsi/device_handler/scsi_dh_alua.c | 16 ++-- drivers/scsi/device_handler/scsi_dh_emc.c | 7 +++ drivers/scsi/device_handler/scsi_dh_hp_sw.c | 10 --

[PATCH 1/2] scsi: merge __scsi_execute into scsi_execute

2017-02-23 Thread Christoph Hellwig
All but one caller want the decoded sense header, so offer the existing __scsi_execute helper as the public scsi_execute API to simply the callers. Signed-off-by: Christoph Hellwig --- drivers/ata/libata-scsi.c | 12 -- drivers/scsi/cxlflash/superpipe.c | 8 +++

sense handling improvements, part 2

2017-02-23 Thread Christoph Hellwig
No real changes, but I did an explicit rebase against the 4.11/scsi-fixes branch.

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Rob Herring
On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate >

[PATCH] qedf: fixup compilation warning about atomic_t usage

2017-02-23 Thread Dupuis, Chad
From: "Dupuis, Chad" Based on an original patch by Hannes Reinecke. The driver didn't follow the atomic_t vs refcount_t change, and anyway one should be using kref_read() instead of accessing the counter inside an kref. Fixes: 61d8658b4a435e ("scsi: qedf: Add QLogic

[PATCH] cciss: correct check map error.

2017-02-23 Thread Don Brace
remove device driver failed to check map error messages Reported-by: Johnny Bieren Tested-by: Johnny Bieren Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/block/cciss.c | 32

Re: [PATCH] qedf: fixup compilation warning about atomic_t usage

2017-02-23 Thread Chad Dupuis
On Thu, 23 Feb 2017, 11:44am -, Hannes Reinecke wrote: > The driver didn't follow the atomic_t vs refcount_t change, and > anyway one should be using kref_read() instead of accessing the > counter inside an kref. > > Fixes: 61d8658b4a435e ("scsi: qedf: Add QLogic FastLinQ offload FCoE

Re: sense handling improvements

2017-02-23 Thread Christoph Hellwig
On Thu, Feb 23, 2017 at 09:28:20AM -0500, Martin K. Petersen wrote: > > "Christoph" == Christoph Hellwig writes: > > Christoph, > > >> I applied 1-4 to 4.11/scsi-fixes. Both 5 and 6 had problems so please > >> fix those up. > > Christoph> What kind of problem? I didn't see

Re: sense handling improvements

2017-02-23 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph, >> I applied 1-4 to 4.11/scsi-fixes. Both 5 and 6 had problems so please >> fix those up. Christoph> What kind of problem? I didn't see anything on the list. They didn't apply. I tried to fix them up by hand. 5 was easy

Re: [PATCH] scsi_error: count medium access timeout only once per EH run

2017-02-23 Thread Laurence Oberman
- Original Message - > From: "Hannes Reinecke" > To: "Martin K. Petersen" > Cc: "Christoph Hellwig" , "James Bottomley" > , > linux-scsi@vger.kernel.org, "Hannes Reinecke" ,

[PATCH] qedf: fixup compilation warning about atomic_t usage

2017-02-23 Thread Hannes Reinecke
The driver didn't follow the atomic_t vs refcount_t change, and anyway one should be using kref_read() instead of accessing the counter inside an kref. Fixes: 61d8658b4a435e ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.) Cc: Chad Dupuis Cc: Nilesh

[PATCHv2] hpsa: expose enclosures

2017-02-23 Thread Hannes Reinecke
Some servers have a built-in enclosure which will show up on the same bus as the internal physical devices. This patch fixes the driver to expose them. Cc: Don Brace Signed-off-by: Hannes Reinecke --- drivers/scsi/hpsa.c | 5 - 1 file changed, 4

[PATCH] qla2xxx: fix spelling mistake: "seperator" -> "separator"

2017-02-23 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in pr_err message Signed-off-by: Colin Ian King --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] scsi_error: count medium access timeout only once per EH run

2017-02-23 Thread Hannes Reinecke
The current medium access timeout counter will be increased for each command, so if there are enough failed commands we'll hit the medium access timeout for even a single failure. Fix this by making the timeout per EH run, ie the counter will only be increased once per device and EH run. Cc: Ewan

Re: [PATCH] lpfc: add missing Kconfig NVME dependencies

2017-02-23 Thread Christoph Hellwig
On Wed, Feb 22, 2017 at 08:20:47AM -0800, James Smart wrote: > > add missing Kconfig NVME dependencies > > Can't believe I missed posting this Oh. I'm not sure everyone is happy having to drag in the whole nvme and nvme target stack when building lpfc. Is there a way to make nvme optional?

Re: sense handling improvements

2017-02-23 Thread Christoph Hellwig
On Wed, Feb 22, 2017 at 07:51:44PM -0500, Martin K. Petersen wrote: > I applied 1-4 to 4.11/scsi-fixes. Both 5 and 6 had problems so please > fix those up. What kind of problem? I didn't see anything on the list.

[PATCH v2] scsi: ufs: Factor out ufshcd_read_desc_param

2017-02-23 Thread Potomski, MichalX
Since in UFS 2.1 specification some of the descriptor lengths differs from 2.0 specification and some devices, which are reporting spec version 2.0 have different descriptor lengths we can not rely on hardcoded values taken from 2.0 specification. This patch introduces reading these lengths per

Re: Advanced Format SAT devices show incorrect physical block size

2017-02-23 Thread Pali Rohár
On Monday 30 January 2017 18:43:12 Pali Rohár wrote: > On Monday 30 January 2017 17:17:03 Alan Stern wrote: > > On Sun, 29 Jan 2017, Pali Rohár wrote: > > > On Wednesday 11 January 2017 16:23:29 Alan Stern wrote: > > > > On Tue, 10 Jan 2017, James Bottomley wrote: > > > > > On Tue, 2017-01-10 at

Re: [PATCHv3 01/10] mpt3sas: switch to pci_alloc_irq_vectors

2017-02-23 Thread Sreekanth Reddy
On Thu, Feb 23, 2017 at 6:22 AM, Martin K. Petersen wrote: >> "Christoph" == Christoph Hellwig writes: > > Christoph> Martin, can we get at least this patch still in for 4.11? > Christoph> I'd really like to see as many intance of the old MSI-X >