Re: [PATCH] target/user: Add daynmic growing data area featuresupport

2017-02-24 Thread Andy Grover
On 02/23/2017 06:07 PM, Xiubo Li wrote: >> Cool. This is a good approach for an initial patch but this raises >> concerns about efficiently managing kernel memory usage -- the data area >> grows but never shrinks, and total possible usage increases per >> backstore. (What if there are 1000?) Any

[PATCH v3 07/14] qla2xxx: Export DIF stats via debugfs

2017-02-24 Thread Himanshu Madhani
From: Anil Gurumurthy Signed-off-by: Anil Gurumurthy Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 12 drivers/scsi/qla2xxx/qla_dfs.c | 15 +++ 2 files changed,

[PATCH v3 08/14] qla2xxx: Change scsi host lookup method.

2017-02-24 Thread Himanshu Madhani
From: Quinn Tran For target mode, when new scsi command arrive, driver first performs a look up of the SCSI Host. The current look up method is based on the ALPA portion of the NPort ID. For Cisco switch, the ALPA can not be used as the index. Instead, the new search

[PATCH v3 14/14] qla2xxx: Update driver version to 9.00.00.00-k

2017-02-24 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_version.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h

[PATCH v3 04/14] qla2xxx: Use IOCB interface to submit non-critical MBX.

2017-02-24 Thread Himanshu Madhani
From: Quinn Tran The Mailbox interface is currently over subscribed. We like to reserve the Mailbox interface for the chip managment and link initialization. Any non essential Mailbox command will be routed through the IOCB interface. The IOCB interface is able to absorb

[PATCH v3 03/14] qla2xxx: Allow vref count to timeout on vport delete.

2017-02-24 Thread Himanshu Madhani
From: Joe Carnuccio Cc: Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 4 +--- drivers/scsi/qla2xxx/qla_def.h | 6 +-

[PATCH v3 09/14] qla2xxx: Fix memory leak for abts processing

2017-02-24 Thread Himanshu Madhani
From: Quinn Tran Cc: Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v3 02/14] qla2xxx: Allow relogin to proceed if remote login did not finish

2017-02-24 Thread Himanshu Madhani
From: Quinn Tran If the remote port have started the login process, then the PLOGI and PRLI should be back to back. Driver will allow the remote port to complete the process. For the case where the remote port decide to back off from sending PRLI, this local port sets an

[PATCH v3 11/14] qla2xxx: Fix inadequate lock protection for ABTS.

2017-02-24 Thread Himanshu Madhani
From: Quinn Tran Normally, ABTS is sent to Target Core as Task MGMT command. In the case of error, qla2xxx needs to send response, hardware_lock is required to prevent request queue corruption. Cc: Signed-off-by: Quinn Tran

[PATCH v3 12/14] qla2xxx: Add async new target notification

2017-02-24 Thread Himanshu Madhani
From: Quinn Tran Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 6 +++--- drivers/scsi/qla2xxx/qla_target.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-)

[PATCH v3 06/14] qla2xxx: Improve T10-DIF/PI handling in driver.

2017-02-24 Thread Himanshu Madhani
From: Quinn Tran Add routines to support T10 DIF tag. Signed-off-by: Quinn Tran Signed-off-by: Anil Gurumurthy Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.h | 1

[PATCH v3 05/14] qla2xxx: Add DebugFS node to display Port Database

2017-02-24 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_def.h | 2 + drivers/scsi/qla2xxx/qla_dfs.c | 92 -- 2 files changed, 90 insertions(+), 4

[PATCH v3 13/14] qla2xxx: Fix sess_lock & hardware_lock lock order problem.

2017-02-24 Thread Himanshu Madhani
From: Quinn Tran The main lock that needs to be held for CMD or TMR submission to upper layer is the sess_lock. The sess_lock is used to serialize cmd submission and session deletion. The addition of hardware_lock being held is not necessary. This patch removes

[PATCH v3 10/14] qla2xxx: Fix request queue corruption.

2017-02-24 Thread Himanshu Madhani
From: Quinn Tran When FW notify driver or driver detects low FW resource, driver tries to send out Busy SCSI Status to tell Initiator side to back off. During the send process, the lock was not held. Cc: Signed-off-by: Quinn Tran

[PATCH v3 00/14] qla2xxx: Bug Fixes and updates for target.

2017-02-24 Thread Himanshu Madhani
Hi Nic, Please consider this series for inclusion in target-pending. This series contains following changes. o Fix for the deadlock because of inconsistent lock usage reported by you. o Added patch to submit non-critical MBX command via IOCB path. o Improved T10-DIF/PI handling with target

[PATCH v3 01/14] qla2xxx: Fix delayed response to command for loop mode/direct connect.

2017-02-24 Thread Himanshu Madhani
From: Quinn Tran Current driver wait for FW to be in the ready state before processing in-coming commands. For Arbitrated Loop or Point-to- Point (not switch), FW Ready state can take a while. FW will transition to ready state after all Nports have been logged in. In the

Re: [PATCH] libiscsi: add lock around task lists to fix list corruption regression

2017-02-24 Thread Guilherme G. Piccoli
On 02/23/2017 07:25 PM, Chris Leech wrote: > Yikes, my git-send-email settings suppressed the important CCs. Sorry! > > Guilherme and Ilkka, can you comment about your testing results or review > please? Hi Chris, thanks for looping me. Patch seems nice, I do have some points below, most

Kernel crash with 4.10 trying to remove scsi disks

2017-02-24 Thread Farhan Ali
Hello, I have noticed a kernel crash with 4.10 kernel in our s390 environment, running a test trying to remove scsi disks. Here is a snippet of the kernel crash message: [29448.452771] kernfs: can not remove 'node_name', no directory [29448.452795] [ cut here ]

[PATCH] scsi: aacraid: remove redundant zero check on ret

2017-02-24 Thread Colin King
From: Colin Ian King The check for ret being zero is redundant as a few statements earlier we break out of the while loop if ret is non-zero. Thus we can remove the zero check and also the dead-code non-zero case too. Detected by CoverityScan, CID#1411632 ("Logically

[PATCH] scsi: lpfc: fix missing spin_unlock on sql_list_lock

2017-02-24 Thread Colin King
From: Colin Ian King In the case where sglq is null, the current code just returns without unlocking the spinlock sql_list_lock. Fix this by breaking out of the while loop and the exit path will then unlock and return NULL as was the original intention. Detected by

[PATCH] scsi: lpfc: don't dereference dma_buf->iocbq before null check

2017-02-24 Thread Colin King
From: Colin Ian King dma_buf->iocbq is being dereferenced immediately before it is being null checked, so we have a potential null pointer dereference bug. Fix this by only dereferencing it only once we have passed a null check on the pointer. Detected by

[PATCH] scsi: lpfc: sanity check hrq is null before dereferencing it

2017-02-24 Thread Colin King
From: Colin Ian King The sanity check for hrq should be moved to before the deference of hrq to ensure we don't perform a null pointer deference. Detected by CoverityScan, CID#1411650 ("Dereference before null check") Signed-off-by: Colin Ian King

[PATCH] scsi: lpfc: remove redundant assignment of sgel

2017-02-24 Thread Colin King
From: Colin Ian King In the NVMET_FCOP_RSP case, sgel is assigned but never used and hence is redundant and can be removed. Detected by CoverityScan, CID#1411658 ("Unused value") Signed-off-by: Colin Ian King ---

Re: [PATCH 2/2] Add S6 support

2017-02-24 Thread Charles Chiou
From: Charles Hi all, Ping? Does this patch has any issue need to fix? Thank you.

Re: [PATCH 1/2] Support Pegasus 3 product

2017-02-24 Thread Charles Chiou
From: Charles Hi all, Ping? Does this patch has any issue need to fix? Thank you.

Re: [PATCH 1/2] Support Pegasus 3 product

2017-02-24 Thread Charles Chiou
From: Charles

[PATCH] qedi: Fix memory leak in tmf response processing.

2017-02-24 Thread Manish Rangankar
From: "Dupuis, Chad" Signed-off-by: Manish Rangankar Signed-off-by: Chad Dupuis --- drivers/scsi/qedi/qedi_fw.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedi/qedi_fw.c