On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote:
> Very straightforward conversion to the new function in the caam driver
> and shash library.
>
> Signed-off-by: Logan Gunthorpe
> Cc: Herbert Xu
> Cc: "David S. Miller"
On 26/04/17 02:59 AM, wrote:
> Good to know that somebody is working on this. Those problems troubled
> us as well.
Thanks Christian. It's a daunting problem and a there's a lot of work to
do before we will ever be where we need to be so any help, even an ack,
is greatly appreciated.
Logan
Colin,
> trivial fix to spelling mistake in DEBUG2 debug message
Applied to 4.12/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> This module specific flag can be made static as it does not need to be
> in global scope.
Applied to 4.12/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Finn,
> free_irq() expects the same device identity that was passed to
> corresponding request_irq(), otherwise the IRQ is not freed.
Applied to 4.12/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
> It could be just cmp 0xe instead of >>1 and cmp 0x7, with readable
> code.
Applied to 4.12/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
> MASK_EE_STATUS added by 66ec6d59 was unused, but it seems to have been
> defined to do this.
Applied to 4.12/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> The indentation is weird, and you're also adding memsets of the
> allocations which is a behavior change. Please take a look at the the
> attached version that fixes this up.
Applied to 4.12/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Sreekanth,
> We need to satisfy this condition on those system where 32 bit dma
> consistent mask is not supported and it only supports 64 bit dma
> consistent mask. So on these system we can't set
> pci_set_consistent_dma_mask() to DMA_BIT_MASK(32).
Which systems are you talking about?
It
- Original Message -
> From: jsmart2...@gmail.com
> To: linux-scsi@vger.kernel.org, sta...@vger.kernel.org
> Cc: jthumsh...@suse.de, linux-n...@lists.infradead.org, emi...@redhat.com,
> "James Smart" ,
> "Dick Kennedy" , "James Smart"
>
Show the SCSI CDB for pending SCSI commands in
/sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. An example
of how SCSI commands are displayed by this code:
8801703245c0 {.op=READ, .cmd_flags=META PRIO, .rq_flags=DONTPREP IO_STAT
STATS, .tag=14, .internal_tag=-1, .cmd=Read(10) 28 00 2a
On 26/04/17 01:44 AM, Christoph Hellwig wrote:
> I think we'll at least need a draft of those to make sense of these
> patches. Otherwise they just look very clumsy.
Ok, I'll work up a draft proposal and send it in a couple days. But
without a lot of cleanup such as this series it's not going
From: James Smart
To select the appropriate shost template, the driver is issuing
a mailbox command to retrieve the wwn. Turns out the sending of
the command precedes the reset of the function. On SLI-4 adapters,
this is inconsequential as the mailbox command location is
> Feel free to submit documentation patches.
Do involved software developers agree on the functionality for
stack dumps because of out of memory situations?
Regards,
Markus
On Wed, 2017-04-26 at 20:50 +0200, SF Markus Elfring wrote:
> > Basically most everything that has a gfp_t argument does a
> > dump_stack() on OOM unless __GFP_NOWARN is specified by that gfp_t.
>
> How do you think about to improve any programming interface documentation
> around such a function
> -Original Message-
> From: Martin Wilck [mailto:mwi...@suse.com]
> Sent: Tuesday, April 11, 2017 7:36 AM
> To: Don Brace ; joseph.szczy...@hpe.com;
> Gerry Morong ; John Hall
> ; j...@linux.vnet.ibm.com; Kevin
On Tue, 2017-04-18 at 08:56 -0700, James Bottomley wrote:
> The priority has got to be the removal we've been ordered to do rather
> than waiting around to see if the transport comes back so we can send a
> final flush.
>
> How about this approach. It goes straight to DEL if the device is
>
On Tue, 2017-04-25 at 13:53 -0700, Bart Van Assche wrote:
> __scsi_remove_device() hangs if it is waiting for the SYNCHRONIZE CACHE
> command submitted by the sd driver to finish if the block layer queue is
> stopped and does not get restarted. This patch series avoids that that
> hang occurs.
> [
> Basically most everything that has a gfp_t argument does a
> dump_stack() on OOM unless __GFP_NOWARN is specified by that gfp_t.
How do you think about to improve any programming interface documentation
around such a function property?
Are there any special checks needed for function
On Wed, 2017-04-26 at 10:57 -0700, Subhash Jadavani wrote:
> PS: ufshcd_memory_alloc() also does some DMA coherent memory allocation
> (via dmam_alloc_coherent() APIs) and tries to print out the message on
> allocation failure. Although i don't know "out of memory" messages will
> be printed
> Although i don't know "out of memory" messages will be printed out by
> dmam_alloc_coherent() APIs
> or not.
Would such information belong to the programming interface documentation?
Are there any related tags or source code annotations needed?
Regards,
Markus
On 2017-04-25 13:30, SF Markus Elfring wrote:
From: Markus Elfring
Date: Tue, 25 Apr 2017 22:00:05 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: void function return statements are not generally useful
Thus remove such a
On 2017-04-25 13:28, SF Markus Elfring wrote:
From: Markus Elfring
Date: Tue, 25 Apr 2017 21:50:43 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: Possible unnecessary 'out of memory' message
Thus remove such a statement
On 2017-04-25 13:26, SF Markus Elfring wrote:
From: Markus Elfring
Date: Tue, 25 Apr 2017 21:45:25 +0200
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the
On 2017-04-26 10:28, kusumi.tomoh...@gmail.com wrote:
From: Tomohiro Kusumi
It could be just cmp 0xe instead of >>1 and cmp 0x7, with readable
code.
Signed-off-by: Tomohiro Kusumi
---
drivers/scsi/ufs/ufshcd.c | 11 +--
From: Tomohiro Kusumi
It could be just cmp 0xe instead of >>1 and cmp 0x7, with readable code.
Signed-off-by: Tomohiro Kusumi
---
drivers/scsi/ufs/ufshcd.c | 11 +--
drivers/scsi/ufs/ufshci.h | 4
2 files changed, 5 insertions(+), 10
Hi,
Thanks for your review.
> yes, this makes it more readable, but i am not sure why we will have to type
> cast UFSHCD_STATUS_READY macro to u32 type? i think it is redundant, let me
> know if you think otherwise.
Sorry, nothing really.
I'll resend without u32 cast in short (i.e. change to
On 2017-04-20 05:01, kusumi.tomoh...@gmail.com wrote:
From: Tomohiro Kusumi
It could be just cmp 0xe instead of >>1 and cmp 0x7, with readable
code.
Signed-off-by: Tomohiro Kusumi
---
drivers/scsi/ufs/ufshcd.c | 11 +--
On 2017-04-20 05:01, kusumi.tomoh...@gmail.com wrote:
From: Tomohiro Kusumi
MASK_EE_STATUS added by 66ec6d59 was unused, but it seems to have been
defined to do this.
Signed-off-by: Tomohiro Kusumi
---
drivers/scsi/ufs/ufshcd.c | 4 ++--
1 file
From: Christoph Hellwig
Date: Wed, 26 Apr 2017 09:34:22 +0200
> The caller only looks at the scsi_request result field anyway.
>
> Signed-off-by: Christoph Hellwig
Acked-by: David S. Miller
From: Christoph Hellwig
Date: Wed, 26 Apr 2017 09:34:21 +0200
> ide_pm_execute_rq exectures a PM request synchronously, and in the failure
> case where it calls __blk_end_request_all it never checks the error field
> passed to the end_io callback, so don't bother setting it.
>
>
On 04/26/2017 12:34 AM, Christoph Hellwig wrote:
> While moving forward with the block error work I noticed three more
> places that pass non-errno values to the end_request variants, and
> never actually check those return values. This little series fixes
> those up to always pass 0.
Applied,
Hi,
I have a problem with drives in my RAID. Some of drives are getting
disconnected whenever I am trying to write significant amount of data to the
array.
My problematic RAID6 consisting of 7 drives:
* 2 x WDC WD15EADS-22P8B0
* 5 x SAMSUNG HD154UI
The drives are connected through HP SAS
On Wednesday, April 26, 2017 09:34:22 AM Christoph Hellwig wrote:
> The caller only looks at the scsi_request result field anyway.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Bartlomiej Zolnierkiewicz
Best regards,
--
Bartlomiej Zolnierkiewicz
On Wednesday, April 26, 2017 09:34:21 AM Christoph Hellwig wrote:
> ide_pm_execute_rq exectures a PM request synchronously, and in the failure
> case where it calls __blk_end_request_all it never checks the error field
> passed to the end_io callback, so don't bother setting it.
>
>
-cmss-chinamobile-com/tcmu-Dynamic-growing-data-area-support/20170426-162910
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget
https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x
Hi Corentin,
[auto build test ERROR on scsi/for-next]
[also build test ERROR on v4.11-rc8 next-20170424]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Don-Brace/smartpqi-updates/20170426
Am 25.04.2017 um 20:20 schrieb Logan Gunthorpe:
This patch introduces functions which kmap the pages inside an sgl.
These functions replace a common pattern of kmap(sg_page(sg)) that is
used in more than 50 places within the kernel.
The motivation for this work is to eventually safely support
On Tue, Apr 25, 2017 at 12:20:49PM -0600, Logan Gunthorpe wrote:
> This is a prep patch to add a new error code to libiscsi. We want to
> rework some kmap calls to be able to fail. When we do, we'd like to
> use this error code.
The kmap case in iscsi_tcp_segment_map can already fail. Please add
On Tue, Apr 25, 2017 at 12:20:48PM -0600, Logan Gunthorpe wrote:
> This patch introduces functions which kmap the pages inside an sgl.
> These functions replace a common pattern of kmap(sg_page(sg)) that is
> used in more than 50 places within the kernel.
>
> The motivation for this work is to
On Tue, Apr 25, 2017 at 12:21:02PM -0600, Logan Gunthorpe wrote:
> Straightforward conversion to the new helper, except due to the lack
> of error path, we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in
> certain cases in the future.
>
> Signed-off-by: Logan Gunthorpe
ide_pm_execute_rq exectures a PM request synchronously, and in the failure
case where it calls __blk_end_request_all it never checks the error field
passed to the end_io callback, so don't bother setting it.
Signed-off-by: Christoph Hellwig
---
drivers/ide/ide-pm.c | 2 +-
1 file
The caller only looks at the scsi_request result field anyway.
Signed-off-by: Christoph Hellwig
---
drivers/ide/ide-devsets.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ide/ide-devsets.c b/drivers/ide/ide-devsets.c
index b1223234037d..9b69c32ee560
The SAS transport queues are only used by bsg, and bsg always looks at
the scsi_request results and never add the error passed in the end_io
callback.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/scsi_transport_sas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
While moving forward with the block error work I noticed three more
places that pass non-errno values to the end_request variants, and
never actually check those return values. This little series fixes
those up to always pass 0.
On Tue, Apr 25, 2017 at 02:18:09PM -0600, Jon Derrick wrote:
> NVME specifies an EUI64/NGUID in little-endian format, while SCSI
> specifies that the Device Identification VPD use big-endian for EUI
> formats. The current code copies this bytestream directly from the
> Identification Namespace
From: Xiubo Li
For each target there will be one ring, when the target number
grows larger and larger, it could eventually runs out of the
system memories.
In this patch for each target ring, currently for the cmd area
the size will be fixed to 8MB and for the data
From: Xiubo Li
Currently for the TCMU, the ring buffer size is fixed to 64K cmd
area + 1M data area, and this will be bottlenecks for high iops.
The struct tcmu_cmd_entry {} size is fixed about 112 bytes with
iovec[N] & N <= 4, and the size of struct iovec is about
From: Xiubo Li
Changed for V6:
- Remove the tcmu_vma_close(). Since the unmap thread will do the same for it
- The unmap thread will skip the busy devices.
- Using and testing the V5 version 3 weeks and the V6 for about 1 week, all in
a higher IOPS environment:
49 matches
Mail list logo