RE: [PATCH] aacraid: Fix 2T+ drives on SmartIOC-2000

> -Original Message- > From: Dave Carroll [mailto:david.carr...@microsemi.com] > Sent: Wednesday, August 30, 2017 3:23 PM > To: Martin K . Petersen ; James Bottomley > > Cc: Dave Carroll ; linux-scsi

Re: [PATCH V3 7/8] block: allow to allocate req with REQF_PREEMPT when queue is preempt frozen

On Fri, 2017-09-08 at 11:08 +0800, Ming Lei wrote: > Looks I replied or clarified all your questions/comments on this > patchset. No, you have not addressed all my comments, you know that you have not addressed all my comments so you should not have written that you have addressed all my

Re: [PATCH V2 10/12] scsi: sd_zbc: Disable zone write locking with scsi-mq

Ming, On 9/8/17 05:43, Ming Lei wrote: > Hi Damien, > > On Fri, Sep 08, 2017 at 01:16:38AM +0900, Damien Le Moal wrote: >> In the case of a ZBC disk used with scsi-mq, zone write locking does >> not prevent write reordering in sequential zones. Unlike the legacy >> case, zone locking can only be

Re: [PATCH V2 00/12] scsi-mq support for ZBC disks

Christoph, On 9/8/17 01:20, Christoph Hellwig wrote: > I'm really worried about how this is tied into the sd driver. > > From a quick look it seems like the only thing you really need in > the scheduler that is done through struct scsi_disk is the > offset + len -> zone number lookup - I'd much

Re: [PATCH V2 10/12] scsi: sd_zbc: Disable zone write locking with scsi-mq

Hi Damien, On Fri, Sep 08, 2017 at 01:16:38AM +0900, Damien Le Moal wrote: > In the case of a ZBC disk used with scsi-mq, zone write locking does > not prevent write reordering in sequential zones. Unlike the legacy > case, zone locking can only be done after the command request is > removed from

Re: [PATCH V2 09/12] scsi: sd_zbc: Limit zone write locking to sequential zones

On Fri, Sep 08, 2017 at 11:48:09AM +0200, Christoph Hellwig wrote: > On Fri, Sep 08, 2017 at 10:39:25AM +0200, Johannes Thumshirn wrote: > > It's a shame we have all this overflow checking kcalloc() and > > kmalloc_array() functions but none of them is taking NUMA nodes into > > account. > >

[PATCH] mpt3sas: Fix a double unlock in _transport_smp_handler()

We can't "goto out;" if we're not holding "ioc->transport_cmds.mutex". It leads to a double unlock bug, and I don't think we should set "ioc->transport_cmds.status" if we don't have the lock. Fixes: 651a01364994 ("scsi: scsi_transport_sas: switch to bsg-lib for SMP passthrough") Signed-off-by:

Re: [PATCH V2 09/12] scsi: sd_zbc: Limit zone write locking to sequential zones

On Fri, Sep 08, 2017 at 10:39:25AM +0200, Johannes Thumshirn wrote: > It's a shame we have all this overflow checking kcalloc() and > kmalloc_array() functions but none of them is taking NUMA nodes into > account. Something that could be trivially fixed..

Re: [PATCH V2 09/12] scsi: sd_zbc: Limit zone write locking to sequential zones

On Fri, Sep 08, 2017 at 01:16:37AM +0900, Damien Le Moal wrote: > +/* > + * Allocate a zone bitmap (one bit per zone). > + */ > +static inline unsigned long *sd_zbc_alloc_zone_bitmap(struct scsi_disk *sdkp) > +{ > + struct request_queue *q = sdkp->disk->queue; > + > + return

Re: [PATCH V2 00/12] scsi-mq support for ZBC disks

I'm really worried about how this is tied into the sd driver. >From a quick look it seems like the only thing you really need in the scheduler that is done through struct scsi_disk is the offset + len -> zone number lookup - I'd much rather expose this from sd upwards and keep the scheduler in

Re: [PATCH V2 08/12] scsi: sd_zbc: Fix sd_zbc_read_zoned_characteristics()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH V2 07/12] scsi: sd_zbc.c: Use well defined macros

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH V2 06/12] scsi: sd_zbc: Rearrange code

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH V2 05/12] scsi: sd_zbc: Fix comments and indentation

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH V2 04/12] scsi: sd_zbc: Move zbc disk declarations to sd_zbc.h

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH V2 03/12] scsi: sd_zbc: Move ZBC declarations to scsi_proto.h

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH V2 02/12] block: Fix declaration of blk-mq scheduler functions

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH V2 01/12] block: Fix declaration of blk-mq debugfs functions

On Fri, Sep 08, 2017 at 01:16:29AM +0900, Damien Le Moal wrote: > __blk_mq_debugfs_rq_show() and blk_mq_debugfs_rq_show() are exported > symbols but ar eonly declared in the block internal file are only Otherwise this looks good to me, Reviewed-by: Johannes Thumshirn

[PATCH] scsi: lpfc: remove redundant null check on eqe

From: Colin Ian King The pointer eqe is always non-null inside the while loop, so the check to see if eqe is NULL is redudant and hence can be removed. Detected by CoverityScan CID#1248693 ("Logically Dead Code") Signed-off-by: Colin Ian King

[PATCH] scsi: shost->async_scan should be protected by mutex_lock

shost->async_scan should be protected by mutex_lock, otherwise the check of "called twice" won't work. Signed-off-by: Ouyang Zhaowei --- drivers/scsi/scsi_scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_scan.c