Re: [PATCH V9 0/7] blk-mq-sched: improve sequential I/O performance

On Fri, Oct 13, 2017 at 02:23:07PM -0600, Jens Axboe wrote: > On 10/13/2017 01:21 PM, Jens Axboe wrote: > > On 10/13/2017 01:08 PM, Jens Axboe wrote: > >> On 10/13/2017 12:05 PM, Ming Lei wrote: > >>> Hi Jens, > >>> > >>> In Red Hat internal storage test wrt. blk-mq scheduler, we found that I/O >

Re: [PATCH v2 5/5] ufs/phy: qcom: Refactor to use phy_init call

On 2017-10-11 23:19, Vivek Gautam wrote: Refactor ufs_qcom_power_up_sequence() to get rid of ugly exported phy APIs and use the phy_init() and phy_power_on() to do the phy initialization. Signed-off-by: Vivek Gautam --- Changes since v1: - The UFS phy retain

Re: [PATCH V9 4/7] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On Sat, 2017-10-14 at 02:05 +0800, Ming Lei wrote: > @@ -89,19 +89,36 @@ static bool blk_mq_sched_restart_hctx(struct > blk_mq_hw_ctx *hctx) > return false; > } > > -static void blk_mq_do_dispatch_sched(struct blk_mq_hw_ctx *hctx) > +static bool blk_mq_do_dispatch_sched(struct

Re: [PATCH V9 6/7] SCSI: allow to pass null rq to scsi_prep_state_check()

On Sat, 2017-10-14 at 02:05 +0800, Ming Lei wrote: > In the following patch, we will implement scsi_get_budget() > which need to call scsi_prep_state_check() when rq isn't > dequeued yet. My understanding is that this change is only needed because scsi_mq_get_budget() calls

[PATCH 0/2] qla2xxx: Couple bug fixes for FC-NVMe

From: Himanshu Madhani Hi Martin, This series has couple bug fixes for FC-NVMe code path. Please apply them to 4.15/scsi-queue at your earliest convenience. Thanks, Himanshu Giridhar Malavali (1): qla2xxx: Query FC4 type during RSCN processing Himanshu

[PATCH 1/2] qla2xxx: Use ql2xnvmeenable to enable Q-Pair for FC-NVMe

From: Himanshu Madhani In some env, user can choose to not enable SCSI-MQ but wants to use FC-NVMe feature of the driver. Since driver relies on Q-Pairs to allocate FC-NVMe resources, use existing module parameter to create Q-Pairs when FC-NVMe is enabled.

Re: [PATCH V9 0/7] blk-mq-sched: improve sequential I/O performance

On 10/13/2017 01:21 PM, Jens Axboe wrote: > On 10/13/2017 01:08 PM, Jens Axboe wrote: >> On 10/13/2017 12:05 PM, Ming Lei wrote: >>> Hi Jens, >>> >>> In Red Hat internal storage test wrt. blk-mq scheduler, we found that I/O >>> performance is much bad with mq-deadline, especially about sequential

Re: [PATCH V9 0/7] blk-mq-sched: improve sequential I/O performance

On 10/13/2017 01:08 PM, Jens Axboe wrote: > On 10/13/2017 12:05 PM, Ming Lei wrote: >> Hi Jens, >> >> In Red Hat internal storage test wrt. blk-mq scheduler, we found that I/O >> performance is much bad with mq-deadline, especially about sequential I/O >> on some multi-queue SCSI devcies(lpfc,

Re: [PATCH V9 0/7] blk-mq-sched: improve sequential I/O performance

On 10/13/2017 12:05 PM, Ming Lei wrote: > Hi Jens, > > In Red Hat internal storage test wrt. blk-mq scheduler, we found that I/O > performance is much bad with mq-deadline, especially about sequential I/O > on some multi-queue SCSI devcies(lpfc, qla2xxx, SRP...) > > Turns out one big issue

Re: [PATCH 1/5] qla2xxx: Add module param ql2xenablemsix

Hi Johannes, > On Oct 12, 2017, at 12:19 AM, Johannes Thumshirn wrote: > > On Wed, Oct 11, 2017 at 01:36:46PM -0700, Madhani, Himanshu wrote: > [...] >> +int ql2xenablemsix = 1; >> +module_param(ql2xenablemsix, int, 0444); >> +MODULE_PARM_DESC(ql2xenablemsix, >> +"Set

[PATCH V9 2/7] blk-mq-sched: move actual dispatching into one helper

So that it becomes easy to support to dispatch from sw queue in the following patch. No functional change. Reviewed-by: Bart Van Assche Reviewed-by: Omar Sandoval Suggested-by: Christoph Hellwig # for simplifying dispatch logic

[PATCH V9 1/7] blk-mq-sched: dispatch from scheduler only after progress is made on ->dispatch

When hw queue is busy, we shouldn't take requests from scheduler queue any more, otherwise it is difficult to do IO merge. This patch fixes the awful IO performance on some SCSI devices(lpfc, qla2xxx, ...) when mq-deadline/kyber is used by not taking requests if hw queue is busy. Reviewed-by:

[PATCH V9 4/7] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

For SCSI devices, there is often per-request-queue depth, which need to be respected before queuing one request. The current blk-mq always dequeues request first, then calls .queue_rq() to dispatch the request to lld. One obvious issue of this way is that I/O merge may not be good, because when

[PATCH V9 5/7] blk-mq-sched: improve dispatching from sw queue

SCSI devices use host-wide tagset, and the shared driver tag space is often quite big. Meantime there is also queue depth for each lun( .cmd_per_lun), which is often small, for example, on both lpfc and qla2xxx, .cmd_per_lun is just 3. So lots of requests may stay in sw queue, and we always flush

[PATCH V9 6/7] SCSI: allow to pass null rq to scsi_prep_state_check()

In the following patch, we will implement scsi_get_budget() which need to call scsi_prep_state_check() when rq isn't dequeued yet. Signed-off-by: Ming Lei --- drivers/scsi/scsi_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH V9 7/7] SCSI: implement .get_budget and .put_budget for blk-mq

We need to tell blk-mq for reserving resource before queuing one request, so implement these two callbacks. Then blk-mq can avoid to dequeue request earlier, and IO merge can be improved a lot. Signed-off-by: Ming Lei --- drivers/scsi/scsi_lib.c | 75

[PATCH V9 3/7] sbitmap: introduce __sbitmap_for_each_set()

We need to iterate ctx starting from any ctx in round robin way, so introduce this helper. Reviewed-by: Omar Sandoval Cc: Omar Sandoval Signed-off-by: Ming Lei --- include/linux/sbitmap.h | 64

[PATCH V9 0/7] blk-mq-sched: improve sequential I/O performance

Hi Jens, In Red Hat internal storage test wrt. blk-mq scheduler, we found that I/O performance is much bad with mq-deadline, especially about sequential I/O on some multi-queue SCSI devcies(lpfc, qla2xxx, SRP...) Turns out one big issue causes the performance regression: requests are still

Re: [PATCH 1/8] lib: Introduce sgl_alloc() and sgl_free()

On Fri, 2017-10-13 at 10:43 -0700, Randy Dunlap wrote: > On 10/12/17 15:45, Bart Van Assche wrote: > > + * @sg: Scatterlist with one or more elements > > @sgl: Thanks Randy. I will fix this before I repost this series. Bart.

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On Sat, 2017-10-14 at 01:29 +0800, Ming Lei wrote: > ->can_queue is size of the whole tag space shared by all LUNs, looks it isn't > reasonable to increase cmd_per_lun to .can_queue. Sorry but I disagree. Setting cmd_per_lun to a value lower than can_queue will result in suboptimal performance if

Re: [PATCH 1/8] lib: Introduce sgl_alloc() and sgl_free()

On 10/12/17 15:45, Bart Van Assche wrote: > diff --git a/lib/sgl_alloc.c b/lib/sgl_alloc.c > new file mode 100644 > index ..d96b395dd5c8 > --- /dev/null > +++ b/lib/sgl_alloc.c > @@ -0,0 +1,102 @@ > +/** > + * sgl_free_order - free a scatterlist and its pages > + * @sg: Scatterlist

Re: [PATCH V8 4/7] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On 10/13/2017 11:24 AM, Ming Lei wrote: > For SCSI devices, there is often per-request-queue depth, which need > to be respected before queuing one request. > > The current blk-mq always dequeues request first, then calls .queue_rq() > to dispatch the request to lld. One obvious issue of this way

Re: [PATCH V8 1/7] blk-mq-sched: fix scheduler bad performance

On 10/13/2017 11:24 AM, Ming Lei wrote: > When hw queue is busy, we shouldn't take requests from > scheduler queue any more, otherwise it is difficult to do > IO merge. > > This patch fixes the awful IO performance on some > SCSI devices(lpfc, qla2xxx, ...) when mq-deadline/kyber > is used by not

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On Fri, Oct 13, 2017 at 05:08:52PM +, Bart Van Assche wrote: > On Sat, 2017-10-14 at 00:45 +0800, Ming Lei wrote: > > On Fri, Oct 13, 2017 at 04:31:04PM +, Bart Van Assche wrote: > > > On Sat, 2017-10-14 at 00:07 +0800, Ming Lei wrote: > > > > Actually it is in hot path, for example, lpfc

[PATCH V8 0/7] blk-mq-sched: improve sequential I/O performance

Hi Jens, In Red Hat internal storage test wrt. blk-mq scheduler, we found that I/O performance is much bad with mq-deadline, especially about sequential I/O on some multi-queue SCSI devcies(lpfc, qla2xxx, SRP...) Turns out one big issue causes the performance regression: requests are still

[PATCH V8 2/7] blk-mq-sched: move actual dispatching into one helper

So that it becomes easy to support to dispatch from sw queue in the following patch. No functional change. Reviewed-by: Bart Van Assche Reviewed-by: Omar Sandoval Suggested-by: Christoph Hellwig # for simplifying dispatch logic

[PATCH V8 1/7] blk-mq-sched: fix scheduler bad performance

When hw queue is busy, we shouldn't take requests from scheduler queue any more, otherwise it is difficult to do IO merge. This patch fixes the awful IO performance on some SCSI devices(lpfc, qla2xxx, ...) when mq-deadline/kyber is used by not taking requests if hw queue is busy. Reviewed-by:

[PATCH V8 4/7] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

For SCSI devices, there is often per-request-queue depth, which need to be respected before queuing one request. The current blk-mq always dequeues request first, then calls .queue_rq() to dispatch the request to lld. One obvious issue of this way is that I/O merge may not be good, because when

[PATCH V8 3/7] sbitmap: introduce __sbitmap_for_each_set()

We need to iterate ctx starting from any ctx in round robin way, so introduce this helper. Reviewed-by: Omar Sandoval Cc: Omar Sandoval Signed-off-by: Ming Lei --- include/linux/sbitmap.h | 64

[PATCH V8 5/7] blk-mq-sched: improve dispatching from sw queue

SCSI devices use host-wide tagset, and the shared driver tag space is often quite big. Meantime there is also queue depth for each lun( .cmd_per_lun), which is often small, for example, on both lpfc and qla2xxx, .cmd_per_lun is just 3. So lots of requests may stay in sw queue, and we always flush

[PATCH V8 6/7] SCSI: allow to pass null rq to scsi_prep_state_check()

In the following patch, we will implement scsi_get_budget() which need to call scsi_prep_state_check() when rq isn't dequeued yet. Signed-off-by: Ming Lei --- drivers/scsi/scsi_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH V8 7/7] SCSI: implement .get_budget and .put_budget for blk-mq

We need to tell blk-mq for reserving resource before queuing one request, so implement these two callbacks. Then blk-mq can avoid to dequeue request earlier, and IO merge can be improved a lot. Signed-off-by: Ming Lei --- drivers/scsi/scsi_lib.c | 75

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On Sat, 2017-10-14 at 00:45 +0800, Ming Lei wrote: > On Fri, Oct 13, 2017 at 04:31:04PM +, Bart Van Assche wrote: > > On Sat, 2017-10-14 at 00:07 +0800, Ming Lei wrote: > > > Actually it is in hot path, for example, lpfc and qla2xx's queue depth is > > > 3, > > > > Sorry but I doubt whether

Re: [PATCH v2 4/5] qla2xxx: Changes to support N2N logins

On Fri, 2017-10-13 at 09:34 -0700, Madhani, Madhani wrote: > From: Duane Grigsby > > If we discovered a topology that is N2N then we will issue a login > to the target. If our WWPN is bigger than the target's WWPN then we > will initiate login, otherwise we will just

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On Fri, Oct 13, 2017 at 04:31:04PM +, Bart Van Assche wrote: > On Sat, 2017-10-14 at 00:07 +0800, Ming Lei wrote: > > Actually it is in hot path, for example, lpfc and qla2xx's queue depth is 3, > > Sorry but I doubt whether that is correct. More in general, I don't know any > modern >

[PATCH v2 5/5] qla2xxx: Update driver version to 10.00.00.02-k

From: Himanshu Madhani Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h

[PATCH v2 2/5] qla2xxx: Add ATIO-Q processing for INTx mode

From: Himanshu Madhani Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 1 + drivers/scsi/qla2xxx/qla_isr.c| 8 ++-- drivers/scsi/qla2xxx/qla_target.c | 12 +--- 3 files changed, 16

[PATCH v2 3/5] qla2xxx: Allow MBC_GET_PORT_DATABASE to query and save the port states

From: Duane Grigsby The MBC_GET_PORT_DATABASE command normally checks the port state informationi. This patch allows it to save that info in the fcport structure and ignore the check if the query flag is set. Signed-off-by: Duane Grigsby

[PATCH v2 4/5] qla2xxx: Changes to support N2N logins

From: Duane Grigsby If we discovered a topology that is N2N then we will issue a login to the target. If our WWPN is bigger than the target's WWPN then we will initiate login, otherwise we will just wait for the target to initiate login. Signed-off-by: Duane Grigsby

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On 10/13/2017 10:31 AM, Bart Van Assche wrote: > On Sat, 2017-10-14 at 00:07 +0800, Ming Lei wrote: >> Actually it is in hot path, for example, lpfc and qla2xx's queue depth is 3, > > Sorry but I doubt whether that is correct. More in general, I don't know any > modern > storage HBA for which

[PATCH v2 0/5] qla2xxx: Patches for scsi-misc

From: Himanshu Madhani Hi Martin, This series adds support for INTx mode for qla2xxx driver. Also, adds support for N2N login for FC-NVMe. Please apply to 4.15/scsi-queue at your earliest convenience. Changes from v1 -> v2 o Fixed warnings reported by 0-day

[PATCH v2 1/5] qla2xxx: Add module param ql2xenablemsix

From: Himanshu Madhani Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gbl.h | 1 + drivers/scsi/qla2xxx/qla_isr.c | 9 ++--- drivers/scsi/qla2xxx/qla_os.c | 9 + 3 files changed, 16 insertions(+), 3

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On Sat, 2017-10-14 at 00:07 +0800, Ming Lei wrote: > Actually it is in hot path, for example, lpfc and qla2xx's queue depth is 3, Sorry but I doubt whether that is correct. More in general, I don't know any modern storage HBA for which the default queue depth is so low. Bart.

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On 10/13/2017 10:22 AM, Ming Lei wrote: > On Fri, Oct 13, 2017 at 10:20:01AM -0600, Jens Axboe wrote: >> On 10/13/2017 10:17 AM, Ming Lei wrote: >>> On Fri, Oct 13, 2017 at 08:44:23AM -0600, Jens Axboe wrote: On 10/12/2017 06:19 PM, Ming Lei wrote: > On Thu, Oct 12, 2017 at 12:46:24PM

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On 10/13/2017 10:21 AM, Ming Lei wrote: > On Fri, Oct 13, 2017 at 10:19:04AM -0600, Jens Axboe wrote: >> On 10/13/2017 10:07 AM, Ming Lei wrote: >>> On Fri, Oct 13, 2017 at 08:44:23AM -0600, Jens Axboe wrote: On 10/12/2017 06:19 PM, Ming Lei wrote: > On Thu, Oct 12, 2017 at 12:46:24PM

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On Fri, Oct 13, 2017 at 10:20:01AM -0600, Jens Axboe wrote: > On 10/13/2017 10:17 AM, Ming Lei wrote: > > On Fri, Oct 13, 2017 at 08:44:23AM -0600, Jens Axboe wrote: > >> On 10/12/2017 06:19 PM, Ming Lei wrote: > >>> On Thu, Oct 12, 2017 at 12:46:24PM -0600, Jens Axboe wrote: > On 10/12/2017

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On Fri, Oct 13, 2017 at 10:19:04AM -0600, Jens Axboe wrote: > On 10/13/2017 10:07 AM, Ming Lei wrote: > > On Fri, Oct 13, 2017 at 08:44:23AM -0600, Jens Axboe wrote: > >> On 10/12/2017 06:19 PM, Ming Lei wrote: > >>> On Thu, Oct 12, 2017 at 12:46:24PM -0600, Jens Axboe wrote: > On 10/12/2017

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On 10/13/2017 10:17 AM, Ming Lei wrote: > On Fri, Oct 13, 2017 at 08:44:23AM -0600, Jens Axboe wrote: >> On 10/12/2017 06:19 PM, Ming Lei wrote: >>> On Thu, Oct 12, 2017 at 12:46:24PM -0600, Jens Axboe wrote: On 10/12/2017 12:37 PM, Ming Lei wrote: > For SCSI devices, there is often

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On 10/13/2017 10:07 AM, Ming Lei wrote: > On Fri, Oct 13, 2017 at 08:44:23AM -0600, Jens Axboe wrote: >> On 10/12/2017 06:19 PM, Ming Lei wrote: >>> On Thu, Oct 12, 2017 at 12:46:24PM -0600, Jens Axboe wrote: On 10/12/2017 12:37 PM, Ming Lei wrote: > For SCSI devices, there is often

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On Fri, Oct 13, 2017 at 08:44:23AM -0600, Jens Axboe wrote: > On 10/12/2017 06:19 PM, Ming Lei wrote: > > On Thu, Oct 12, 2017 at 12:46:24PM -0600, Jens Axboe wrote: > >> On 10/12/2017 12:37 PM, Ming Lei wrote: > >>> For SCSI devices, there is often per-request-queue depth, which need > >>> to be

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On Fri, Oct 13, 2017 at 08:44:23AM -0600, Jens Axboe wrote: > On 10/12/2017 06:19 PM, Ming Lei wrote: > > On Thu, Oct 12, 2017 at 12:46:24PM -0600, Jens Axboe wrote: > >> On 10/12/2017 12:37 PM, Ming Lei wrote: > >>> For SCSI devices, there is often per-request-queue depth, which need > >>> to be

Hello

Hello, Can i trust an investment project in your country? accepted please send email for more details. Best Regards Daria Yoong Shang

[PATCH] scsi: scsi_transport_fc: make the function argument as const

This is a followup patch for: https://lkml.org/lkml/2017/10/13/476 Make the function argument of fc_attach_transport as const as it is only stored in the const field 'f' (made const in the patch in the link) of a fc_internal structure. Signed-off-by: Bhumika Goyal --- This

Re: [PATCH V7 4/6] blk-mq: introduce .get_budget and .put_budget in blk_mq_ops

On 10/12/2017 06:19 PM, Ming Lei wrote: > On Thu, Oct 12, 2017 at 12:46:24PM -0600, Jens Axboe wrote: >> On 10/12/2017 12:37 PM, Ming Lei wrote: >>> For SCSI devices, there is often per-request-queue depth, which need >>> to be respected before queuing one request. >>> >>> The current blk-mq

[PATCH] scsi: scsi_transport_fc: make a field of fc_internal structure const

The 'f' field of the fc_internal structure do not modify the fields of the fc_function_template structure it points to. And there are no other pointers initialized with this field 'f'. So, the field 'f' is never modified and therefore make it const. Signed-off-by: Bhumika Goyal

Re: [PATCH 1/1] qla2xxx: Fix sparse warnings for N2N

> On Oct 13, 2017, at 5:25 AM, Ewan D. Milne wrote: > > On Thu, 2017-10-12 at 23:08 -0700, Madhani, Madhani wrote: >> From: Himanshu Madhani >> >> Fixes following warning reported by 0-day kernel test build >> >>

Re: [PATCH 1/8] lib: Introduce sgl_alloc() and sgl_free()

On 10/12/2017 05:00 PM, Bart Van Assche wrote: > On Thu, 2017-10-12 at 16:52 -0600, Jens Axboe wrote: >> On 10/12/2017 04:45 PM, Bart Van Assche wrote: >>> +++ b/include/linux/sgl_alloc.h >>> @@ -0,0 +1,16 @@ >>> +#ifndef _SGL_ALLOC_H_ >>> +#define _SGL_ALLOC_H_ >>> + >>> +#include /* bool, gfp_t

[PATCH] zfcp: fix erp_action use-before-initialize in REC action trace

v4.10 commit 6f2ce1c6af37 ("scsi: zfcp: fix rport unblock race with LUN recovery") extended accessing parent pointer fields of struct zfcp_erp_action for tracing. If an erp_action has never been enqueued before, these parent pointer fields are uninitialized and NULL. Examples are zfcp objects

Re: [PATCH 1/1] qla2xxx: Fix sparse warnings for N2N

On Thu, 2017-10-12 at 23:08 -0700, Madhani, Madhani wrote: > From: Himanshu Madhani > > Fixes following warning reported by 0-day kernel test build > > drivers/scsi/qla2xxx/qla_iocb.c: In function 'qla2x00_els_dcmd2_iocb_timeout': >

Re: [PATCHv6 4/5] scsi_devinfo: Whitespace fixes

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCHv6 5/5] scsi_devinfo: fixup string compare

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCHv6 1/5] scsi_debug: allow to specify inquiry vendor and model

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCHv6 3/5] scsi_devinfo: Reformat blacklist flags

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCHv6 2/5] scsi: Export blacklist flags to sysfs

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCHv6 0/5] scsi: Fixup blacklist handling

On 10/02/2017 04:26 PM, Hannes Reinecke wrote: > Hi all, > > the SCSI blacklist handling seems to be rather tricky issue; > everytime a fix is included it tends to break other devices. > This patchset attempt to simplify the devlist handling yet again, > but this time implementing the framework

Re: [PATCH 8/8] scsi/pmcraid: Use sgl_alloc_order() and sgl_free_order()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH 7/8] scsi/pmcraid: Remove an unused structure member

Fair enough, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH 6/8] scsi/ipr: Use sgl_alloc_order() and sgl_free_order()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH 1/8] lib: Introduce sgl_alloc() and sgl_free()

On Thu, Oct 12, 2017 at 11:00:10PM +, Bart Van Assche wrote: > On Thu, 2017-10-12 at 16:52 -0600, Jens Axboe wrote: > > On 10/12/2017 04:45 PM, Bart Van Assche wrote: > > > +++ b/include/linux/sgl_alloc.h > > > @@ -0,0 +1,16 @@ > > > +#ifndef _SGL_ALLOC_H_ > > > +#define _SGL_ALLOC_H_ > > > +

Re: [PATCH 4/8] nvmet/rdma: Use sgl_alloc() and sgl_free()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH 3/8] nvmet/fc: Use sgl_alloc() and sgl_free()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

[PATCH v4 0/5] scsi: ufs: add ufs driver code for Hisilicon Hi3660 SoC

This patchset adds driver support for UFS for Hi3660 SoC. It is verified on HiKey960 board. Li Wei (5): scsi: ufs: add Hisilicon ufs driver code dt-bindings: scsi: ufs: add document for hisi-ufs arm64: dts: add ufs dts node arm64: defconfig: enable configs for Hisilicon ufs arm64:

[PATCH v4 4/5] arm64: defconfig: enable configs for Hisilicon ufs

This enable configs for Hisilicon Hi UFS driver. Signed-off-by: Li Wei Signed-off-by: Zhangfei Gao Signed-off-by: Guodong Xu --- arch/arm64/configs/defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v4 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

add ufs node document for Hisilicon. Signed-off-by: Li Wei --- Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 47 ++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/ufs/ufs-hisi.txt diff --git

[PATCH v4 5/5] arm64: defconfig: enable f2fs and squashfs

Partitions in HiKey960 are formatted as f2fs and squashfs. f2fs is for userdata; squashfs is for system. Both partitions are required by Android. Signed-off-by: Li Wei Signed-off-by: Zhangfei Gao Signed-off-by: Guodong Xu ---

[PATCH v4 3/5] arm64: dts: add ufs dts node

arm64: dts: add ufs node for Hisilicon. Signed-off-by: Li Wei --- arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 5 + arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 19 +++ 2 files changed, 24 insertions(+) diff --git

[PATCH v4 1/5] scsi: ufs: add Hisilicon ufs driver code

add Hisilicon ufs driver code. Signed-off-by: Li Wei Signed-off-by: Geng Jianfeng Signed-off-by: Zang Leigang Signed-off-by: Yu Jianfeng --- drivers/scsi/ufs/Kconfig| 9 +

[RESEND PATCH] scsi: shost->async_scan should be protected by mutex_lock

shost->async_scan should be protected by mutex_lock, otherwise the check of "called twice" won't work. Signed-off-by: Ouyang Zhaowei --- drivers/scsi/scsi_scan.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_scan.c

[PATCH 1/1] qla2xxx: Fix sparse warnings for N2N

From: Himanshu Madhani Fixes following warning reported by 0-day kernel test build drivers/scsi/qla2xxx/qla_iocb.c: In function 'qla2x00_els_dcmd2_iocb_timeout': drivers/scsi/qla2xxx/qla_iocb.c:2611:50: warning: format '%x' expects a matching 'unsigned int' argument