[PATCH] scsi: aic7xxx: remove really aiclib.c

2018-01-27 Thread Corentin Labbe
aiclib.c is unused (and contain no code) since commit 1ff927306e08 ("[SCSI] aic7xxx: remove aiclib.c") 13 years later, finish the cleaning by remove it from tree. Signed-off-by: Corentin Labbe --- drivers/scsi/aic7xxx/aiclib.c | 34 -- 1

Re: [PATCH V3] blk-mq: introduce BLK_STS_DEV_RESOURCE

2018-01-27 Thread Mike Snitzer
On Sat, Jan 27 2018 at 10:00pm -0500, Bart Van Assche wrote: > On Sat, 2018-01-27 at 21:03 -0500, Mike Snitzer wrote: > > You cannot even be forthcoming about the technical merit of a change you > > authored (commit 6077c2d70) that I'm left to clean up in the face of > >

Re: [PATCH V3] blk-mq: introduce BLK_STS_DEV_RESOURCE

2018-01-27 Thread Bart Van Assche
On Sat, 2018-01-27 at 21:03 -0500, Mike Snitzer wrote: > You cannot even be forthcoming about the technical merit of a change you > authored (commit 6077c2d70) that I'm left to clean up in the face of > performance bottlenecks it unwittingly introduced? If you were being > honest: you'd grant

Re: [PATCH V3] blk-mq: introduce BLK_STS_DEV_RESOURCE

2018-01-27 Thread Mike Snitzer
On Sat, Jan 27 2018 at 7:54pm -0500, Bart Van Assche wrote: > On Sat, 2018-01-27 at 19:23 -0500, Mike Snitzer wrote: > > Your contributions do _not_ make up for your inability to work well with > > others. Tiresome doesn't begin to describe these interactions. > > > >

Re: [PATCH V3] blk-mq: introduce BLK_STS_DEV_RESOURCE

2018-01-27 Thread Bart Van Assche
On Sat, 2018-01-27 at 19:23 -0500, Mike Snitzer wrote: > Your contributions do _not_ make up for your inability to work well with > others. Tiresome doesn't begin to describe these interactions. > > Life is too short to continue enduring your bullshit. > > But do let us know when you have

Re: [PATCH V3] blk-mq: introduce BLK_STS_DEV_RESOURCE

2018-01-27 Thread Mike Snitzer
On Sat, Jan 27 2018 at 5:12pm -0500, Bart Van Assche wrote: > On Sat, 2018-01-27 at 14:09 -0500, Mike Snitzer wrote: > > Ming let me know that he successfully tested this V3 patch using both > > your test (fio to both mpath and underlying path) and Bart's (02-mq with > >

Re: [PATCH V3] blk-mq: introduce BLK_STS_DEV_RESOURCE

2018-01-27 Thread Ming Lei
On Sat, Jan 27, 2018 at 10:12:43PM +, Bart Van Assche wrote: > On Sat, 2018-01-27 at 14:09 -0500, Mike Snitzer wrote: > > Ming let me know that he successfully tested this V3 patch using both > > your test (fio to both mpath and underlying path) and Bart's (02-mq with > > can_queue in guest).

Re: [PATCH resend 0/6] Fix cdrom autoclose

2018-01-27 Thread Michal Suchánek
On Fri, 26 Jan 2018 12:04:56 -0800 James Bottomley wrote: > On Fri, 2018-01-26 at 17:58 +0100, Michal Suchanek wrote: > > First time I did not get any feedback for the patches. > > This is likely because no-one who might inspect the code saw the > patches ... what

Re: [PATCH V3] blk-mq: introduce BLK_STS_DEV_RESOURCE

2018-01-27 Thread Bart Van Assche
On Sat, 2018-01-27 at 14:09 -0500, Mike Snitzer wrote: > Ming let me know that he successfully tested this V3 patch using both > your test (fio to both mpath and underlying path) and Bart's (02-mq with > can_queue in guest). > > Would be great if you'd review and verify this fix works for you

Re: [PATCH V3] blk-mq: introduce BLK_STS_DEV_RESOURCE

2018-01-27 Thread Mike Snitzer
On Tue, Jan 23 2018 at 10:31pm -0500, Ming Lei wrote: > On Tue, Jan 23, 2018 at 04:57:34PM +, Bart Van Assche wrote: > > On Wed, 2018-01-24 at 00:37 +0800, Ming Lei wrote: > > > On Tue, Jan 23, 2018 at 04:24:20PM +, Bart Van Assche wrote: > > > > My opinion about

[PATCH resend 5/6] Documentetion: cdrom: introduce CDS_DRIVE_ERROR

2018-01-27 Thread Michal Suchanek
CDS_DRIVE_NOT_READY is used for the state in which CDROM is 'becoming ready' (typically analyzing the disc) but also as the fallback when nothing else applies. Introduce CDS_DRIVE_ERROR for the fallback case. Signed-off-by: Michal Suchanek ---

[PATCH resend 1/6] delay: add poll_event_interruptible

2018-01-27 Thread Michal Suchanek
Add convenience macro for polling an event that does not have a waitqueue. Signed-off-by: Michal Suchanek --- include/linux/delay.h | 12 1 file changed, 12 insertions(+) diff --git a/include/linux/delay.h b/include/linux/delay.h index b78bab4395d8..3ae9fa395628

[PATCH resend 3/6] cdrom: wait for tray to close

2018-01-27 Thread Michal Suchanek
The scsi command to close tray only starts the motor and does not wait for the tray to close. Wait until the state chages from TRAY_OPEN so users do not race with the tray closing. This looks like inifinte wait but unless the drive is broken it either closes the tray within a few seconds or

[PATCH resend 4/6] cdrom: introduce CDS_DRIVE_ERROR

2018-01-27 Thread Michal Suchanek
CDS_DRIVE_NOT_READY is used for the state in which CDROM is 'becoming ready' (typically analyzing the disc) but also as the fallback when nothing else applies. Introduce CDS_DRIVE_ERROR for the fallback case. Signed-off-by: Michal Suchanek --- drivers/block/paride/pcd.c | 2

[PATCH resend 6/6] cdrom: wait for drive to become ready

2018-01-27 Thread Michal Suchanek
When the drive closes it can take tens of seconds until the disc is analyzed. Wait for the drive to become ready or report an error. Signed-off-by: Michal Suchanek --- drivers/cdrom/cdrom.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/cdrom/cdrom.c