Re: [PATCH] device_handler: remove VLAs

Stephen, > In preparation to enabling -Wvla, remove VLAs and replace them with > fixed-length arrays instead. > > scsi_dh_{alua,emc,rdac} use variable-length array declarations to > store command blocks, with the appropriate size as determined by > COMMAND_SIZE. This patch replaces these with

Re: [PATCH] scsi: eata: drop VLA in reorder()

Linus, > That said, I wonder if the solution to this particular driver is > "delete it". Because the hardware is truly ancient and nobody sane > would use it any more. I'm not aware of anybody actively using these anymore. They are mid-nineties vintage with an M68K processor onboard. I ran a

Re: [PATCH] scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls

Finn, > In jazz_esp and sun3x_esp, the esp_driver_ops methods pass esp->dev > in dma api calls as if it was a pointer to a struct device. But > it actually points to a struct platform_device. Fix this. Applied to 4.17/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] lpfc: Add missing unlock in WQ full logic

James, > Commit 6e8e1c14c61e ("scsi: lpfc: Add WQ Full Logic for NVME Target") > fails the static checker. Checker correctly identified a missing > unlock on a return path. Applied to 4.17/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v4 0/10] hisi_sas: support x6000 board and some misc changes

John, > This patchset primarily adds support for the Huawei x6000 board, > which includes hip07 chipset. Unfortunately, due to some board > layout differences with our development board, we need to set > a PHY-related register differently for optimal signal quality. As > such, a signal

Re: [PATCH v4] Make SCSI Status CONDITION MET equivalent to GOOD

Doug, > The SCSI PRE-FETCH (10 or 16) command is present both on hard disks > and some SSDs. It is useful when the address of the next block(s) to > be read is known but it is not following the LBA of the current READ > (so read-ahead won't help). It returns two "good" SCSI Status values. > If

Re: [PATCH 0/9] lpfc updates for 12.0.0.1

James, > This patch contains lpfc bug fixes > > The patches were cut against the Martin's 4.17/scsi-queue tree, > plus the following patch applied: > [PATCH v2] lpfc: use __raw_writeX on DPP copies > https://marc.info/?l=linux-scsi=152027455929958=2 Applied to 4.17/scsi-queue. Thank you!

Re: [PATCH] qla2xxx: Remove FC_NO_LOOP_ID for FCP and FC-NVMe Discovery

Himanshu, > Commit 7d64c39e64310 fixed regression of FCP discovery when > Nport Handle is in-use and relogin is triggered. However, > during FCP and FC-NVMe discovery this resulted into only > discovering NVMe LUNs. > > This patch fixes issue where FCP and FC-NVMe protocol is used on > same port

Re: [PATCH v3] scsi: libsas: defer ata device eh commands to libata

Jason, > When ata device doing EH, some commands still attached with tasks are not > passed to libata when abort failed or recover failed, so libata did not > handle these commands. After these commands done, sas task is freed, but > ata qc is not freed. This will cause ata qc leak and trigger a

Re: [PATCH] scsi: ipr: Use dma_pool_zalloc()

Souptick, > Use dma_pool_zalloc() instead of dma_pool_alloc + memset Applied to 4.17/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: eata: drop VLA in reorder()

Linus Torvalds wrote on 13/03/18 05:15: On Sun, Mar 11, 2018 at 8:08 PM, Tobin C. Harding wrote: I think we are going to see a recurring theme here. MAX_MAILBOXES==64 so this patch adds 1536 bytes to the stack on a 64 bit machine or 768 bytes on a 32 bit machine.

Re: [PATCH 12/13] qla2xxx: Fix Async GPN_FT for FCP and FC-NVMe scan

Hi Quinn, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20180309] [also build test WARNING on v4.16-rc5] [cannot apply to v4.16-rc4 v4.16-rc3 v4.16-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

Re: [PATCH] device_handler: remove VLAs

On Mon, 12 Mar 2018 15:41:26 +, Bart Van Assche wrote: > On Sat, 2018-03-10 at 14:14 +0100, Stephen Kitt wrote: > > The two patches I sent were supposed to be alternative solutions; see > > https://marc.info/?l=linux-scsi=152063671005295=2 for the > > introduction (I

Re: [PATCH] scsi: eata: drop VLA in reorder()

On Sun, Mar 11, 2018 at 8:08 PM, Tobin C. Harding wrote: > > I think we are going to see a recurring theme here. MAX_MAILBOXES==64 > so this patch adds 1536 bytes to the stack on a 64 bit machine or 768 > bytes on a 32 bit machine. Yeah, that's a bit excessive. It probably

mpt3sas: sleeping function called from invalid context

Hello, For the first I/O request after boot that is sent to a disk attached to an mpt3sas adapter I see the below complaint appearing in the kernel log. This occurs at least with kernels v4.16-rc4 and v4.16-rc5. What I see in the mpt3sas source code is that

[PATCH 00/13] qla2xxx: Fixes for FC-NVMe

Hi Martin, This patch series addresses issue with FC-NVMe abort handling in the driver. Code has been cleaned up and devloss timeout support has been added in qla2xxx. Please apply this series to 4.17/scsi-queue at your earliest convenience. Hi Christoph, Sagi, Please review this series. I

[PATCH 10/13] qla2xxx: Fix FC-NVMe IO abort during driver reset

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 17 - drivers/scsi/qla2xxx/qla_nvme.h | 2 +- drivers/scsi/qla2xxx/qla_os.c |

[PATCH 11/13] qla2xxx: Cleanup code to improve FC-NVMe error handling

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_isr.c | 78 +++-- drivers/scsi/qla2xxx/qla_nvme.c | 2 +- 2 files

[PATCH 07/13] qla2xxx: Return busy if rport going away

From: Darren Trapp This patch adds mechanism to retur EBUSY if rport is going away to prevent exhausting FC-NVMe layer's retry counter. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani ---

[PATCH 01/13] qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index 6b33a1f24f56..162a523b985e 100644 ---

[PATCH 03/13] qla2xxx: Add changes for devloss timeout in driver

From: Darren Trapp Add support for error recovery within devloss timeout, now that FC-NVMe transport support devloss timeout. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani ---

[PATCH 13/13] qla2xxx: Update driver version to 10.00.00.06-k

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 549bef9afddd..0c55d7057280 100644 ---

[PATCH 02/13] qla2xxx: Set IIDMA and fcport state before qla_nvme_register_remote()

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 06/13] qla2xxx: Fix n2n_ae flag to prevent dev_loss on PDB change

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 2 -- drivers/scsi/qla2xxx/qla_isr.c | 3 --- drivers/scsi/qla2xxx/qla_mbx.c | 3 +++ 3 files

[PATCH 05/13] qla2xxx: Add FC-NVMe abort processing

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 36 ++-- drivers/scsi/qla2xxx/qla_nvme.h | 1 + 2 files changed,

[PATCH 12/13] qla2xxx: Fix Async GPN_FT for FCP and FC-NVMe scan

From: Quinn Tran This patch combines FCP and FC-NVMe scan into single scan when driver detects FC-NVMe capability on same port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani ---

[PATCH 08/13] qla2xxx: Remove nvme_done_list

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 - drivers/scsi/qla2xxx/qla_gbl.h | 2 -- drivers/scsi/qla2xxx/qla_init.c | 1 -

[PATCH 09/13] qla2xxx: Fix retry for PRLI RJT with reason of BUSY

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_init.c | 13 - drivers/scsi/qla2xxx/qla_mbx.c | 7

[PATCH 04/13] qla2xxx: Restore ZIO threshold setting

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c

[PATCH v3] scsi: eata: drop VLAs in reorder()

Avoid 3 VLAs[1] by using a single dinamically allocated array and some helper variables: we don't need 3 arrays. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Salvatore Mesoraca --- drivers/scsi/eata.c | 40 ++-- 1 file

Re: [PATCH v2] scsi: eata: drop VLA in reorder()

2018-03-12 13:48 GMT+01:00 Salvatore Mesoraca : > Avoid 3 VLAs[1] by using a single dinamically allocated array > and some helper variables: we don't need 3 arrays. > > [1] https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Salvatore Mesoraca >

Re: [PATCH] device_handler: remove VLAs

On Sat, 2018-03-10 at 14:14 +0100, Stephen Kitt wrote: > The two patches I sent were supposed to be alternative solutions; see > https://marc.info/?l=linux-scsi=152063671005295=2 for the introduction (I > seem to have messed up the headers, so the mails didn’t end up threaded > properly). The two

Re: ERROR: "scsi_device_from_queue" [drivers/md/dm-multipath.ko] undefined!

On Sat, Mar 10 2018 at 2:29pm -0500, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 3266b5bd97eaa72793df0b6e5a106c69ccc166c4 > commit: 8d47e65948ddea4398892946d9e50778a316b397 dm mpath: remove

RE: [PATCH V4 1/4] scsi: hpsa: fix selection of reply queue

> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Thursday, March 08, 2018 9:32 PM > To: James Bottomley ; Jens Axboe > ; Martin K . Petersen > Cc: Christoph Hellwig ;

Re: [PATCH v4] Make SCSI Status CONDITION MET equivalent to GOOD

On Tue, 2018-03-06 at 22:19 -0500, Douglas Gilbert wrote: > The SCSI PRE-FETCH (10 or 16) command is present both on hard disks > and some SSDs. It is useful when the address of the next block(s) to > be read is known but it is not following the LBA of the current READ > (so read-ahead won't

Re: [PATCH 1/1] qed: Add firmware 8.33.11.0

On Feb 28, Rahul Verma wrote: > This patch add a new qed firmware with fixes and added > support for new features. > -Support VLAN remove action in steering flow. > -Optimized the FW flow and several bug fixes. > -Allow VXLAN steering. > -Supports T10DIF and SRQ. > -Support for port redirection

[PATCH v2] scsi: eata: drop VLA in reorder()

Avoid 3 VLAs[1] by using a single dinamically allocated array and some helper variables: we don't need 3 arrays. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Salvatore Mesoraca --- drivers/scsi/eata.c | 40 ++-- 1 file

Re: [PATCH] scsi: eata: drop VLA in reorder()

2018-03-12 4:08 GMT+01:00 Tobin C. Harding : > Adding kernel newbies to CC because I pose a few noob questions :) > Adding Linus to CC because I quoted him. > > On Sun, Mar 11, 2018 at 10:06:58PM +0100, Salvatore Mesoraca wrote: >> n_ready will always be less than or equal to

Re: [PATCH V4 1/4] scsi: hpsa: fix selection of reply queue

On Mon, Mar 12, 2018 at 08:52:02AM +0100, Christoph Hellwig wrote: > On Sat, Mar 10, 2018 at 11:01:43PM +0800, Ming Lei wrote: > > > I really dislike this being open coded in drivers. It really should > > > be helper chared with the blk-mq map building that drivers just use. > > > > > > For now

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

On Mon, 12 Mar 2018, Michael Schmitz wrote: > diff --git a/drivers/scsi/zorro_esp.c b/drivers/scsi/zorro_esp.c > new file mode 100644 > index 000..47053d1 > --- /dev/null > +++ b/drivers/scsi/zorro_esp.c > @@ -0,0 +1,1136 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* zorro_esp.c: ESP

Re: [PATCH V4 4/4] scsi: virtio_scsi: fix IO hang caused by irq vector automatic affinity

On Sat, Mar 10, 2018 at 11:15:20AM +0100, Christoph Hellwig wrote: > This looks generally fine to me: > > Reviewed-by: Christoph Hellwig > > As a follow on we should probably kill virtscsi_queuecommand_single and > thus virtscsi_host_template_single as well. > > Given storage IO is

Re: [PATCH V4 1/4] scsi: hpsa: fix selection of reply queue

On Sat, Mar 10, 2018 at 11:01:43PM +0800, Ming Lei wrote: > > I really dislike this being open coded in drivers. It really should > > be helper chared with the blk-mq map building that drivers just use. > > > > For now just have a low-level blk_pci_map_queues that > > blk_mq_pci_map_queues, hpsa

Re: [PATCH V4 1/4] scsi: hpsa: fix selection of reply queue

Linux-Regression-ID: lr#15a115 On Fri, 2018-03-09 at 11:32 +0800, Ming Lei wrote: > From 84676c1f21 (genirq/affinity: assign vectors to all possible CPUs), > one msix vector can be created without any online CPU mapped, then one > command's completion may not be notified. > > This patch setups

[PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

From: Michael Schmitz New combined SCSI driver for all ESP based Zorro SCSI boards for m68k Amiga. Code largely based on board specific parts of the old drivers (blz1230.c, blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed after the 2.6 kernel series for

Re: [PATCH] scsi: eata: drop VLA in reorder()

On Mon, 12 Mar 2018 14:08:34 +1100, "Tobin C. Harding" said: > removal patch that 768 was a lot of stack space. That comment did, > however say 'deep in some transfer call chain'. I don't know what a > 'transfer call chain' (the transfer bit) is but is there some heuristic > we can use to know

Re: [PATCH] device_handler: remove VLAs

On 03/09/2018 11:32 PM, Stephen Kitt wrote: > In preparation to enabling -Wvla, remove VLAs and replace them with > fixed-length arrays instead. > > scsi_dh_{alua,emc,rdac} use variable-length array declarations to > store command blocks, with the appropriate size as determined by > COMMAND_SIZE.