On 06/23/2018 12:22 PM, Douglas Gilbert wrote:
The scsi_io_completion function contains three BUG() and BUG_ON() calls.
Replace them with WARN variants.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
Reviewed-by: Bart Van Assche
---
drivers/scsi/scsi_lib.c | 15
Hi Sayali,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on v4.18-rc2 next-20180625]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci
On 06/23/2018 12:22 PM, Douglas Gilbert wrote:
Add likely() and unlikely() hints to conditionals on or near the fastpath.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
Reviewed-by: Bart Van Assche
---
A reviewer wanted any performance improvement (or otherwise) quantified.
On 06/23/2018 12:22 PM, Douglas Gilbert wrote:
Since the action "reprep" is called from two places, rather than repeat
the code, make a new scsi_io_completion helper with "reprep" as its
suffix.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
Reviewed-by: Bart Van Assche
---
On 06/23/2018 12:22 PM, Douglas Gilbert wrote:
Place scsi_io_completion()'s complex error processing associated with a
local enumeration into a static helper function. That enumeration's
values start with "ACTION_" so use the suffix "_action" in the helper
function's name.
Signed-off-by:
On 06/23/2018 12:22 PM, Douglas Gilbert wrote:
Break out several intertwined paths when cmd->result is non zero and
place them in the scsi_io_completion_nz_result helper function. The
logic is not changed.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
Reviewed-by: Bart Van
On 06/23/2018 12:22 PM, Douglas Gilbert wrote:
Change and add some variable names, adjust some associated comments
for clarity. Correct some misleading comments.
Signed-off-by: Douglas Gilbert
Reviewed-by: Johannes Thumshirn
Reviewed-by: Bart Van Assche
---
drivers/scsi/scsi_lib.c | 72
On 06/23/2018 12:22 PM, Douglas Gilbert wrote:
scsi_end_request() is called multiple times from scsi_io_completion()
which branches on its bool returned value. Add comment before the static
definition of scsi_end_request() about the meaning of that return.
Signed-off-by: Douglas Gilbert
Add configfs support to provision ufs device at runtime.
Usage:
echo > /config/ufshcd/ufs_provision
To check provisioning status:
cat /config/ufshcd/ufs_provision
1 -> Success (Reboot device to check updated provisioning)
Signed-off-by: Sayali Lokhande
---
This change adds a new API ufshcd_do_config_device() to
write configuration descriptor with the provisioning data.
Configfs support is added in driver to trigger ufs provisioning at
runtime. Provisioning data is parsed from vendor specific provisioning
file. This parsed data is passed as a buffer
-Original Message-
From: Kyuho Choi [mailto:chlrb...@gmail.com]
Sent: Monday, June 18, 2018 6:50 AM
To: Sayali Lokhande
Cc: subha...@codeaurora.org; c...@codeaurora.org; vivek.gau...@codeaurora.org;
rna...@codeaurora.org; vinholika...@gmail.com; j...@linux.vnet.ibm.com;
Since blk_rq_bytes(req) returns req->__data_len, assigning that value
to req->__data_len is superfluous. Hence remove that assignment.
See also commit 5db44863b6eb ("[SCSI] sd: Implement support for WRITE SAME").
Signed-off-by: Bart Van Assche
---
drivers/scsi/sd.c | 1 -
1 file changed, 1
https://bugzilla.kernel.org/show_bug.cgi?id=199703
--- Comment #14 from Don (don.br...@microsemi.com) ---
I'm wondering how you updated.
If you were booted from a cciss block driver before, the disk mapping would be
to a /dev/cciss/c0dX boot device.
Do you use by-label, by-uuid, ...?
If not
https://bugzilla.kernel.org/show_bug.cgi?id=199703
--- Comment #13 from Roberto M. (roby_program...@fastwebnet.it) ---
I mean I can't blacklist cciss, I can't blacklist a module that doens't exist
anymore
I can't blacklist HPSA, because from kernel 4.14 it's only driver for this
boards.. (in my
https://bugzilla.kernel.org/show_bug.cgi?id=199703
--- Comment #12 from Roberto M. (roby_program...@fastwebnet.it) ---
Hi Don,
Thank you for your answer
1) for your comment #9 you saw my last lspci output with a working kernel, I
mean the original one from kernel.org 4.13.16, it boot, there is
Proof Of Payment. View your payment funds.
FBI Director Christopher A. Wray Director Since August 2, 2017 - Present
__
This email has been scanned by the Symantec Email Security.cloud service.
https://bugzilla.kernel.org/show_bug.cgi?id=199703
--- Comment #11 from Don (don.br...@microsemi.com) ---
One more thing. the hpsa_allow_any module parameter was removed by this patch:
commit c8cd71f1f32a6227ecadbbbaaf3147a41292ecb5
Author: Hannes Reinecke
Date: Tue Aug 15 08:58:09 2017 +0200
https://bugzilla.kernel.org/show_bug.cgi?id=199703
--- Comment #10 from Don (don.br...@microsemi.com) ---
(In reply to Don from comment #9)
> I notice this:
>
> 13:08.0 RAID bus controller [0104]: Hewlett-Packard Company Smart Array
> E200i (SAS Controller) [103c:3238]
> Subsystem:
https://bugzilla.kernel.org/show_bug.cgi?id=199703
Don (don.br...@microsemi.com) changed:
What|Removed |Added
CC||don.br...@microsemi.com
On 19/06/2018 03:31, Martin K. Petersen wrote:
Jason,
So we have to change this embedded static ata host to a dynamically
allocated ata host and initialize the ->kref member. To use
ata_host_get() and ata_host_put() in libsas, we need to move the
declaration of these functions to the public
Proof Of Payment. View your payment funds.
FBI Director Christopher A. Wray Director Since August 2, 2017 - Present
__
This email has been scanned by the Symantec Email Security.cloud service.
On Fri, 2018-06-22 at 06:55 -0700, Raghava Aditya Renukunta wrote:
> The driver fails to set the correct queue depth for native devices, due
> to failing to set the device type prior to calling
> aac_set_safw_target_qd(). This results in slave configure setting the
> queue depth to 1.
>
> This
This patch avoids that smatch reports the following warnings:
drivers/scsi/qedi/qedi_fw_api.c:129: init_sqe() warn: inconsistent indenting
drivers/scsi/qedi/qedi_fw_api.c:137: init_sqe() warn: inconsistent indenting
Signed-off-by: Bart Van Assche
Cc: qlogic-storage-upstr...@cavium.com
---
On 06/25/18 05:32, Nilesh Javali wrote:
This patch fixes the static checker warning,
drivers/scsi/qedi/qedi_main.c:891 qedi_get_boot_tgt_info()
error: snprintf() is printing too much 256 vs 255
Which static checker produced this warning?
Signed-off-by: Nilesh Javali
---
This patch fixes the static checker warning,
drivers/scsi/qedi/qedi_main.c:891 qedi_get_boot_tgt_info()
error: snprintf() is printing too much 256 vs 255
Signed-off-by: Nilesh Javali
---
drivers/scsi/qedi/qedi_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On Sat, Jun 23, 2018 at 2:56 AM, Bart Van Assche wrote:
> On 06/22/18 09:38, Sreekanth Reddy wrote:
>>
>> In driver's .resume() callback function, driver is doing IOC reset
>> operation. And as per your suggestion we tried using
>> scsi_internal_device_block_nowait() to block the all the devices
31 matches
Mail list logo
