Re: [PATCH -next] scsi: lpfc: Remove set but not used variables 'tgtp'

YueHaibing, > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_nodelist_data': > drivers/scsi/lpfc/lpfc_debugfs.c:553:29: warning: > variable 'tgtp' set but not used [-Wunused-but-set-variable] > > It never used since 2b65e18202fd

Re: [PATCH -next] scsi: lpfc: Remove set but not used variable 'psli'

YueHaibing, > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/scsi/lpfc/lpfc_hbadisc.c: In function 'lpfc_free_tx': > drivers/scsi/lpfc/lpfc_hbadisc.c:5431:19: warning: > variable 'psli' set but not used [-Wunused-but-set-variable] > > Since commit 895427bd012c ("scsi: lpfc: NVME

Re: [PATCH -next] scsi: arcmsr: Remove set but not used variables 'id, lun'

YueHaibing, > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/scsi/arcmsr/arcmsr_hba.c: In function 'arcmsr_drain_donequeue': > drivers/scsi/arcmsr/arcmsr_hba.c:1320:10: warning: > variable 'lun' set but not used [-Wunused-but-set-variable] > >

Re: [PATCH] sg: remove bad blk_end_request_all() call

Jens, > We just need to free the request here. Additionally, this is > currently wrong for a queue that's using MQ currently, it'll > crash. Applied to 4.20/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] osd: initiator should use mq variant of request ending

Jens, > This is currently wrong since it isn't dependent on if we're using > mq or not. At least now it'll be correct when we force mq. Applied to 4.20/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH] scsi_error: Remove scsi_block_when_processing_errors: message

This message floods the log when enabling mask 0x7 for  /proc/sys/dev/scsi/logging_level  kernel: scsi_block_when_processing_errors: rtn: 1  Its not needed and makes tracing just scsi_eh* messages way too verbose so get rid of it Signed-off-by: Laurence Oberman ---  

Re: [PATCH 0/3] sd: Rely on the driver core for asynchronous probing

On Tue, 2018-10-16 at 01:19 -0400, Martin K. Petersen wrote: > Bart, > > > During the 2018 edition of LSF/MM there was a session about increasing > > SCSI disk probing concurrency. This patch series implements what has > > been proposed during that session, namely: - Make sure that the driver > >

[PATCH] scsi: ibmvscsi_tgt: Remove target_wait_for_sess_cmd()

From: "Bryant G. Ly" There is currently a bug with the driver where there is never a call to target_sess_cmd_list_set_waiting(), it only called target_wait_for_sess_cmd(), which basically means that the sess_wait_list would always be empty. Thus, list_empty(>sess_wait_list) = true, (eg: no

Re: aacraid: latest driver results in Host adapter abort request. / Outstanding commands on (0,0,0,0):

Hi David, can you give as any hint? We're running aroud 120 Adaptec Controllers and i don't want to replace them all... Greets, Stefan Am 27.09.2018 um 14:23 schrieb Stefan Priebe - Profihost AG: > > Am 27.09.2018 um 12:59 schrieb Emmanuel Florac: >> Le Wed, 19 Sep 2018 08:10:41 +0200 >>

Re: [PATCH] sg: remove bad blk_end_request_all() call

On 2018-10-16 10:38 a.m., Jens Axboe wrote: We just need to free the request here. Additionally, this is currently wrong for a queue that's using MQ currently, it'll crash. Surprise removals are difficult code paths to check. That snippet is after the request has been generated and before the

[PATCH RESEND] scsi: qla2xxx: I/Os timing out on surprise removal of

When doing a surprise removal of an adapter, some in flight I/Os can get stuck and take a while to complete (they actually timeout and are retried). We are not handling an early error exit from qla2xxx_eh_abort properly. Fixes: 45235022da99 ("scsi: qla2xxx: Fix driver unload by shutting down

Re: [PATCH] IB/srp: remove old request_fn_active check

Jens, >> How about adding Hannes' Signed-off-by? See also >> https://www.spinics.net/lists/linux-scsi/msg123488.html. > > I had no idea this existed, I'll just replace with that one instead > and your reviewed-by (and mine). > Martin, is this queued up? Nope, I was waiting for Hannes to

Re: [PATCH] IB/srp: remove old request_fn_active check

On 10/16/18 9:09 AM, Martin K. Petersen wrote: > > Jens, > >>> How about adding Hannes' Signed-off-by? See also >>> https://www.spinics.net/lists/linux-scsi/msg123488.html. >> >> I had no idea this existed, I'll just replace with that one instead >> and your reviewed-by (and mine). > >> Martin,

Re: [PATCH] IB/srp: remove old request_fn_active check

On 10/16/18 8:55 AM, Bart Van Assche wrote: > On Tue, 2018-10-16 at 08:31 -0600, Jens Axboe wrote: >> This check is only viable for non scsi-mq. Since that is going away, >> kill this legacy check. >> >> Cc: Bart Van Assche >> Cc: Parav Pandit >> Cc: linux-scsi@vger.kernel.org >> Signed-off-by:

Re: [PATCH] IB/srp: remove old request_fn_active check

On Tue, 2018-10-16 at 08:31 -0600, Jens Axboe wrote: > This check is only viable for non scsi-mq. Since that is going away, > kill this legacy check. > > Cc: Bart Van Assche > Cc: Parav Pandit > Cc: linux-scsi@vger.kernel.org > Signed-off-by: Jens Axboe > --- >

[PATCH] bsg: convert to use blk-mq

Requires a few changes to the FC transport class as well. Cc: Johannes Thumshirn Cc: Benjamin Block Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- block/bsg-lib.c | 102 +-- drivers/scsi/scsi_transport_fc.c | 61 ++ 2

[PATCH] sg: remove bad blk_end_request_all() call

We just need to free the request here. Additionally, this is currently wrong for a queue that's using MQ currently, it'll crash. Cc: Doug Gilbert Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- drivers/scsi/sg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] fnic_scsi: replace gross legacy tag hack with blk-mq hack

Would be nice to fix up the SCSI midlayer instead, but this will do for now. Cc: Christoph Hellwig Cc: Satish Kharat Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- drivers/scsi/fnic/fnic_scsi.c | 61 +++ 1 file changed, 12 insertions(+), 49

[PATCH] osd: initiator should use mq variant of request ending

This is currently wrong since it isn't dependent on if we're using mq or not. At least now it'll be correct when we force mq. Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- drivers/scsi/osd/osd_initiator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] IB/srp: remove old request_fn_active check

This check is only viable for non scsi-mq. Since that is going away, kill this legacy check. Cc: Bart Van Assche Cc: Parav Pandit Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- drivers/infiniband/ulp/srp/ib_srp.c | 7 --- 1 file changed, 7 deletions(-) diff --git

Re: [PATCH 19/28] qedf: fully convert to the generic DMA API

On Sun, 14 Oct 2018, 11:59am, Christoph Hellwig wrote: > External Email > > The driver is currently using an odd mix of legacy PCI DMA API and > generic DMA API calls, switch it over to the generic API entirely. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn > --- >

Re: [PATCH 13/28] megaraid_sas: switch to generic DMA API

On Fri, Oct 12, 2018 at 12:20 AM Christoph Hellwig wrote: > > Switch from the legacy PCI DMA API to the generic DMA API. > > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 150 ++-- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 16 +-- >

Re: [PATCH v3 4/5] target: split out helper for cxn timeout error stashing

On Tue, 16 Oct 2018 00:42:57 -0400, Martin K. Petersen wrote: > > I guess I'll resend entire series in future to avoid false kbuild > > reports. > > Yes, please. Patchwork can't handle individual patches getting updated > either. Okay, will do. > Applied to 4.20/scsi-queue. Thanks Martin.

[PATCH V15 0/2] Add UFS provisioning support in driver

This patch adds Configfs support to provision UFS device at runtime. This feature can be primarily useful in factory or assembly line as some devices may be required to be configured multiple times during initial system development phase. Configuration Descriptors can be written multiple times