+Bean
Thanks,
Avri
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org
> On Behalf Of Avri Altman
> Sent: Friday, November 30, 2018 9:32 AM
> To: James E.J. Bottomley ; Martin K. Petersen
> ; linux-scsi@vger.kernel.org
> Cc: Christoph Hellwig ; Avi Shchislowski
> ; Alex Lemberg
John,
> +static int hisi_sas_dif_dma_map(struct hisi_hba *hisi_hba,
> + int *n_elem_dif, struct sas_task *task)
> +{
> + struct device *dev = hisi_hba->dev;
> + struct sas_ssp_task *ssp_task;
> + struct scsi_cmnd *scsi_cmnd;
> + int rc;
> +
> + if
Hi John,
> We have also noticed that if we just enable DIF in hisi_sas (with MQ),
> and not DIX, then no issue.
Enabling DIF doesn't really do anything on the kernel side other than
setting PROTECT=1 in the READ/WRITE CDB and telling the driver which DIX
protection operation the HBA should use.
On Sat, 2018-12-01 at 15:59 +0100, Hannes Reinecke wrote:
> On 12/1/18 12:34 AM, David Disseldorp wrote:
> > Initialise the t10_wwn vendor, model and revision defaults when a
> > device is allocated instead of when it's enabled. This ensures that
> > custom vendor or model strings set prior to enab
The PCI_IRQ_AFFINITY flag prevents customers from
changing the smp_affinity and smp_affinity_list entries.
- add a module parameter to allow this flag to be turned
off.
- to turn off PCI_IRQ_AFFINITY:
flag hpsa_disable_irq_affinity=1
Reviewed-by: David Carroll
Reviewed-by: Scott Teel
Signe
On Mon, 3 Dec 2018, Hannes Reinecke wrote:
> As I said: I need to do PIO for the last two bytes of the data buffer.
> For everything else DMA works nicely, it's just the last two bytes which
> might be left over in the FIFO buffer under certain circumstances.
I read the driver a few times alrea
On 11/27/18 9:21 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1056537 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/scsi/BusLogic.c | 1
> On Dec 2, 2018, at 12:52 PM, Thomas Meyer wrote:
>
> External Email
>
> --
> External Email
>
> NULL check before some freeing functions is not needed.
>
> Signed-off-by: Thomas Meyer
> ---
>
> diff -u -p a/drivers/scsi/
On 12/2/18 11:13 PM, Finn Thain wrote:
On Sun, 2 Dec 2018, Hannes Reinecke wrote:
On 12/2/18 10:21 PM, Finn Thain wrote:
On Sun, 2 Dec 2018, Hannes Reinecke wrote:
Well, that lone 'kmap' is due to a quirk/errata in the datasheet;
essentially
we have to PIO a lone byte out of the FIFO to clea
From: Xiang Chen
Sht->sg_tablesize is set in the driver, and it will be assigned to
shost->sg_tablesize in SCSI mid-layer. So it is not necessary to
assign shost->sg_table one more time in the driver.
In addition to the change, change each scsi_host_template.sg_tablesize
to HISI_SAS_SGE_PAGE_CNT
From: Xiang Chen
For v3 hw, we support DIF operation for SAS, but not SATA.
In addition, DIF CRC16 is supported.
This patchset adds the SW support for the described features. The main
components are as follows:
- Allocate memory for PI
- Fill PI fields
- Fill related to DIF in DQ and protection
This patchset fixes some warnings detected by the sparse tool, like these:
drivers/scsi/hisi_sas/hisi_sas_main.c:1469:52: warning: incorrect type in
assignment (different base types)
drivers/scsi/hisi_sas/hisi_sas_main.c:1469:52:expected unsigned short
[unsigned] [assigned] [usertype] tag_of_
From: Xiang Chen
Relocate the codes related to dma_map/unmap in hisi_sas_task_prep()
to reduce complexity, with a view to add DIF/DIX support.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 146 +-
1 file changed
This patchset introduces support to the driver for DIF (or PI -protection
information).
We are dropping DIX support for now, based on issues discussed in the
following:
https://marc.info/?l=linux-scsi&m=154357719329297&w=4
We will only support PI in v3 hw at the moment, even though previous hw
On Sun, 2 Dec 2018 23:22:23 +0100, David Disseldorp wrote:
> > > + if (!(dev->transport->transport_flags & TRANSPORT_FLAG_PASSTHROUGH)) {
> > > + strlcpy(dev->t10_wwn.vendor, "LIO-ORG",
> > > + sizeof(dev->t10_wwn.vendor));
> > > + strlcpy(dev->t10_wwn.model, dev->t
15 matches
Mail list logo
