Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

On Mon, 8 Jan 2018 11:08:36 +0100 Peter Zijlstra wrote: > On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote: > > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman > > wrote: > > > In at least one place (mpls) you are patching a fast

Re: [PATCH] iSCSI-target: Use common error handling code in iscsi_decode_text_input()

On Fri, 3 Nov 2017 22:33:08 +0100 SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 3 Nov 2017 22:20:38 +0100 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function.

Re: [PATCH V8 5/5] libata: Align DMA buffer to dma_get_cache_alignment()

> This function is called only for the PIO mode commands, so I doubt this > is > necessary... That is true but there are platforms out there that issue disk level PIO commands via DMA (or can do so). Indeed the Cyrix MediaGX could do that in the 1990s but I never add support 8) So I think

Re: scsi target, likely GPL violation

On Mon, 12 Nov 2012 09:08:43 -0500 Theodore Ts'o ty...@mit.edu wrote: On Sun, Nov 11, 2012 at 10:15:02AM -0500, Bradley M. Kuhn wrote: Andy's initial email ended with the request: Please explain. Thus, Andy's email seemed designed to seek facts, which I think is a reasonable and good

Re: scsi target, likely GPL violation

1. Yes, I've got first hand proof of a GPL violation (in which case we'll then move to seeing how we can remedy this) or 2. A genuine public apology for the libel, which I'll do my best to prevail on RTS to accept. Because any further discussion of

Re: scsi target, likely GPL violation

For our commercial target core, we only use Linux kernel symbols that are not marked as GPL. In addition, we define the API between the target And this has what meaning ? The Linux kernel is a GPL work, any derivative work is a GPL work. The symbol tags are just a guidance. You do not have

Re: scsi target, likely GPL violation

On Fri, 09 Nov 2012 11:52:19 -0800 Andy Grover agro...@redhat.com wrote: On 11/09/2012 03:03 AM, Alan Cox wrote: I fail to understand the maintainer question however. If you were trying to block people adding target features that competed that would be a different thing. You think it's

[PATCH] mpt: missing break

From: Alan Cox a...@linux.intel.com This happens to do the right thing in all cases on fibre channel but not on other media types Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/message/fusion/mptscsih.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/message/fusion

Re: [RESEND PATCH] scsi: make struct scsi_varlen_cdb_hdr packed

The alignment is fine (the offset of the u16 is 8 bytes), but unfortunately with the metag port of gcc, sizeof(struct scsi_varlen_cdb_hdr) is rounded up to a 4 byte boundary (even though the largest data member alignment is only 2 bytes), which is 12 bytes instead of 10. That sounds

Re: [PATCH 3/3] block: add back command filter modification via sysfs

O + if (!q-cmd_filter) { + q-cmd_filter = kmalloc(sizeof(struct blk_cmd_filter), + GFP_KERNEL); + blk_set_cmd_filter_defaults(q-cmd_filter); Out of memory - memset - oops -- To unsubscribe from this list: send the line

Re: [PATCH 3/3] block: add back command filter modification via sysfs

+ssize_t blk_filter_store(struct request_queue *q, + const char *page, size_t count, int rw) +{ + unsigned long okbits[BLK_SCSI_CMD_PER_LONG], *target_okbits; + bool set; + const char *p = page; + char *endp; + int start = -1, cmd; + + if

[PATCH] aha152x: Allow use on 64bit systems

From: Alan Cox a...@linux.intel.com This is reported to work, known to work on PCMCIA and a code check shows no problems on the other bits of the code. Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/scsi/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] scsi_error: Fix language abuse.

On Fri, 08 Feb 2008 20:32:54 -0500 Douglas Gilbert [EMAIL PROTECTED] wrote: Alan Cox wrote: The word illegal has a precise dictionary meaning of prohibited by law. Also contrary to or forbidden by official rules, regulations, etc. The OED I have here doesn't seem to think so, however

[PATCH] megaraid: outb_p extermination

From conversations with the maintainers the _p isn't needed so kill it. That removes the last non ISA _p user from the SCSI layer to my knowledge. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-mm1/drivers/scsi

[PATCH] scsi_error: Fix language abuse.

-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-mm1/drivers/scsi/constants.c linux-2.6.24-mm1/drivers/scsi/constants.c --- linux.vanilla-2.6.24-mm1/drivers/scsi/constants.c 2008-02-06 14:14:40.0 + +++ linux-2.6.24-mm1

Re: [PATCH] scsi_error: Fix language abuse.

http://www.t10.org/ftp/t10/drafts/spc3/spc3r23.pdf By a simple text search. I don't think the pedantry is worth the confusion ... Ok so we should file a formal change request with T10 instead perhaps ? Alan - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH rc8-mm1] hotfix libata-scsi corruption

However, I'd like to see if we can track the problem through the SG_IO direct path ... how many adjacent page bytes are corrupt? Just a few or a large number (I'm wondering if it's an off by one or off by alignment type bug)? Which ATA controller is involved - in theory ATA DMA is byte

Re: INITIO scsi driver fails to work properly

Ok my attempt to get the card failed so we are going to have to do this the hard way. See where this patch crashes and what it prints (On top of the other patches) diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc8-mm1/drivers/scsi/initio.c

Megaraid: Use of outb_p

I notice the MegaRAID driver uses outb_p. Can someone at LSI confirm that the delays between each I/O are required, and if so how long they must be. I'm trying to sort out the use of in/outb_p and where it is unneccessary or used for non ISA devices. (Please cc me on the reply) Alan - To

Re: Megaraid: Use of outb_p

On Fri, 18 Jan 2008 13:32:12 -0700 Yang, Bo [EMAIL PROTECTED] wrote: Alan, The in/outb_p in MegaRAID scsi driver is used for our old io mapped megaraid controller. There are still some customers are using those old controller. Please keep them. Do they need the I/O delays. If they need

Re: sata_nv does not function in kernel 2.6.20.21

Error -16 is EBUSY, which causes the driver load to fail due to the Unable to reserve mem region message. This means that the sata_nv driver needed to use PCI BAR 6, but was unable to for some reason. Given that sata_nv uses devres like other libata drivers, IMO the likely cause is

Re: INITIO scsi driver fails to work properly

Yes it works under 2.6.16.13. See the beginning of this thread, i mention there some things about newer versions. It worked (ish.. it has problems and always has had) before the big updates, and according to my tester after the big update + two patches that escaped somewhere in the process.

Re: INITIO scsi driver fails to work properly

Our reporter has applied patches since then and now reports the exact same symptoms that Filippos does. (It just hangs after loading the driver.) Can you add me to the cc of the Red Hat bug, or give me the # - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a

Re: Maybe Sorry for that but where should i write .)

Actually, the correct mailing list is linux-ide. Alan Cox began working on the driver. Cc'ing both. Unless I get further info from Initio I don't expect anything to happen. They simply don't provide enough info to write a driver. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

On Fri, 21 Dec 2007 13:30:08 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: The sense buffer ins scsi_cmnd can nowadays be DMA'ed into directly by some low level drivers (that typically happens with USB mass storage). Should that not be fixed in USB storage by using pci_alloc_coherent

Re: INITIO scsi driver fails to work properly

initio doesn't seem to have a maintainer... Are you able to identify any earlier kernel which worked OK? Maybe it's a new device? If you can get the `lspci -vvxx' output for that device we can take a look. If I remember rightly the fixes for this went into the scsi tree a couple of

Re: INITIO scsi driver fails to work properly

On Mon, 17 Dec 2007 16:40:53 +0200 Boaz Harrosh [EMAIL PROTECTED] wrote: On Mon, Dec 17 2007 at 15:05 +0200, Alan Cox [EMAIL PROTECTED] wrote: initio doesn't seem to have a maintainer... Are you able to identify any earlier kernel which worked OK? Maybe it's a new device? If you can

Re: 2.6.24-rc3-mm2: Result: hostbyte=0x01 driverbyte=0x00\nend_request: I/O error

[ 225.378426] sd 2:0:1:0: [sdb] Result: hostbyte=0x01 driverbyte=0x00 [ 225.378659] end_request: I/O error, dev sdb, sector 141295703 [ 225.390133] sd 2:0:1:0: [sdb] Result: hostbyte=0x01 driverbyte=0x00 [ 225.391988] end_request: I/O error, dev sdb, sector 141295703 [ 225.392463]

Re: [PATCH] Unify sysfs filenames for firmware version

Management stuff always seems to be tied to a single card. It's one of the things that puts me off hardware RAID. There are 113 cards this driver works for in concert. Maybe my tail feathers are showing ;- You might want to mention the card firmware in question run on 3 or 4 entirely

Re: Process Scheduling Issue using sg/libata

SFF ATA controllers are peculiar in that... 1. it doesn't have reliable IRQ pending bit. 2. it doesn't have reliable IRQ mask bit. 3. some controllers tank the machine completely if status or data register is accessed differently than the chip likes. And 4. which is a killer for a lot

Re: What still uses the block layer?

/dev/sd-ide-b - second IDE HDD, /dev/sr-sata-0 - first SATA CD-ROM, I wouldn't try dividing those by pata v sata. You'll cause all sorts of problems in the process because of PATA-SATA and SATA-PATA bridges. - To unsubscribe from this list: send the line unsubscribe linux-scsi in

Re: OOM killer gripe (was Re: What still uses the block layer?)

I'm sure somebody will eventually write an OLS paper or something on the advisability of making swapping decisions with 4k granularity when disks really want bigger I/O transactions. Funnily enough someone thought of that many years ago. They even added and documented it, then they made it

Re: What still uses the block layer?

This is where we disagree. The existence of devices you cannot stably enumerate does not eliminate the existence of devices you trivially can. trivially You are I assume familiar in full with EDD 3.0, EDD 1.x and the Ralf Brown documentation on the BIOS drive mappings and tables for

Re: [git patches] libata update

ACPI Exception (exoparg2-0442): AE_AML_PACKAGE_LIMIT, Index (0) is beyond end of object [20070126] ACPI Error (psparse-0537): Method parse/execution failed [\_SB_.PCI0.IDE0.GTM_] (Node 810100318a20), AE_AML_PACKAGE_LIMIT ACPI Error (psparse-0537): Method parse/execution failed

Re: [PATCH 3/3] faster workaround

-static void ata_fill_sg(struct ata_queued_cmd *qc) +void ata_fill_sg(struct ata_queued_cmd *qc) { struct ata_port *ap = qc-ap; struct scatterlist *sg; @@ -4217,10 +4217,15 @@ int ata_check_atapi_dma(struct ata_queue */ void ata_qc_prep(struct ata_queued_cmd *qc) { +

Re: [PATCH 3/3] faster workaround

The problem is that the 3112 generates Data FIS's of a size other than a multiple of 512 bytes. Spec-legal, but exposed firmware bugs in many early SATA drives. Early Seagate hard drives choked when the formula (sector%15)==1 was satisfied (or something along those lines). And the 3114

Re: What's in linux-2.6-block.git for 2.6.24

Sep 18 18:50:01 treogen [ 63.44] ata1.00: status: {DRDY } Sep 18 18:50:01 treogen [ 63.44] ata1: hard resetting link Timed out waiting for data transfers to complete that didn't. Does sound like the device got told the wrong sized transfer. It then falls off the bus because Jeff

Re: [PATCH] libata: slightly improved req-sense, send-diag no-ops

REQUEST SENSE -- as we autosense, R.S. just returns zeroes SEND DIAGNOSTIC -- our default (no-op) self-test succeeds, all other requests for testing fail. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Acked-by: Alan Cox [EMAIL PROTECTED] Possibly our

[PATCH] dtc: Fix typo

Signed-off-by: Alan Cox [EMAIL PROTECTED] (and pointed out by several people) diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/scsi/dtc.c linux-2.6.23rc6-mm1/drivers/scsi/dtc.c --- linux.vanilla-2.6.23rc6-mm1/drivers/scsi/dtc.c 2007-09-18

[PATCH] eata_pio: Clean up proc handling, bracketing and use cpu_relax()

-by: Alan Cox [EMAIL PROTECTED] diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/scsi/eata_pio.c linux-2.6.23rc6-mm1/drivers/scsi/eata_pio.c --- linux.vanilla-2.6.23rc6-mm1/drivers/scsi/eata_pio.c 2007-09-18 15:14:00.0 +0100 +++ linux

Re: [PATCH] t128: Indent and add printk levels

On Thu, 26 Jul 2007 11:51:08 -0600 Matthew Wilcox [EMAIL PROTECTED] wrote: On Thu, Jul 26, 2007 at 06:50:44PM +0100, Alan Cox wrote: -[4] __initdata = {{0, IRQ_AUTO}, {0, IRQ_AUTO}, -{0 ,IRQ_AUTO}, {0, IRQ_AUTO}}; +[4] __initdata = { { Fair comment - fixed - will send

[PATCH] t128: Indent and add printk levels

Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/drivers/scsi/t128.c linux-2.6.23rc1-mm1/drivers/scsi/t128.c --- linux.vanilla-2.6.23rc1-mm1/drivers/scsi/t128.c 2007-07-26 15:01:46.0 +0100 +++ linux

[PATCH] aacraid: Resend, Fix security hole

On the SCSI layer ioctl path there is no implicit permissions check for ioctls (and indeed other drivers implement unprivileged ioctls). aacraid however allows all sorts of very admin only things to be done so should check. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive

[PATCH] dmx3191d: Coding style police

Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc4-mm2/drivers/scsi/dmx3191d.c linux-2.6.22-rc4-mm2/drivers/scsi/dmx3191d.c --- linux.vanilla-2.6.22-rc4-mm2/drivers/scsi/dmx3191d.c2007-06-07 14:24

[PATCH] dtc: Coding police and printk levels

Seems printk levels hadn't been invented last time this driver was tidied up. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc4-mm2/drivers/scsi/dtc.c linux-2.6.22-rc4-mm2/drivers/scsi/dtc.c --- linux.vanilla

[PATCH] ppa: Coding police and printk levels

Add printk levels Clean up some oddities of formatting Fix goto labels Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc4-mm2/drivers/scsi/ppa.c linux-2.6.22-rc4-mm2/drivers/scsi/ppa.c --- linux.vanilla-2.6.22-rc4

Re: [patch 4/6] ps3: Disk Storage Driver

Any particular reason why this is done as a separate block device driver rather than as SCSI? Because no new fake SCSI drivers are accepted anymore. Where did drivers/ata come from ;) How about making it a fake ata driver if James is being fussy 8) - To unsubscribe from this list: send

Re: [patch 4/6] ps3: Disk Storage Driver

That sounds like a good idea for my virtual I/O case on Niagara too actually :-) It was actually meant semi-seriously in that drivers/ata sits on top of the abstract parts of drivers/scsi which James keeps asking for someone to get split properly off and which would sort all these out.

Re: [PATCH 0/5] SCSI/initio fixes, cleanups, PCI API support

On Sun, 27 May 2007 10:52:00 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: This patchset presents the path to PCI API support in the initio driver. But the first patch really begs the question: Has this driver really been broken since Oct 2003? If so, let's just delete it. Jeff. I (and

Re: [PATCH] [scsi] Remove __GFP_DMA

That didn't used to work right on the AMD boards when I tried it last as we ended up with a buffer that was mapped by the IOMMU for some reason and that was not below 2GB. The physical address you mean? If that is still happening then it needs to get fixed. The allocation should not

Re: [PATCH] [scsi] Remove __GFP_DMA

On Wed, 23 May 2007 15:17:08 -0400 Salyzyn, Mark [EMAIL PROTECTED] wrote: The 31 bit limit for some of these cards is a problem, we currently only do __GFP_DMA for bounce buffer sg elements allocated for user supplied references in ioctls. I figure we should be using pci_alloc_consistent

Re: why does x86 make defconfig build a single, lonely module?

On Mon, 14 May 2007 19:29:12 +0200 (MEST) Jan Engelhardt [EMAIL PROTECTED] wrote: On May 13 2007 12:48, James Bottomley wrote: Why does ATA select SCSI anyway? Surely PATA doesn't require it? That's a bit offtopic and to the wrong list. libata-pata does require SCSI ... And in the

Re: HDIO_DRIVE_CMD and hdparm

- SCSI doesn't handle HDIO_DRIVE_CMD(null), and returns EINVAL = fine for hdparm - If a block device doesn't support the ioctl, blkdev_driver_ioctl() returns ENOTTY = hdparm error message Those are both correct -ENOTTY I don't know this ioctl

[PATCH]: Fix old SCSI adapter crashes with CD-ROM

to 24bits. According to Jens the right long term fix is for the CD layer to route the requests differently but in the mean time this has been tested by a victim and verified to sort the problem out. For the other 99.9% of users it's a no-op and doesn't bounce data. Signed-off-by: Alan Cox [EMAIL

Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM

On Tue, 8 May 2007 17:03:35 +0100 Alan Cox [EMAIL PROTECTED] wrote: The CD-ROM layer doesn't bounce requests for old ISA controllers (and nor should it). However they get injected into the SCSI layer via sr_ioctl which also doesn't bounce them and SCSI then passes the buffer along to a device

[PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

to 24bits. According to Jens the right long term fix is for the CD layer to route the requests differently but in the mean time this has been tested by a victim and verified to sort the problem out. For the other 99.9% of users it's a no-op and doesn't bounce data. Signed-off-by: Alan Cox [EMAIL

Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

Mike Christie tells me we're missing bouncing by accident in the scsi_execute path (but not the scsi_execute_async path). He says this is the fix he proposed: http://marc.info/?l=linux-scsim=115981479822790w=2 Can we just merge this instead? Short answer: No Long answer - it doesn't

Re: [PATCH]: Fix old SCSI adapter crashes with CD-ROM (take 2)

Long answer - it doesn't take this path. Different bug, both want fixing I suspect. Actually, it does take this path ... one of the things we've been doing in SCSI is slowly eliminating the old direct submission paths in favour of sending everything through the correct block layer

Re: BAD_SG_DMA panic in aha1542

That's as close as it gets without redoing everything from scratch. I'll give Alan's and James' patches a go within the next 13 hours. (Alan: what *else* would you name a variable associated with a bounce buffer besides Zebedee? Thanks for the occasion to smile...) The one I sent has a

Re: BAD_SG_DMA panic in aha1542

As before, no problems using the sda hard disk (which is the boot drive): everything works reliably until I touch the cdrom drive. A little quiet contemplation and gnome number 387 suggests trying the following (and providing more detailed information such as the last message printed before the

Re: [patch 1/7] libata: check for AN support

+ /* + * check to see if this ATAPI device supports + * Asynchronous Notification + */ + if ((ap-flags ATA_FLAG_AN) ata_id_has_AN(id)) + { Bracketing police ^^^ + /* issue SET feature command

Re: [patch 7/7] libata: send event when AN received

+ /* check the 'N' bit in word 0 of the FIS */ + if (f[0] (1 15)) { + int port_addr = ((f[0] 0x0f00) 8); + struct ata_device *adev = ap-device[port_addr]; You can't be sure that the port_addr returned will be in range if

Re: InitIO SCSI: Volunteers required

This doesn't change much outside the initialization and irq code, so any additional de-crappyfication will hopefully apply ontop. This will actually clash horribly with the rest of the rework, so it does need to be applied after the other changes. The driver in my tree no longer looks much like

Re: InitIO SCSI: Volunteers required

Once again a pci_get_device conversation isn't all that helpfull at all. fortunately in this case I've done a patch to convert this driver to proper pci probing in 2004, and I've attached the forward-ported version below now that we've actually found some testers that weren't locatable back

Re: [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves

+#define lower_32_bits(n) (sizeof(n) == 8 ? (u32)(n) : (n)) n0x would be simpler. Do we actually have any call for this? The only case for all of this we care about is sector_t, which is one type, with specific properties (eg always being positive). The rest is over-engineering.

InitIO SCSI: Volunteers required

I'm looking for some testers for a revamp of the initio driver. No real code changes other than to hopefully stop it exploding on load on 64bit, but a major reorganisation, commenting and de-windowsification so the code is actually readable and I can do the pci_find_device to pci_get_device

Re: [PATCH 3/4] libata: reimplement suspend/resume support using sdev-manage_start_stop

-by: Alan Cox [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: impact of 4k sector size on the IO FS stack

Now, if this disk was copied byte per byte (/bin/dd) to a 4096-based disk, and Linux would start using a sector size of 4096, then I would suddenly have The ATA drives I'm aware of report 512 byte sector size, do 512 byte I/O's but use 4K physical sectors and to get sane performance except the

Re: impact of 4k sector size on the IO FS stack

First generation of 1K sector drives will continue to use the same 512-byte ATA sector size you are familiar with. A single 512-byte write will cause the drive to perform a read-modify-write cycle. This configuration is physical 1K sector, logical 512b sector. The problem case is

Re: impact of 4k sector size on the IO FS stack

For 1K/4K logical sector sizes, who knows. EFI? grins and runs Certainly seems incompatible with the current popular DOS partition format. Its a bit messier than that. There are two interpretations of DOS partition formats found on 2K sector size magneto opticals. One is that everything is

Re: impact of 4k sector size on the IO FS stack

Are there other concerns in the IO or FS stack that we should bring up with vendors? I have been asked to summarize the impact of 4k sectors on linux for a disk vendor gathering and want to make sure that I put all of our linux specific items into that summary... We need to make sure the

Re: [PATCH] Bug 4940 Repeatable Kernel Panic on Adaptec 2015S I20 device on bootup

On Mon, Aug 08, 2005 at 03:16:18PM +0100, Christoph Hellwig wrote: Please either update the driver to use the pci_driver model or even better remove it completely and let everyone use the i2o drivers now that they have full 64bit dma and managment support. In the mean time. I ack the fix for

Re: [RFC][PATCH] libata ATAPI alignment

On Gwe, 2005-07-29 at 01:06 -0400, Jeff Garzik wrote: So, one thing that's terribly ugly about SATA ATAPI is that we need to pad DMA transfers to the next 32-bit boundary, if the length is not evenly divisible by 4. Looks good and avoids the special case leaking into the core code.

PATCH: Re-merge cleanups

This restores the Adrian Bunk and Al Viro cleanups that got trashed in the driver update. It also fixes a few formatting glitches and adds cpu_relax() calls to the polls spinning on the controller/bus. Signed-off-by: Alan Cox [EMAIL PROTECTED] Alan --- drivers/scsi/atp870u.c.old 2005-03-11 13

Re: PATCH: atp870u DMA mask

On Gwe, 2005-03-11 at 14:40, Arjan van de Ven wrote: -if (!pci_set_dma_mask(pdev, 0xFFUL)) { +if (!pci_set_dma_mask(pdev, 0xUL)) { isn't it still an F short? And... why not use the DMA_32_BIT or whatever define.. it's there for exactly this reason :) No its

Re: atp870u chaos

Is there a solution available or planned? Is the sourcecode of the driver under gpl or is it a good idea to contact acard? The Acard driver is GPL, they dont appear to provide much documentation though. It had some known problems with shared IRQ lines but they should have been sorted - To

Re: [Re: SCSI bootup problem]

Mark A.Tagliaferro wrote: If I install LILO to floppy disk instead of Master Boot Sector will the standard kernel be able to boot? The kernel has to be on a non-SCSI device (for now). Thats not true. The kernel needs to be on whatever the BIOS decides to boot Alan - To unsubscribe from

Re: AVA-1505 trouble

(scsi0:6:0) cannot abort running or disconnected command followed by an Oops (NULL pointer) and hard lockup. EIP=c01c3892 points inside internal_done as you can see from this piece of System.map: c01c386c T aha152x_queue c01c3888 T internal_done c01c38a4 T aha152x_command c01c3910 T

Re: Kernel 2.4.4 source package apa1480 Slim SCSI

the adaptec aha1480 Slim Scsi. they are normaly located in /drivers/scsi/pcmcia. 2.4-ac still includes it if you need it .. but .. it was not included in kernel 2.4.4 source, since it has been historically included under all the other kernels. The aic7xxx in Linus tree should support it

Re: Problems even with 512 block size MOs

Copying a 6.5 MByte file with cp returns nearly immediately on the commandline, but umount nearly takes forever. Maximum rate detected by xosview during umount was about 30 kByte. I have similar behaviour on another machine and with different disk. However I don't get any dmesg output

Re: Linux Cluster using shared scsi

Does this package also tell the kernel to re-establish a reservation for all devices after a bus reset, or at least inform a user level program? Finding out when there has been a bus reset has been a stumbling block for me. You cannot rely on a bus reset. Imagine hot swap disks on an FC

Re: MO drives (2048 byte block vfat fs) in lk 2.4

The EIP resolved most often to cont_prepare_write() in fs/buffer. A disassembly suggests line 1802 in buffer.c [2.4.3ac11]. That is around a memset() between __block_prepare_write() and __block_commit_write() calls within the while loop. Most other addresses were within the same while loop.

Re: [RFC][PATCH] adding PCI bus information to SCSI layer

Also ISA adapters are not the only non-PCI adapters, there are the growing band of pseudo adapters that may or may not have a PCI bus at the bottom of some other protocol stack. An ioctl might be better. We already have an ioctl for querying the lun information for a disk. We could also

Re: ext2 corruption in 2.4.2, scsi only system

After scanning the mailing list archives, I was under the impression that this Buslogic issue was an AC series problem. Is there a known problem with Buslogic controllers in 2.4.2? It seems there is. The changes in -ac and in 2.4.3pre limit the max blocks per request which seems to make it

Re: About DC-315U scsi driver

when I burn CDRs. Some files burned is different from the origin at HD. I use 2.2.17 with Tekram's driver,and nothing is wrong. Indeed; people report more problems on 2.4 kernels than on 2.2 kernels. I currently have no clue why. 2.4 causes longer continuous I/O requests to be sent to

Re: qlogicfc broken in 2.4.2 and later?

When I try to load it, I get the following messages: /lib/modules/2.4.3-pre2/kernel/drivers/scsi/qlogicfc.o: init_module: No such device Hint: insmod errors can be caused by incorrect module parameters, including invalid IO or IRQ parameters

Re: stability problem with SCSI in linux 2.4.2

I think I've found a stability problem in the SCSI subsystem of actual kernel 2.4.2. The 2.4.2 adaptec driver has plenty of problems. Either use the -ac version and/or get Justin Gibbs new driver - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message

Re: [PATCH] s/isa//g in drivers/scsi/g_NCR5380.c and some cleanup (242)

(Does anybody know who the maintainer for this code is?) There isnt one (An indication of how often this code path is used can be found in the fact that the previous define of NCR5380_write had its payload and address mixed up, probably making for wierd results should the code ever be

Re: [PATCH] s/isa//g in drivers/scsi/g_NCR5380.c and some cleanup (242)

Looking at the define of NCR_5380_write #define NCR5380_write(reg, value) isa_writeb(NCR5380_map_name + +NCR53C400_mem_base + (reg), value) followed by an use of NCR5380_write NCR5380_write(C400_CONTROL_STATUS_REG, CSR_BASE | CSR_TRANS_DIR); I doubt that it is not the intention

Re: [PATCH] s/isa//g in drivers/scsi/g_NCR5380.c and some cleanup (242)

I am sorry but have I inverted the arguments to the memcpy_*io calls? Or are you referring to something other than the arguments here? You seem to have swapped the source/dest over in memcpy_toio cases and I need to convince myself you did that correctly - To unsubscribe from this list: send

Re: Changing MAX_COMMAND_SIZE within the 2.4.x timeframe?

After reflection, my inclination is that the *correct* solution is to fix the low-level drivers to reject the SCSI-III commands themselves. This is more consistent with the devolution of authority from the mid-level to the individual low-level drivers that has been going on.

Re: [PATCH] consolidating data direction tables

That could be done, but you'd never be able to drop these tables. And ? I'd prefer a clean break to the new interface. It's better. Doug Gilbert is working on it. You drop them after 2.6, much more polite - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body