Re: [PATCH 0/2] scsi: hyper-v storvsc changes by Ubuntu

2014-05-21 Thread Andy Whitcroft
On 16 May 2014 16:39, Ian Abbott abbo...@mev.co.uk wrote: These changes to the Microsoft Hyper-V storage driver in Ubuntu Saucy's 3.13 kernel look useful for the mainline kernel, especially as they enable 'TRIM' support. Andy Whitcroft (2): scsi: hyper-v storvsc switch up to SPC-3 scsi

[PATCH 0/4] Hyper-V TRIM support

2013-09-13 Thread Andy Whitcroft
. Patches against v3.11. Comments? -apw Andy Whitcroft (4): scsi: add scsi device flag to request VPD pages be used at SPC-2 scsi: add scsi device flag to request READ CAPACITY (16) be preferred scsi: hyper-v storage -- mark as VPD capable at SPC-2 scsi: hyper-v storage -- mark as preferring READ

[PATCH 4/4] scsi: hyper-v storage -- mark as preferring READ CAPACITY (16) at SPC-2

2013-09-13 Thread Andy Whitcroft
BugLink: http://bugs.launchpad.net/bugs/1223499 Signed-off-by: Andy Whitcroft a...@canonical.com --- drivers/scsi/storvsc_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 14ba8fd..25e7dd5 100644 --- a/drivers/scsi

[PATCH 2/4] scsi: add scsi device flag to request READ CAPACITY (16) be preferred

2013-09-13 Thread Andy Whitcroft
BugLink: http://bugs.launchpad.net/bugs/1223499 Signed-off-by: Andy Whitcroft a...@canonical.com --- drivers/scsi/sd.c | 2 ++ include/scsi/scsi_device.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 5a8a04d..eba4d6c 100644

[PATCH 3/4] scsi: hyper-v storage -- mark as VPD capable at SPC-2

2013-09-13 Thread Andy Whitcroft
BugLink: http://bugs.launchpad.net/bugs/1223499 Signed-off-by: Andy Whitcroft a...@canonical.com --- drivers/scsi/storvsc_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 1a28f56..14ba8fd 100644 --- a/drivers/scsi

Re: [PATCH 0/4] Hyper-V TRIM support

2013-09-13 Thread Andy Whitcroft
On Fri, Sep 13, 2013 at 07:57:58AM -0700, James Bottomley wrote: This is an awful lot of contortions (which don't seem to have any other users on the horizon) to support a device that's not standards compliant. What about this, it's simple, it does the right thing and it's contained in the

Re: checkpatch: kill the bogus camelcase check

2013-04-10 Thread Andy Whitcroft
On Tue, Apr 09, 2013 at 02:50:54PM -0700, James Bottomley wrote: It's making checkpatch unusable on most drivers because it's spewing tons of bogus warnings. The problem is the assumption that studly caps is always wrong: it isn't if the variables are named after the various conventions in

Re: 2.6.24-rc2-mm1 -- QLogics ISP1020 gone missing

2007-11-15 Thread Andy Whitcroft
All of our machines with QLogics ISP1020 cards seem to have lost them on boot with 2.6.24-rc1-mm1+hotfixes. # lspci :00:0a.0 SCSI storage controller: QLogic Corp. ISP1020 Fast-wide SCSI (rev 05) # lspci -n :00:0a.0 0100: 1077:1020 (rev 05) # lspci -v -v :00:0a.0 SCSI storage

Re: 2.6.23-rc4-mm1

2007-09-14 Thread Andy Whitcroft
On Tue, Sep 11, 2007 at 04:31:12AM +0900, FUJITA Tomonori wrote: [...] The only patch which touches qla1280 is git-block.patch. From a quick squizz the change looks OK, although it's tricky and something might have broken. (the dprintk at line 2929 needs to print remseg, not seg_cnt).

Re: 2.6.23-rc4-mm1

2007-09-13 Thread Andy Whitcroft
On Tue, Sep 11, 2007 at 04:10:47AM +0900, FUJITA Tomonori wrote: The only patch which touches qla1280 is git-block.patch. From a quick squizz the change looks OK, although it's tricky and something might have broken. Can you try this patch (against 2.6.23-rc4-mm1)? Yep this patch seems

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andy Whitcroft
Andrew Morton wrote: +start_sector = req-sector*priv-blocking_factor; +sectors = req-nr_sectors*priv-blocking_factor; s/*/ * /. checkpatch missed this. Ok, this is something we need to decide on. Currently we only ask for consistent spacing on all the mathematic operators. This