[PATCH v1 9/9] scsi: ufs: enable FASTAUTO mode during low load condition

2018-07-06 Thread Asutosh Das
UFS device vendors. Signed-off-by: Subhash Jadavani Signed-off-by: Can Guo Signed-off-by: Asutosh Das --- drivers/scsi/ufs/ufshcd.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 50588cf..a6e43f9 100644 --- a/drivers/scsi/ufs

[PATCH v1 4/9] scsi: ufs: add option to change default UFS power management level

2018-07-06 Thread Asutosh Das
-by: Can Guo Signed-off-by: Asutosh Das --- .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 11 drivers/scsi/ufs/ufshcd-pltfrm.c | 14 +++ drivers/scsi/ufs/ufshcd.c | 29 +++--- drivers/scsi/ufs/ufshcd.h

[PATCH v1 6/9] scsi: ufs: optimize clock, pm_qos, hibern8 handling in queuecommand

2018-07-06 Thread Asutosh Das
-by: Asutosh Das --- drivers/scsi/ufs/ufs-qcom.c | 2 +- drivers/scsi/ufs/ufshcd.c | 33 + drivers/scsi/ufs/ufshcd.h | 2 +- 3 files changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c index 221820a..fa01924

[PATCH v1 2/9] scsi: Allow auto suspend override by low-level driver

2018-07-06 Thread Asutosh Das
the LLD itself instead of waiting for userspace to control the power management. Signed-off-by: Sujit Reddy Thumma Signed-off-by: Subhash Jadavani Signed-off-by: Asutosh Das --- drivers/scsi/scsi_scan.c | 4 drivers/scsi/scsi_sysfs.c | 3 ++- drivers/scsi/sd.c | 2 ++ include/scsi

[PATCH v1 8/9] scsi: ufs: enable runtime pm only after ufshcd init

2018-07-06 Thread Asutosh Das
after ufshcd_init() is done and after hba struct is stored in the platform device private data. Signed-off-by: Gilad Broner Signed-off-by: Can Guo Signed-off-by: Asutosh Das --- drivers/scsi/ufs/ufshcd-pltfrm.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH v1 5/9] scsi: ufs: add support for hibern8 on idle

2018-07-06 Thread Asutosh Das
rn8 with another idle timer. Signed-off-by: Subhash Jadavani Signed-off-by: Can Guo Signed-off-by: Asutosh Das --- drivers/scsi/ufs/ufshcd.c | 372 - drivers/scsi/ufs/ufshcd.h | 39 + include/trace/events/ufs.h | 20 +++ 3 files changed, 397 inserti

[PATCH v1 3/9] scsi: ufs: Override auto suspend tunables for ufs

2018-07-06 Thread Asutosh Das
From: Sujit Reddy Thumma Override auto suspend tunables for UFS device LUNs during initialization so as to efficiently manage background operations and the power consumption. Signed-off-by: Sujit Reddy Thumma Signed-off-by: Gilad Broner Signed-off-by: Asutosh Das --- drivers/scsi/ufs

[PATCH v1 0/9] UFS: Fixes and enhancements

2018-07-06 Thread Asutosh Das
This patch series adds some enhancements and fixes to UFS driver. Gilad Broner (1): scsi: ufs: enable runtime pm only after ufshcd init Subhash Jadavani (6): scsi: ufs: add support to allow non standard behaviours (quirks) scsi: ufs: add option to change default UFS power management level

[PATCH v1 1/9] scsi: ufs: add support to allow non standard behaviours (quirks)

2018-07-06 Thread Asutosh Das
Signed-off-by: Asutosh Das --- drivers/scsi/ufs/ufshcd.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index f51758f..e996a08 100644 --- a/drivers/scsi/ufs/ufshcd.h +++ b/drivers/scsi/ufs/ufshcd.h @@ -613,6 +613,9 @@ struct ufs_hba

[PATCH v1 7/9] scsi: ufs: add UFS power collapse support during hibern8

2018-07-06 Thread Asutosh Das
-off-by: Can Guo Signed-off-by: Asutosh Das --- drivers/scsi/ufs/ufshcd.c | 8 ++-- drivers/scsi/ufs/ufshcd.h | 13 - 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 40d9c35..50588cf 100644 --- a/drivers

Re: [PATCH 1/4] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr

2018-05-16 Thread Asutosh Das (asd)
On 5/6/2018 3:44 PM, Alim Akhtar wrote: In the right behavior, setting the bit to '0' indicates clear and '1' indicates no change. If host controller handles this the other way, UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR can be used. Signed-off-by: Seungwon Jeon Signed-off-by: Alim

[PATCH v2 10/10] scsi: ufs: Add clock ungating to a separate workqueue

2018-05-03 Thread Asutosh Das
urora.org> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 11 ++- drivers/scsi/ufs/ufshcd.h | 1 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/d

[PATCH v2 02/10] scsi: ufs-qcom: Enable UFSHCD_QUIRK_BROKEN_PWR_MODE_CHANGE quirk

2018-05-03 Thread Asutosh Das
Enable UFSHCD_QUIRK_BROKEN_PWR_MODE_CHANGE quirk to avoid failures in seen on some UFS devices. Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufs-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/sc

[PATCH v2 01/10] scsi: ufs: Allowing power mode change

2018-05-03 Thread Asutosh Das
-by: Subhash Jadavani <subha...@codeaurora.org> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 8 +++- drivers/scsi/ufs/ufshcd.h | 7 +++ 2 files changed, 14 insertions(+), 1 deletion(-)

[PATCH v2 06/10] scsi: ufs: add reference counting for scsi block requests

2018-05-03 Thread Asutosh Das
-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 28 drivers/scsi/ufs/ufshcd.h | 2 ++ 2 files changed, 22 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers

[PATCH v2 04/10] scsi: ufs: fix exception event handling

2018-05-03 Thread Asutosh Das
query requests, in case of timeout. Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> Signed-off-by: Maya Erez <me...@codeaurora.org> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufsh

[PATCH v2 08/10] scsi: ufs: make sure all interrupts are processed

2018-05-03 Thread Asutosh Das
leared when handling the previous interrupt. Read the interrupt status in a loop after processing the received interrupt to catch such interrupts and handle it. Signed-off-by: Venkat Gopalakrishnan <venk...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers

[PATCH v2 09/10] scsi: ufs: fix irq return code

2018-05-03 Thread Asutosh Das
org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 137 ++ 1 file changed, 101 insertions(+), 36 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 09b7a3f..557d538 10064

[PATCH v2 05/10] scsi: ufshcd: fix possible unclocked register access

2018-05-03 Thread Asutosh Das
e sure that required clocks are enabled before vendor specific setup_clocks callback is called. Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> Signed-off-by: Venkat Gopalakrishnan <venk...@codeaurora.org> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-of

[PATCH v2 07/10] scsi: ufs-qcom: remove broken hci version quirk

2018-05-03 Thread Asutosh Das
davani <subha...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufs-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c index d9edef8..27be327 100644 --- a/drivers/s

[PATCH v2 03/10] scsi: ufs: Add LCC quirk for host and device

2018-05-03 Thread Asutosh Das
host & device; hence this change splits the quirk in 2 parts one for host and one for device. Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> Signed-off-by: Venkat Gopalakrishnan <venk...@codeaurora.org> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-off-

[PATCH v2 00/10] ufshcd optimizations and fixes

2018-05-03 Thread Asutosh Das
This patch set has a bunch of optimizations for UFS HCI. Changes since v1: Addressed the review comments Asutosh Das (2): scsi: ufs-qcom: Enable UFSHCD_QUIRK_BROKEN_PWR_MODE_CHANGE quirk scsi: ufs: Add LCC quirk for host and device Maya Erez (1): scsi: ufs: fix exception event handling

Re: [PATCH 9/9] scsi: ufs: Add clock ungating to a separate workqueue

2018-02-25 Thread Asutosh Das (asd)
On 2/24/2018 5:27 AM, Miguel Ojeda wrote: On Wed, Feb 21, 2018 at 5:56 AM, Asutosh Das <asuto...@codeaurora.org> wrote: From: Vijay Viswanath <vvisw...@codeaurora.org> UFS driver can receive a request during memory reclaim by kswapd. So when ufs driver puts the ungate w

Re: [PATCH 1/9] scsi: ufs: Allowing power mode change

2018-02-22 Thread Asutosh Das (asd)
On 2/23/2018 10:40 AM, Kyuho Choi wrote: Hi Asutosh, I've simple question in below. On 2/21/18, Asutosh Das <asuto...@codeaurora.org> wrote: From: Yaniv Gardi <yga...@codeaurora.org> Due to M-PHY issues, moving from HS to any other mode or gear or even Hibern8 causes some

Re: [PATCH 5/9] scsi: ufs: add reference counting for scsi block requests

2018-02-22 Thread Asutosh Das (asd)
On 2/21/2018 6:48 PM, Stanislav Nijnikov wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Asutosh Das Sent: Wednesday, February 21, 2018 6:57 AM To: subha...@codeaurora.org; c...@codeaurora.org; vivek.gau

[PATCH 1/9] scsi: ufs: Allowing power mode change

2018-02-20 Thread Asutosh Das
avani <subha...@codeaurora.org> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c

[PATCH 8/9] scsi: ufs: fix irq return code

2018-02-20 Thread Asutosh Das
org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 137 ++ 1 file changed, 101 insertions(+), 36 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 4d4c7d6..6541e1d 10064

[PATCH 3/9] scsi: ufs: fix exception event handling

2018-02-20 Thread Asutosh Das
query requests, in case of timeout. Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> Signed-off-by: Maya Erez <me...@codeaurora.org> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufsh

[PATCH 2/9] scsi: ufs: Add LCC quirk for host and device

2018-02-20 Thread Asutosh Das
ned-off-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 16 drivers/scsi/ufs/ufshcd.h | 11 +++ 2 files changed, 27 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufsh

[PATCH 5/9] scsi: ufs: add reference counting for scsi block requests

2018-02-20 Thread Asutosh Das
-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 44 +--- drivers/scsi/ufs/ufshcd.h | 5 + 2 files changed, 42 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/ufs

[PATCH 7/9] scsi: ufs: make sure all interrupts are processed

2018-02-20 Thread Asutosh Das
leared when handling the previous interrupt. Read the interrupt status in a loop after processing the received interrupt to catch such interrupts and handle it. Signed-off-by: Venkat Gopalakrishnan <venk...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers

[PATCH 4/9] scsi: ufshcd: fix possible unclocked register access

2018-02-20 Thread Asutosh Das
e sure that required clocks are enabled before vendor specific setup_clocks callback is called. Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> Signed-off-by: Venkat Gopalakrishnan <venk...@codeaurora.org> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-of

[PATCH 9/9] scsi: ufs: Add clock ungating to a separate workqueue

2018-02-20 Thread Asutosh Das
g> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 10 +- drivers/scsi/ufs/ufshcd.h | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers

[PATCH 6/9] scsi: ufs-qcom: remove broken hci version quirk

2018-02-20 Thread Asutosh Das
davani <subha...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufs-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c index 2b38db2..221820a 100644 --- a/drivers/s

[PATCH 0/9] ufshcd optimizations and fixes

2018-02-20 Thread Asutosh Das
This patch set has a bunch of optimizations for UFS HCI. Maya Erez (1): scsi: ufs: fix exception event handling Subhash Jadavani (4): scsi: ufs: Add LCC quirk for host and device scsi: ufshcd: fix possible unclocked register access scsi: ufs: add reference counting for scsi block

Re: [PATCH 1/1] scsi: ufs: make sure all interrupts are processed

2018-02-04 Thread Asutosh Das (asd)
On 2/2/2018 8:53 AM, Asutosh Das (asd) wrote: On 1/31/2018 1:09 PM, Avri Altman wrote: Hi, Can you elaborate how this can even happen? Isn't the interrupt aggregation capability should attend for those cases? Thanks, Avri -Original Message- From: linux-scsi-ow...@vger.kernel.org

Re: [PATCH 1/1] scsi: ufs: make sure all interrupts are processed

2018-02-01 Thread Asutosh Das (asd)
] On Behalf Of Asutosh Das Sent: Tuesday, January 30, 2018 6:54 AM To: subha...@codeaurora.org; c...@codeaurora.org; vivek.gau...@codeaurora.org; rna...@codeaurora.org; vinholika...@gmail.com; j...@linux.vnet.ibm.com; martin.peter...@oracle.com Cc: linux-scsi@vger.kernel.org; Venkat Gopalakrishnan <v

Re: [PATCH 1/1] scsi: ufs-qcom: remove broken hci version quirk

2018-01-29 Thread Asutosh Das (asd)
On 1/30/2018 11:33 AM, Vivek Gautam wrote: Hi Asutosh, On 1/30/2018 10:11 AM, Asutosh Das wrote: From: Subhash Jadavani <subha...@codeaurora.org> UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS host controller version 2.x.y and this has been fixed from version

[PATCH 1/1] scsi: ufs: make sure all interrupts are processed

2018-01-29 Thread Asutosh Das
leared when handling the previous interrupt. Read the interrupt status in a loop after processing the received interrupt to catch such interrupts and handle it. Signed-off-by: Venkat Gopalakrishnan <venk...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers

[PATCH 1/1] scsi: ufs-qcom: remove broken hci version quirk

2018-01-29 Thread Asutosh Das
davani <subha...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufs-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c index 2b38db2..221820a 100644 --- a/drivers/s

[PATCH 1/1] scsi: ufs: add reference counting for scsi block requests

2018-01-29 Thread Asutosh Das
-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 44 +--- drivers/scsi/ufs/ufshcd.h | 5 + 2 files changed, 42 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/ufs

[PATCH 1/1] scsi: ufshcd: fix possible unclocked register access

2018-01-29 Thread Asutosh Das
e sure that required clocks are enabled before vendor specific setup_clocks callback is called. Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> Signed-off-by: Venkat Gopalakrishnan <venk...@codeaurora.org> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-of

[PATCH 1/1] scsi: ufs: fix exception event handling

2018-01-28 Thread Asutosh Das
query requests, in case of timeout. Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> Signed-off-by: Maya Erez <me...@codeaurora.org> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufsh

[PATCH 1/1] scsi: ufs: Add LCC quirk for host and device

2018-01-25 Thread Asutosh Das
ned-off-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 16 drivers/scsi/ufs/ufshcd.h | 11 +++ 2 files changed, 27 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufsh

[PATCH 1/1] scsi: ufs: Enable quirk to ignore sending WRITE_SAME command

2018-01-23 Thread Asutosh Das
org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 8af2af3..5a8dc3b 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufs

[PATCH 1/1] scsi: ufs: Allowing power mode change

2018-01-23 Thread Asutosh Das
avani <subha...@codeaurora.org> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c

Re: [PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

2017-08-13 Thread Asutosh Das (asd)
eering -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Asutosh Das (asd) Qualcomm Innovation Center, Inc. is a member of Code Aurora

Re: [ufs]: [scsi]: BUG: spinlock recursion on CPU#4

2017-06-05 Thread Asutosh Das (asd)
On 6/1/2017 7:32 PM, Bart Van Assche wrote: On Thu, 2017-06-01 at 12:28 +0530, Asutosh Das (asd) wrote: Please can you check if this is actually a bug and my understanding is correct. Hello Asutosh, Spinlock recursion is always a bug. With what kernel version did you encounter

[ufs]: [scsi]: BUG: spinlock recursion on CPU#4

2017-06-01 Thread Asutosh Das (asd)
key_false(inline) -025|trace_workqueue_execute_end(inline) -025|process_one_work() -026|worker_thread() -027|kthread() -028|ret_from_fork(asm) ---|end of frame Please can you check if this is actually a bug and my understanding is correct. If so, I can put up a patch for the same. -- Asuto