Re: [PATCH v3 09/12] Make scsi_mq_prep_fn() call scsi_init_command()

Looks good, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v3 04/12] Protect SCSI device state changes with a mutex

On Fri, Jun 02, 2017 at 02:21:55PM -0700, Bart Van Assche wrote: > Serializing SCSI device state changes avoids that two state changes > can occur concurrently, e.g. the state changes in scsi_target_block() > and __scsi_remove_device(). This serialization is essential to make > patch "Make

[PATCH 6/6] sd: add support for TCG OPAL self encrypting disks

Just wire up the generic TCG OPAL infrastructure to the SCSI disk driver and the Security In/Out commands. Note that I don't know of any actual SCSI disks that do support TCG OPAL, but this is required to support ATA disks through libata. Signed-off-by: Christoph Hellwig <h...@lst

[PATCH 4/6] libata: factor out a ata_identify_page_supported helper

Signed-off-by: Christoph Hellwig <h...@lst.de> --- drivers/ata/libata-core.c | 59 +-- 1 file changed, 32 insertions(+), 27 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 445e7050637b..f57131115594

[PATCH 1/6] libata: move ata_read_log_page to libata-core.c

It is core functionality, and only one of the users is in the EH code. Signed-off-by: Christoph Hellwig <h...@lst.de> --- drivers/ata/libata-core.c | 64 +++ drivers/ata/libata-eh.c | 64 --- drive

[PATCH 2/6] libata: factor out a ata_log_supported helper

Signed-off-by: Christoph Hellwig <h...@lst.de> --- drivers/ata/libata-core.c | 59 +-- 1 file changed, 16 insertions(+), 43 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index d4bab5052268..0672733997bb

TCG Opal support for libata

Hi all, this series adds support for using our new generic TCG OPAL code with SATA disks, and as side effect for SCSI disks (although so far it doesn't seem like none of those actually exist).

[PATCH 5/6] libata: implement SECURITY PROTOCOL IN/OUT

This allows us to use the generic OPAL code with ATA devices. Signed-off-by: Christoph Hellwig <h...@lst.de> --- drivers/ata/libata-core.c | 32 drivers/ata/libata-scsi.c | 76 +++ include/linux/ata.h | 1 + include

[PATCH 3/6] libata: clarify log page naming / grouping

Signed-off-by: Christoph Hellwig <h...@lst.de> --- drivers/ata/libata-core.c | 10 +- include/linux/ata.h | 10 +++--- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 0672733997bb..445e7050637b

Re: [PATCH v2 12/12] xen/scsifront: Remove code that zeroes driver-private command data

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v2 11/12] virtio: Remove code that zeroes driver-private command data

Nit: the driver name is virtio_scsi, not just virtio. Otherwise this looks fine: Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v2 10/12] snic: Remove code that zeroes driver-private command data

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v2 09/12] Make scsi_mq_prep_fn() call scsi_init_command()

I like this idea, but.. > -void scsi_init_command(struct scsi_device *dev, struct scsi_cmnd *cmd) > +void scsi_init_command(struct scsi_device *dev, struct scsi_cmnd *cmd, > +struct scsi_data_buffer *prot_sdb) > { > void *buf = cmd->sense_buffer; > - void *prot =

Re: [PATCH v2 08/12] Introduce scsi_mq_sgl_size()

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v2 06/12] Make __scsi_remove_device go straight from BLOCKED to DEL

On Thu, Jun 01, 2017 at 04:27:05PM -0700, Bart Van Assche wrote: > If a device is blocked, make __scsi_remove_device() cause it to > transition to the DEL state. This means that all the commands > issued in .shutdown() will error in the mid-layer, thus making > the removal proceed without being

Re: [PATCH v2 05/12] Introduce scsi_start_queue()

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v2 03/12] Create two versions of scsi_internal_device_unblock()

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v2 04/12] Protect SCSI device state changes with a mutex

On Thu, Jun 01, 2017 at 04:27:03PM -0700, Bart Van Assche wrote: > Enable this mechanism for all scsi_target_*block() callers but not > for the scsi_internal_device_unblock() calls from the mpt3sas driver > because that driver can call scsi_internal_device_unblock() from > atomic context. This is

Re: [PATCH v2 02/12] Split scsi_internal_device_block()

Yes, much better: Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v2 01/12] Avoid that scsi_exit_rq() triggers a use-after-free

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 00/31] SCSI patches for kernel v4.13.

On Thu, Jun 01, 2017 at 02:08:04PM +, Bart Van Assche wrote: > The first eight patches in this series do not depend on any block layer > changes. > Do you want me to repost this patches or can you perhaps queue these without a > repost? It would be great if you could repost them, also for

Re: [PATCH 2/2] target/configfs: Kill se_lun->lun_link_magic

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 1/2] target/configfs: Kill se_device->dev_link_magic

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH] target: Avoid target_shutdown_sessions loop during queue_depth change

cff1216577b3 Author: Christoph Hellwig <h...@lst.de> Date: Mon May 2 15:45:19 2016 +0200 target: consolidate and fix session shutdown To avoid this case, instead move sessions into a local list and avoid draining the same session multiple times when invoked via core_tpg_set_initiato

Re: [PATCH 2/8] target: remove iblock WRITE_SAME passthrough support

On Wed, May 31, 2017 at 11:27:01PM -0700, Nicholas A. Bellinger wrote: > Hey HCH & Jens, > > Is this already queued up for v4.13 to address the missing LBPRZ feature > bit..? > > If not, I'll happy to take it via target-pending along with the > following to re-enable it via

Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler

> + case SAS_PROTOCOL_SSP: > + { > + unsigned char op = task->ssp_task.cmd->cmnd[0]; > + > + if (op == READ_6 || op == WRITE_6 || > + op == READ_10 || op == WRITE_10 || > + op == READ_12 || op == WRITE_12 || > +

Re: [PATCH v3 13/23] scsi: hisi_sas: add phy up/down/bcast and channel ISR

On Wed, May 31, 2017 at 10:33:05PM +0800, John Garry wrote: > From: Xiang Chen > > Add code to initialise interrupts and add some interrupt handlers. > > Signed-off-by: John Garry > Signed-off-by: Xiang Chen > --- >

Re: [PATCH] qla2xxx: Remove an unused structure member

On Mon, May 22, 2017 at 01:10:53PM -0700, Bart Van Assche wrote: > qla_tgt_cmd.free_work is not used by the qla2xxx driver. Hence > remove that member of struct qla_tgt_cmd. Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v2 3/4] scsi_dh_alua: do not call BUG_ON when updating port group

On Mon, May 15, 2017 at 08:30:19PM +0200, Martin Wilck wrote: > please be assured that I'm not trying to paper over anything. Your > concern about sdev->handler_data is justified. While I think that it's > a separate issue from what my patches were supposed to address, let me > see if I can come

Re: [PATCH blktests 0/3] Add SCSI generic test group

On Thu, May 18, 2017 at 03:29:45PM +0200, Johannes Thumshirn wrote: > On 05/18/2017 03:19 PM, Christoph Hellwig wrote: > > All SG_IO test should also apply to block device nodes that support > > the ioctl.. > > > > But these are not necessarily SG_IO tests, are t

Re: [PATCH v2] Use ctlr directly in rdac_failover_get()

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 01/18] block: Introduce blk_queue_cmd_size()

On Fri, May 19, 2017 at 11:29:59AM -0700, Bart Van Assche wrote: > This function will be used by later patches in this series. And it could already be used to simplify blk_alloc_flush_queue a bit.. Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 18/18] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 16/18] scsi-mq: Make behavior scsi_mq_prep_fn() closer to that of scsi_prep_fn()

Looks good, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 17/18] scsi: Consolidate more initialization code

Looks good, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 15/18] scsi: storvsc: Initialize driver-private command before using it

On Fri, May 19, 2017 at 11:30:13AM -0700, Bart Van Assche wrote: > The storvsc driver is the only SCSI LLD that uses driver-private > command data and that does not zero-initialize that data before > reading it. Make this driver consistent with the other SCSI LLDs > that use driver-private command

Re: [PATCH 06/18] scsi: Make scsi_ioctl_reset() pass the request queue pointer to blk_rq_init()

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de> Although we really need to stop abusing requests/cmds for EH.. (Hannes, time to dust off your old patches!)

Re: [PATCH 14/18] scsi: Make scsi_initialize_rq() zero the entire struct scsi_cmnd

On Fri, May 19, 2017 at 11:30:12AM -0700, Bart Van Assche wrote: > This simplifies the memset() call in scsi_initialize_rq() and avoids > that any stale data is left behind in struct scsi_request. > > Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> > Cc: Christoph

Re: [PATCH 13/18] scsi: Move sense buffer pointer initialization into scsi_initialize_rq()

On Fri, May 19, 2017 at 11:30:11AM -0700, Bart Van Assche wrote: > This patch is a preparation for the next patch that will zero > the struct scsi_request embedded in struct scsi_cmnd before > calling scsi_req_init(). Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 12/18] scsi: Inline scsi_init_command()

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 11/18] scsi: Move most of scsi_init_command() into scsi_initialize_rq()

that it gets back the meaning it > had before commit e9c787e65c0c, namely the value of the jiffies > counter at request allocation time. Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 11/18] scsi: Move most of scsi_init_command() into scsi_initialize_rq()

On Sun, May 21, 2017 at 08:45:23AM +0200, Christoph Hellwig wrote: > On Fri, May 19, 2017 at 11:30:09AM -0700, Bart Van Assche wrote: > > Move the initializations that only have to be performed once and > > not every time a request is prepared from scsi_init_command() > > in

Re: [PATCH 11/18] scsi: Move most of scsi_init_command() into scsi_initialize_rq()

On Fri, May 19, 2017 at 11:30:09AM -0700, Bart Van Assche wrote: > Move the initializations that only have to be performed once and > not every time a request is prepared from scsi_init_command() > into scsi_initialize_rq(). This patch also moves the > jiffies_at_alloc assignment such that it gets

Re: [PATCH 10/18] scsi: Only add commands to the device command list if required by the LLD

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 09/18] scsi: Change argument type of scsi_req_init()

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 08/18] block: Make scsi_req_init() calls implicit

On Fri, May 19, 2017 at 11:30:06AM -0700, Bart Van Assche wrote: > Instead of explicitly calling scsi_req_init(), let > blk_get_request() call that function from inside blk_rq_init(). > Add an .initialize_rq_fn() callback function to the block drivers > that need it. Thanks Bart, this looks like

Re: [PATCH 07/18] block: Introduce request_queue.initialize_rq_fn()

ion code has to be repeated after every > blk_get_request() call by adding a new callback function to struct > request_queue. > > Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> > Cc: Jens Axboe <ax...@fb.com> > Cc: Christoph Hellwig <h...@lst.de> &

Re: [PATCH 02/18] bsg: Check private request size before attaching to a queue

Hi Bart, I think this is the wrong kind of check - while we do care about the size of the queue, we only do it as a side effect of the queue being able to handle REQ_OP_SCSI_IN/REQ_OP_SCSI_OUT commands. I think we'll need a flag for those in the queue instead. And btw, I didn't get your cover

Re: [PATCH blktests 0/3] Add SCSI generic test group

All SG_IO test should also apply to block device nodes that support the ioctl..

Re: [PATCH] scsi: zero per-cmd driver data for each MQ I/O

On Wed, May 17, 2017 at 11:05:18PM +, Bart Van Assche wrote: > Thank you for the feedback. I'm working on a patch series that merges the > scsi-sq > and scsi-mq code paths for command initialization and that should fix the bug > you > encountered. While that sounds great (I tried it a while

Re: [PATCH] scsi: zero per-cmd driver data for each MQ I/O

Looks good, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [Consult]: Can the coming Huawei scsi device handler be accepted in the scsi/device_handler

On Mon, May 15, 2017 at 12:08:12PM +0800, Guan Junxiong wrote: > Hi, Christoph Hellwig > Thanks for your reply. But I am a little confused: > > Our Huawei scsi device handler will support ALUA. Besides , some new > enhancements such as error self negotiation > on th

Re: [dm-devel] [Consult]: Can the coming Huawei scsi device handler be accepted in the scsi/device_handler

On Sat, May 13, 2017 at 12:07:04PM +0800, Guan Junxiong wrote: > Hello,Alasdair and Mike: > I am going to add our vendor specific Huawei scsi device handler based on > scsi_dh > framework into the linux/drivers/scsi/device_handler directory. > Is it possible to be merged into the device

Re: [PATCH v1 1/4] scsi: ufs: Add ioctl() interface with Query Request

NAK for new SCSI LLDD ioctl handlers, we're not in the 90s anymore.

Re: [PATCH v1 3/4] scsi: ufs: Expose Task Management to ioctl() UAPI

On Thu, May 11, 2017 at 04:01:48PM +0200, Michal Potomski wrote: > From: Michał Potomski > > Since we already have UFS ioctl() API some additional tools > like task management are "nice-to-have" for testing and management > purposes. No way you're going to bypass the

Re: [PATCH v2] sd: Ignore sync cache failures when not supported

Normally we'd just pass the scsi_sense_hdr structure in from the caler if we care about sense data. Is this something you considered? Otherwise this looks fine to me.

Re: [PATCH 4/5] scsi: bnx2fc: annoate unlock + release for sparse

Looks good, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 5/5] scsi: bnx2fc: convert bnx2fc_l2_rcv_thread() to workqueue

Looks good, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 3/5] scsi: bnx2fc: clean up header definitions

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 2/5] scsi: bnx2fc: convert per-CPU thread to workqueue

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 1/5] scsi: bnx2i: convert to workqueue

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: remove REQ_OP_WRITE_SAME

On Thu, Apr 13, 2017 at 10:23:10PM -0400, Martin K. Petersen wrote: > The other thing that keeps me a bit on the fence is that a bunch of the > plumbing to handle a bio with a payload different from bi_size is needed > for the copy offload token. I'm hoping to have those patches ready for > 4.13.

Re: [PATCH v2] Avoid that scsi_exit_rq() triggers a use-after-free

Please just add a flag to ->flags instead of adding a whole new field. Otherwise this looks good to me.

[PATCH, RFC] MAINTAINERS: update OSD entries

really leave the Supported status in MAINTAINERS given that the code is barely maintained? Signed-off-by: Christoph Hellwig <h...@lst.de> --- MAINTAINERS | 4 1 file changed, 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1bb06c5f7716..28dd83a1d9e2 100644 --- a/MAINT

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

On Wed, Apr 26, 2017 at 12:11:33PM -0600, Logan Gunthorpe wrote: > Ok, well for starters I think you are mistaken about kmap being able to > fail. I'm having a hard time finding many users of that function that > bother to check for an error when calling it. A quick audit of the arch code shows

Re: [PATCH v2 02/21] libiscsi: Add an internal error code

On Tue, Apr 25, 2017 at 12:20:49PM -0600, Logan Gunthorpe wrote: > This is a prep patch to add a new error code to libiscsi. We want to > rework some kmap calls to be able to fail. When we do, we'd like to > use this error code. The kmap case in iscsi_tcp_segment_map can already fail. Please add

Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

On Tue, Apr 25, 2017 at 12:20:48PM -0600, Logan Gunthorpe wrote: > This patch introduces functions which kmap the pages inside an sgl. > These functions replace a common pattern of kmap(sg_page(sg)) that is > used in more than 50 places within the kernel. > > The motivation for this work is to

[PATCH 2/3] ide-pm: always pass 0 error to __blk_end_request_all

ide_pm_execute_rq exectures a PM request synchronously, and in the failure case where it calls __blk_end_request_all it never checks the error field passed to the end_io callback, so don't bother setting it. Signed-off-by: Christoph Hellwig <h...@lst.de> --- drivers/ide/ide-pm.c | 2 +-

[PATCH 3/3] ide-pm: always pass 0 error to ide_complete_rq in ide_do_devset

The caller only looks at the scsi_request result field anyway. Signed-off-by: Christoph Hellwig <h...@lst.de> --- drivers/ide/ide-devsets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/ide-devsets.c b/drivers/ide/ide-devsets.c index b1223234037d..9b69c3

[PATCH 1/3] scsi_transport_sas: always pass 0 error to blk_end_request_all

The SAS transport queues are only used by bsg, and bsg always looks at the scsi_request results and never add the error passed in the end_io callback. Signed-off-by: Christoph Hellwig <h...@lst.de> --- drivers/scsi/scsi_transport_sas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

three little req->errors follow ups

While moving forward with the block error work I noticed three more places that pass non-errno values to the end_request variants, and never actually check those return values. This little series fixes those up to always pass 0.

Re: [PATCH] nvme-scsi: Use correct byte ordering for eui64 in Dev ID VPD

On Tue, Apr 25, 2017 at 02:18:09PM -0600, Jon Derrick wrote: > NVME specifies an EUI64/NGUID in little-endian format, while SCSI > specifies that the Device Identification VPD use big-endian for EUI > formats. The current code copies this bytestream directly from the > Identification Namespace

Re: [PATCH] lpfc: Fix memory corruption of the lpfc_ncmd->list pointers

On Tue, Apr 25, 2017 at 10:58:44AM -0700, Christoph Hellwig wrote: > On Fri, Apr 21, 2017 at 05:49:08PM -0700, jsmart2...@gmail.com wrote: > > This is a nvme-specific bug. The patch was cut against the > > linux-block tree, for-4.12/block tree. It should be pulled in throug

Re: [PATCH] lpfc: Fix memory corruption of the lpfc_ncmd->list pointers

On Fri, Apr 21, 2017 at 05:49:08PM -0700, jsmart2...@gmail.com wrote: > This is a nvme-specific bug. The patch was cut against the > linux-block tree, for-4.12/block tree. It should be pulled in through > that tree. It conflicts with your nvme changes that are in the nvme-4.12. Can you respin it?

Re: [PATCH] nvme/scsi: Consider LBA format in IO splitting calculation

Applied to nvme-4.12.

Re: [PATCH v2 1/1] aacraid: pci_alloc_consistent() failures on ARM64

h...@microsemi.com> [hch: tweaked indentation, removed memsets] Signed-off-by: Christoph Hellwig <h...@lst.de> --- drivers/scsi/aacraid/aachba.c | 13 ++--- drivers/scsi/aacraid/commctrl.c | 6 -- drivers/scsi/aacraid/comminit.c | 3 +-- drivers/scsi/aacraid/commsup.c |

Re: [PATCH v2 7/7] sd_zbc: Do not write lock zones for reset

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v2 5/7] sd_zbc: Rename sd_zbc_setup_write_cmnd

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v2 6/7] sd_zbc: Remove superfluous assignments

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v2 4/7] scsi: Improve scsi_get_sense_info_fld

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v2 3/7] sd: Cleanup sd_done sense data handling

I would just use a switch and kill the op and unmap variables entirely, e.g. something like the patch below: --- From: Christoph Hellwig <h...@lst.de> Subject: sd: Cleanup sd_done sense data handling Use a switch for the sense key, and remove two pointless variables that are only use

Re: [PATCH v2 2/7] sd: Improve sd_completed_bytes

_div calls with calls to sectors_to_logical(). > > No functional change is introduced by this patch. > > Signed-off-by: Damien Le Moal <damien.lem...@wdc.com> Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v2 1/7] sd: Fix functions description

Looks good, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH] sg: reset 'res_in_use' after unlinking reserved array

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH] mpt: Move scsi_remove_host() out of mptscsih_remove_host()

Looks good, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [RFC] scsi: reduce protection of scan_mutex in scsi_remove_device

On Fri, Apr 21, 2017 at 02:13:02PM -0700, Song Liu wrote: > When a device is deleted through sysfs handle "delete", the code > locks shost->scan_mutex. If multiple devices are deleted at the > same time, these deletes will be handled in series. > > On the other hand, some devices do long latency

Re: [PATCH v3 00/22] lpfc updates for 11.2.0.12

Applie to the nvme-4.12 branch. Any praying we're not going to see any conflicts with the SCSI tree.

Re: [PATCH] scsi: mvumi: remove code handling zero scsi_sg_count(scmd) case

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de> Note that there is plenty opportunity for cleanup even in the moved code section, but let's get this issue sorted out only for now.

Re: [PATCH] scsi: mvumi: add check for dma mapping errors

On Sat, Apr 22, 2017 at 02:17:50AM +0300, Alexey Khoroshilov wrote: > } else { > - scmd->SCp.dma_handle = scsi_bufflen(scmd) ? > - pci_map_single(mhba->pdev, scsi_sglist(scmd), > - scsi_bufflen(scmd), > -

Re: [PATCH 3/4] scsi: pmcraid: fix endianess sparse annotations

should be swapped once and store in an in-memory structure. But for now this patch looks fine to me: Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 4/4] scsi: pmcraid: fix minor sparse warnings

Looks fine, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH 2/4] scsi: pmcraid: fix lock imbalance in pmcraid_reset_reload()

d seem like the best way to go, e.g. this patch: --- >From 8c58854f345bd87789b68eba2b2f72d0cac952fa Mon Sep 17 00:00:00 2001 From: Christoph Hellwig <h...@lst.de> Date: Sun, 23 Apr 2017 10:33:23 +0200 Subject: pmcraid: fix lock imbalance in pmcraid_reset_reload() sparse found a bug that

Re: [PATCH] scsi: pmcraid: use normal copy_from_user

Looks good, Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH] scsi: sas: move scsi_remove_host call into sas_remove_host

Looks good: Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

On Fri, Apr 21, 2017 at 09:57:37AM +0100, John Garry wrote: > On 21/04/2017 09:39, Johannes Thumshirn wrote: >>> wangyijing already sent an RFC for fixing this issue (mentioned above), >>> > which was a signifiagnt rewrite of some of libsas. >>> > I am hoping that he would retry, and that

Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs

On Fri, Apr 21, 2017 at 10:04:45AM +0200, Johannes Thumshirn wrote: > This series re-orders the calls to scsi_remove_host() and sas_remove_host() in > all SAS HBA drivers (apart from mpt3sas which is doing it correctly). This is > for two reasons: > 1) After the change to recursive removal

Re: [PATCH 0/5] v2: block subsystem refcounter conversions

On Thu, Apr 20, 2017 at 11:33:19AM -0700, Eric Biggers wrote: > Like I suggested months ago, how about doing an efficient implementation of > refcount_t which doesn't use the bloated cmpxchg loop? Then there would be no > need for endless performance arguments. In fact, in PaX there are already

Re: [PATCH 3/4] nfs: remove the objlayout driver

On Thu, Apr 20, 2017 at 08:18:28PM +, Trond Myklebust wrote: > OK. I'm applying this patch for the 4.12 merge window. If, as Boaz > suggests, there is still an interest in exofs, then I suggest we put > that to the test by moving it into the STAGING area, to see if someone > will step up to

Re: [PATCH 3/4] nfs: remove the objlayout driver

On Fri, Apr 21, 2017 at 09:27:11AM +0200, Valentin Rothberg wrote: > Hi Christoph, > > I just came across this patch in linux-next commit 6d22323b2e9f. > scripts/checkkconfigsymbols.py reports that there is a leftover > reference on PNFS_OBJLAYOUT in fs/exofs/Kconfig.ore line 10 (depends > on

Re: ["PATCH-v2" 00/22] lpfc updates for 11.2.0.12

On Fri, Apr 21, 2017 at 02:52:13AM +0300, Sagi Grimberg wrote: > > > The patches are dependent on the FC nvme/nvmet patches from the following 2 > > series: > > http://lists.infradead.org/pipermail/linux-nvme/2017-April/009250.html > >

<    4   5   6   7   8   9   10   11   12   13   >