On Wed, Jan 24, 2018 at 01:36:00PM -0800, James Bottomley wrote:
> On Wed, 2018-01-24 at 11:20 -0800, Mike Kravetz wrote:
> > On 01/24/2018 11:05 AM, James Bottomley wrote:
> > >
> > > I've got two community style topics, which should probably be
> > > discussed
> > > in the plenary
> > >
> > >
*bp)
> - {
> +{
> struct xfs_agf *agf = XFS_BUF_TO_AGF(bp);
>
> if (xfs_sb_version_hascrc(>m_sb)) {
> @@ -2449,8 +2449,7 @@ xfs_agf_verify(
>be32_to_cpu(agf->agf_refcount_level) > XFS_BTREE_MAXLEVELS))
> return false;
>
>
On Fri, Mar 31, 2017 at 03:11:28PM +, Bart Van Assche wrote:
> On Fri, 2017-03-31 at 13:02 +0300, Dmitry Monakhov wrote:
> > Another good example may be a bug with dirty page cache after blkdiscard
> > https://lkml.org/lkml/2017/3/22/789 . This simple bug result in crappy
> > fsimage if mkfs
On Wed, May 18, 2016 at 11:39:30PM +0100, Sitsofe Wheeler wrote:
> Hi,
>
> With Ubuntu's 4.4.0-22-generic kernel and a Fedora 23
> 4.6.0-1.vanilla.knurd.1.fc23.x86_64 kernel I've found that the
> BLKZEROOUT syscall can malfunction and not zero data.
>
> When BLKZEROOUT is issued to an MD device
On Wed, Apr 13, 2016 at 09:51:04AM -0700, James Bottomley wrote:
> On Wed, 2016-04-13 at 09:29 -0700, Bart Van Assche wrote:
> > On 04/13/2016 09:21 AM, Martin K. Petersen wrote:
> > > From a filesystem/ioctl perspective, BLKDISCARD is a hint. We
> > > should not be
> > > rounding off or aligning
Hi folks,
Well, we made it! As of yesterday, the File Storage systems microconf has
been approved for Plumbers! If you're interested in attending, I highly
recommend that you register[0] immediately, as the earlybird deadline is
tomorrow, June 5th.
We have a solid list of discussion ideas on
On Thu, May 21, 2015 at 09:21:12PM +0200, Jan Kara wrote:
On Thu 21-05-15 11:09:55, Kent Overstreet wrote:
On Thu, May 21, 2015 at 06:54:53PM +0200, Jan Kara wrote:
On Wed 20-05-15 18:04:40, Kent Overstreet wrote:
Yeah. I never figured out a sane way to migrate pages and keep
Hi everyone,
Linux Plumbers is coming up in just four months! I would like for there to be
a file storage miniconf at this year's LPC, so I've started assembling a plan
for what we might discuss. As a starting point, I've filled the planning page
with the topics that didn't achieve any sort of
returning stale cache contents at a
later time.
Depends on block: Add discard flag to blkdev_issue_zeroout() function.
Signed-off-by: Darrick J. Wong darrick.w...@oracle.com
---
block/ioctl.c | 45 ++---
include/uapi/linux/fs.h |7 +++
2 files
On Wed, Dec 10, 2014 at 05:41:54PM -0800, Darrick J. Wong wrote:
On Wed, Dec 10, 2014 at 02:29:29AM -0800, Darrick J. Wong wrote:
On Wed, Dec 10, 2014 at 02:15:14AM -0800, Darrick J. Wong wrote:
On Wed, Dec 10, 2014 at 01:04:58AM -0800, Darrick J. Wong wrote:
On Wed, Dec 10, 2014 at 09
The Apricorn SATA dongle will occasionally return USBSUSBSUSB in
response to SCSI commands when running in UAS mode. Therefore,
disable UAS mode on this dongle.
Signed-off-by: Darrick J. Wong darrick.w...@oracle.com
---
drivers/usb/storage/unusual_uas.h | 10 ++
1 file changed, 10
On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede wrote:
Hi,
On 09-12-14 20:31, Darrick J. Wong wrote:
Hi,
I have an Apricorn USB 3 disk dongle thing that claims to support UAS.
However, the kernel crashes when I plug it in[1].
Yes there are some known issues with uas error
On Wed, Dec 10, 2014 at 01:04:58AM -0800, Darrick J. Wong wrote:
On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede wrote:
Hi,
On 09-12-14 20:31, Darrick J. Wong wrote:
Hi,
I have an Apricorn USB 3 disk dongle thing that claims to support UAS.
However, the kernel crashes when
On Wed, Dec 10, 2014 at 02:15:14AM -0800, Darrick J. Wong wrote:
On Wed, Dec 10, 2014 at 01:04:58AM -0800, Darrick J. Wong wrote:
On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede wrote:
Hi,
On 09-12-14 20:31, Darrick J. Wong wrote:
Hi,
I have an Apricorn USB 3 disk
On Wed, Dec 10, 2014 at 02:29:29AM -0800, Darrick J. Wong wrote:
On Wed, Dec 10, 2014 at 02:15:14AM -0800, Darrick J. Wong wrote:
On Wed, Dec 10, 2014 at 01:04:58AM -0800, Darrick J. Wong wrote:
On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede wrote:
Hi,
On 09-12-14 20:31
Hi,
I have an Apricorn USB 3 disk dongle thing that claims to support UAS.
However, the kernel crashes when I plug it in[1].
I'm not sure what this is caused by, but I also have an ASMedia 2105 SATA
bridge that works with UAS just fine. Not sure if the Apricorn thing is simply
broken, or if
On Fri, Nov 14, 2014 at 03:22:05PM -0500, Martin K. Petersen wrote:
Martin == Martin K Petersen martin.peter...@oracle.com writes:
Martin What would you prefer as the default for the ext4 use case? To
Martin allocate or to discard?
I didn't get a preference for whether sb_issue_zeroout()
returning stale cache contents at a
later time.
This patch depends on mkp's earlier patch block: Introduce
blkdev_issue_zeroout_discard() function.
Signed-off-by: Darrick J. Wong darrick.w...@oracle.com
---
block/ioctl.c | 45 ++---
include/uapi/linux
On Fri, Nov 07, 2014 at 12:08:14AM -0500, Martin K. Petersen wrote:
blkdev_issue_discard() will zero a given block range on disk. This is
done by way of either WRITE SAME or regular WRITE. I.e. the blocks on
disk will be written and thus provisioned.
There are use cases where the desired
On Wed, Apr 02, 2014 at 12:17:58PM -0700, Zach Brown wrote:
+static int bio_integrity_generate_verify(struct bio *bio, int operate)
{
+ if (operate)
+ sector = bio-bi_iter.bi_sector;
+ else
+ sector = bio-bi_integrity-bip_iter.bi_sector;
+ if
On Wed, Apr 02, 2014 at 01:01:33PM -0700, Zach Brown wrote:
+static int setup_pi_ext(struct kiocb *req, int is_write)
+{
+ struct file *file = req-ki_filp;
+ struct io_extension *ext = req-ki_ioext-ke_kern;
+ void *p;
+ unsigned long start, end;
+ int retval;
+
+ if
On Wed, Apr 02, 2014 at 03:22:20PM -0400, Jeff Moyer wrote:
Darrick J. Wong darrick.w...@oracle.com writes:
Define a generic interface to allow userspace to attach metadata to an
IO operation. This interface will be used initially to implement
protection information (PI) pass through
On Wed, Apr 02, 2014 at 12:49:47PM -0700, Zach Brown wrote:
@@ -916,6 +921,17 @@ void aio_complete(struct kiocb *iocb, long res, long
res2)
struct io_event *ev_page, *event;
unsigned long flags;
unsigned tail, pos;
+ int ret;
+
+ ret =
On Wed, Apr 02, 2014 at 03:33:11PM -0700, Zach Brown wrote:
One thing I'm not sure about: What's the largest IO (in terms of # of
blocks,
not # of struct iovecs) that I can throw at the kernel?
Yeah, dunno. I'd guess big :). I'd hope that the PI code already has a
way to clamp the
On Wed, Apr 02, 2014 at 03:53:33PM -0700, Zach Brown wrote:
I'd just remove this generic teardown callback path entirely. If
there's PI state hanging off the iocb tear it down during iocb teardown.
Hmm, I thought aio_complete /was/ iocb teardown time.
Well, usually :). If you build
This RFC provides a rough implementation of a mechanism to allow
userspace to attach protection information (e.g. T10 DIF) data to a
disk write and to receive the information alongside a disk read.
There's a new IO extension interface wherein we define a structure
(per zab's comments on the v2
the non-AIO calls to use this mechanism.
Signed-off-by: Darrick J. Wong darrick.w...@oracle.com
---
fs/aio.c | 180 +-
include/linux/aio.h |7 ++
include/uapi/linux/aio_abi.h | 15 +++-
3 files changed, 197 insertions
to provide. This is intended, for example, to
satisfy programs that really only care to provide an app tag.
Signed-off-by: Darrick J. Wong darrick.w...@oracle.com
---
Documentation/block/data-integrity.txt | 11
block/blk-integrity.c |1
drivers/scsi/sd_dif.c
Frøm: Gu Zheng guz.f...@cn.fujitsu.com
Most code of function bio_integrity_verify and bio_integrity_generate
is the same, so introduce a help function bio_integrity_generate_verify()
to remove the duplicate code.
Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com
---
fs/bio-integrity.c | 83
Provide an IO extension handler that attaches PI data from the io
extension structure to a kiocb, then teach directio how to attach the
pages representing the PI buffer directly to a bio.
Signed-off-by: Darrick J. Wong darrick.w...@oracle.com
---
Documentation/block/data-integrity.txt | 11
Expose possible userland flags to the new PI IO extension so that
userspace can discover what flags exist.
Signed-off-by: Darrick J. Wong darrick.w...@oracle.com
---
Documentation/ABI/testing/sysfs-block | 14 ++
Documentation/block/data-integrity.txt | 22
Refactor blk-integrity.c to avoid duplicating similar functions, and
remove all users of pi_buf, since it's really only there to handle the
(common) case where the kernel auto-generates all the PI data.
Signed-off-by: Darrick J. Wong darrick.w...@oracle.com
---
fs/bio-integrity.c | 120
On Sun, Mar 23, 2014 at 03:02:44PM +0100, Jan Kara wrote:
On Sat 22-03-14 02:43:20, Darrick J. Wong wrote:
On Fri, Mar 21, 2014 at 07:32:16PM -0700, Darrick J. Wong wrote:
On Fri, Mar 21, 2014 at 05:29:09PM -0700, Zach Brown wrote:
I'll admit, though, that I don't really like having
On Fri, Mar 21, 2014 at 07:32:16PM -0700, Darrick J. Wong wrote:
On Fri, Mar 21, 2014 at 05:29:09PM -0700, Zach Brown wrote:
On Fri, Mar 21, 2014 at 03:54:37PM -0700, Darrick J. Wong wrote:
On Fri, Mar 21, 2014 at 05:44:10PM -0400, Benjamin LaHaise wrote:
I'm inclined to agree
On Fri, Mar 21, 2014 at 10:57:31AM -0400, Jeff Moyer wrote:
Darrick J. Wong darrick.w...@oracle.com writes:
This RFC provides a rough implementation of a mechanism to allow
userspace to attach protection information (e.g. T10 DIF) data to a
disk write and to receive the information
On Fri, Mar 21, 2014 at 11:23:32AM -0700, Zach Brown wrote:
On Thu, Mar 20, 2014 at 09:30:41PM -0700, Darrick J. Wong wrote:
This RFC provides a rough implementation of a mechanism to allow
userspace to attach protection information (e.g. T10 DIF) data to a
disk write and to receive
On Fri, Mar 21, 2014 at 05:44:10PM -0400, Benjamin LaHaise wrote:
Hi folks,
On Fri, Mar 21, 2014 at 11:23:32AM -0700, Zach Brown wrote:
On Thu, Mar 20, 2014 at 09:30:41PM -0700, Darrick J. Wong wrote:
This RFC provides a rough implementation of a mechanism to allow
userspace to attach
On Fri, Mar 21, 2014 at 05:29:09PM -0700, Zach Brown wrote:
On Fri, Mar 21, 2014 at 03:54:37PM -0700, Darrick J. Wong wrote:
On Fri, Mar 21, 2014 at 05:44:10PM -0400, Benjamin LaHaise wrote:
I'm inclined to agree with Zach on this item. Ultimately, we need an
extensible data structure
Refactor blk-integrity.c to avoid duplicating similar functions, and
remove all users of pi_buf, since it's really only there to handle the
(common) case where the kernel auto-generates all the PI data.
Signed-off-by: Darrick J. Wong darrick.w...@oracle.com
---
fs/bio-integrity.c | 120
This RFC provides a rough implementation of a mechanism to allow
userspace to attach protection information (e.g. T10 DIF) data to a
disk write and to receive the information alongside a disk read. The
interface is an extension to the AIO interface: two new commands
(IOCB_CMD_P{READ,WRITE}VM) are
Frøm: Gu Zheng guz.f...@cn.fujitsu.com
Most code of function bio_integrity_verify and bio_integrity_generate
is the same, so introduce a help function bio_integrity_generate_verify()
to remove the duplicate code.
Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com
---
fs/bio-integrity.c | 83
Provide a set of new AIO commands (IOCB_CMD_P{READ,WRITE}VM) that
utilize the last iovec of the iovec array to convey protection
information to and from userspace.
Signed-off-by: Darrick J. Wong darrick.w...@oracle.com
---
Documentation/block/data-integrity.txt | 11 ++
fs/aio.c
to provide. This is intended, for example, to
satisfy programs that really only care to provide an app tag.
Signed-off-by: Darrick J. Wong darrick.w...@oracle.com
---
Documentation/block/data-integrity.txt | 11
block/blk-integrity.c |1
drivers/scsi/sd_dif.c
Expose possible userland flags to the new AIO/DIO PI interface so that
userspace can discover what flags exist.
Signed-off-by: Darrick J. Wong darrick.w...@oracle.com
---
Documentation/ABI/testing/sysfs-block | 14 ++
Documentation/block/data-integrity.txt | 26
On Fri, Jan 03, 2014 at 03:03:42PM -0500, Martin K. Petersen wrote:
Hannes == Hannes Reinecke h...@suse.de writes:
Hannes Personally, I doubt it's a good idea to kill it off, but a
Hannes proper (userland) API for it has been a long time missing.
Before we throw the baby out with the bath
On Thu, Feb 07, 2013 at 01:40:14AM -0800, Joel Becker wrote:
On Wed, Feb 06, 2013 at 03:34:49PM -0500, Chuck Lever wrote:
On Feb 6, 2013, at 3:24 PM, Darrick J. Wong darrick.w...@oracle.com
wrote:
On Wed, Feb 06, 2013 at 01:51:22PM -0600, Ben Myers wrote:
Hi,
I'm
On Wed, Feb 06, 2013 at 01:51:22PM -0600, Ben Myers wrote:
Hi,
I'm interested in discussing how to pass protection information to and from
userspace. Maybe Martin could be enlisted for the discussion.
I read that some work has already been done in this area but have not been
able
to
.
Right now, the SCSI layer promotes a DIF type 0 disk into a DIF type 1 disk,
which seems incorrect.
Signed-off-by: Darrick J. Wong darrick.w...@oracle.com
---
drivers/scsi/sd_dif.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/sd_dif.c b/drivers/scsi/sd_dif.c
index
Provide a facility to use the request_firmware() interface to get a SAS
address from userspace. This can be used by SAS LLDDs that cannot
obtain the address from the host adapter.
Resend of 8 Oct. 2007 patch, now based off 2.6.25-rc2 + scsi_misc.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED
J. Wong [EMAIL PROTECTED]
---
drivers/scsi/aic94xx/aic94xx_tmf.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/aic94xx/aic94xx_tmf.c
b/drivers/scsi/aic94xx/aic94xx_tmf.c
index b52124f..4b24bd3 100644
--- a/drivers/scsi/aic94xx/aic94xx_tmf.c
+++ b
If the aic94xx chip doesn't have a SAS address in the chip's flash memory,
make libsas get one for us.
Resend of 8 Oct 2007 patch, now based off 2.6.25-rc2 + scsi_misc.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/aic94xx/aic94xx.h | 16
drivers
On Thu, Feb 07, 2008 at 06:41:25PM -0600, James Bottomley wrote:
On Mon, 2008-02-04 at 23:53 -0800, [EMAIL PROTECTED] wrote:
From: Darrick J. Wong [EMAIL PROTECTED]
It appears that the LSI SAS 1064E chip needs to be reset after a
suspend/resume cycle before the driver attempts further
On Wed, Jan 30, 2008 at 06:59:34PM +0800, Keith Hopkins wrote:
V28. My controller functions well with a single drive (low-medium load).
Unfortunately, all attempts to get the mirrors in sync fail and usually hang
the whole box.
Adaptec posted a V30 sequencer on their website; does that
Looks sane to me;
Acked-by: Darrick J. Wong [EMAIL PROTECTED]
--D
On Sun, Jan 13, 2008 at 02:20:18AM +0900, FUJITA Tomonori wrote:
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi/libsas/sas_scsi_host.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
On Mon, Jan 14, 2008 at 03:49:16PM +0100, Jan Sembera wrote:
Hi,
we have array of 16 SAS disks connected to Adaptec controllers
...
this elsewhere and I was recommended to send it to linux-scsi.
Hmm... I think Peter Bogdanovic was hitting this error recently (cc'd).
There are a lot of
code in question is ETASK. I've replaced this by
ECOMM (communications error on send) a network error code that seems to
most closely relay what ETASK meant.
Yay, cleanups :)
Acked-by: Darrick J. Wong [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-scsi
On Mon, Dec 17, 2007 at 11:40:14AM -0800, Joe Perches wrote:
drivers/scsi/scsi_transport_sas.c |2 +-
SAS bits are
Acked-by: Darrick J. Wong [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More
without warning. Change libsas to reject commands to domain
devices that have already gone away.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/libsas/sas_ata.c |4
drivers/scsi/libsas/sas_expander.c |3 +++
drivers/scsi/libsas/sas_port.c |2 ++
drivers
On Tue, Dec 04, 2007 at 05:48:33PM -0500, Jeff Garzik wrote:
As an aside, issues like this really really imply a need to move libsas
away from the old libata EH stuff (like brking did with ipr, in patches).
Hm... does the new libata EH handle the case of device was
unplugged, don't bother
On Mon, Dec 03, 2007 at 05:09:54PM +0100, Krzysztof B??aszkowski wrote:
I noticed also another failure when i removed a drive. The event was not
notified by anything (ie the block device and corresponding sg were
registered) so i run dd on this truly virtual drive.
dd reached D state (as
On Mon, Dec 03, 2007 at 02:43:09PM -0500, Jeff Garzik wrote:
But what do you mean by device removal code can get hung up? That sounds
like a bug we should fix.
At the moment, libsas' sas_rphy_remove function doesn't distinguish between
removing a device before or after the disk has been
Update sas_ata to use the new ata_sas_rphy mechanisms as provided by
Brian King, and simplify ATA device discovery...
WARNING WARNING WARNING! This patch is experimental, use at your own
risk.
Comments-requested-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/libsas/sas_ata.c
.
jgarzik: If an ATA command was in-progress at the time of a port freeze,
can complete after thawing? (Does that even make sense?)
Comments-requested-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/libsas/sas_ata.c | 86 ++---
1 files changed, 71
On Mon, Nov 05, 2007 at 06:07:29PM +0100, Adrian Bunk wrote:
This patch contains the following cleanups:
- static functions in .c files shouldn't be marked inline
- make needlessly global code static
- #if 0 unused code
asd_unpause_lseq can be removed; the other if 0'd functions are debug
sparse complains about the mixing of enums in libsas. Since the
underlying numeric values of both enums are the same, combine them
to get rid of the warning.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/aic94xx/aic94xx_dev.c |6 +++---
drivers/scsi/aic94xx
Annotate sas_queuecommand with locking details, and clean up a few
more sparse warnings about static/non-static declarations.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/libsas/sas_scsi_host.c |6 +-
include/scsi/libsas.h |4 +---
2 files changed
On Tue, Oct 09, 2007 at 09:41:47AM -0700, Andrew Vasquez wrote:
On Tue, 09 Oct 2007, James Smart wrote:
Why do you prefer request_firmware() vs something over sysfs ?
Does environments like the kdump kernel also have access to data needed
by request_firmware() ?
Assuming the
.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/aic94xx/aic94xx.h |1 -
drivers/scsi/aic94xx/aic94xx_hwi.c | 40 +--
drivers/scsi/aic94xx/aic94xx_init.c |2 --
3 files changed, 29 insertions(+), 14 deletions(-)
diff --git a/drivers
On Mon, Oct 08, 2007 at 03:48:32PM -0700, Andrew Vasquez wrote:
So how about factoring that out to a transport-level interface. How
about something along the lines of the following patch, whereby the
software driver upon detecting no valid WWPN, makes an upcall to each
interface's
Use the request_firmware() interface to get a SAS address from userspace.
This way, there's no debate as to who or how an address gets generated;
it's up to the administrator to provide one if the driver can't find one
on its own.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers
If the aic94xx chip doesn't have a SAS address in the chip's flash memory,
make libsas get one for us. Also clean out some old code that had been
used to do this in the past.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/aic94xx/aic94xx.h | 16
On Tue, Oct 02, 2007 at 04:51:48PM -0600, Moore, Eric wrote:
I replied to this thread a couple times last week, and no response from
Darrick. I doubt this is required becase the MESSAGE_UNIT_RESET is
issued from inside mpt_do_ioc_recovery. I need some logs with debug
enabled. Darrick did
On Sat, Sep 29, 2007 at 02:25:33AM -0400, Jeff Garzik wrote:
Muli Ben-Yehuda wrote:
On Fri, Sep 28, 2007 at 04:55:34PM -0700, Darrick J. Wong wrote:
On Thu, Sep 27, 2007 at 10:33:41PM -0400, Jeff Garzik wrote:
Unless I'm missing something, the SMP request goes /to/ the PCI device
:)
Signed
On Thu, Sep 27, 2007 at 10:33:41PM -0400, Jeff Garzik wrote:
Unless I'm missing something, the SMP request goes /to/ the PCI device :)
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
ACK; builds ok and SMP commands seem to work ok (not that they didn't
before).
--Darrick
---
On Thu, Sep 20, 2007 at 07:06:35PM -0600, Moore, Eric wrote:
Darrick - MESSAGE_UNIT_RESET is already issued from inside
mpt_do_ioc_recovery(), so you don't need to send this in advance of
that.YOu will find that occuring from the function MakeIocReady.
Anyways... would it be possible for
IOC facts reply, msgLength=0 offsetof=6!
So far it seems to fix suspend/resume on all the MPT Fusion cards I have
(SAS and U320 SCSI) but since I don't know the internals of that chip I
can't say for sure if this is a proper fix.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers
Randy Dunlap scolded me for introducing poorly styled code. Since it
was a copy-and-paste block from mpt_suspend(), fix both.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/message/fusion/mptbase.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git
sas_smp_handler crashes when smp utils are used with an aic94xx host
because certain devices (the sas_host itself, specifically) lack rphy
structures. No rphy means no SMP target support, but we shouldn't crash
here.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/libsas
On Fri, Jun 22, 2007 at 02:26:29PM +0100, Alan Cox wrote:
@@ -244,7 +242,7 @@
if (check_signature(base +
signatures[sig].offset, signatures[sig].string,
strlen(signatures[sig].string))) {
addr =
On Sun, May 27, 2007 at 05:37:43PM +, James Bottomley wrote:
[SCSI] libsas: convert to use the data buffer accessors
snip
This patch is pending because it requires ACKs from:
Darrick J. Wong [EMAIL PROTECTED]
ACK.
--D
-
To unsubscribe from this list: send the line unsubscribe linux
tasks. I _think_ this will fix one of
the SCB timeout crash problems (though I've not been able to reproduce
it lately...)
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/aic94xx/aic94xx_tmf.c | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git
Constantin Teodorescu wrote:
03:02:15 kernel: [ cut here ]
03:02:15 kernel: kernel BUG at drivers/scsi/aic94xx/aic94xx_hwi.h:354!
On the odd chance you still have this controller (and have the time to
test out patches), would you mind applying this patch:
that affect
the driver in order to detect if an incomplete shutdown of the Adapter
had occurred (kdump).
Tests out ok on the affected machines, so:
Acked-by: Darrick J. Wong [EMAIL PROTECTED]
--D
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message
Salyzyn, Mark wrote:
In my unit tests of aacraid_kexec_5.patch, restart was not called for
normal operations. If you are just doing a normal boot, what conditions
are causing restart to be called in your case? Is it a warm restart?
Some kind of operation that leaves the Adapter in an
Salyzyn, Mark wrote:
As an option for a patch (later), what was the actual value of the
Munit.OIMR register (on the x3550 and the x3650 please, just in case)?
0xF.
--D
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More
Constantin Teodorescu wrote:
So ... should I ask for other controller quotation ?
Could you recommend me a good SAS controller, with 8 internal ports,
supporting Linux , with 99.% reliability ? :-)
I have the following options : Intel® RAID Controller SRCSAS18E
(Parowan) and LSI
to crash at startup. Move the initializers (we need both
rx_sync_cmd and enable_int pointers) further up to proceed the
restart_adapter call.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/aacraid/rx.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git
Douglas Gilbert wrote:
So that is almost 12 months that I have been reporting
this driver as broken. Is it just me or my hardware?
I seem to recall you saying that the LSI Fusion card was plugged into
the same expander as the 48300? If so, does unplugging the Fusion card
from the expander
Per Tejun's request, rename the lldd_task field and add comments about it.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/libsas/sas_ata.c |8
include/linux/libata.h|4 +++-
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi
We don't need to reset the SAS phy in sas_ata_post_internal; all
that is necessary is to clear out the task from the SAS HA.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/libsas/sas_ata.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers
John Scarpa wrote:
First a very big thanks to all of u! I have been suffering a serious
lack of sleep problem lately.. i should have noticed that by whom has
been submitting the past 500 fixes and updates!
Quick question, is the driver still consider experimental??
Very much so. The SAS
James Bottomley wrote:
The problem is that memory obtained by devm_kzalloc() cannot be returned
by kfree() ... they come from different allocation lists. The solution
is probably to have a corresponding ata_probe_ent_free(), I just don't
exactly see how to tell if the object came from the
Orion Poplawski wrote:
I'm thinking about trying to setup a two node HA storage cluster
connected to an external SAS box. Is such a thing possible at this time?
I've had success with aic94xx + dm_multipath before. There has recently
been a bug in the multipath tools wherein it fails to detect
Mark Rustad wrote:
I have systems with Supermicro X6-class (Nocona/Lindenhurst)
motherboards with Adaptec SCSI and SAFTE backplanes running software
RAID-1 (md) on a pair of drives. When I hot-insert a drive, I get a lot
of noise from the kernel apparently due to lack of handling something in
Wu, Gilbert wrote:
Hi James,
We are investigating this issue here. We will update the status when
we can duplicate the problem here and root cause.
FWIW,
v17 looks good for both SAS/SATA load testing. The 24-disk x260 seems
to have crapped out after about 800 rounds of load/unload due to
James Bottomley wrote:
On Tue, 2007-01-30 at 01:19 -0800, Darrick J. Wong wrote:
Break out sas_ata as a free-standing module that provides a SATA
Translation Layer (SATL) for libsas. This patch requires the libsas
SATL registration patch; the changes to sas_ata itself are rather
minor
James Bottomley wrote:
There's a problem somewhere with your error handler changes (which I
picked up thanks to the problems with the V28 firmware). What I see
without your changes is that for a directly attached SATA device, when
the firmware begins its death spiral, the commands all return
Hi all,
This is a roll-up of all of my ATA related uncommitted patches against
libsas and aic94xx to date. Per James Bottomley's request, I'm pushing
these patches out for further review in aic94xx-sas. The big changes in
this patch set are a lot of bug and locking fixes, the conversion of the
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/libsas/Kconfig |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libsas/Kconfig b/drivers/scsi/libsas/Kconfig
index aafdc92..b64e391 100644
--- a/drivers/scsi/libsas/Kconfig
+++ b/drivers/scsi
tested this against an IBM x206m with two SATA disks with no
BUG messages and no other signs of things going wrong, and the machine
finally passed the pounder stress test.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/libsas/sas_ata.c |4
drivers/scsi/libsas
1 - 100 of 163 matches
Mail list logo
