[PATCH 01/48] hpsa: correct endian sparse warnings

Correct endiness issues reported by sparse. SA controllers are little endian. This patch ensures endiness correctness. Signed-off-by: Don Brace don.br...@pmcs.com Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Webb Scales web...@hp.com --- drivers/scsi/hpsa.c | 275

[PATCH 02/48] hpsa: fix memory leak in kdump hard reset

From: Tomas Henzl the...@redhat.com There is a potential memory leak in hpsa_kdump_hard_reset_controller. Reviewed-by: Don Brace don.br...@pmcs.com Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Tomas Henzl the...@redhat.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers

[PATCH 00/48] hpsa driver updates

- performance enhancements. - removal of command queueing in driver - elimination of race conditions around aborts - change to internal driver workqueues --- Don Brace (11): hpsa: correct endian sparse warnings hpsa: change how SA controllers are reset hpsa: correct

[PATCH 03/48] hpsa: turn off interrupts when kdump starts

the hpsa_kdump_hard_reset_controller fixes it. At this point we can't know in which state the card is, so using SA5_INTR_OFF + SA5_REPLY_INTR_MASK_OFFSET defines directly, instead of the function the drivers provides, seems to be apropriate. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br

[PATCH 07/48] hpsa: rename free_irqs to hpsa_free_irqs

From: Robert Elliott elli...@hp.com Change the function names to have hpsa prefix. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 43 ++- 1

[PATCH 15/48] hpsa: trivial message and comment clean ups

From: Stephen Cameron stephenmcame...@gmail.com Cleanup comments to be more specific. Make messages more informational. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 21

[PATCH 17/48] hpsa: rename hpsa_request_irq to hpsa_request_irqs

From: Robert Elliott elli...@hp.com Make the function name more descriptive. We use more than one interrupt. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 11 ++- 1 file

[PATCH 08/48] hpsa: Fix -Wunused-but-set-variable warning

From: Fabian Frederick f...@skynet.be Remove unused variable in hpsa_free_cmd_pool. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Fabian Frederick f...@skynet.be Acked-by: Don Brace don.br...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |4

[PATCH 20/48] hpsa: fix memory leak in hpsa_alloc_cmd_pool

From: Robert Elliott elli...@hp.com Partial allocation failure wasn't handled correctly Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |6 +- 1 file changed, 5 insertions(+), 1

[PATCH 19/48] hpsa: report allocation failures while allocating SG chain blocks

From: Robert Elliott elli...@hp.com Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b

[PATCH 16/48] hpsa: report failure to ioremap config table

From: Robert Elliott elli...@hp.com Enhance error reporting. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 18/48] hpsa: pass error from pci_set_consistent_dma_mask from hpsa_message

From: Robert Elliott elli...@hp.com Return the actual error code instead of a generic error code. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion

[PATCH 46/48] hpsa: detect and report failures changing controller transport modes

hpsa_wait_for_mode_change_ack and all their callers check/propagate the result. More consistency in printing errors and whether dev_err is used. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 40

[PATCH 47/48] hpsa: add in gen9 controller model names

Add in gen9 controller model names Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index

[PATCH 45/48] hpsa: shorten the wait for the CISS doorbell mode change ack

uninterruptible usleep_range(), which triggers rt_sched timeout errors if the wait is long. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 15 +-- 1 file changed, 9 insertions

[PATCH 43/48] hpsa: move SG descriptor set-up out of hpsa_scatter_gather()

a conditional operation from inside the loop. The case for which the conditional formerly tested is now executed (unconditionally) after the loop is exited. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Webb Scales web...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi

[PATCH 48/48] hpsa: add in P840ar controller model name

Add in P840ar model name for gen9 Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 6568da5..15ef65c 100644

[PATCH 42/48] hpsa: do not use function pointers in fast path command submission

From: Stephen Cameron stephenmcame...@gmail.com Performance tweak, avoid unnecessary function calls. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |8 +--- drivers/scsi/hpsa.h |5 + 2 files changed, 6 insertions

[PATCH 28/48] hpsa: use per-controller work queue

a driver specific, per-controller work queue avoids this. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Webb Scales web...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 16 +--- drivers/scsi/hpsa.h |1 + 2 files changed, 14 insertions(+), 3

[PATCH 24/48] hpsa: do not queue commands internally in driver

-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 306 +-- drivers/scsi/hpsa.h | 17 --- drivers/scsi/hpsa_cmd.h | 10 -- 3 files changed, 38 insertions(+), 295 deletions(-) diff --git

[PATCH 29/48] hpsa: honor queue depth of physical devices

to parity drives. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Webb Scales web...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 318 +-- drivers/scsi/hpsa.h | 14 ++ drivers/scsi/hpsa_cmd.h | 148

[PATCH 25/48] hpsa: do not request device rescan on every ioaccel path error

...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 14 ++ drivers/scsi/hpsa.h |1 - 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 70f07af..94a82e3 100644 --- a/drivers/scsi/hpsa.c

[PATCH 23/48] hpsa: get rid of cmd_special_alloc and cmd_special_free

-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 106 ++- drivers/scsi/hpsa.h |2 - 2 files changed, 31 insertions(+), 77 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 99c32a0..26e3e5b 100644 --- a/drivers

[PATCH 22/48] hpsa: reserve some commands for use by driver

commands internally in the driver so that we can remove the locks thta protect the queue that we will no longer have. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |7 +-- drivers/scsi/hpsa.h |2 ++ 2 files changed, 7

[PATCH 27/48] hpsa: use workqueue to resubmit failed ioaccel commands

, and prevent excessive rescanning of devices. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 60 --- drivers/scsi/hpsa_cmd.h |1 + 2 files changed, 42 insertions(+), 19 deletions

[PATCH 26/48] hpsa: factor out hpsa_ciss_submit function

of the ioaccellerated paths but which have some sort of error condition are retried down the normal path. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 126 +++ 1 file changed, 67

[PATCH 34/48] hpsa: do not check for msi(x) in interrupt_pending

From: Stephen Cameron stephenmcame...@gmail.com No need to check whether interrupt pending for MSI(X) and conversely, no need to check whether MSI(X) interrupts are being used when checking if interrupts are pending. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br

[PATCH 31/48] hpsa: optimize cmd_alloc function by remembering last allocation

-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |7 +-- drivers/scsi/hpsa.h |1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index c95a20c..72abcf3 100644

[PATCH 21/48] hpsa: avoid unneccesary calls to resource freeing functions

(relevant pointers would be NULL) but it is potentially confusing. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 30/48] hpsa: fix race between abort handler and main i/o path

hpsa_drain_accel_commands to use the reference count as the authoritative indicator of whether a command is allocated instead of the h-cmd_pool_bits bitmap. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 109

[PATCH 37/48] hpsa: guard against overflowing raid map array

-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index afd192d..03fae8a 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -3921,6

[PATCH 40/48] hpsa: do not use a void pointer for scsi_cmd field of struct CommandList

From: Stephen Cameron stephenmcame...@gmail.com There's no reason for it to be a void *, it should be a struct scsi_cmnd * Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |6 +++--- drivers/scsi/hpsa_cmd.h |2 +- 2

[PATCH 41/48] hpsa: print CDBs instead of kernel virtual addresses for uncommon errors

From: Stephen Cameron stephenmcame...@gmail.com Printing the address of the command pointer is of little value, change to print the CDB. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 29 - 1 file

[PATCH 38/48] hpsa: check for ctlr lockup after command allocation in main io path

...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 03fae8a..834ac78 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -4097,8 +4097,15

[PATCH 36/48] hpsa: do not ack controller events on controllers that do not support it

From: Stephen Cameron stephenmcame...@gmail.com Acking controller events on controllers that do not support it can cause such controllers to lock up. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Joe Handzik joseph.t.hand...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com

[PATCH 35/48] hpsa: remove incorrect BUG_ONs checking for raid offload enable

accel commands could still be in flight, ie. perhaps having just been submitted into hpsa_scsi_ioaccel_raid_map concurrent with -offload_enabled having just been set to zero. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |4 1

[PATCH 33/48] hpsa: slightly optimize SA5_performant_completed

Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h index 1856445..aa6cb0b 100644 --- a/drivers/scsi/hpsa.h +++ b

[PATCH 32/48] hpsa: count passthru cmds with atomics, not a spin locked int

Performance enhancement. Remove spin_locks from the driver. Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c | 39 +-- drivers/scsi/hpsa.h |3 +-- 2 files changed, 6 insertions(+), 36

[PATCH 39/48] hpsa: return failed from device reset/abort handlers

-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 834ac78..a02ea7f 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -4343,6 +4343,10 @@ static int

[PATCH 02/13] hpsa: remove dev_warn prints from RAID-1ADM

From: Robert Elliott elli...@hp.com RAID-1ADM is unusable with dev_warn called on every command. Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com Reviewed-by: Stephen M. Cameron stephenmcame...@gmail.com Reviewed-by: Webb Scales web...@hp.com --- drivers

[PATCH 01/13] hpsa: Clean up warnings from sparse.

Clean up issues reported when running sparse. Signed-off-by: Don Brace don.br...@pmcs.com Reviewed-by: Webb Scales webb.sca...@hp.com --- drivers/scsi/hpsa.c | 29 - drivers/scsi/hpsa.h |6 +++--- 2 files changed, 19 insertions(+), 16 deletions(-) diff --git

[PATCH 00/13] hpsa update

This patch set is based on Linus's tree. The changes are: - correct warnings from sparse - updates for some error handling issues - general code cleanup - performance enhancements based on removing spin_locks --- Don Brace (1): hpsa: Clean up warnings from sparse. Nicholas Bellinger

[PATCH 08/13] hpsa: get rid of type/attribute/direction bit field where possible

of the userland ABI. Signed-off-by: Don Brace don.br...@pmcs.com Reviewed-by: Webb Scales webb.sca...@hp.com --- drivers/scsi/hpsa.c | 58 --- drivers/scsi/hpsa_cmd.h | 18 +++ 2 files changed, 42 insertions(+), 34 deletions(-) diff

[PATCH 11/13] hpsa: Convert SCSI LLD -queuecommand() for host_lock less operation

From: Nicholas Bellinger n...@linux-iscsi.org There isn't anything in hpsa that requires the host lock to be held during queuecommand. Signed-off-by: Don Brace don.br...@pmcs.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org Reviewed-by: Stephen M. Cameron stephenmcame...@gmail.com

[PATCH 07/13] hpsa: fix endianness issue with scatter gather elements

). Signed-off-by: Don Brace don.br...@pmcs.com Signed-off-by: Robert Elliott elli...@hp.com Reviewed-by: Webb Scales web...@hp.com --- drivers/scsi/hpsa.c | 223 +-- drivers/scsi/hpsa_cmd.h | 14 +-- 2 files changed, 107 insertions(+), 130 deletions

[PATCH 04/13] hpsa: correct off-by-one sizing of chained SG block

From: Webb Scales web...@hp.com Correct the size calculation of the chained SG block Signed-off-by: Don Brace don.br...@pmcs.com Signed-off-by: Webb Scales web...@hp.com Reviewed-by: Stephen M. Cameron stephenmcame...@gmail.com Reviewed-by: Don Brace don.br...@pmcs.com --- drivers/scsi/hpsa.c

[PATCH 06/13] hpsa: fix allocation sizes for CISS_REPORT_LUNs commands

and physical sizes separately. Allocate the memory based on the specific data structure sizes. Signed-off-by: Don Brace don.br...@pmcs.com Reviewed-by: Webb Scales webb.sca...@hp.com --- drivers/scsi/hpsa.c | 14 +++--- drivers/scsi/hpsa_cmd.h |2 +- 2 files changed, 8 insertions(+), 8

[PATCH 10/13] hpsa: do not be so noisy about check conditions

From: Stephen M. Cameron stephenmcame...@gmail.com We were printing a lot of useless information before ultimately just passing things up to the SCSI mid layer. Just let the midlayer handle it without LLD chatter. Signed-off-by: Don Brace don.br...@pmcs.com Signed-off-by: Stephen M. Cameron

[PATCH 12/13] hpsa: always call pci_set_master after pci_enable_device

that after pci_request_regions both in the kdump code and the normal pci_init code. Remove the comment summarizing what pci_set_master does, with the incomplete commentary on the impact of pci_disable_device. Signed-off-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com

[PATCH 09/13] hpsa: use atomics for commands_outstanding

From: Stephen M. Cameron stephenmcame...@gmail.com Use atomics for commands_outstanding instead of protecting with spin locks. Signed-off-by: Don Brace don.br...@pmcs.com Signed-off-by: Stephen M. Cameron stephenmcame...@gmail.com Reviewed-by: Joe Handzik joseph.t.hand...@hp.com --- drivers

[PATCH 05/13] hpsa: remove 'action required' phrasing

From: Stephen M. Cameron stephenmcame...@gmail.com In the case of LUN data changing, the driver will auto rescan and so it's not even true that action is required. Remove action required phrases from warning messages and replace with description phrases. Signed-off-by: Don Brace don.br

[PATCH 13/13] hpsa: remove spin lock around command allocation

From: Stephen M. Cameron stephenmcame...@gmail.com It is already using atomic test_and_set_bit to do the allocation. There is some microscopic chance of starvation, but it is so microscopic that it should never happen in reality. Signed-off-by: Don Brace don.br...@pmcs.com Reviewed-by: Webb

[PATCH 03/13] hpsa: fix a couple pci id table mistakes

From: Stephen M. Cameron scame...@beardog.cce.hp.com Fix a couple of pci id table mistakes: Subdevice ID 0x3323 missing from product[] table (another name for HP Smart Storage 1210m) Bogus 0x1925 subdevice id removed from hpsa_pci_device_id[] (no such thing.) Signed-off-by: Don Brace

Re: [PATCH 1/1 linux-next] hpsa: remove set but unused variable rc

of patches for 3.19 or ack this now, What would you prefer? --- Don Brace don.br...@pmcs.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] MAINTAINERS: Change hpsa and cciss maintainer

Change ownership of the hpsa driver from Stephen M. Cameron (Hewlett-Packard) to Don Brace (PMC-Sierra). Change ownership of the cciss driver from Mike Miller (Hewlett-Packard) to Don Brace (PMC-Sierra). Reviewed-by: Robert Elliott elli...@hp.com Signed-off-by: Don Brace don.br...@pmcs.com

<    4   5   6   7   8   9