iommu code merges sg segments without considering lld's sg segment
restrictions. iommu code can't access to the limitations because they
are in request_queue. This patch adds max_segment_size to device
structure. seg_boundary_mask will be added too later.
Signed-off-by: FUJITA Tomonori [EMAIL
This enables pci-gart iommu to merge sg lists properly about lld's max
segment size limit.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
arch/x86_64/kernel/pci-gart.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/arch/x86_64/kernel/pci-gart.c b/arch/x86_64
This removes blk_queue_max_segment_size and uses dma_max_segment_size
in scsi_host_template.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/ata/sata_inic162x.c | 19 +++
1 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/ata/sata_inic162x.c b
scsi_add_host sets shost_gendev.parent-max_segment_size to enables
iommu code to merge sg lists properly about lld's max segment size
limit.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi/hosts.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git
iommu code merges sg lists without considering lld's restrictions so
some llds need a workaround to split sg lists again. This patchset
fixes iommu to handle lld's max segment size limit properly.
The problem is that iommu code can't access to the restrictions
because they are in request_queue.
-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi/hosts.c |5 +
drivers/scsi/scsi_lib.c |1 +
include/scsi/scsi_host.h |6 ++
3 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 96bc312..22877d3 100644
On Wed, 26 Sep 2007 06:11:45 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
This patch moves blk_queue_max_segment_size to scsi_alloc_queue from
llds. It enables scsi_add_host to tells iommu lld's
dma_max_segment_size. If a low-level driver doesn't specify
On Wed, 26 Sep 2007 12:02:21 +0200
Muli Ben-Yehuda [EMAIL PROTECTED] wrote:
On Wed, Sep 26, 2007 at 05:57:57PM +0900, FUJITA Tomonori wrote:
iommu code merges sg lists without considering lld's restrictions so
some llds need a workaround to split sg lists again. This patchset
fixes iommu
On Wed, 26 Sep 2007 09:38:32 -0500
James Bottomley [EMAIL PROTECTED] wrote:
On Wed, 2007-09-26 at 23:34 +0900, FUJITA Tomonori wrote:
Yeah, I thought about it and it's possible (but not so easy). parisc
has IOMMU merging helper code and two parisc IOMMUs use it. ia64
sba_iommu is almost
On Wed, 26 Sep 2007 09:05:58 -0700
Greg KH [EMAIL PROTECTED] wrote:
On Wed, Sep 26, 2007 at 05:58:01PM +0900, FUJITA Tomonori wrote:
iommu code merges sg segments without considering lld's sg segment
restrictions. iommu code can't access to the limitations because they
are in request_queue
On Wed, 26 Sep 2007 10:42:06 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
On Wed, 26 Sep 2007 06:11:45 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
This patch moves blk_queue_max_segment_size to scsi_alloc_queue from
llds. It enables
On Tue, 25 Sep 2007 20:42:35 -0500
James Bottomley [EMAIL PROTECTED] wrote:
On Wed, 2007-09-26 at 10:28 +0900, FUJITA Tomonori wrote:
On Tue, 25 Sep 2007 20:00:02 -0500
James Bottomley [EMAIL PROTECTED] wrote:
Andrew asked that I provide a status report of pending updates. The
list
On Tue, 25 Sep 2007 22:37:33 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index adc9559..694015d 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -342,6 +342,10 @@ struct Scsi_Host
On Tue, 25 Sep 2007 22:45:53 -0500
James Bottomley [EMAIL PROTECTED] wrote:
On Tue, 2007-09-25 at 23:34 -0400, Jeff Garzik wrote:
Matthew Wilcox wrote:
On Tue, Sep 25, 2007 at 10:37:33PM -0400, Jeff Garzik wrote:
Are there any const-ness worries for scsi_host_template, or plans for
On Tue, 25 Sep 2007 23:01:53 -0500
James Bottomley [EMAIL PROTECTED] wrote:
On Wed, 2007-09-26 at 12:55 +0900, FUJITA Tomonori wrote:
On Tue, 25 Sep 2007 22:45:53 -0500
James Bottomley [EMAIL PROTECTED] wrote:
On Tue, 2007-09-25 at 23:34 -0400, Jeff Garzik wrote:
Matthew Wilcox
On Tue, 25 Sep 2007 22:45:53 -0500
James Bottomley [EMAIL PROTECTED] wrote:
On Tue, 2007-09-25 at 23:34 -0400, Jeff Garzik wrote:
Matthew Wilcox wrote:
On Tue, Sep 25, 2007 at 10:37:33PM -0400, Jeff Garzik wrote:
Are there any const-ness worries for scsi_host_template, or plans for
On Sun, 23 Sep 2007 15:19:13 +0200
Torsten Kaiser [EMAIL PROTECTED] wrote:
On 9/21/07, Jens Axboe [EMAIL PROTECTED] wrote:
SG chaining bits:
- This is the bulk of the patchset. It consists of three major
components:
- sglist-core, which add helpers for iterating sg lists and
On Tue, 18 Sep 2007 12:18:40 +0200
Jens Axboe [EMAIL PROTECTED] wrote:
On Mon, Sep 17 2007, FUJITA Tomonori wrote:
On Mon, 17 Sep 2007 15:28:19 +0200
Jens Axboe [EMAIL PROTECTED] wrote:
On Sat, Sep 15 2007, FUJITA Tomonori wrote:
On Fri, 14 Sep 2007 21:16:35 -0700
Paul Jackson
On Mon, 17 Sep 2007 15:28:19 +0200
Jens Axboe [EMAIL PROTECTED] wrote:
On Sat, Sep 15 2007, FUJITA Tomonori wrote:
On Fri, 14 Sep 2007 21:16:35 -0700
Paul Jackson [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
Can you try this patch (against 2.6.23-rc4-mm1)?
From
+0x21a): undefined reference to `isa_unregister_driver'
make[1]: *** [.tmp_vmlinux1] Error 1
make[1]: Leaving directory `/home/fujita/git/linux-2.6'
make: *** [debian/stamp-build-kernel] Error 2
Is this already fixed like this?
-
From: FUJITA Tomonori [EMAIL PROTECTED]
Subject: [PATCH] isa: add fake
On Sun, 16 Sep 2007 17:03:50 -0600
Matthew Wilcox [EMAIL PROTECTED] wrote:
On Mon, Sep 17, 2007 at 07:41:06AM +0900, FUJITA Tomonori wrote:
On Sun, 16 Sep 2007 09:31:34 -0600
Matthew Wilcox [EMAIL PROTECTED] wrote:
On Sat, Sep 15, 2007 at 09:39:05AM -0500, James Bottomley wrote:
I
On Fri, 14 Sep 2007 21:16:35 -0700
Paul Jackson [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
Can you try this patch (against 2.6.23-rc4-mm1)?
From 592bd2049cb3e6e1f1dde7cf631879f26ddffeaa Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori [EMAIL PROTECTED]
Date: Mon, 10 Sep 2007 04:17
On Sat, 15 Sep 2007 14:30:10 +0200
Stefan Richter [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
On Sat, 15 Sep 2007 08:16:03 +0200
Stefan Richter [EMAIL PROTECTED] wrote:
Or would be for newer SCSI transports such as Fibre Channel,
FireWire storage, iSCSI, SAS, and more, be OK
On Fri, 14 Sep 2007 14:43:43 -0700
Dave Jiang [EMAIL PROTECTED] wrote:
I'm using the latest linus git tree. This is in fileio mode with
IOMode=wb. It seems that if I do I/O and then immediately disconnect
then the cache sync commands fail. Is this expected behavior or should
the connection
On Sat, 15 Sep 2007 23:07:10 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
The majority of llds don't set supported_mode in scsi_host_template so
we get:
luce:/sys/class/scsi_host/host0$ cat supported_mode
unknown
It's harmless but it would be better to get
On Fri, 14 Sep 2007 23:14:21 +0200 (CEST)
Stefan Richter [EMAIL PROTECTED] wrote:
Signed-off-by: Stefan Richter [EMAIL PROTECTED]
---
And one more update:
There is SAS too, and I forgot 'is' in on a disk which __ accessed via.
drivers/scsi/Kconfig | 67
.
Even if we revert the qla1280 patch, scsi-ml still sends chaining sg
list. So it doesn't work.
The following patch disables chaining sg list for qla1280. If the fix
that I've just sent doesn't work, please try this.
-
From: FUJITA Tomonori [EMAIL PROTECTED]
Subject: [PATCH] add use_sg_chaining
On Mon, 10 Sep 2007 12:20:38 -0700
Andrew Morton [EMAIL PROTECTED] wrote:
On Mon, 10 Sep 2007 20:59:49 +0200 Torsten Kaiser [EMAIL PROTECTED] wrote:
On 9/10/07, Andrew Morton [EMAIL PROTECTED] wrote:
On Mon, 10 Sep 2007 18:49:26 +0100 Andy Whitcroft [EMAIL PROTECTED]
wrote:
I
calls to -queuecommand
This is on the top of the patchset. Can I get your ACK on it?
This depends on scsi-misc, the patchset, and sg chaining stuff.
--
From: FUJITA Tomonori [EMAIL PROTECTED]
Subject: [PATCH] advansys: convert to use the data buffer accessors
- remove the unnecessary map_single
is git-block.patch. From a quick
squizz the change looks OK, although it's tricky and something might have
broken.
Can you try this patch (against 2.6.23-rc4-mm1)?
From 592bd2049cb3e6e1f1dde7cf631879f26ddffeaa Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori [EMAIL PROTECTED]
Date: Mon, 10 Sep 2007 04
On Sun, 09 Sep 2007 11:25:57 +0300
Boaz Harrosh [EMAIL PROTECTED] wrote:
On Fri, Sep 07 2007 at 0:50 +0300, FUJITA Tomonori [EMAIL PROTECTED] wrote:
This patchset, which I submitted before, adds a new data structure,
scsi_data_buffer, including everything for data transfer:
struct
On Sun, 09 Sep 2007 17:28:41 +0300
Boaz Harrosh [EMAIL PROTECTED] wrote:
On Sun, Sep 09 2007 at 16:47 +0300, FUJITA Tomonori [EMAIL PROTECTED] wrote:
On Sun, 09 Sep 2007 13:12:03 +0300
Boaz Harrosh [EMAIL PROTECTED] wrote:
On Fri, Sep 07 2007 at 0:50 +0300, FUJITA Tomonori [EMAIL
On Sun, 9 Sep 2007 23:38:55 +0900
FUJITA Tomonori [EMAIL PROTECTED] wrote:
On Sun, 09 Sep 2007 17:28:41 +0300
Boaz Harrosh [EMAIL PROTECTED] wrote:
On Sun, Sep 09 2007 at 16:47 +0300, FUJITA Tomonori [EMAIL PROTECTED]
wrote:
On Sun, 09 Sep 2007 13:12:03 +0300
Boaz Harrosh [EMAIL
On Sun, 09 Sep 2007 17:09:15 +0300
Boaz Harrosh [EMAIL PROTECTED] wrote:
On Sun, Sep 09 2007 at 16:47 +0300, FUJITA Tomonori [EMAIL PROTECTED] wrote:
On Sun, 09 Sep 2007 11:25:57 +0300
Boaz Harrosh [EMAIL PROTECTED] wrote:
On Fri, Sep 07 2007 at 0:50 +0300, FUJITA Tomonori [EMAIL
about the sg chaining's scsi_lib.c?
--
From b887de7c48a674ace622544addd70ebc8ae31fd2 Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori [EMAIL PROTECTED]
Date: Thu, 6 Sep 2007 08:41:33 +0100
Subject: [PATCH] remove sglist_len
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi/scsi_lib.c
From: Boaz Harrosh [EMAIL PROTECTED]
This is a minimal patch needed if we want to use the new
scsi_data_buffer implementation, by useing of the new data
accessors. But it is not a complete clean up of the !use_sg path.
Libata-core still has the qc-flags ATA_QCFLAG_SG and !qc-n_elem
code paths.
From: Boaz Harrosh [EMAIL PROTECTED]
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/sd.c |6 +++---
drivers/scsi/sr.c | 25 +
2 files changed, 16 insertions(+), 15 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index
- remove the unnecessary map_single path.
- convert to use the new accessors for the sg lists and the parameters.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi/qla1280.c | 369
1 files changed, 154 insertions(+), 215
From: Boaz Harrosh [EMAIL PROTECTED]
- remove the unnecessary map_single path.
- convert to use the new accessors for the sg lists and the
parameters.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/scsi_debug.c | 36 ++--
1 files changed, 10
This just blindly converts ide-scsi to use the new accessors for the
sg lists and the parameters.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi/ide-scsi.c | 23 ---
1 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/ide-scsi.c
From: Boaz Harrosh [EMAIL PROTECTED]
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/scsi_error.c | 29 +++--
1 files changed, 11 insertions(+), 18 deletions(-)
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index 8a525ab..af39a39
This patchset, which I submitted before, adds a new data structure,
scsi_data_buffer, including everything for data transfer:
struct scsi_data_buffer {
unsigned length;
int resid;
short sg_count;
short __sg_count;
struct scatterlist *sglist;
};
One
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi/scsi_tgt_if.c |2 +-
drivers/scsi/scsi_tgt_lib.c | 27 ++-
2 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/scsi_tgt_if.c b/drivers/scsi/scsi_tgt_if.c
index ca22ddf
This adds a new data structure, scsi_data_buffer, including scsi data
transfer. One scsi_data_buffer structure is embedded in struct
scsi_cmnd for uni-directional transfer.
This is a preparation for bidirectional support.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi
On Wed, 5 Sep 2007 08:05:34 -0700
Andrew Vasquez [EMAIL PROTECTED] wrote:
On Sat, 01 Sep 2007, FUJITA Tomonori wrote:
This adds target mode support to qla2xxx.
With set ql2enable_target_mode module parameter to 1, the driver runs
in target mode. By default, ql2enable_target_mode
2001
From: FUJITA Tomonori [EMAIL PROTECTED]
Date: Sat, 18 Aug 2007 19:00:47 +0900
Subject: [PATCH 1/2] revert sg segment size ifdefs
This reverts sg segment size ifdefs that the current code has in order
to provide a way to reduce sgpool memory consumption.
Signed-off-by: FUJITA Tomonori [EMAIL
Jeff, can I get your ACK on this patch?
Whatever in a request queue we set, iommu code ignores all the sg list
limitations.
---
From 703d5158361bb6a4ecdc5cd9a6961a8cfb419f73 Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori [EMAIL PROTECTED]
Date: Mon, 3 Sep 2007 06:49:11 +0100
Subject: [PATCH 2/2
On Mon, 03 Sep 2007 13:00:43 -0400
Douglas Gilbert [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
On Sun, 2 Sep 2007 04:56:01 -0700
Andrew Morton [EMAIL PROTECTED] wrote:
Begin forwarded message:
Date: Mon, 27 Aug 2007 15:01:33 +0100
From: Luciano Rocha [EMAIL PROTECTED
is 60. So, in your case, only the first 36 bytes are
valid. But I guess that it's not good to leak random kernel data to
user-space.
Can you try this patch?
---
From 2529dbda52ac2302eab9838910d59e13dedeb3bd Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori [EMAIL PROTECTED]
Date: Sun, 2 Sep 2007 13:32
This patchset adds target mode support to fc transport class and
qla2xxx driver. The pathset is against scsi-misc.
The target mode support for fc transport class works in the same way
as srp transport class. fc_remote_port_{rolechg,delete} calls
scsi_tgt_it_nexus_{create,destroy} for target
should use host-can_queue instead of host-hostt-can_queue.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
Signed-off-by: Mike Christie [EMAIL PROTECTED]
---
drivers/scsi/scsi_tgt_lib.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/scsi_tgt_lib.c b
at a scsi_host. We would add a hook to a
scsi_host_template to change the active_mode attribute
dynamically. But now there is no hook since no lld supports that
feature.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
Signed-off-by: Mike Christie [EMAIL PROTECTED]
---
drivers/scsi/hosts.c |1
This adds minimum target driver support like the srp transport does:
- fc_remote_port_{rolechg,delete} calls
scsi_tgt_it_nexus_{create,destroy} for target drivers.
- add callbacks to notify target drivers of the nexus and tmf
operation results to fc_function_template.
Signed-off-by: FUJITA
srp transport works for target drivers without supported_mode
attribute but it would be better to use it explicitly.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi/ibmvscsi/ibmvstgt.c |1 +
drivers/scsi/scsi_transport_srp.c | 10 ++
2 files changed, 7 insertions
On Mon, 20 Aug 2007 09:10:31 +0200
Jens Axboe [EMAIL PROTECTED] wrote:
On Sat, Aug 18 2007, FUJITA Tomonori wrote:
On Fri, 17 Aug 2007 01:47:59 +0900
FUJITA Tomonori [EMAIL PROTECTED] wrote:
This is for Jens' sglist branch in the block git tree.
It enables sg chaining support
On Mon, 20 Aug 2007 15:05:22 +0200
Jens Axboe [EMAIL PROTECTED] wrote:
On Mon, Aug 20 2007, FUJITA Tomonori wrote:
On Mon, 20 Aug 2007 09:10:31 +0200
Jens Axboe [EMAIL PROTECTED] wrote:
On Sat, Aug 18 2007, FUJITA Tomonori wrote:
On Fri, 17 Aug 2007 01:47:59 +0900
FUJITA
On Fri, 17 Aug 2007 01:47:59 +0900
FUJITA Tomonori [EMAIL PROTECTED] wrote:
This is for Jens' sglist branch in the block git tree.
It enables sg chaining support for the LLDs that use scsi_for_each_sg
accessor properly.
---
From a6e50a3b476bc193de103e8c1d95877ced38918e Mon Sep 17 00:00
This is for Jens' sglist branch in the block git tree.
It enables sg chaining support for the LLDs that use scsi_for_each_sg
accessor properly.
---
From a6e50a3b476bc193de103e8c1d95877ced38918e Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori [EMAIL PROTECTED]
Date: Fri, 17 Aug 2007 01:35:41 +0900
This is for the sglist branch in Jens' block git tree.
---
From 445923d1a8ff272293af3aadb6e58f82e6439e98 Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori [EMAIL PROTECTED]
Date: Thu, 16 Aug 2007 02:25:32 +0900
Subject: [PATCH] ppc sg chaining support fixes
Signed-off-by: FUJITA Tomonori [EMAIL
The patch is only compile tested.
---
From d5ad824bce0e5e3894a102fee74f1f7c36d639b7 Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori [EMAIL PROTECTED]
Date: Sun, 12 Aug 2007 15:33:23 +0900
Subject: [PATCH] microtek: convert to use the data buffer accessors
- remove the unnecessary map_single path
On Sun, 12 Aug 2007 11:01:20 -0400
Harrosh, Boaz [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote ...
Subject: [PATCH] microtek: convert to use the data buffer accessors
- remove the unnecessary map_single path.
- convert to use the new accessors for the sg lists and the
parameters
On Wed, 08 Aug 2007 11:58:14 -0500
Mike Christie [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
On Tue, 07 Aug 2007 12:13:41 -0500
Mike Christie [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
Allocating 64K contiguous memory is not good so the next thing to do
is converting sg
On Wed, 08 Aug 2007 12:20:43 -0500
Mike Christie [EMAIL PROTECTED] wrote:
Mike Christie wrote:
For drivers like sg and st, do mean the the sg list that is passed to
functions like scsi_execute_async? If we kill that argument, and instead
have sg.c and other scsi_execute_async callers
- remove the unnecessary map_single path.
- convert to use the new accessors for the sg lists and the
parameters.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/fc4/fc.c | 41 +++--
1 files changed, 15 insertions(+), 26 deletions(-)
diff
On Tue, 7 Aug 2007 08:55:49 +0200
Jens Axboe [EMAIL PROTECTED] wrote:
On Mon, Aug 06 2007, FUJITA Tomonori wrote:
On Tue, 31 Jul 2007 23:12:26 +0300
Boaz Harrosh [EMAIL PROTECTED] wrote:
The tested Kernels:
1. Jens's sglist-arch
I was not able to pass all tests
On Tue, 7 Aug 2007 00:14:29 -0700
Andrew Morton [EMAIL PROTECTED] wrote:
On Mon, 06 Aug 2007 22:55:41 -0500 James Bottomley [EMAIL PROTECTED] wrote:
The real root cause of all of this is that there's no tree I can
persuade all the interested parties to test that includes all of these
On Tue, 07 Aug 2007 12:13:41 -0500
Mike Christie [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
Allocating 64K contiguous memory is not good so the next thing to do
is converting sg to use the sg chaining support fully. Or it might be
For LLDs like aic7xxx, I think we are stuck
011c05c2e514d1db4834147ed83526473711b0a3 Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori [EMAIL PROTECTED]
Date: Mon, 6 Aug 2007 16:16:24 +0900
Subject: [PATCH] fix sg chaining leak
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi/scsi_lib.c |1 -
1 files changed, 0 insertions(+), 1
unsigned short is too small for sizeof(struct scatterlist) *
min(q-max_hw_segments, q-max_phys_segments).
This fixes memory leak with 4096 segments since 16 (likely sg size
with x86) * 4096 sets sglist_len to zero.
This might not happen without sg chaining support.
Signed-off-by: FUJITA
From: Boaz Harrosh [EMAIL PROTECTED]
Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO
sg-chaining
Date: Tue, 31 Jul 2007 23:12:26 +0300
Boaz Harrosh wrote:
FUJITA Tomonori wrote:
From: Benny Halevy [EMAIL PROTECTED]
Subject: Re: [PATCHSET 0/5] Peaceful co
On Sun, 05 Aug 2007 12:55:16 -0400
Douglas Gilbert [EMAIL PROTECTED] wrote:
FUJITA Tomonori wrote:
unsigned short is too small for sizeof(struct scatterlist) *
min(q-max_hw_segments, q-max_phys_segments).
This fixes memory leak with 4096 segments since 16 (likely sg size
with x86
Hopefully, this works. Is there an easier way to remove tgt
dependencies in scsi_transport_srp?
---
From 00924b31df30e4ddcf9ba9b5082171e5e46b9eb0 Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori [EMAIL PROTECTED]
Date: Thu, 2 Aug 2007 00:03:11 +0900
Subject: [PATCH] scsi_transport_srp: remove tgt
On Tue, 31 Jul 2007 12:40:41 -0600
Moore, Eric [EMAIL PROTECTED] wrote:
On Monday, July 30, 2007 4:32 PM, FUJITA Tomonori wrote:
On another note, while unloading the driver, and I get an
following opps
from bsg in the context of scsi_remove_host. This is w/o the SMP
passthrough
.
---
From 00924b31df30e4ddcf9ba9b5082171e5e46b9eb0 Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori [EMAIL PROTECTED]
Date: Thu, 2 Aug 2007 00:03:11 +0900
Subject: [PATCH] scsi_transport_srp: remove tgt dependencies
it's better to remove tgt dependencies in srp transport class since
most people want
From: Brian King [EMAIL PROTECTED]
Subject: [PATCH 1/1] scsi: Fix SRP_ATTRS Kconfig
Date: Mon, 30 Jul 2007 11:12:10 -0500
Since the srp transport class was added, if scsi tgt support is not
selected, the current Kconfig allows for enabling a dependent device
driver, such as ibmvscsi, which
It's better to initialize host-shost_data to zero like
target-starget_data and device-sdev_data.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi/hosts.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index
[88355044] :mptsas:mptsas_exit+0x10/0x5f
[80252afb] sys_delete_module+0x1b1/0x1e0
[80307d9c] __up_write+0x21/0x10d
[8020bc4e] system_call+0x7e/0x83
This patch fix the problem?
---
From: FUJITA Tomonori [EMAIL PROTECTED]
Subject: [PATCH] scsi_transport_sas: initialize
From: Moore, Eric [EMAIL PROTECTED]
Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg
Date: Mon, 30 Jul 2007 11:10:07 -0600
On Sunday, July 29, 2007 1:37 AM, FUJITA Tomonori wrote:
Eric, can I get your ACK on this patch?
One comment on the the patch:
+ if (!(ioc
From: FUJITA Tomonori [EMAIL PROTECTED]
Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg
Date: Sun, 29 Jul 2007 14:07:01 +0900
From: Moore, Eric [EMAIL PROTECTED]
Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg
Date: Fri, 27 Jul 2007 17:24:19 -0600
The patch is only compile tested.
---
From: FUJITA Tomonori [EMAIL PROTECTED]
Subject: [PATCH] zfcp: convert to use the data buffer accessors
- remove the unnecessary map_single path.
- convert to use the new accessors for the sg lists and the
parameters.
Signed-off-by: FUJITA Tomonori [EMAIL
whether they will be supported or not but they were added for the
possible future changes.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
block/bsg.c | 10 +++---
include/linux/bsg.h | 13 +
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/block/bsg.c b
on the request_queue_t definition.
Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the
option back in to the block.
Caught with a randconfig on sh.
Signed-off-by: Paul Mundt [EMAIL PROTECTED]
Acked-by: Jens Axboe [EMAIL PROTECTED]
Acked-by: FUJITA Tomonori [EMAIL PROTECTED
From: Moore, Eric [EMAIL PROTECTED]
Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg
Date: Fri, 27 Jul 2007 17:24:19 -0600
On Thursday, July 26, 2007 6:44 PM, FUJITA Tomonori wrote:
Does this work for you? Sorry, I'm not at the lab now and can't test
it. But I can do
From: Adrian Bunk [EMAIL PROTECTED]
Subject: 2.6.23-rc1-mm1: SCSI_SRP_ATTRS compile error
Date: Wed, 25 Jul 2007 20:06:18 +0200
On Wed, Jul 25, 2007 at 05:36:56PM +0100, Andy Whitcroft wrote:
Of the machines we test releases on automatically this only compiles on
NUMA-Q and does not boot
From: Boaz Harrosh [EMAIL PROTECTED]
Subject: [RFC 7/8] sd.c and sr.c move to scsi_sgtable implementation
Date: Thu, 05 Jul 2007 16:44:04 +0300
- sd and sr would adjust IO size to align on device's block
size. So code needs to change once we move to scsi_sgtable
implementation.
From: Moore, Eric [EMAIL PROTECTED]
Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg
Date: Thu, 26 Jul 2007 10:32:45 -0600
On Thursday, July 26, 2007 4:09 AM, FUJITA Tomonori wrote:
The SMP response's function result wasn't set correctly? bsg's
smp_rep_manufacturer
From: Boaz Harrosh [EMAIL PROTECTED]
Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO
sg-chaining
Date: Wed, 25 Jul 2007 22:22:20 +0300
FUJITA Tomonori wrote:
From: Benny Halevy [EMAIL PROTECTED]
Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable
From: Benny Halevy [EMAIL PROTECTED]
Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO
sg-chaining
Date: Wed, 25 Jul 2007 11:26:44 +0300
However, I'm perfectly happy to go with whatever the empirical evidence
says is best .. and hopefully, now we don't have to
From: Boaz Harrosh [EMAIL PROTECTED]
Subject: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO
sg-chaining
Date: Tue, 24 Jul 2007 11:47:50 +0300
As Jens said, there is nothing common to scsi_sgtable and
sglists. Save the fact that it is a massive conflict at
scsi-ml. They
From: Boaz Harrosh [EMAIL PROTECTED]
Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO
sg-chaining
Date: Tue, 24 Jul 2007 13:01:34 +0300
FUJITA Tomonori wrote:
From: Boaz Harrosh [EMAIL PROTECTED]
Subject: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable
From: FUJITA Tomonori [EMAIL PROTECTED]
Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO
sg-chaining
Date: Tue, 24 Jul 2007 20:12:47 +0900
From: Boaz Harrosh [EMAIL PROTECTED]
Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large
IO sg
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi/qla4xxx/ql4_os.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index e69160a..15ff730 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b
From: Moore, Eric [EMAIL PROTECTED]
Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg
Date: Tue, 24 Jul 2007 18:22:08 -0600
On Monday, July 23, 2007 11:28 PM, FUJITA Tomonori wrote:
With 2.6.23-rc1 + mptsas smp patch, you get directories /sys/class/bsg
like:
I
From: Moore, Eric [EMAIL PROTECTED]
Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg
Date: Tue, 24 Jul 2007 18:22:08 -0600
I'm not sure what the intent of this else case.
This code is for an invisible SMP target in LSI SAS HBAs. There are
better ways to get the
wrote:
FUJITA Tomonori wrote:
From: Mike Christie [EMAIL PROTECTED]
Subject: Re: [RFC 4/8] scsi-ml: scsi_sgtable implementation
Date: Thu, 12 Jul 2007 14:09:44 -0500
Boaz Harrosh wrote:
+/*
+ * Should fit within a single page.
+ */
+enum { SCSI_MAX_SG_SEGMENTS
message?
However, here are some feedback with regards to the patch:
Thanks.
On Sunday, July 08, 2007 9:52 PM, FUJITA Tomonori wrote:
+
+smpreq-RequestDataLength = req-data_len - 4;
Our firmware formats the data in little endian, so you'll need to
convert this inorder for it work
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 34 +++---
1 files changed, 11 insertions(+), 23 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 6735260..65f7fc1 100644
No need to check use_sg since sg_tablesize is set appropriately in the
scsi host template.
Brian King's patch (2a7309372fe56ae46c499b772d811ad31c501dd9) did this
cleanup but the data buffer accessors patch (written before the patch
and merged after it) restored the check.
Signed-off-by: FUJITA
This replaces the current linear search for a unique minor number with
lib/idr.c.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
block/bsg.c | 69 ++
include/linux/bsg.h |1 -
2 files changed, 30 insertions(+), 40 deletions
- kill uhdr in bsg_command structure
- it's not necessary to put SG v4 stuff to block/scsi_ioctl.c
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
block/bsg.c |9 -
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/block/bsg.c b/block/bsg.c
index f0259c2..2b5e72b
201 - 300 of 482 matches
Mail list logo
