Re: [PATCH 1/2] Convert target drivers to use sbitmap

2018-05-15 Thread Felipe Balbi
onvert the percpu_ida users to the sbitmap API. > > Signed-off-by: Matthew Wilcox <mawil...@microsoft.com> > --- [...] > drivers/usb/gadget/function/f_tcm.c | 8 +++--- for drivers/usb/gadget/function/f_tcm.c Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH/RFC 3/6] usb: gadget: Add NO_DMA dummies for DMA mapping API

2018-02-15 Thread Felipe Balbi
-by: Geert Uytterhoeven <ge...@linux-m68k.org> Should I take this or is it going with the rest of the series? If you wanna take it through Trivial or something like that: Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH/RFC 6/6] Treewide: Remove depends on HAS_DMA in case of platform dependency

2018-02-15 Thread Felipe Balbi
ncy on HAS_DMA, as they are selected from > SND_SOC_APQ8016_SBC. > > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> for drivers/usb/gadget/: Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

2017-12-20 Thread Felipe Balbi
Hi, Joe Perches <j...@perches.com> writes: > drivers/usb/phy/phy-tahvo.c| 2 +- Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi

Re: [PATCH v2 07/15] usb: gadget: configfs: make config_item_type const

2017-10-17 Thread Felipe Balbi
; Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

2017-10-17 Thread Felipe Balbi
mbine all the followup patches and the constification > patches into a series. I'm assuming this depends on patch 1 of the series. In that case: Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH v3 17/20] usb: gadget: pch_udc: Replace PCI pool old API

2017-03-06 Thread Felipe Balbi
iewed-by: Peter Senna Tschudin <peter.se...@collabora.com> Fine by me: Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Felipe Balbi
Hi, Jarkko Sakkinen writes: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >> >> >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >> >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: >> > > Constify local structures. >> > > >>

Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-04 Thread Felipe Balbi
s.open-mesh.org > Cc: linux-blueto...@vger.kernel.org > Signed-off-by: Florian Westphal <f...@strlen.de> > --- for u_ether.c: Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> > diff --git a/drivers/usb/gadget/function/u_ether.c > b/drivers/usb/gadget/function/

Re: [PATCH] cleanup on stack DECLARE_COMPLETIONs

2014-12-23 Thread Felipe Balbi
On Tue, Dec 23, 2014 at 06:34:08PM +0100, Nicholas Mc Guire wrote: fixups for incorrect use of DECLARE_COMPLETION. see also commit 6e9a4738 (completions: lockdep annotate on stack completions) The only somewhat special case being drivers/misc/sgi-gru/grukservices.c:quicktest2 which had a

Re: [PATCH v18 3/4] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-04-28 Thread Felipe Balbi
On Mon, Apr 28, 2014 at 04:12:02PM -0700, Loc Ho wrote: Hi Kishon/Felipe, This patch adds support for the APM X-Gene SoC AHCI SATA host controller driver. It requires the corresponding APM X-Gene SoC PHY driver. This initial version only supports Gen3 speed. This version seems

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-02-27 Thread Felipe Balbi
Hi, On Thu, Feb 27, 2014 at 11:14:05AM -0700, Loc Ho wrote: This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to configure for specified speed in hertz. why ? looks like

Re: [PATCH v12 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-02-27 Thread Felipe Balbi
Hi, On Thu, Feb 27, 2014 at 11:14:07AM -0700, Loc Ho wrote: +/* + * This function is used to configure the PHY to operation as either SATA Gen1 + * or Gen2 speed. + */ +static void xgene_phy_sata_force_gen(struct xgene_phy_ctx *ctx, + int lane, int gen)

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-02-27 Thread Felipe Balbi
Hi, On Thu, Feb 27, 2014 at 11:57:44AM -0800, Loc Ho wrote: On Thu, Feb 27, 2014 at 11:14:05AM -0700, Loc Ho wrote: This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-02-27 Thread Felipe Balbi
Hi, On Thu, Feb 27, 2014 at 01:09:57PM -0800, Loc Ho wrote: This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to configure for specified speed in hertz. why

Re: [PATCH 42/51] DMA-API: usb: musb: use platform_device_register_full() to avoid directly messing with dma masks

2013-09-20 Thread Felipe Balbi
callbacks, which may be called during the musb device probing. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk you want me to carry this one through my tree or you prefer getting my Acked-by ? Either way works for me: Acked-by: Felipe Balbi ba...@ti.com there's also the third option of me

Re: [PATCH 42/51] DMA-API: usb: musb: use platform_device_register_full() to avoid directly messing with dma masks

2013-09-20 Thread Felipe Balbi
Hi, On Fri, Sep 20, 2013 at 02:49:38PM +0100, Russell King - ARM Linux wrote: On Fri, Sep 20, 2013 at 08:11:25AM -0500, Felipe Balbi wrote: Hi, On Fri, Sep 20, 2013 at 12:14:38AM +0100, Russell King wrote: Use platform_device_register_full() for those drivers which can, to avoid

Re: SYSFS errors

2013-02-19 Thread Felipe Balbi
Hi, On Tue, Feb 19, 2013 at 07:03:10AM -0300, Mauro Carvalho Chehab wrote: But my gut feeling says to stay concervative and not touch this code - we don't know what uses it and how much we would break by fixing it. The current situation is not that big of a deal IMVHO and I'd be willing

Re: SYSFS errors

2013-02-19 Thread Felipe Balbi
On Tue, Feb 19, 2013 at 02:06:26PM +0100, Borislav Petkov wrote: On Tue, Feb 19, 2013 at 09:46:40AM -0300, Mauro Carvalho Chehab wrote: Ah, now I see what you're meaning. That would require to dynamically create a per-mci DEVICE_ATTR(). Dude, look at the code, we do that already. And

Re: SYSFS errors

2013-02-19 Thread Felipe Balbi
Hi, On Tue, Feb 19, 2013 at 02:28:54PM +0100, Borislav Petkov wrote: On Tue, Feb 19, 2013 at 03:15:00PM +0200, Felipe Balbi wrote: what's the problem with that ? Not a problem - simply annoying. $ ./test.sh cat: /path/to/file/that/doesnt/exist.txt: No such file or directory Setting

Re: SYSFS errors

2013-02-19 Thread Felipe Balbi
Hi, On Tue, Feb 19, 2013 at 11:14:40AM -0300, Mauro Carvalho Chehab wrote: Please consider adding a default attribute which return '-EINVAL' or somesuch when the function pointers are not set. But _not_ adding it via device_create_file(). That's evil. This thread started with Felipe's

Re: SYSFS errors

2013-02-19 Thread Felipe Balbi
On Tue, Feb 19, 2013 at 11:35:21AM -0300, Mauro Carvalho Chehab wrote: Em Tue, 19 Feb 2013 14:50:56 +0100 Borislav Petkov b...@alien8.de escreveu: On Tue, Feb 19, 2013 at 03:38:09PM +0200, Felipe Balbi wrote: because changing the permission will cause the same issue: Actually, I take

Re: SYSFS errors

2013-02-18 Thread Felipe Balbi
Hi, On Mon, Feb 18, 2013 at 09:49:16AM -0800, Greg KH wrote: Input/output error - /sys/devices/cpu/power/autosuspend_delay_ms The issue with this file is, if the power.use_autosuspend flag is not set for the device, then it can't be read or written to. This flag changes dynamically with

Re: SYSFS errors

2013-02-18 Thread Felipe Balbi
Hi, On Mon, Feb 18, 2013 at 04:46:38PM -0300, Mauro Carvalho Chehab wrote: No such device - /sys/devices/system/edac/mc/mc0/sdram_scrub_rate Odd, go ask the edac developers will do ;-) Well, the question is missing ;) /me assumes that you want to talk about suspending/resume

Re: SYSFS errors

2013-02-18 Thread Felipe Balbi
On Mon, Feb 18, 2013 at 04:48:06PM -0500, Alan Stern wrote: On Mon, 18 Feb 2013, Felipe Balbi wrote: Hi, On Mon, Feb 18, 2013 at 09:49:16AM -0800, Greg KH wrote: Input/output error - /sys/devices/cpu/power/autosuspend_delay_ms The issue with this file

Re: [PATCH] Try #3: Use SCSI read/write(16) with 32-bit LBA drives

2012-11-14 Thread Felipe Balbi
Hi, On Wed, Nov 14, 2012 at 08:06:20PM -0500, Jason J. Herne wrote: On Wed, Nov 14, 2012 at 5:22 PM, Sergei Shtylyov sshtyl...@mvista.com wrote: Hello. On 15-11-2012 2:03, Jason J. Herne wrote: From: Jason J. Herne hern...@gmail.com You have already posted Try #3. And