On Sat, 19 Aug 2017, Bhumika Goyal wrote:
> Make this const as it is only stored in the type field of a device
> structure, which is const.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
Acked-by: Guennadi Liakhovetski <g.liakhovet...@
Hi Christoph,
On Mon, 24 Nov 2014, Christoph Hellwig wrote:
I'm tempted to merge this into drivers-for-3.19 ASAP, any argument against
that? Guennadi, do you have any additional hardware to Hannes one real and
one
virtual adapter to test this new driver on before?
I've got a similar /
On Fri, 21 Nov 2014, Hannes Reinecke wrote:
The am53c974 is a re-implementation of the tmscsim driver,
and provides the same functionality.
So remove the tmscsim driver and make am53c974 an alias to tmscsim.
Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de
Signed-off-by: Hannes Reinecke h
Hi,
On Fri, 21 Nov 2014, Hannes Reinecke wrote:
On 11/21/2014 11:26 AM, Christoph Hellwig wrote:
On Fri, Nov 21, 2014 at 10:27:47AM +0100, Hannes Reinecke wrote:
Hi all,
having found some issues with the current tmscsim driver
I looked at the code and found is really awkward to clean
On Fri, 3 Oct 2014, Finn Thain wrote:
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
Thanks
Guennadi
---
This macro is only used in the NCR5380 drivers and they don't include
this header.
---
drivers/scsi/tmscsim.h
. like
- dprintkdbg(DBG_0, msgin_qtag: (0x%p) tag=%i srb=%p\n,
-srb-cmd, tag, srb);
+ dprintkdbg(DBG_0, msgin_qtag: tag=%i\n, tag);
Thanks
Guennadi
if (!(dcb-tag_mask (1 tag)))
dprintkl(KERN_DEBUG,
--
1.7.10.4
---
Guennadi Liakhovetski, Ph.D
On Mon, 23 Sep 2013, Jingoo Han wrote:
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han jg1@samsung.com
Acked-by: Guennadi Liakhovetski g.liakhovet
On Mon, 19 Nov 2012, Bill Pemberton wrote:
drivers/scsi/tmscsim.c | 2 +-
Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from
On Mon, 19 Nov 2012, Bill Pemberton wrote:
CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.
drivers/scsi/tmscsim.c| 2 +-
Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open
On Mon, 19 Nov 2012, Bill Pemberton wrote:
CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.
drivers/scsi/tmscsim.c| 2 +-
Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open
On Mon, 19 Nov 2012, Bill Pemberton wrote:
drivers/scsi/tmscsim.c| 16 +++---
Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe
Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
Note: I didn't test this. I still have a dc390 card in my PC, so, I could
test it, but I haven't yet got time for this and I'll be away the next
week. The patch looks correct and safe. If it does break anything, well,
we'll get to know
-host_lock);
+spin_unlock_irqrestore(pACB-pScsiHost-host_lock, flags);
return IRQ_HANDLED;
}
--
1.7.7
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line unsubscribe linux-scsi
On Sat, 16 Jun 2007, Matthew Wilcox wrote:
On Sun, Jun 17, 2007 at 12:42:44AM +0200, Guennadi Liakhovetski wrote:
sd* as long as the respective ldd is linked into the kernel. Now, this
just didn't work for me under 2.6.22-rc3-... (scsi-misc-2.6) with
sym53c8xx_2. I'd expected it would
, is it?...
Thanks and sorry for taking you on a time-travel
Guennadi
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
and any code called from this driver.
So why save it?
Or am I missing some bigger picture Here?
Looks like you're right. SavedSGCount seems indeed unneeded. I'll ack your
patch.
Thanks
Guennadi
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line unsubscribe linux-scsi
/tmscsim.h
@@ -57,7 +57,6 @@ u8 SGcount;
u8 MsgCnt;
u8 EndMessage;
-u8 SavedSGCount;
u8 MsgInBuf[6];
u8 MsgOutBuf[6];
--
1.5.0.4.402.g8035
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send
{ who = ~RES_TARGET; who |= (int)(tgt); }
while (0)
#define SET_RES_TARGET_LNX(who, tgt) do { who = ~RES_TARGET_LNX; who |=
(int)(tgt) 1; } while (0)
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Guennadi
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, 5 May 2007, Christoph Hellwig wrote:
On Fri, May 04, 2007 at 10:59:40PM +0200, Guennadi Liakhovetski wrote:
cpu_to_le32 endianness conversions in tmscsim.c, followed by
arithmetic operations don't look correct. Besides, {in,out}[wl]
already perform the necessary conversions
On Sat, 5 May 2007, Christoph Hellwig wrote:
On Fri, May 04, 2007 at 11:00:49PM +0200, Guennadi Liakhovetski wrote:
Dynamically map the buffer for PIO for the residue byte.
This look okay. Btw, is there a chance you could run tmscsim.c
through scripts/Lindent before your next round
DMA_INT code is disabled since 1998, remove it to prepare
for further cleanup.
Signed-off-by: G. Liakhovetski [EMAIL PROTECTED]
diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
index a583e89..d0e171c 100644
--- a/drivers/scsi/tmscsim.c
+++ b/drivers/scsi/tmscsim.c
@@ -625,70 +625,6
cpu_to_le32 endianness conversions in tmscsim.c, followed by
arithmetic operations don't look correct. Besides, {in,out}[wl]
already perform the necessary conversions. Further, bus addresses
of request buffers are guaranteed to be (mapped) under 4G by
current scsi- and block-layer defaults. This
Dynamically map the buffer for PIO for the residue byte.
Signed-off-by: G. Liakhovetski [EMAIL PROTECTED]
diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
index be869d0..aec63ef 100644
--- a/drivers/scsi/tmscsim.c
+++ b/drivers/scsi/tmscsim.c
@@ -351,6 +351,27 @@ static u8
On Sun, 29 Apr 2007, David Miller wrote:
From: James Bottomley [EMAIL PROTECTED]
Date: Sun, 29 Apr 2007 16:18:19 -0500
On Sun, 2007-04-29 at 22:56 +0200, Guennadi Liakhovetski wrote:
2. are they ever sent apart from when accompanying the DISCONNECT /
RESELECT?
I've never seen
which I'm trying to derive whether the handling in tmscsim is
correct, and, if not, how to correct it...
Thanks
Guennadi
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
+obj-$(CONFIG_SCSI_WAIT_SCAN) += scsi_wait_scan.o
Which means, with this change you cannot build a kernel without module
support but with scsi_wait_scan, which was possible before. Don't know if
anybody would ever want to do this though...
Thanks
Guennadi
---
Guennadi Liakhovetski
On Sun, 11 Mar 2007, James Bottomley wrote:
On Sun, 2007-03-11 at 21:56 +0100, Guennadi Liakhovetski wrote:
Which means, with this change you cannot build a kernel without module
support but with scsi_wait_scan, which was possible before. Don't know if
anybody would ever want to do
() will be
called at late_initcall time, but it will be redundant because
In
a monolithic kernel, this is done by the async scan infrastructure
so, it will just have no effect, right?
If so, then, of course it only makes sense as a module.
Thanks
Guennadi
---
Guennadi Liakhovetski
, preferrably 2.6.20. I think, by now Mandriva
should have something newer than 2.6.17? If it still fails, please, write
again.
Thanks
Guennadi
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info
---
Guennadi Liakhovetski
Signed-off-by: Guennadi Liakhovetski [EMAIL PROTECTED]
Index: linux-2_6/drivers/scsi/dc395x.c
===
RCS file: /usr/src/cvs/linux-2_6/drivers/scsi/dc395x.c,v
retrieving revision 1.1.1.8
diff -u -p -r1.1.1.8
in about 12
hours.
Guennadi
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 15 Aug 2005, Guennadi Liakhovetski wrote:
On Sun, 14 Aug 2005, James Bottomley wrote:
OK, why don't we do this. Instead of having me trawl through the trees
looking for the correct patch to reverse, why don't you attach it in an
email and I'll try to get it in to 2.6.13
Termination turned on on the zip, at the tape end there's a passive
terminator. The cable to the tape is pretty bad, I had to replace it in
another computer, but the tape IS SLOW. And it works on dc390.
Just wanted to make sure it's not a software bug?
Thanks
Guennadi
---
Guennadi Liakhovetski
that patch before 2.6.13, but, that's because I feel
personal responsibility for that bug:-)
Thanks
Guennadi
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
On Sun, 14 Aug 2005, James Bottomley wrote:
On Sun, 2005-08-14 at 21:33 +0200, Guennadi Liakhovetski wrote:
Just to make sure everyone agrees on this - there's currently a know bug
in dc395x with highmem reported by Pierre Ossman in thread Kernel panic
with dc395x in 2.6.12.2 on linux
and libata won't be able to use them in this form). The rest of
the 2 patches could then be applied to respective drivers.
Thanks
Guennadi
On Sun, 7 Aug 2005, Pierre Ossman wrote:
Guennadi Liakhovetski wrote:
So, now that we have somebody to test alternative patches, let's try it...
Please, first
On Sun, 7 Aug 2005, Mike Christie wrote:
Guennadi Liakhovetski wrote:
Now, it would be best, I think, if somebody could review the patches to
dc395x and tmscsim. In case the 2 functions are correct, they could be
included in a central file (scsi_lib?) for all drivers, needing PIO (I
a long time ago, and didn't revisit it
since then, hope, it's still fresh enough:-)
Including as attachments for easier separation.
Good luck
Guennadi
---
Guennadi LiakhovetskiSigned-off-by: Guennadi Liakhovetski [EMAIL PROTECTED]
diff -u a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
-info.html
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 31 Mar 2005 [EMAIL PROTECTED] wrote:
On Wed, 30 Mar 2005, James Bottomley wrote:
On Wed, 2005-03-30 at 23:22 +0200, Guennadi Liakhovetski wrote:
What is going to happen to this stuff? The current Linus' tree contains a
broken (by me:-() dc395x, other drivers (including tmscsim
in the original sg list
because some adjacent elements were merged during the mapping?
Thanks
Guennadi
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
Guennadi
---
Guennadi Liakhovetski
Signed-off-by: Guennadi Liakhovetski [EMAIL PROTECTED]
diff -u a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
--- a/drivers/scsi/dc395x.c 17 Nov 2004 21:04:51
+++ b/drivers/scsi/dc395x.c 17 Mar 2005 20:18:14
@@ -234,7 +234,8 @@
u8 sg_count
sg_dma_address(sg) +
psge-length psge-address) {
but wasn't sure.
Thanks
Guennadi
---
Guennadi Liakhovetski
Index: drivers/scsi/dc395x.c
===
RCS file: /usr/src/cvs/linux-2_6/drivers/scsi/dc395x.c,v
retrieving revision 1.1.1.4
diff -u
On Sun, 6 Feb 2005, Guennadi Liakhovetski wrote:
Two weeks since I posted this patch - ping...
...and another two weeks since you, Jamie, replied to me privately. Just
wanted to say, it would be good to get this bug fixed for the post-2.6.11
SCSI patch.
Regards
Guennadi
On Sun, 23 Jan
Received: from lyakh (helo=localhost)
by poirot.grange with local-esmtp (Exim 3.35 #1 (Debian))
id 1D3LcN-00021y-00; Mon, 21 Feb 2005 23:01:27 +0100
Date: Mon, 21 Feb 2005 23:01:27 +0100 (CET)
From: Guennadi Liakhovetski [EMAIL PROTECTED]
To: Jamie Lenehan [EMAIL PROTECTED]
cc
and tape drive and install a different backup solution.
So, I can't test any patches.
Thanks for your help.
Guennadi
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
On Sun, 9 Jan 2005, Jamie Lenehan wrote:
On Sun, Jan 09, 2005 at 12:42:26PM +0100, Guennadi Liakhovetski wrote:
[...]
I could try to improve the highmem situation / sg-handling. Or do you plan
to do it, Jamie?
It's on my list of things to do, but I doubt I'll have any time to do
49 matches
Mail list logo
