Re: [PATCH 14/22] [media] usbvision-i2c: fix format overflow warning

2017-07-17 Thread Hans Verkuil
On 17/07/17 14:57, Arnd Bergmann wrote: > On Mon, Jul 17, 2017 at 2:53 PM, Hans Verkuil wrote: >> On 14/07/17 14:07, Arnd Bergmann wrote: >>> gcc-7 notices that we copy a fixed length string into another >>> string of the same size, with additional characters: >>

Re: [PATCH 14/22] [media] usbvision-i2c: fix format overflow warning

2017-07-17 Thread Hans Verkuil
On 14/07/17 14:07, Arnd Bergmann wrote: > gcc-7 notices that we copy a fixed length string into another > string of the same size, with additional characters: > > drivers/media/usb/usbvision/usbvision-i2c.c: In function > 'usbvision_i2c_register': > drivers/media/usb/usbvision/usbvision-i2c.c:190

Re: [PATCH 6/6] media/cobalt: use pci_irq_allocate_vectors

2016-12-14 Thread Hans Verkuil
On 14/12/16 11:47, Christoph Hellwig wrote: On Wed, Dec 14, 2016 at 11:37:17AM +0100, Hans Verkuil wrote: Completely forgot this. Is it OK to queue it for 4.11? Or is it blocking other follow-up work you want to do for 4.10? My plan was to see if Bjorn would take the patch to do the trivial

Re: [PATCH 6/6] media/cobalt: use pci_irq_allocate_vectors

2016-12-14 Thread Hans Verkuil
On 14/12/16 11:29, Christoph Hellwig wrote: Hi Hans, just checked the current Linux tree and cobalt still uses the old pci_enable_msi_range call. Did you queue this patch up for 4.10? -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...

Re: [PATCH 6/6] media/cobalt: use pci_irq_allocate_vectors

2016-09-16 Thread Hans Verkuil
Hi Christoph, On 09/11/2016 03:31 PM, Christoph Hellwig wrote: > Simply the interrupt setup by using the new PCI layer helpers. > > Despite using pci_enable_msi_range, this driver was only requesting a > single MSI vector anyway. > > Signed-off-by: Christoph Hellwig > --- > drivers/media/pci/c

Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace dma_set_mask()+dma_set_coherent_mask() with new helper

2013-09-30 Thread Hans Verkuil
On 09/19/2013 11:44 PM, Russell King wrote: > Replace the following sequence: > > dma_set_mask(dev, mask); > dma_set_coherent_mask(dev, mask); > > with a call to the new helper dma_set_mask_and_coherent(). > > Signed-off-by: Russell King Acked-by

[PATCHv2] pm80xx: fix Adaptec 71605H hang

2013-07-26 Thread Hans Verkuil
01_ha->iomb_size as that is the correct value for both old and new controllers. Signed-off-by: Hans Verkuil Cc: sta...@vger.kernel.org # for v3.10 and up --- drivers/scsi/pm8001/pm8001_hwi.c | 4 ++-- drivers/scsi/pm8001/pm80xx_hwi.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff

Re: [PATCH] pm80xx: fix Adaptec 71605H hang

2013-07-24 Thread Hans Verkuil
gt; Sent: Monday, July 15, 2013 3:14 PM > To: Hans Verkuil > Cc: linux-scsi@vger.kernel.org; Anand Kumar Santhanam; > lindar_...@usish.com; Sangeetha Gnanasekaran; > jinpu.w...@profitbricks.com > Subject: Re: [PATCH] pm80xx: fix Adaptec 71605H hang > > On 07/14/2013 10:25 AM, H

Re: The pm80xx driver hangs in 3.10 with the Adaptec 71605H HBA

2013-07-15 Thread Hans Verkuil
Hi Anand! On 07/15/2013 02:37 PM, Anand Kumar Santhanam wrote: > Hi Hans, > > Pls find responses inline. > > Regards > Anand > > -Original Message- > From: Jack Wang [mailto:xjtu...@gmail.com] > Sent: Monday, July 15, 2013 2:24 PM > To: Hans Ve

Re: The pm80xx driver hangs in 3.10 with the Adaptec 71605H HBA

2013-07-14 Thread Hans Verkuil
Hi Anand, On 07/12/2013 03:14 PM, Anand Kumar Santhanam wrote: > Hans, > > I reviewed the code changes and I did not see major differences except > for the fact that in adaptec driver we have 64 interrupt handlers to > handle 64 MSI-X. > This was optimized in open src driver to use only 1 interru

[PATCH] pm80xx: fix Adaptec 71605H hang

2013-07-14 Thread Hans Verkuil
The IO command size is 128 bytes for these new controllers as opposed to 64 for the old 8001 controller. The Adaptec out-of-tree driver did this correctly. After comparing the two this turned out to be the crucial difference. Signed-off-by: Hans Verkuil Acked-by: anandkumar.santha...@pmcs.com

The pm80xx driver hangs in 3.10 with the Adaptec 71605H HBA

2013-07-12 Thread Hans Verkuil
Hi! I am trying to get my Adaptec 71605H HBA to work with kernel 3.10. Unfortunately it hangs while waiting for a completion. After registering all the interrupts the pm8001_pci_probe() function calls pm8001_init_sas_add(). That function calls PM8001_CHIP_DISP->get_nvmd_req() and waits for a comp