Re: BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x900/0xe50

2015-12-04 Thread James Bottomley
On Fri, 2015-12-04 at 18:46 +0100, Andrea Gelmini wrote: > On Fri, Dec 04, 2015 at 09:09:32AM -0800, James Bottomley wrote: > > Actually, that would be really helpful, since I only have access to one, > > very old, enclosure device. My ssh key is > > Ok. > Do you ne

Re: BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x900/0xe50

2015-12-04 Thread James Bottomley
On Thu, 2015-12-03 at 23:20 +0100, Andrea Gelmini wrote: > On Thu, Dec 03, 2015 at 12:59:06PM -0800, James Bottomley wrote: > > sg_map -i > > > > in your system, you should see something with an inquiry string like > > enclosure. It's the /dev/sg of that you need

Re: [PATCH] mpt3sas: add PCI dependency for CONFIG_SCSI_MPT2SAS

2015-12-04 Thread James Bottomley
On Fri, 2015-12-04 at 15:27 +0100, Arnd Bergmann wrote: > CONFIG_SCSI_MPT2SAS was added as a backwards-compatibility helper that > selects the replacement SCSI_MPT3SAS symbol, but lacks the dependencies: > > warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct > dependencies (SCSI_

Re: BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x900/0xe50

2015-12-03 Thread James Bottomley
On Thu, 2015-12-03 at 16:11 -0500, Douglas Gilbert wrote: > On 15-12-03 03:59 PM, James Bottomley wrote: > > On Thu, 2015-12-03 at 21:36 +0100, Andrea Gelmini wrote: > >> On Wed, Dec 02, 2015 at 02:58:21PM -0800, James Bottomley wrote: > >>> On Tue, 2015-12-01 at 21:

Re: BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x900/0xe50

2015-12-03 Thread James Bottomley
On Thu, 2015-12-03 at 21:36 +0100, Andrea Gelmini wrote: > On Wed, Dec 02, 2015 at 02:58:21PM -0800, James Bottomley wrote: > > On Tue, 2015-12-01 at 21:20 +0100, Andrea Gelmini wrote: > > OK, this looks like some type of problem with a USB enclosure. It's > > probably

Re: BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x900/0xe50

2015-12-02 Thread James Bottomley
On Tue, 2015-12-01 at 21:20 +0100, Andrea Gelmini wrote: > Hi everybody, >and thanks a lot for your work. > >As soon as I plugged an external WD USB hard drive (details in the > attached file) >into USB3 port, I've got this (much more info in the attached files). >Using commit 225

Re: [scsi:fixes 16/18] warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct dependencies (SCSI_LOWLEVEL && ..)

2015-12-02 Thread James Bottomley
On Thu, 2015-12-03 at 05:02 +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git fixes > head: 136dc13bf2988d987682e60558bb9b9873215f29 > commit: b840c3627b6f4f856b333a14a72f8ed86da2f86c [16/18] mpt3sas: Add dummy > Kconfig option for backwards

Re: MPT2SAS boot fail... due to silently loosing the driver

2015-11-30 Thread James Bottomley
[cc to linux-scsi added] On Mon, 2015-11-30 at 12:21 -0500, Martin K. Petersen wrote: > > "Ingo" == Ingo Molnar writes: > > Ingo> So you need to make it interactive, with a short help text that > Ingo> explains to users that this is legacy option only, and that they > Ingo> should enable the

Re: linux kernel security issuse scsi_report_lun_scan report

2015-11-21 Thread James Bottomley
On Fri, 2015-11-20 at 13:24 -0800, Linus Torvalds wrote: > On Fri, Nov 20, 2015 at 12:57 PM, James Bottomley > wrote: > > > > It's done under the scan mutex, so there can only be one thread in that > > code at once. > > Hmm. Looking at the call chain seems t

Re: linux kernel security issuse scsi_report_lun_scan report

2015-11-20 Thread James Bottomley
On Fri, 2015-11-20 at 12:33 -0800, Linus Torvalds wrote: > On Fri, Nov 20, 2015 at 10:26 AM, James Bottomley > wrote: > > > > We can look at it, but the analysis shouldn't be correct. > > Just take the five seconds to check the freeing path, please. The last >

Re: linux kernel security issuse scsi_report_lun_scan report

2015-11-20 Thread James Bottomley
On Fri, 2015-11-20 at 12:54 -0800, Linus Torvalds wrote: > On Fri, Nov 20, 2015 at 10:26 AM, James Bottomley > wrote: > > > > We can look at it, but the analysis shouldn't be correct. This device > > is the one we first used to issue the report lun scan. Either it

Re: linux kernel security issuse scsi_report_lun_scan report

2015-11-20 Thread James Bottomley
On Fri, 2015-11-20 at 10:14 -0800, Linus Torvalds wrote: > [ I don't know if the original reporter ended up actually sending this > to the scsi list like Greg asked, so I'll forward it myself just in > case ] No, this is the first time we've seen this. > There seems to be a very old use-after-fre

Re: [PATCH] scsi: hpsa: select CONFIG_SCSI_SAS_ATTR

2015-11-20 Thread James Bottomley
On Fri, 2015-11-20 at 10:09 -0600, Don Brace wrote: > Signed-off-by: Don Brace You mean acked-by ... it can only be signed-off-by if *you* resend the patch because signoffs track the patch transmission path. James > And...Thanks! > > > On 11/19/2015 04:04 PM, Arnd Bergmann wrote: > > The hpsa

Re: [BISECTED] v4.4-rc1 SCSI disk init crash

2015-11-19 Thread James Bottomley
On Thu, 2015-11-19 at 11:54 -0800, Bart Van Assche wrote: > On 11/19/2015 11:22 AM, Aaro Koskinen wrote: > > I get the below crash when cold booting OCTEON router with USB disk as > > rootfs. Bisected to: > > > > commit bf2cf3baa20b0a6cd2d08707ef05dc0e992a8aa0 > > Author: Bart Van Assche >

Re: [PATCH v2] Separate target visibility from reaped state information

2015-11-16 Thread James Bottomley
ou're claiming to be fixing no longer exists because it was fixed by commit f2495e228fce9f9cec84367547813cbb0d6db15a Author: James Bottomley Date: Tue Jan 21 07:01:41 2014 -0800 [SCSI] dual scan thread bug fix If that isn't the case, we can fix it, but I'd like to see the evi

[GIT PULL] final round of SCSI updates for the 4.3+ merge window

2015-11-13 Thread James Bottomley
Sorry for the delay in this patch which was mostly caused by getting the merger of the mpt2/mpt3sas driver, which was seen as an essential item of maintenance work to do before the drivers diverge too much. Unfortunately, this caused a compile failure (detected by linux-next), which then had to be

Re: [PATCH V2 1/3] scsi: mptxsas: try 64 bit DMA when 32 bit DMA fails

2015-11-10 Thread James Bottomley
On Tue, 2015-11-10 at 15:26 -0500, Sinan Kaya wrote: > > On 11/10/2015 3:05 PM, James Bottomley wrote: > > OK, you don't seem to be understanding the problem: the Altix isn't a > > LSI card, it was a SGI platform. > > Got it. > > > It was the platf

Re: [PATCH V2 1/3] scsi: mptxsas: try 64 bit DMA when 32 bit DMA fails

2015-11-10 Thread James Bottomley
On Tue, 2015-11-10 at 14:56 -0500, Sinan Kaya wrote: > > On 11/10/2015 2:43 PM, James Bottomley wrote: > > The Issue, as stated by LSI is > > > > Initially set the consistent DMA mask to 32 bit and then change > > it > > to 64 bit

Re: [PATCH V2 1/3] scsi: mptxsas: try 64 bit DMA when 32 bit DMA fails

2015-11-10 Thread James Bottomley
On Tue, 2015-11-10 at 14:14 -0500, Sinan Kaya wrote: > > On 11/10/2015 1:27 PM, James Bottomley wrote: > > On Tue, 2015-11-10 at 12:19 -0500, Sinan Kaya wrote: > >> On 11/10/2015 11:47 AM, Arnd Bergmann wrote: > >>> On Tuesday 10 November 2015 11:06:40 Sinan Kaya

Re: [PATCH V2 1/3] scsi: mptxsas: try 64 bit DMA when 32 bit DMA fails

2015-11-10 Thread James Bottomley
On Tue, 2015-11-10 at 12:19 -0500, Sinan Kaya wrote: > On 11/10/2015 11:47 AM, Arnd Bergmann wrote: > > On Tuesday 10 November 2015 11:06:40 Sinan Kaya wrote: > >> On 11/10/2015 3:38 AM, Arnd Bergmann wrote: > >> From the email thread, it looks like this was introduced to support > >> some legacy

Re: [PATCH v4 1/3] ibmvscsi: make parameters max_id and max_channel read-only

2015-11-09 Thread James Bottomley
On Mon, 2015-11-09 at 15:47 +0100, Laurent Vivier wrote: > The value of the parameter is never re-read by the driver, > so a new value is ignored. Let know the user he > can't modify it by removing writable attribute. This isn't correct. They're read in every time a new SCSI host is bound. I don

[PATCH v4] string_helpers: fix precision loss for some inputs

2015-11-06 Thread James Bottomley
From: James Bottomley It was noticed that we lose precision in the final calculation for some inputs. The most egregious example is size=3000 blk_size=1900 in units of 10 should yield 5.70 MB but in fact yields 3.00 MB (oops). This is because the current algorithm doesn't correctly accoun

Re: [patch] ses: tighten range checks in ses_intf_add()

2015-11-05 Thread James Bottomley
On Fri, 2015-11-06 at 00:52 +0300, Dan Carpenter wrote: > James, could you take a look at this? My patch was really incomplete > and even the bits that I wrote were buggy... :/ This might be easier > for someone who is familiar with the code and can say what the expected > ranges are etc. Yes,

[GIT PULL] first round of SCSI updates for the 4.3+ merge window

2015-11-05 Thread James Bottomley
This patch includes a couple of minor fixes, some core changes to help issues we're still seeing with the suspend/resume code and updates to lpfc and cxlflash. We're (actually Martin Petersen is) trying to wrangle a mpt2/mpt3sas merger for the merge window which will help enormously with the maint

Re: [PATCH 2/2] Restart list search after unlock in scsi_remove_target

2015-11-05 Thread James Bottomley
On Thu, 2015-11-05 at 08:55 -0800, Dan Williams wrote: > On Wed, Nov 4, 2015 at 2:44 PM, James Bottomley > wrote: > [..] > > The fundamental problem with this is how have the conditions that caused > > us to move away from list restart: > > > > commit bc3f02a

Re: [PATCH 2/2] Restart list search after unlock in scsi_remove_target

2015-11-04 Thread James Bottomley
On Wed, 2015-11-04 at 14:35 -0800, Bart Van Assche wrote: > On 10/30/2015 03:09 PM, Bart Van Assche wrote: > > When dropping a lock while iterating a list we must restart the search > > as other threads could have manipulated the list under us. Without this > > we can get stuck in an endless loop.

Re: [PATCH] st: trivial: remove form feed characters

2015-11-04 Thread James Bottomley
On Wed, 2015-11-04 at 23:04 +0200, "Kai Mäkisara (Kolumbus)" wrote: > > On 4.11.2015, at 11.52, Maurizio Lombardi wrote: > > > > Signed-off-by: Maurizio Lombardi > > --- > > drivers/scsi/st.c | 24 > > 1 file changed, 8 insertions(+), 16 deletions(-) > > > > diff --git a

Re: [PATCH v2] string_helpers: fix precision loss for some inputs

2015-11-03 Thread James Bottomley
On Wed, 2015-11-04 at 00:26 +0100, Rasmus Villemoes wrote: > On Tue, Nov 03 2015, James Bottomley > wrote: > > > On Tue, 2015-11-03 at 23:13 +0100, Rasmus Villemoes wrote: > >> On Tue, Nov 03 2015, James Bottomley > >> wrote: > >> > >> &g

[PATCH v3] string_helpers: fix precision loss for some inputs

2015-11-03 Thread James Bottomley
From: James Bottomley It was noticed that we lose precision in the final calculation for some inputs. The most egregious example is size=3000 blk_size=1900 in units of 10 should yield 5.70 MB but in fact yields 3.00 MB (oops). This is because the current algorithm doesn't correctly accoun

Re: [PATCH v2] string_helpers: fix precision loss for some inputs

2015-11-03 Thread James Bottomley
On Tue, 2015-11-03 at 23:13 +0100, Rasmus Villemoes wrote: > On Tue, Nov 03 2015, James Bottomley > wrote: > > > From: James Bottomley > > > > It was noticed that we lose precision in the final calculation for some > > inputs. The most egregious example is si

Re: [PATCH v2] string_helpers: fix precision loss for some inputs

2015-11-03 Thread James Bottomley
On Tue, 2015-11-03 at 13:37 -0800, Bart Van Assche wrote: > On 11/03/2015 01:21 PM, James Bottomley wrote: > > + while (blk_size >= UINT_MAX) > > i++; > > (reduced CC-list) Let's keep at least the lists in cc. > Hello James, > > Is the a

Re: [PATCH v2] string_helpers: fix precision loss for some inputs

2015-11-03 Thread James Bottomley
From: James Bottomley It was noticed that we lose precision in the final calculation for some inputs. The most egregious example is size=3000 blk_size=1900 in units of 10 should yield 5.70 MB but in fact yields 3.00 MB (oops). This is because the current algorithm doesn't correctly accoun

[PATCH] string_helpers: fix precision loss for some inputs

2015-11-03 Thread James Bottomley
From: James Bottomley It was noticed that we lose precision in the final calculation for some inputs. The most egregious example is size=3000 blk_size=1900 in units of 10 should yield 5.70 MB but in fact yields 3.00 MB (oops). This is because the current algorithm doesn't correctly accoun

[GIT PULL] SCSI fixes for 4.3-rc4

2015-10-30 Thread James Bottomley
This is three essential bug fixes for various SCSI parts. The only affected users are SCSI multi-path via device handler (basically all the enterprise) and mvsas users. The dh bugs are an async entanglement in boot resulting in a serious WARN_ON trip and a use after free on remove leading to a cr

Re: [RESEND PATCH] mpt2sas: Remove usage of 'struct timeval'

2015-10-30 Thread James Bottomley
On October 30, 2015 6:05:15 PM GMT+09:00, Tina Ruchandani wrote: >'struct timeval' will have its tv_sec value overflow on 32-bit systems >in year 2038 and beyond. This patch replaces the use of struct timeval >for computing mpi_request.TimeStamp, and instead uses ktime_t which >provides >64-bit

Re: [PATCH] scsi_dh: Use module_request_nowait

2015-10-27 Thread James Bottomley
On Tue, 2015-10-27 at 14:45 -0700, Laura Abbott wrote: > We recevied a bugzilla report: > > Additional info: > reporter: libreport-2.6.3 > WARNING: CPU: 3 PID: 10195 at kernel/kmod.c:140 > __request_module+0x214/0x330() > Modules linked in: uas usb_storage xfs libcrc32c vhost_net vhost macvtap > m

Re: [PATCH] scsi: restart list search after unlock in scsi_remove_target

2015-10-19 Thread James Bottomley
On Mon, 2015-10-19 at 17:56 +0200, Christoph Hellwig wrote: > On Mon, Oct 19, 2015 at 08:36:23AM -0700, Bart Van Assche wrote: > > Thanks for looking into this. However, I think we need a motivation in the > > patch description why this patch does not reintroduce the soft lockup > > documented in

Re: [PATCH v2] scsi: advansys needs ISA dma api for ISA support

2015-10-16 Thread James Bottomley
On Fri, 2015-10-16 at 16:19 +0200, Arnd Bergmann wrote: > On Friday 16 October 2015 06:53:44 James Bottomley wrote: > > > > > > Signed-off-by: Arnd Bergmann > > > > > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > > > index d2f48

Re: [PATCH v2] scsi: advansys needs ISA dma api for ISA support

2015-10-16 Thread James Bottomley
On Fri, 2015-10-16 at 14:13 +0200, Arnd Bergmann wrote: > The advansys drvier uses the request_dma function that is used on ISA > machines for the internal DMA controller, which causes build errors > on platforms that have ISA slots but do not provide the ISA DMA API: > > drivers/scsi/advansys.c:

Re: [PATCH] scsi: kconfig: When possible, compile drivers with COMPILE_TEST

2015-10-14 Thread James Bottomley
On Thu, 2015-10-15 at 00:30 +0100, Luis de Bethencourt wrote: > On 14/10/15 23:42, James Bottomley wrote: > > On Wed, 2015-10-14 at 22:13 +0100, Luis de Bethencourt wrote: > >> These drivers only have runtime but no build time dependencies, so they can > >> be built

Re: [PATCH] scsi: kconfig: When possible, compile drivers with COMPILE_TEST

2015-10-14 Thread James Bottomley
On Wed, 2015-10-14 at 22:13 +0100, Luis de Bethencourt wrote: > These drivers only have runtime but no build time dependencies, so they can > be built for testing purposes if the Kconfig COMPILE_TEST option is enabled. > > This is useful to have more build coverage and make sure that drivers are >

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-10-14 Thread James Bottomley
On Wed, 2015-10-14 at 11:34 -0700, Lee Duncan wrote: > On 10/14/2015 06:55 AM, James Bottomley wrote: > > On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote: > >> Update the SCSI hosts module to use the ida_simple*() routines > >> to manage its host_no index instead

Re: [PATCH 0/3] SCSI: Fix hard lockup in scsi_remove_target()

2015-10-14 Thread James Bottomley
On Wed, 2015-10-14 at 16:39 +0200, Johannes Thumshirn wrote: > On Wed, 2015-10-14 at 07:30 -0700, James Bottomley wrote: > > On Wed, 2015-10-14 at 15:50 +0200, Johannes Thumshirn wrote: > > > Removing a SCSI target via scsi_remove_target() suspected to be > > > racy.

Re: [PATCH 0/3] SCSI: Fix hard lockup in scsi_remove_target()

2015-10-14 Thread James Bottomley
On Wed, 2015-10-14 at 15:50 +0200, Johannes Thumshirn wrote: > Removing a SCSI target via scsi_remove_target() suspected to be racy. When a > sibling get's removed from the list it can occassionly happen that one CPU is > stuck endlessly looping around this code block > > list_for_each_entry(starg

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-10-14 Thread James Bottomley
On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote: > Update the SCSI hosts module to use the ida_simple*() routines > to manage its host_no index instead of an ATOMIC integer. This > means that the SCSI host number will now be reclaimable. OK, but why would we want to do this? We do it for sd b

Re: [PATCH] scsi: advansys needs ISA dma api for ISA support

2015-10-13 Thread James Bottomley
On Mon, 2015-10-12 at 17:44 +0200, Arnd Bergmann wrote: > On Monday 12 October 2015 08:28:01 James Bottomley wrote: > > > > > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > > > index d2f480b04a52..d4aa6a1a806c 100644 > > > --- a/drivers/scsi/K

Re: [PATCH] scsi: advansys needs ISA dma api for ISA support

2015-10-12 Thread James Bottomley
On Mon, 2015-10-12 at 17:10 +0200, Arnd Bergmann wrote: > The advansys drvier uses the request_dma function that is used on ISA > machines for the internal DMA controller, which causes build errors > on platforms that have ISA slots but do not provide the ISA DMA API: > > drivers/scsi/advansys.c:

Re: SSP frame iu defines

2015-10-12 Thread James Bottomley
On Thu, 2015-10-08 at 15:47 +0100, John Garry wrote: > On 08/10/2015 15:22, Arnd Bergmann wrote: > > On Thursday 08 October 2015 15:17:49 John Garry wrote: > >> Hi, > >> > >> For a new driver I am preparing for a SAS controller, I need defintions > >> for the SSP command and TMF iu structures. Curr

Re: Bugs in multipath scsi in 4.3-rc2

2015-10-12 Thread James Bottomley
On Mon, 2015-10-12 at 14:45 +0200, Hannes Reinecke wrote: > On 10/04/2015 09:45 AM, Christoph Hellwig wrote: > > On Fri, Oct 02, 2015 at 06:44:57AM -0700, James Bottomley wrote: > >> I think I prefer restoring that to having to build in every dh module to > >> get the

[GIT PULL] SCSI fixes for 4.3-rc4

2015-10-11 Thread James Bottomley
This is a set of three bug fixes, two of which are regressions from recent updates (the 3ware one from 4.1 and the device handler fixes from 4.2). The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Ariel Nahum (1): l

Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

2015-10-08 Thread James Bottomley
On Thu, 2015-10-08 at 15:46 +, Himanshu Madhani wrote: > > On 10/7/15, 4:41 PM, "Julian Calaby" wrote: > > >Hi Xose, > > > >On Thu, Oct 8, 2015 at 2:13 AM, Xose Vazquez Perez > > wrote: > >> On Fri, May 22, 2015 at 10:00 AM, Julian Calaby > >> wrote: > >> > >>> Some qla2xxx devices have firm

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-07 Thread James Bottomley
On Wed, 2015-10-07 at 22:23 +0200, Hannes Reinecke wrote: > On 10/06/2015 07:17 PM, James Bottomley wrote: > > On Tue, 2015-10-06 at 10:14 -0700, Lee Duncan wrote: > >> On 10/06/2015 02:40 AM, Christoph Hellwig wrote: > >>>> struct Scsi_Host *scsi_h

Re: [PATCHv3 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread James Bottomley
On Tue, 2015-10-06 at 12:08 -0700, Lee Duncan wrote: > Update the SCSI hosts module to use idr to manage > its host_no index instead of an ATOMIC integer. This > also allows using idr_find() to look up the SCSI > host structure given the host number. > > This means that the SCSI host number will n

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread James Bottomley
On Tue, 2015-10-06 at 10:14 -0700, Lee Duncan wrote: > On 10/06/2015 02:40 AM, Christoph Hellwig wrote: > >> struct Scsi_Host *scsi_host_lookup(unsigned short hostnum) > >> { > >> - struct device *cdev; > >> - struct Scsi_Host *shost = NULL; > >> - > >> - cdev = class_find_device(&shost_class,

Re: [PATCH 00/18] mpt2sas, mpt3sas: Combine mpt2sas and mpt3sas driver code base

2015-10-06 Thread James Bottomley
On Tue, 2015-10-06 at 15:59 +0530, Sreekanth Reddy wrote: > On Tue, Oct 6, 2015 at 3:16 PM, Christoph Hellwig wrote: > > This series seems to miss patch 5 which actually removes the mpt2sas > > driver - it probably was too large for the list. > > [Sreekanth] > > Yes Chris, As this Phase5 size is

Re: [PATCH 0/5] Modify ida_* users to use ida_simple_*

2015-10-05 Thread James Bottomley
On Mon, 2015-10-05 at 13:44 -0400, Tejun Heo wrote: > On Thu, Oct 01, 2015 at 11:59:04AM -0700, Lee Duncan wrote: > > The ida index management routines are used in several > > driver modules to manage allocation and release of > > index values. Reviewing the way in which the > > ida routines were c

Re: Bugs in multipath scsi in 4.3-rc2

2015-10-02 Thread James Bottomley
On Fri, 2015-10-02 at 15:34 +0200, Christoph Hellwig wrote: > On Fri, Oct 02, 2015 at 06:25:01AM -0700, James Bottomley wrote: > > That doesn't matter: if you modprobe alua after all devices are > > discovered, it will attach correctly to all potential devices from the > &g

Re: Bugs in multipath scsi in 4.3-rc2

2015-10-02 Thread James Bottomley
On Fri, 2015-10-02 at 14:56 +0200, Christoph Hellwig wrote: > On Wed, Sep 30, 2015 at 03:34:54PM -0700, James Bottomley wrote: > > Perhaps we don't have to be that draconian. There's no real reason we > > can't autoload asynchronously. If the module isn't rea

Re: Odd Behavior in the enclosure module around the 2 fault bits

2015-10-01 Thread James Bottomley
On Wed, 2015-09-30 at 15:17 +, Ryan Attard wrote: > My coworkers and I were setting some enclosure states on our storage > devices, and then reading the states back using sysfs, and came across > the 'fault' field being set to 2. When we investigated into the ses.c > file, we found this wonder

Re: [PATCH] storvsc: use small sg_tablesize on x86

2015-10-01 Thread James Bottomley
On Thu, 2015-10-01 at 20:30 +, KY Srinivasan wrote: > > > -Original Message- > > From: Olaf Hering [mailto:o...@aepfle.de] > > Sent: Tuesday, September 8, 2015 3:07 AM > > To: KY Srinivasan ; Haiyang Zhang > > ; jbottom...@odin.com > > Cc: linux-ker...@vger.kernel.org; linux-scsi@vger.

Re: Bugs in multipath scsi in 4.3-rc2

2015-09-30 Thread James Bottomley
On Wed, 2015-09-30 at 17:53 -0400, Tejun Heo wrote: > Hello, Christoph. > > On Wed, Sep 30, 2015 at 05:14:49PM +0200, Christoph Hellwig wrote: > > The problem is that async probing deadlocks vs a synchronous > > request_module, as Tejun figured out based on the thrad in > > http://thread.gmane.org

Re: twa generates WARNING upon boot

2015-09-30 Thread James Bottomley
On Wed, 2015-09-30 at 09:41 -0700, Christoph Hellwig wrote: > On Wed, Sep 30, 2015 at 09:36:24AM -0700, James Bottomley wrote: > > Are you sure? The init trace that kicked all this off still has > > twa_init in it. I was figuring the most likely suspect is > > twa_get_p

Re: twa generates WARNING upon boot

2015-09-30 Thread James Bottomley
On Wed, 2015-09-30 at 09:31 -0700, Christoph Hellwig wrote: > On Wed, Sep 30, 2015 at 09:15:30AM -0700, James Bottomley wrote: > > I already thought of this. Unfortunately, it fails if the internally > > posted command is a single sector (the size of TW_MIN_SGL_LENGTH), which >

Re: twa generates WARNING upon boot

2015-09-30 Thread James Bottomley
On Wed, 2015-09-30 at 09:08 -0700, Christoph Hellwig wrote: > Hi all, > > I'd like to propose the following patch intead. It uses a helper > to check the conditions for the copied commands, and also fixes another > place to use it which uses a different and I think buggy check: > > This avoids t

Re: twa generates WARNING upon boot

2015-09-29 Thread James Bottomley
On Tue, 2015-09-29 at 20:25 +0200, "Tóth Attila" wrote: > 2015.Szeptember 29.(K) 20:02 időpontban James Bottomley ezt írta: > > On Tue, 2015-09-29 at 10:37 -0700, James Bottomley wrote: > >> On Tue, 2015-09-29 at 18:49 +0200, "Tóth Attila" wrote: > >>

Re: twa generates WARNING upon boot

2015-09-29 Thread James Bottomley
On Tue, 2015-09-29 at 10:37 -0700, James Bottomley wrote: > On Tue, 2015-09-29 at 18:49 +0200, "Tóth Attila" wrote: > > 2015.Szeptember 27.(V) 23:19 időpontban adam radford ezt írta: > > > On Sun, Sep 27, 2015 at 4:56 AM, "Tóth Attila" > > > wr

Re: twa generates WARNING upon boot

2015-09-29 Thread James Bottomley
On Tue, 2015-09-29 at 18:49 +0200, "Tóth Attila" wrote: > 2015.Szeptember 27.(V) 23:19 időpontban adam radford ezt írta: > > On Sun, Sep 27, 2015 at 4:56 AM, "Tóth Attila" > > wrote: > >> Here is a current trace I see after booting that kernel: > >> [ cut here ] > >> WARNIN

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread James Bottomley
On Mon, 2015-09-28 at 14:50 +, David Laight wrote: > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > > Sent: 28 September 2015 15:27 > > On Mon, 2015-09-28 at 08:58 +, David Laight wrote: > > > From: Rafael J. Wysocki > > >

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread James Bottomley
On Mon, 2015-09-28 at 08:58 +, David Laight wrote: > From: Rafael J. Wysocki > > Sent: 27 September 2015 15:09 > ... > > > > Say you have three adjacent fields in a structure, x, y, z, each one > > > > byte long. > > > > Initially, all of them are equal to 0. > > > > > > > > CPU A writes 1 to

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-26 Thread James Bottomley
On Fri, 2015-09-25 at 22:58 +0200, Rafael J. Wysocki wrote: > On Friday, September 25, 2015 01:25:49 PM Viresh Kumar wrote: > > On 25 September 2015 at 13:33, Rafael J. Wysocki wrote: > > > You're going to change that into bool in the next patch, right? > > > > Yeah. > > > > > So what if bool is

Re: Bugs in multipath scsi in 4.3-rc2

2015-09-25 Thread James Bottomley
On Fri, 2015-09-25 at 17:18 +0200, Christoph Hellwig wrote: > Hi Paul, > > can you send the request_module fix as a proper signed off and described > patch? I'll figure out what w can do about async scan vs request_module > in the meantime. So the warning seems to be because scsi_dh_find_driver(

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

2015-09-23 Thread James Bottomley
On Wed, 2015-09-23 at 20:14 +0930, Arthur Marsh wrote: > > Jiang Liu wrote on 23/09/15 14:54: > > > Hi Arthur, > > I have found the cause of the warning messages, it's caused > > by a flaw in the conversion. But according to my understanding, > > it isn't related to the kexec/kdump failure. C

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

2015-09-22 Thread James Bottomley
On Wed, 2015-09-23 at 07:55 +0930, Arthur Marsh wrote: > > Jiang Liu wrote on 22/09/15 17:00: > > Previously the eata driver just grabs and accesses eata PCI devices > > without implementing a PCI device driver, that causes troubles with > > latest IRQ related > > > > Commit 991de2e59090 ("PCI, x8

Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)

2015-09-17 Thread James Bottomley
On Thu, 2015-09-17 at 13:15 -0400, Tejun Heo wrote: > Hello, > > On Thu, Sep 17, 2015 at 09:48:37AM -0700, James Bottomley wrote: > > Well, there's an easy fix for that. We could have ida_remove() actually > > free the bitmap and not cache it if it's the last

Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)

2015-09-17 Thread James Bottomley
On Thu, 2015-09-17 at 19:06 +0300, Michael S. Tsirkin wrote: > On Thu, Sep 17, 2015 at 07:15:44AM -0700, James Bottomley wrote: > > On Thu, 2015-09-17 at 08:33 +0300, Michael S. Tsirkin wrote: > > > On Wed, Sep 16, 2015 at 07:29:17PM -0500, Suman Anna wrote: > > > >

Re: [PATCH RESEND] scsi: Fix sense information setting in fixed sized format

2015-09-17 Thread James Bottomley
On Thu, 2015-09-17 at 15:42 +0300, Sagi Grimberg wrote: > On 9/3/2015 10:02 PM, Ewan Milne wrote: > > On Thu, 2015-09-03 at 19:49 +0300, Sagi Grimberg wrote: > >> In fixed size sense format the information field is a four byte > >> field. > >> > >> Signed-off-by: Sagi Grimberg > >> Reviewed-by: Ma

Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)

2015-09-17 Thread James Bottomley
On Thu, 2015-09-17 at 08:33 +0300, Michael S. Tsirkin wrote: > On Wed, Sep 16, 2015 at 07:29:17PM -0500, Suman Anna wrote: > > The virtio core uses a static ida named virtio_index_ida for > > assigning index numbers to virtio devices during registration. > > The ida core may allocate some internal

Re: [PATCH v2 01/30] cxlflash: Fix to avoid invalid port_sel value

2015-09-16 Thread James Bottomley
Could you please add a cover letter (a 0/30) and thread your patches from that? For large patch series, it really does make following everything a lot easier for me (and most other people who use a threaded mail reader). Thanks, James -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 01/17] Add ida and idr helper routines.

2015-09-15 Thread James Bottomley
On Tue, 2015-09-15 at 14:27 -0400, Tejun Heo wrote: > Hello, > > On Tue, Sep 15, 2015 at 09:46:01AM -0700, Lee Duncan wrote: > > +/** > > + * ida_get_index - allocate a ida index value > > + * @idaidr handle > > + * @lock spinlock handle protecting this index > > + * @p_id pointer

Re: [PATCH v2] scsi: introduce short_inquiry flag for broken host adapters

2015-09-15 Thread James Bottomley
> > > Signed-off-by: Vitaly Kuznetsov > > --- > > Changes since v1: > > - This is a successor of previously sent "scsi_scan: move 'INQUIRY result > > too short' message to debug level" patch. Instead of moving the message > > t

Re: [PATCH 01/17] Add ida and idr helper routines.

2015-09-15 Thread James Bottomley
On Tue, 2015-09-15 at 09:46 -0700, Lee Duncan wrote: > Clients of the ida and idr index-management routines > tend to use the same calling sequences much of the time, > so this change adds helper functions for allocating and > releasing indexes of either flavor, i.e. with or > without pointer manag

[GIT PULL] final round of SCSI updates for the 4.2+ merge window

2015-09-11 Thread James Bottomley
There's one late arriving patch here (added today), fixing a build issue which the scsi_dh patch set in here uncovered. Other than that, everything has been incubated in -next and the checkers for a week. The major pieces of this patch are a set patches facilitating better integration between scs

Re: [PATCH-v2 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-09-11 Thread James Bottomley
Tuesday, September 08, 2015 5:26 PM > > > To: Nicholas A. Bellinger > > > Cc: linux-scsi; linux-kernel; James Bottomley; Calvin Owens; Christoph > > > Hellwig; MPT-FusionLinux.pdl; kernel-team; Nicholas Bellinger; Chaitra > > > Basappa > > > Subject: Re:

Re: randconfig build error with next-20150908, in drivers/md/dm-mpath.c

2015-09-08 Thread James Bottomley
On Tue, 2015-09-08 at 13:23 -0400, Mike Snitzer wrote: > On Tue, Sep 08 2015 at 1:10pm -0400, > Jim Davis wrote: > > > Building with the attached random configuration file, > > > > drivers/built-in.o: In function `activate_path': > > /home/jim/linux-next/drivers/md/dm-mpath.c:1225: undefined re

Re: [PATCH] SCSI: Scale up REPORT_LUNS timeout on failure

2015-09-04 Thread James Bottomley
On Fri, 2015-09-04 at 10:47 -0500, Brian King wrote: > On 09/04/2015 10:36 AM, James Bottomley wrote: > > On Wed, 2015-09-02 at 09:31 -0500, Brian King wrote: > >> This patch fixes an issue seen with an IBM 2145 (SVC) where, following an > >> error > >> injecti

Re: [PATCH] SCSI: Scale up REPORT_LUNS timeout on failure

2015-09-04 Thread James Bottomley
On Wed, 2015-09-02 at 09:31 -0500, Brian King wrote: > This patch fixes an issue seen with an IBM 2145 (SVC) where, following an > error > injection test which results in paths going offline, when they came > back online, the path would timeout the REPORT_LUNS issued during the > scan. This timeou

[GIT PULL] first round of SCSI updates for the 4.2+ merge window

2015-09-01 Thread James Bottomley
This includes one new driver: cxlflash plus the usual grab bag of updates for the major drivers: qla2xxx, ipr, storvsc, pm80xx, hptiop, plus a few assorted fixes. There's another tranch coming, but I want to incubate it another few days in the checkers, plus it includes a mpt2sas separated lifetim

Re: [PATCH] scsi_scan: move 'INQUIRY result too short' message to debug level

2015-09-01 Thread James Bottomley
On Mon, 2015-08-31 at 14:50 +0200, Vitaly Kuznetsov wrote: > Some Hyper-V hosts are known for ignoring SPC-2/3/4 requirement > for 'INQUIRY data (see table ...) shall contain at least 36 bytes'. As a > result we get tons on 'scsi 0:7:1:1: scsi scan: INQUIRY result too short > (5), using 36' message

Re: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

2015-08-31 Thread James Bottomley
On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote: > Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying > tags. What's the actual problem description this causes? James > Signed-off-by: K. Y. Srinivasan > Cc: sta...@vger.kernel.org > --- > drivers/scsi/storvs

Re: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check

2015-08-30 Thread James Bottomley
On Sun, 2015-08-30 at 10:36 +, Winkler, Tomas wrote: > > > > > > > > > > > > I'm just not sure why the patches are not merged or even rejected. > > > > > > Because ideally I want a Maintainer ack. That's Doug Gilbert. > > James > The patches were discussed and the ACked by Doug in February

Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-30 Thread James Bottomley
On Sun, 2015-08-30 at 00:22 -0700, Nicholas A. Bellinger wrote: > On Fri, 2015-08-28 at 13:25 -0700, James Bottomley wrote: > > On Thu, 2015-08-27 at 12:15 -0700, Nicholas A. Bellinger wrote: > > > On Thu, 2015-08-27 at 07:40 -0700, James Bottomley wrote: > > > > On

Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-28 Thread James Bottomley
On Thu, 2015-08-27 at 12:15 -0700, Nicholas A. Bellinger wrote: > On Thu, 2015-08-27 at 07:40 -0700, James Bottomley wrote: > > On Thu, 2015-08-27 at 10:37 +0530, Sreekanth Reddy wrote: > > > HI Nicholas & Calvin, > > > > > > Thanks for the patchset.

Re: [PATCH 10/10] scsi_dh: move 'dh_state' sysfs attribute to generic code

2015-08-28 Thread James Bottomley
On Thu, 2015-08-27 at 14:17 +0200, Hannes Reinecke wrote: > As scsi_dh.c is now always compiled in we should be moving > the 'dh_state' attribute to the generic code. > > Signed-off-by: Hannes Reinecke This looks OK, but needs another reviewer. If you could also fix up the rejections caused by

Re: [PATCH 02/10] dm-mpath, scsi_dh: request scsi_dh modules in scsi_dh, not dm-mpath

2015-08-28 Thread James Bottomley
On Thu, 2015-08-27 at 14:16 +0200, Hannes Reinecke wrote: > @@ -158,7 +171,7 @@ store_dh_state(struct device *dev, struct > device_attribute *attr, > /* >* Attach to a device handler >*/ > - if (!(scsi_dh = get_device_handler(buf))) > +

Re: [PATCH v2 0/10] megaraid_sas : Updates for scsi for-next

2015-08-28 Thread James Bottomley
On Thu, 2015-08-20 at 18:43 +0530, sumit.sax...@avagotech.com wrote: > MegaRaid driver changes. This patch set is resent based on feedback received > by Martin Petersen. > Please consider this patch set for next kernel release. > > Signed-off-by: Sumit Saxena > Signed-off-by: Kashyap Desai > --

Re: [PATCH 0/2] Patches for scsi "misc" branch

2015-08-28 Thread James Bottomley
On Thu, 2015-08-13 at 06:41 -0400, anil.gurumur...@qlogic.com wrote: > From: Anil Gurumurthy > > Hi James, Christoph, > > Please apply the following patches to the scsi tree, misc branch at your > earliest convenience. Both of these patches look OK to me. Could I get a second review, please?

Re: [PATCH] scsi: fix scsi_error_handler vs. scsi_host_dev_release race

2015-08-28 Thread James Bottomley
On Thu, 2015-08-27 at 20:16 +0200, mho...@kernel.org wrote: > From: Michal Hocko > > b9d5c6b7ef57 ("[SCSI] cleanup setting task state in Heh, it's tempting to revert that. The reason is we always need to be interruptible state before we check the flag to avoid missing wakeups. > scsi_error_han

Re: [PATCH V7 1/9] [SCSI] aacraid: Fix for logical device name and UID not exposed to the OS

2015-08-27 Thread James Bottomley
On Thu, 2015-08-27 at 06:50 -0400, Mahesh Rajashekhara wrote: > Description: > Driver sends the right size of the response buffer. > > Changes from V2: > None > > Reviewed By: Tomas Henzl , Murthy Bhat > , Karthikeya Sunkesula > > Signed-off-by: Mahesh Rajashekhara You've had hundreds

Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-27 Thread James Bottomley
On Thu, 2015-08-27 at 10:37 +0530, Sreekanth Reddy wrote: > HI Nicholas & Calvin, > > Thanks for the patchset. Sure We will review and we do some unit > testing on this patch series. Currently my bandwidth is occupied with > some internal activity, so by end of next week I will acknowledge this >

Re: [PATCH RESEND V2 3/7] scsi: storvsc: Untangle the storage protocol negotiation from the vmbus protocol negotiation.

2015-08-26 Thread James Bottomley
On Thu, 2015-08-13 at 08:43 -0700, K. Y. Srinivasan wrote: > From: Keith Mange > > Currently we are making decisions based on vmbus protocol versions > that have been negotiated; use storage potocol versions instead. > > Tested-by: Alex Ng > Signed-off-by: Keith Mange > Signed-off-by: K. Y. Sr

<    2   3   4   5   6   7   8   9   10   11   >