Re: [GIT PULL] target updates for v3.16-rc1

2014-06-13 Thread James Bottomley
On Fri, 2014-06-13 at 15:39 +0200, Christoph Hellwig wrote: On Thu, Jun 12, 2014 at 02:05:16PM -0700, Nicholas A. Bellinger wrote: The first is with virtio-scsi between what has been merged in scsi.git for virtio_scsi: use cmd_size, and the virtio-scsi: Enable DIF/DIX modes in SCSI host LLD

Re: [PATCHv2 1/2] ibmvscsi: Abort init sequence during error recovery

2014-06-13 Thread James Bottomley
On Fri, 2014-06-13 at 10:30 -0500, Brian King wrote: On 05/27/2014 08:55 AM, Nathan Fontenot wrote: On 05/23/2014 10:52 AM, Brian King wrote: If a CRQ reset is triggered for some reason while in the middle of performing VSCSI adapter initialization, we don't want to call the done function

Re: [PATCH 0/2] scsi command timeout fixes

2014-06-13 Thread James Bottomley
something with the command before we know block has relinquished it. That's actually why this bug was so serious: commit d555a2abf3481f81303d835046a5ec2c4fb3ca8e Author: James Bottomley jbottom...@parallels.com Date: Fri Mar 28 10:50:17 2014 -0700 [SCSI] Fix spurious request sense in error

Re: virtio-scsi issues duplicate tags when async_abort is enabled

2014-06-13 Thread James Bottomley
On Fri, 2014-06-13 at 11:52 -0700, Christoph Hellwig wrote: On Fri, Jun 13, 2014 at 10:58:22AM -0700, Venkatesh Srinivas wrote: CC-ing stable as 3.14 and 3.15 are affected; a conservative fix is to enable no_async_abort until the problem is better-understood. No patch attached. Nevermind

Re: virtio-scsi issues duplicate tags when async_abort is enabled

2014-06-13 Thread James Bottomley
On Fri, 2014-06-13 at 12:15 -0700, Venkatesh Srinivas wrote: On Fri, Jun 13, 2014 at 12:09 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Fri, 2014-06-13 at 11:52 -0700, Christoph Hellwig wrote: On Fri, Jun 13, 2014 at 10:58:22AM -0700, Venkatesh Srinivas wrote: CC

Re: virtio-scsi issues duplicate tags when async_abort is enabled

2014-06-13 Thread James Bottomley
On Fri, 2014-06-13 at 12:31 -0700, Greg KH wrote: On Fri, Jun 13, 2014 at 12:18:25PM -0700, James Bottomley wrote: On Fri, 2014-06-13 at 12:15 -0700, Venkatesh Srinivas wrote: On Fri, Jun 13, 2014 at 12:09 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Fri, 2014

[GIT PULL] Final round of SCSI updates for the 3.15+ merge window

2014-06-13 Thread James Bottomley
This is just a couple of drivers (hpsa and lpfc) that got left out for further testing in linux-next. We also have one fix to a prior submission (qla2xxx sparse). The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-for-linus The short changelog is:

Re: [ANNOUNCE] scsi patch queue tree

2014-06-11 Thread James Bottomley
On Wed, 2014-06-11 at 05:01 -0700, Christoph Hellwig wrote: After this first pull for the 3.16 merge window it seems like this worked out fairly well - we got a large number of patches in, and all reviewed by a second pair of eyes. How should we go on from this? The drivers-for-3.16-2

Re: [PATCH 1/2] scsi_scan: Send TEST UNIT READY to the LUN before scanning

2014-06-11 Thread James Bottomley
On Thu, 2014-06-05 at 09:26 +0200, Hannes Reinecke wrote: REPORT_LUN_SCAN does not report any outstanding unit attention condition as per SAM. However, the target might not be fully initialized at that time, so we might end up getting a default entry (or even a partially filled one). But as

Re: [PATCH 1/2] scsi_scan: Send TEST UNIT READY to the LUN before scanning

2014-06-11 Thread James Bottomley
On Wed, 2014-06-11 at 16:33 +0200, Hannes Reinecke wrote: On 06/11/2014 04:24 PM, James Bottomley wrote: On Thu, 2014-06-05 at 09:26 +0200, Hannes Reinecke wrote: REPORT_LUN_SCAN does not report any outstanding unit attention condition as per SAM. However, the target might not be fully

Re: [PATCH 6/6] scsi_scan: Fixup scsilun_to_int()

2014-06-10 Thread James Bottomley
On Tue, 2014-06-10 at 16:48 +0200, Bart Van Assche wrote: On 06/10/14 16:06, James Bottomley wrote: On Tue, 2014-06-10 at 13:37 +0200, Bart Van Assche wrote: On 06/03/14 10:58, Hannes Reinecke wrote: + * Given a struct scsi_lun of: d2 04 0b 03 00 00 00 00, this function

Re: [Bug 77631] New: task scsi_eh_6:537 blocked for more than 120 seconds.

2014-06-10 Thread James Bottomley
From the trace below, this looks to be a USB issue (USB added to cc): the scsi error handler thread is waiting for usb storage to complete the reset. It's a 3.14.5 kernel, so the previous reset hang because of spurious sense requests should be fixed. James On Tue, 2014-06-10 at 16:50 +,

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-06-10 Thread James Bottomley
On Tue, 2014-06-10 at 12:57 -0700, Nicholas A. Bellinger wrote: On Tue, 2014-06-10 at 21:45 +0300, Michael S. Tsirkin wrote: On Tue, Jun 10, 2014 at 10:39:17AM -0700, Nicholas A. Bellinger wrote: On Tue, 2014-06-10 at 16:02 +0300, Michael S. Tsirkin wrote: On Tue, Jun 10, 2014 at

[GIT PULL] First round of SCSI updates for the 3.15+ merge window

2014-06-09 Thread James Bottomley
This patch consists of the usual driver updates (qla2xxx, qla4xxx, lpfc, be2iscsi, fnic, ufs, NCR5380) The NCR5380 is the addition to maintained status of a long neglected driver for older hardware. In addition there are a lot of minor fixes and cleanups and some more updates to make scsi mq

Re: SCSI eats error from flush failure during hot plug

2014-06-07 Thread James Bottomley
On Thu, 2014-06-05 at 16:52 -0700, Steven Haber wrote: Hello, I am testing ATA device durability during hot unplug. I have a power fault test suite that has turned up issues with the fsync-SCSI-ATA codepath. If a device is unplugged while an fsync is in progress, ATA returns a flush error

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-06-06 Thread James Bottomley
On Fri, 2014-06-06 at 12:18 -0500, Mike Christie wrote: On 6/5/14, 9:53 PM, KY Srinivasan wrote: -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Thursday, June 5, 2014 6:33 PM To: KY Srinivasan Cc: James Bottomley; linux-ker...@vger.kernel.org

Re: [RFC Patch]: scsi: sysfs file cache_type not in sync with mode page

2014-06-06 Thread James Bottomley
On Fri, 2014-06-06 at 17:14 -0400, Pai wrote: Hi All, I noticed that the sysfs file cache_type is not is sync with the information in the mode page. If we change the WCE attribute in the mode page (sdparm --set=WCE /dev/sda and sdparm --clear=WCE /dev/sda) it does not reflect this in

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-06-04 Thread James Bottomley
On Wed, 2014-06-04 at 09:33 -0700, K. Y. Srinivasan wrote: Commit ID: 7e660100d85af860e7ad763202fff717adcdaacd added code to derive the FLUSH_TIMEOUT from the basic I/O timeout. However, this patch did not use the basic I/O timeout of the device. Fix this bug. Signed-off-by: K. Y. Srinivasan

Re: [PATCH] scsi: mpt2sas: mpt2sas_base.c: Cleaning up missing null-terminate after strncpy call

2014-06-04 Thread James Bottomley
On Wed, 2014-06-04 at 23:36 +0200, Rickard Strandqvist wrote: Added a guaranteed null-terminate after call to strncpy. This was partly found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se ---

Re: [PATCH 6/6] scsi_scan: Fixup scsilun_to_int()

2014-06-02 Thread James Bottomley
On Sat, 2014-05-31 at 11:01 +0200, Hannes Reinecke wrote: scsilun_to_int() has an error which prevents it from generating correct LUN numbers for 64bit values. Also we should remove the misleading comment about portions of the LUN being ignored; the initiator should treat the LUN as an opaque

Re: [PATCH 7/8] be2iscsi: Fix processing cqe for cxn whose endpoint is freed

2014-06-02 Thread James Bottomley
On Mon, 2014-06-02 at 12:33 -0700, h...@infradead.org wrote: On Mon, Jun 02, 2014 at 07:22:07PM +, James Bottomley wrote: Actually, can you really pull it out, not just revert it? Reverts cause problems with bisection and are unnecessary before the tree goes to Linus

Re: [PATCHv2 0/5] Support 64-bit LUNs

2014-05-29 Thread James Bottomley
On Wed, 2014-05-28 at 03:56 -0700, Christoph Hellwig wrote: James, can you take a look at this series? I would be great to get it merged for 3.16! Remind me how we're planning to fix the conversion bug in scsilun_to_int, it doesn't seem to be in the patch series anymore... I remember there

Re: Make SCSI error handler code easier to understand

2014-05-29 Thread James Bottomley
On Wed, 2014-05-28 at 16:15 -0400, Joe Lawrence wrote: On Mon, 26 May 2014 17:12:27 +0200 Bart Van Assche bvanass...@acm.org wrote: Every now and then someone asks how it is avoided that the SCSI error handler and the SCSI completion handler are invoked concurrently for the same SCSI

Re: [PATCH 1/3] Remove two cancel_delayed_work() calls from the error handler

2014-05-27 Thread James Bottomley
On Tue, 2014-05-27 at 10:06 +0200, Bart Van Assche wrote: On 05/26/14 17:23, Paolo Bonzini wrote: Il 26/05/2014 17:14, Bart Van Assche ha scritto: diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 88d46fe..c972eab 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c

Re: [PATCH 2/3] block: Introduce blk_rq_completed()

2014-05-27 Thread James Bottomley
On Tue, 2014-05-27 at 09:49 +0200, Bart Van Assche wrote: On 05/26/14 17:27, James Bottomley wrote: On Mon, 2014-05-26 at 17:15 +0200, Bart Van Assche wrote: Make it possible to test the REQ_ATOM_COMPLETE bit from outside the block layer core. I don't see the value of patches 2,3

Re: [PATCH 1/3] Remove two cancel_delayed_work() calls from the error handler

2014-05-27 Thread James Bottomley
On Tue, 2014-05-27 at 10:36 +0200, Bart Van Assche wrote: On 05/27/14 10:09, James Bottomley wrote: On Tue, 2014-05-27 at 10:06 +0200, Bart Van Assche wrote: As you probably know scsi_put_command() can get called from softirq context. A BUG_ON() in that context might make it unnecessary

Re: [PATCH 2/3] block: Introduce blk_rq_completed()

2014-05-27 Thread James Bottomley
On Tue, 2014-05-27 at 11:00 +0200, Bart Van Assche wrote: On 05/27/14 10:23, James Bottomley wrote: On Tue, 2014-05-27 at 09:49 +0200, Bart Van Assche wrote: When reading the source code in scsi_error.c it's easy to overlook that scmd_eh_abort_handler(), scsi_abort_command

Re: [PATCH 2/3] block: Introduce blk_rq_completed()

2014-05-27 Thread James Bottomley
On Tue, 2014-05-27 at 12:47 +0200, Paolo Bonzini wrote: Il 27/05/2014 12:21, James Bottomley ha scritto: I could also see us one day extending the TMF capability to abort any running command, which would make even an assertion of block timed out or completed invalid. Actually

Re: [PATCH 2/3] block: Introduce blk_rq_completed()

2014-05-27 Thread James Bottomley
On Tue, 2014-05-27 at 13:52 +0200, Paolo Bonzini wrote: Il 27/05/2014 13:26, James Bottomley ha scritto: You could use a different mechanism than a softirq to tell the abort were successful, for example by overriding scsi_done. But with respect to the block layer, the mechanics of avoiding

Re: [PATCH] notify block layer when using temporary change to cache_type

2014-05-27 Thread James Bottomley
On Tue, 2014-05-27 at 19:39 +0800, Vaughan Cao wrote: This is a fix for commit: 39c60a0948cc06139e2fbfe084f83cb7e7deae3b sd: fix array cache flushing bug causing performance problems We must notify the block layer via q-flush_flags after temporary change the cache_type to write through.

Re: [PATCH 1/3] Remove two cancel_delayed_work() calls from the error handler

2014-05-26 Thread James Bottomley
On Mon, 2014-05-26 at 17:23 +0200, Paolo Bonzini wrote: Il 26/05/2014 17:14, Bart Van Assche ha scritto: scsi_put_command() is either invoked before a command is queued or after a command has completed. scsi_cmnd.abort_work is scheduled after a command has timed out and before it is

Re: [PATCH] acornscsi: remove linked command support

2014-05-25 Thread James Bottomley
On Sat, 2014-05-24 at 15:16 +0200, Paul Bolle wrote: On Sat, 2014-05-24 at 16:13 +0400, James Bottomley wrote: Wait, no, that's not a good idea. We leave obsolete drivers to bitrot. Particularly we try not to touch them unless we have to because there might be a few people still using them

Re: [PATCH] acornscsi: remove linked command support

2014-05-24 Thread James Bottomley
On Sat, 2014-05-24 at 12:35 +0200, Hannes Reinecke wrote: [...] I'm all for it. Removing never-really-implemented feature on obsolete hardware is always a good idea. Acked-by: Hannes Reinecke h...@suse.de Wait, no, that's not a good idea. We leave obsolete drivers to bitrot. Particularly

[GIT PULL] SCSI fixes for 3.15-rc6

2014-05-24 Thread James Bottomley
This is a single fix for a bug exposed by a sysfs change in 3.13 which now causes libsas to trigger a warn on in device removal. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Joe Lawrence (1):

Re: [PATCH 0/2] scsi: hyper-v storvsc changes by Ubuntu

2014-05-22 Thread James Bottomley
On Thu, 2014-05-22 at 10:49 +, KY Srinivasan wrote: -Original Message- From: Andy Whitcroft [mailto:a...@canonical.com] Sent: Wednesday, May 21, 2014 7:25 AM To: Ian Abbott Cc: linux-scsi@vger.kernel.org; de...@linuxdriverproject.org; KY Srinivasan; Haiyang Zhang; James

Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-05-20 Thread James Bottomley
On Thu, 2014-02-27 at 13:17 +0900, Yoshihiro YUNOMAE wrote: +/* Maximum size of a local buffer for structured printk */ +#define SCSI_LOG_LINE_MAX 512 + +/* Local buffer for structured printk */ +struct scsi_log_line { + int offset; + char buf[SCSI_LOG_LINE_MAX]; +}; This piece

Re: [ANNOUNCE] scsi patch queue tree

2014-05-20 Thread James Bottomley
On Wed, 2014-05-21 at 09:46 +1000, Stephen Rothwell wrote: Hi Christoph, On Mon, 19 May 2014 22:39:28 -0700 Christoph Hellwig h...@infradead.org wrote: On Tue, May 20, 2014 at 10:03:43AM +1000, Stephen Rothwell wrote: Is this a request for inclusion of those branches into linux-next

Re: scsi error handling thread and REQUEST SENSE

2014-05-19 Thread James Bottomley
a sense code (and some devices get * confused by sense requests out of the blue) */ continue; However, that last bit is a recent introduction: commit d555a2abf3481f81303d835046a5ec2c4fb3ca8e Author: James Bottomley jbottom

Re: SCSI staging tree for linux-next?

2014-05-18 Thread James Bottomley
On Fri, 2014-05-16 at 15:01 -0700, James Bottomley wrote: On Fri, 2014-05-16 at 15:38 +0200, Hannes Reinecke wrote: On 05/15/2014 07:26 AM, Christoph Hellwig wrote: Hi James, we're past -rc5 and no SCSI patches have been collected for 3.16 yet, despite a lot of patches including

Re: [PATCH 1/2] scsi: hyper-v storvsc switch up to SPC-3

2014-05-16 Thread James Bottomley
On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote: From: Andy Whitcroft a...@canonical.com Suggested-by: James Bottomley james.bottom...@hansenpartnership.com That is my patch, isn't it, just with a slightly modified comment: http://marc.info/?l=linux-scsim=137908428211951 Andy promised

Re: [PATCH 2/2] scsi: hyper-v storvsc -- host takes MAINTENANCE_IN commands badly -- elide them

2014-05-16 Thread James Bottomley
On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote: From: Andy Whitcroft a...@canonical.com BugLink: http://bugs.launchpad.net/bugs/1234417 This is a pretty low quality bug report; where's the analysis that should be in your patch? The problem is, is it not, that when you turn on trim we

Re: [PATCH 1/2] scsi: hyper-v storvsc switch up to SPC-3

2014-05-16 Thread James Bottomley
On Fri, 2014-05-16 at 18:39 +0100, Ian Abbott wrote: On 2014-05-16 18:14, James Bottomley wrote: On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote: From: Andy Whitcroft a...@canonical.com Suggested-by: James Bottomley james.bottom...@hansenpartnership.com That is my patch, isn't

Re: [PATCH 1/2] scsi: hyper-v storvsc switch up to SPC-3

2014-05-16 Thread James Bottomley
On Fri, 2014-05-16 at 19:18 +0100, Ian Abbott wrote: On 2014-05-16 18:58, James Bottomley wrote: On Fri, 2014-05-16 at 18:39 +0100, Ian Abbott wrote: On 2014-05-16 18:14, James Bottomley wrote: On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote: From: Andy Whitcroft a...@canonical.com

Re: SCSI staging tree for linux-next?

2014-05-16 Thread James Bottomley
On Fri, 2014-05-16 at 15:38 +0200, Hannes Reinecke wrote: On 05/15/2014 07:26 AM, Christoph Hellwig wrote: Hi James, we're past -rc5 and no SCSI patches have been collected for 3.16 yet, despite a lot of patches including a lot of reviewed ones pending on the list. I'd really love

Re: Weird I/O errors with USB Hard disk

2014-05-10 Thread James Bottomley
On Sat, 2014-05-10 at 22:38 +0800, loody wrote: hi all: I have a USB hard disk and when I play specific file. it will show below message ( I purpose enable usb/storage/transport.c debug message about urb debug) what makes me confused are 1. Does Unhandled sense code mean the SCSI Request

Re: Weird I/O errors with USB Hard disk

2014-05-10 Thread James Bottomley
On Sun, 2014-05-11 at 00:43 +0800, loody wrote: hi James: 2014-05-10 23:10 GMT+08:00 James Bottomley james.bottom...@hansenpartnership.com: On Sat, 2014-05-10 at 22:38 +0800, loody wrote: hi all: I have a USB hard disk and when I play specific file. it will show below message ( I

Re: [PATCH] iscsi_ibft: search for broadcom specific ibft sign

2014-05-07 Thread James Bottomley
On Wed, 2014-05-07 at 09:47 -0400, Konrad Rzeszutek Wilk wrote: On Wed, May 07, 2014 at 05:00:20AM -0400, vikas.chaudh...@qlogic.com wrote: From: Vikas Chaudhary vikas.chaudh...@qlogic.com Broadcom iscsi offload firmware uses a non standard ibft sign of BIFT. Why? If it uses the

[GIT PULL] SCSI fixes for 3.15-rc4

2014-05-03 Thread James Bottomley
This is two patches both fixing bugs in drivers (virtio-scsi and mpt2sas) causing an oops in certain circumstances. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Fam Zheng (1): virtio-scsi: Skip setting

Re: [PATCH v1.0 1/11] arcmsr: Revise interrupt service routine relate function

2014-04-30 Thread James Bottomley
On Wed, 2014-04-30 at 17:40 +0800, ching wrote: From: Chingching2...@areca.com.tw Rewrite interrupt service routine relate function to fix command timeout on controller very heavy loading. OK, so I think you've confused us a bit. This looks to be an update of your previous v1.4 patch set,

Re: [PATCH v2 00/12] scsi/NCR5380: fix debugging macros and #include structure

2014-04-29 Thread James Bottomley
On Tue, 2014-04-29 at 15:15 +1200, Michael Schmitz wrote: Finn, On Tue, Apr 29, 2014 at 2:22 PM, Finn Thain fth...@telegraphics.com.au wrote: On Sat, 26 Apr 2014, James Bottomley wrote: OK, so this is a pretty big change to an unmaintained driver. I'll take it if you're willing

Re: two small scsi fixes for 3.15-rc3

2014-04-28 Thread James Bottomley
On Mon, 2014-04-28 at 11:03 +0200, Christoph Hellwig wrote: On Fri, Apr 25, 2014 at 08:00:48AM -0700, James Bottomley wrote: You should have received my git tree emails that they were already in SCSI fixes ... didn't you? I certainly got a copy. I've not seen a single reply to the patches

Re: PATCH: mvsas: add support for Supermicro AOC-SAS2LP-MV8

2014-04-28 Thread James Bottomley
On Mon, 2014-04-28 at 18:16 -0700, Xiangliang Yu wrote: Hi, Jan I think below change may be better: { PCI_VDEVICE(MARVELL_EXT, 0x9485), chip_9485 }, Ben Hutchings already submitted a patch for this twice, which I cc'd you on: http://marc.info/?t=13927720393 will you ack it?

Re: [PATCH v2 00/12] scsi/NCR5380: fix debugging macros and #include structure

2014-04-26 Thread James Bottomley
On Wed, 2014-03-19 at 23:35 +1100, Finn Thain wrote: This patch series addresses several issues with NCR5380 drivers: 1. The complex network of #include directives. 2. Three inconsistent implementations of the core driver all attempting to share the same macro definitions in NCR5380.h.

[GIT PULL] SCSI fixes for 3.15-rc3

2014-04-25 Thread James Bottomley
deadlock caused by SCSI error handling James Bottomley (2): More USB deadlock fixes Fix spurious request sense in error handling scame...@beardog.cce.hp.com (1): hpsa: fix NULL dereference in hpsa_put_ctlr_into_performant_mode() And the diffstat: drivers/scsi/hpsa.c | 8

Re: two small scsi fixes for 3.15-rc3

2014-04-25 Thread James Bottomley
On Fri, 2014-04-25 at 13:09 +0200, Christoph Hellwig wrote: Hi Linus, hi James, these are two simple use after free fixes that fix a regression introduced by me in the first scsi update for 3.15-rc1. I've sent them to the scsi list 10 days ago and haven't seen any reply to them, and I'd

Re: Please help me to review the patch about supporting SATA PM in LIBSAS

2014-04-17 Thread James Bottomley
On Thu, 2014-04-17 at 11:07 +0800, xiangliang yu wrote: hi, The patch is support SATA PM device and can find all devices that is attached to PM. By PM you mean Port Multipilier not Power Management ... we can be easily confused by the acronym, so I'd spell it out. It also looks like the

Re: [PATCH] hpsa: fix uninitialized trans_support in hpsa_put_ctlr_into_performant_mode()

2014-04-14 Thread James Bottomley
Your subject line is very tame. It should be the one line summary of why we apply the patch, so it should read something like hpsa: fix NULL deref in performant mode On Thu, 2014-04-10 at 17:17 -0500, scame...@beardog.cce.hp.com wrote: Without this, you'll see a null pointer dereference in

Re: [PATCH RESEND 2] mvsas: Recognise device/subsystem 9485/9485 as 88SE9485

2014-04-14 Thread James Bottomley
On Wed, 2014-02-19 at 01:06 +, Ben Hutchings wrote: Matt Taggart reported that mvsas didn't bind to the Marvell SAS controller on a Supermicro AOC-SAS2LP-MV8 board. lspci reports it as: 01:00.0 RAID bus controller [0104]: Marvell Technology Group Ltd. Device [1b4b:9485] (rev 03)

Re: [GIT PULL] async scsi resume for 3.15

2014-04-11 Thread James Bottomley
On Thu, 2014-04-10 at 18:24 -0700, Dan Williams wrote: Hi Linus, James might still be in the process of sending this your way. However, given the proximity to -rc1, my reasoning for sending this directly is: 1/ It provides a tangible speed up for a non-esoteric use case (laptop resume):

Re: [PATCH 0/3] Fix USB deadlock caused by SCSI error handling

2014-04-10 Thread James Bottomley
On Thu, 2014-04-10 at 19:52 +0200, Hannes Reinecke wrote: On 04/10/2014 05:31 PM, Alan Stern wrote: On Thu, 10 Apr 2014, Hannes Reinecke wrote: On 04/10/2014 12:58 PM, Andreas Reis wrote: That patch appears to work in preventing the crashes, judged on one repeated appearance of the bug.

Re: hpsa driver bug crack kernel down!

2014-04-09 Thread James Bottomley
[+linux-scsi] On Wed, 2014-04-09 at 15:49 -0700, Davidlohr Bueso wrote: On Wed, 2014-04-09 at 10:39 +0800, Baoquan He wrote: Hi, The kernel is 3.14.0+ which is pulled just now. Cc'ing more people. While the hpsa driver appears to be involved in some way, I'm sure if this is a

Re: hpsa driver bug crack kernel down!

2014-04-09 Thread James Bottomley
On Wed, 2014-04-09 at 16:08 -0700, James Bottomley wrote: [+linux-scsi] On Wed, 2014-04-09 at 15:49 -0700, Davidlohr Bueso wrote: On Wed, 2014-04-09 at 10:39 +0800, Baoquan He wrote: Hi, The kernel is 3.14.0+ which is pulled just now. Cc'ing more people. While the hpsa

Re: hpsa driver bug crack kernel down!

2014-04-09 Thread James Bottomley
On Wed, 2014-04-09 at 16:40 -0700, Davidlohr Bueso wrote: On Wed, 2014-04-09 at 16:10 -0700, James Bottomley wrote: On Wed, 2014-04-09 at 16:08 -0700, James Bottomley wrote: [+linux-scsi] On Wed, 2014-04-09 at 15:49 -0700, Davidlohr Bueso wrote: On Wed, 2014-04-09 at 10:39 +0800

Re: [Bug 73621] Kernel exception loading sym53c8xx on dual AMD Athlon Tyan S2460 motherboard

2014-04-08 Thread James Bottomley
On Tue, 2014-04-08 at 09:39 +, bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=73621 Alan a...@lxorguk.ukuu.org.uk changed: What|Removed |Added

[GIT PULL] First round of SCSI updates for the 3.14+ merge window

2014-04-01 Thread James Bottomley
() megaraid_sas_fusion: Return correct error value in megasas_get_ld_map_info() megaraid_sas_fusion: correctly pass queue info pointer bfa: set correct command return code hpsa: fixup MSI-X registration scsi_error: disable eh_deadline if no host_reset_handler is set James Bottomley (2

Re: [PATCH] aic79xx: fix misuse of static variables

2014-04-01 Thread James Bottomley
On Sun, 2014-03-30 at 15:30 +0200, Mathias Krause wrote: The format strings for various printk()s make use of a temporary variable that is declared 'static'. This is probably not intended, so fix those. Actually, it was intended. It was to work around an assignment to const gcc bug: some

Re: [PATCH 0/3] Fix USB deadlock caused by SCSI error handling

2014-03-31 Thread James Bottomley
[lets split the thread] On Mon, 2014-03-31 at 16:37 +0200, Hannes Reinecke wrote: On 03/31/2014 03:33 PM, Alan Stern wrote: On Mon, 31 Mar 2014, Hannes Reinecke wrote: On 03/28/2014 08:29 PM, Alan Stern wrote: On Fri, 28 Mar 2014, James Bottomley wrote: Maybe scmd_eh_abort_handler

[PATCH 3/3] [SCSI] Fix command result state propagation

2014-03-28 Thread James Bottomley
. Fix this by properly zeroing the scmd-status before the command is resubmitted. Signed-off-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: James Bottomley jbottom...@parallels.com --- drivers/scsi/scsi_error.c | 1 + drivers/scsi/scsi_lib.c | 1 + 2 files changed, 2 insertions(+) diff

[PATCH 1/3] [SCSI] Fix abort state memory problem

2014-03-28 Thread James Bottomley
The abort state is being stored persistently across commands, meaning if the command times out a second time, the error handler thinks an abort is still pending. Fix this by properly resetting the abort flag after the abort is finished. Signed-off-by: James Bottomley jbottom...@parallels.com

[PATCH 0/3] Fix USB deadlock caused by SCSI error handling

2014-03-28 Thread James Bottomley
This is a set of three patches we agreed to a while ago to eliminate a USB deadlock. I did rewrite the first patch, if it could be reviewed and tested. Thanks, James --- Alan Stern (1): [SCSI] Fix command result state propagation James Bottomley (2): [SCSI] Fix abort state memory problem

[PATCH 2/3] [SCSI] Fix spurious request sense in error handling

2014-03-28 Thread James Bottomley
this by testing to see if we actually got a CHECK_CONDITION return and skip asking for sense if we don't. Tested-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: James Bottomley jbottom...@parallels.com --- drivers/scsi/scsi_error.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: Deadlock in usb-storage error handling

2014-03-28 Thread James Bottomley
On Thu, 2014-03-20 at 15:49 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: On Thu, 2014-03-20 at 12:34 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: OK, so I think we have three things to do 1. Investigate SCSI and fix it's

Re: [linux-next] scsi_attach_vpd() warning at mm/page_alloc.c:2497

2014-03-27 Thread James Bottomley
On Thu, 2014-03-27 at 13:19 +0300, Sergey Senozhatsky wrote: Hello, [1.971778] [ cut here ] [1.971960] WARNING: CPU: 1 PID: 6 at mm/page_alloc.c:2497 __alloc_pages_nodemask+0x1b9/0x693() [1.972246] Modules linked in: sd_mod ahci [1.972604] CPU: 1

Re: [PATCH 16/39] virtio_scsi: use cmd_size

2014-03-27 Thread James Bottomley
On Tue, 2014-03-25 at 16:36 +0100, Paolo Bonzini wrote: Il 25/03/2014 16:31, Christoph Hellwig ha scritto: Paolo, do you have a virtio_scsi tree to picks this up in? We now have all the infrastructure for it in James' tree. I don't, I usually just give my Acked-by and James picks it

Re: please fix FUSION (Was:[v3.13][v3.14][Regression]kthread:makekthread_create()killable)

2014-03-23 Thread James Bottomley
On Sun, 2014-03-23 at 09:04 +0100, Thomas Gleixner wrote: On Sun, 23 Mar 2014, Tetsuo Handa wrote: Thomas Gleixner wrote: But then systemd/udev mutters: You migh be able to work around the timeout with udev rules and OPTIONS+=event_timeout=120, but that code was maybe

Re: please fix FUSION (Was:[v3.13][v3.14][Regression]kthread:makekthread_create()killable)

2014-03-23 Thread James Bottomley
On Sun, 2014-03-23 at 15:28 +0100, Thomas Gleixner wrote: On Sun, 23 Mar 2014, James Bottomley wrote: On Sun, 2014-03-23 at 09:04 +0100, Thomas Gleixner wrote: On Sun, 23 Mar 2014, Tetsuo Handa wrote: Thomas Gleixner wrote: But then systemd/udev mutters: You migh

Re: please fix FUSION (Was: [v3.13][v3.14][Regression]kthread:makekthread_create()killable)

2014-03-22 Thread James Bottomley
On Sat, 2014-03-22 at 20:25 +0100, Oleg Nesterov wrote: On 03/22, Tetsuo Handa wrote: Oleg Nesterov wrote: Tetsuo, what do you think? I don't like blocking SIGKILL while doing operations that depend on memory allocation by other processes. If the OOM killer is triggered and it chose

Re: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig

2014-03-22 Thread James Bottomley
On Sat, 2014-03-22 at 11:13 -0700, Laura Abbott wrote: Rather than have architectures #define ARCH_HAS_SG_CHAIN in an architecture specific scatterlist.h, make it a proper Kconfig option and use that instead. At same time, remove the header files are are now mostly useless and just include

Re: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig

2014-03-22 Thread James Bottomley
On Sat, 2014-03-22 at 22:23 +, Russell King - ARM Linux wrote: On Sat, Mar 22, 2014 at 02:31:21PM -0700, James Bottomley wrote: Perhaps now might be the time to ask which are the remaining architectures that cannot do SG chaining and then we can fix them and pull the whole thing out

Re: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig

2014-03-22 Thread James Bottomley
On Sat, 2014-03-22 at 22:52 +, Russell King - ARM Linux wrote: On Sat, Mar 22, 2014 at 03:37:40PM -0700, James Bottomley wrote: On Sat, 2014-03-22 at 22:23 +, Russell King - ARM Linux wrote: On Sat, Mar 22, 2014 at 02:31:21PM -0700, James Bottomley wrote: Perhaps now might

Re: please fix FUSION (Was: [v3.13][v3.14][Regression] kthread:makekthread_create()killable)

2014-03-21 Thread James Bottomley
On Fri, 2014-03-21 at 12:32 -0700, Linus Torvalds wrote: On Fri, Mar 21, 2014 at 11:34 AM, Oleg Nesterov o...@redhat.com wrote: Yes, it seems that it actually needs 30 secs. It spends most of the time (30.13286 seconds) in [..] So how about taking a completely different approach: -

Re: [PATCH] Fixup vpd page length calculation

2014-03-20 Thread James Bottomley
On Thu, 2014-03-20 at 08:19 +0100, Hannes Reinecke wrote: The VPD page length parameter is not only used for the length, but also to hold any error code. So it needs to be moved to an integer. And we should be resetting the default VPD page length after each iteration so that we do not

Re: [PATCH 6/6] Invalidate VPD page data

2014-03-20 Thread James Bottomley
On Sat, 2014-03-15 at 09:51 +0100, Hannes Reinecke wrote: Add a flag 'vpd_invalid' to the SCSI device to indicate that the VPD data needs to be refreshed. This is required if either a manual rescan is triggered or if the sense code INQUIRY DATA HAS CHANGED has been received. Signed-off-by:

Re: Deadlock in usb-storage error handling

2014-03-20 Thread James Bottomley
On Thu, 2014-03-20 at 11:36 -0400, Alan Stern wrote: On Wed, 19 Mar 2014, James Bottomley wrote: Basically, usb-storage deadlocks when the SCSI error handler invokes the eh_device_reset_handler callback while a command is running. The command has timed out and will never complete

Re: Deadlock in usb-storage error handling

2014-03-20 Thread James Bottomley
On Thu, 2014-03-20 at 12:34 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: OK, so I think we have three things to do 1. Investigate SCSI and fix it's abort state problem that's causing it not to send the abort second time around 2. Fix usb

Re: Deadlock in usb-storage error handling

2014-03-20 Thread James Bottomley
On Thu, 2014-03-20 at 12:34 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: OK, so I think we have three things to do 1. Investigate SCSI and fix it's abort state problem that's causing it not to send the abort second time around 2. Fix usb

Re: Deadlock in usb-storage error handling

2014-03-20 Thread James Bottomley
On Thu, 2014-03-20 at 15:48 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: On Thu, 2014-03-20 at 12:34 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: OK, so I think we have three things to do 1. Investigate SCSI and fix it's

Re: Deadlock in usb-storage error handling

2014-03-20 Thread James Bottomley
On Thu, 2014-03-20 at 15:59 -0400, Alan Stern wrote: On Thu, 20 Mar 2014, James Bottomley wrote: OK, so I think we have three things to do 1. Investigate SCSI and fix it's abort state problem that's causing it not to send the abort second time around 2. Fix usb

Re: [PATCH] [SCSI] megaraid: use GFP_ATOMIC under spin lock

2014-03-19 Thread James Bottomley
On Wed, 2014-03-19 at 07:21 +, Desai, Kashyap wrote: -Original Message- From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] Sent: Thursday, March 13, 2014 4:00 PM To: Saxena, Sumit Cc: Wei Yongjun; DL-MegaRAID Linux; simon.pu...@gmail.com; jkos...@suse.cz

Re: [PATCH RESEND 4/7] ipr: Get rid of superfluous call to pci_disbale_msi/msix()

2014-03-19 Thread James Bottomley
On Wed, 2014-03-12 at 16:08 -0500, wenxi...@vmlinux.vnet.ibm.com wrote: From: Alexander Gordeev agord...@redhat.com There is no need to call pci_disable_msi() or pci_disable_msix() in case the call to pci_enable_msi() or pci_enable_msix() failed. Signed-off-by: Alexander Gordeev

Re: [PATCH RESEND 4/7] ipr: Get rid of superfluous call to pci_disbale_msi/msix()

2014-03-19 Thread James Bottomley
On Wed, 2014-03-19 at 15:26 -0500, Brian King wrote: On 03/19/2014 02:55 PM, James Bottomley wrote: On Wed, 2014-03-12 at 16:08 -0500, wenxi...@vmlinux.vnet.ibm.com wrote: From: Alexander Gordeev agord...@redhat.com There is no need to call pci_disable_msi() or pci_disable_msix

Re: Deadlock in usb-storage error handling

2014-03-19 Thread James Bottomley
On Wed, 2014-03-19 at 16:31 -0400, Alan Stern wrote: On Wed, 19 Mar 2014, Andreas Reis wrote: I've uploaded a dmesg with the new debugging patch to bugzilla: https://bugzilla.kernel.org/attachment.cgi?id=130041 Thanks. I have now managed to reproduce many of the features of this

Re: [Pv-drivers] [PATCH 2/3] VMW_PVSCSI: Add support for I/O requests coalescing.

2014-03-19 Thread James Bottomley
On Tue, 2014-03-11 at 13:51 -0700, Arvind Kumar wrote: Fixed an issue with log message's prefix. Should have been vmw_pvscsi, was pvscsi. Resending. Please consider this one. Thanks! This change allows pvscsi driver to coalesce I/O requests before issuing them. The number of I/O's

Re: [PATCH 02/11][SCSI]mpt2sas: Added new driver module Parameter disable_eedp to Disable EEDP Support

2014-03-19 Thread James Bottomley
On Fri, 2014-03-14 at 16:37 -0400, Martin K. Petersen wrote: Sreekanth == Reddy, Sreekanth sreekanth.re...@lsi.com writes: Sreekanth A new mpt2sas driver module parameter 'disable_eedp' is added Sreekanth to Disable EEDP support. By default DIF support is enabled in Sreekanth the driver and

Re: [scsi:for-next 200/200] drivers/scsi/scsi_sysfs.c:778: warning: comparison is always false due to limited range of data type

2014-03-19 Thread James Bottomley
to sysfs :: TO: Hannes Reinecke h...@suse.de :: CC: James Bottomley jbottom...@parallels.com Actually, it's not just this that's a problem. Since the _len variables are unsigned chars, they're bogus in more ways than having errors put into them because the lengths of the pages can go

Re: [PATCH 6/6] Invalidate VPD page data

2014-03-18 Thread James Bottomley
On Tue, 2014-03-18 at 07:52 +0100, Hannes Reinecke wrote: On 03/17/2014 11:11 PM, Jeremy Linton wrote: On 3/15/2014 3:51 AM, Hannes Reinecke wrote: Add a flag 'vpd_invalid' to the SCSI device to indicate that the VPD data needs to be refreshed. This is required if either a manual rescan

Re: DMA-API mapping errors in vmw_pvscsi

2014-03-17 Thread James Bottomley
On Mon, 2014-03-17 at 12:52 -0400, Josh Boyer wrote: Hi All, We've had a few reports[1][2] now on the vmw_pvscsi driver throwing DMA-API mapping errors when the DMA_API_DEBUG option is enabled. I've included one from a recent 3.14-rc6 kernel below. Looking at vmw_pvscsi.c, I can see

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-16 Thread James Bottomley
On Sat, 2014-03-15 at 16:35 -0700, Dan Williams wrote: On Sat, Mar 15, 2014 at 2:47 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Fri, 2014-03-14 at 13:11 -0700, Dan Williams wrote: On Mon, Mar 10, 2014 at 11:29 PM, James Bottomley james.bottom

[GIT PULL] SCSI fixes for 3.14-rc6

2014-03-15 Thread James Bottomley
This is a set of six fixes. Two are instant crash/null deref types (storvsc and isci reset fixes). The two qla2xxx are initialisation problems that cause MSI-X failures and card misdetection, the isci erroneous macro is actually illegal C that's causing a miscompile with certain gcc versions and

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-15 Thread James Bottomley
On Fri, 2014-03-14 at 13:11 -0700, Dan Williams wrote: On Mon, Mar 10, 2014 at 11:29 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: In the long game, though this whole debate is moot: setups with hard wired start times adhere to them regardless of what the system does, so

<    5   6   7   8   9   10   11   12   13   14   >