[PATCH v2 12/21] lpfc: Revise NVME module parameter descriptions for better clarity

: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index f02269b46049..65886646a16f 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b

[PATCH v2 18/21] lpfc: Extend RDP support

, extend RDP support with the additional fields and send a multi-frame sequence. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_els.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b

[PATCH v2 19/21] lpfc: Fix oops of nvme host during driver unload.

ff-by: James Smart --- v2: reduce scope to only submit routines. aborts necessary for cleanup. this was a bug found after submit. drivers/scsi/lpfc/lpfc_nvme.c | 8 drivers/scsi/lpfc/lpfc_nvmet.c | 11 +++ 2 files changed, 19 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_n

[PATCH v2 11/21] lpfc: Set missing abort context

Always set ctxp->state to LPFC_NVMET_STE_ABORT if ABORT op gets called Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_nvmet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/s

[PATCH v2 20/21] lpfc: correct nvme sg segment count check

would be a significant rework. Add this item to the list to be refactored in the merge with efct. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/dr

[PATCH v2 14/21] lpfc: Disable NPIV support if NVME is enabled

Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_vport.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_vport.c b/drivers/scsi/lpfc/lpfc_vport.c index c714482bf4c5..c9d33b1268cb 100644 --- a/drivers/scsi

[PATCH v2 17/21] lpfc: Ensure io aborts interlocked with the target.

from ABTS-LS. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_nvme.c | 59 +-- 1 file changed, 34 insertions(+), 25 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi

[PATCH v2 08/21] lpfc: Move CQ processing to a soft IRQ

moves all the real work into the workq element. As nvmet_fc upcalls are no longer in ISR context, don't set the feature flags Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc.h | 3 + drivers/scsi/lpfc/lpfc_init.c

[PATCH v2 21/21] lpfc: change version to 11.4.0.4

From: Dick Kennedy Change version to 11.4.0.4 Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc

[PATCH v2 16/21] lpfc: Fix secure firmware updates

length. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_hw4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hw4.h b/drivers/scsi/lpfc/lpfc_hw4.h index 1db0a38683f4..2b145966c73f

[PATCH v2 04/21] lpfc: Fix lpfc nvme host rejecting IO with Not Ready message

lpfc_nvme_register_rport, rework the "rebind" case to break the nvme rport<->ndlp association when the ndlp already has an nrport. Then rebind the rport to the correct ndlp data and backpointers. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- d

[PATCH v2 10/21] lpfc: Reduce log spew on controller reconnects

the admin very concerned. Convert the messages to Info. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_nvme.c | 6 +++--- drivers/scsi/lpfc/lpfc_nvmet.c | 16 ++-- 2 files changed, 13 insertions(+), 9 deletions

[PATCH v2 05/21] lpfc: Fix warning messages when NVME_TARGET_FC not defined

From: Dick Kennedy Warning messages when NVME_TARGET_FC not defined on ppc builds The lpfc_nvmet_replenish_context() function is only meaningful when NVME target mode enabled. Surround the function body with ifdefs for target mode enablement. Signed-off-by: Dick Kennedy Signed-off-by: James

[PATCH v2 02/21] lpfc: fix pci hot plug crash in list_add call

-by: James Smart --- v2: original v1 hot plug patch split into 2 patches drivers/scsi/lpfc/lpfc_sli.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 8b119f87b51d..b8513c1adcef 100644 --- a

[PATCH v2 09/21] lpfc: Fix FCP hba_wqidx assignment

From: Dick Kennedy The driver is encountering oops in lpfc_sli_calc_ring. The driver is setting hba_wqidx for FCP based on the policy in use for NVME. The two may not be the same. Change to set the wqidx based on the FCP policy. Cc: # 4.12+ Signed-off-by: Dick Kennedy Signed-off-by: James

[PATCH v2 06/21] lpfc: PLOGI failures during NPIV testing

From: Dick Kennedy Local Reject/Invalid RPI errors seen during discovery. Temporary RPI cleanup was occurring regardless of SLI rev. It's only necessary on SLI-4. Adjust the test for whether cleanup is necessary. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Joh

[PATCH v2 15/21] lpfc: Fix crash in lpfc_nvme_fcp_io_submit during LIP

ccurs where we enter the routine as the teardown is happening in a separate thread, validate the parameters before starting the io. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_nvme.c | 10 ++ 1 file changed, 10 inser

[PATCH v2 01/21] lpfc: fix pci hot plug crash in timer management routines

stopped the timers properly. Cc: # 4.12+ Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- v2: original v1 hot plug patch split into 2 patches drivers/scsi/lpfc/lpfc_init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c

[PATCH v2 00/21] lpfc updates for 11.4.0.4

irmware updates lpfc: Ensure io aborts interlocked with the target. lpfc: Extend RDP support lpfc: Fix oops of nvme host during driver unload. lpfc: change version to 11.4.0.4 James Smart (3): lpfc: Reduce log spew on controller reconnects lpfc: Set missing abort context lpfc: corre

[PATCH v2 03/21] lpfc: Fix crash receiving ELS while detaching driver

receive an ELS and process it. When it tries to use the ndlp pointer will be NULL Change the order of the pci_remove_one vs disable interrupts so that interrupts are disabled before the ndlp's are freed. Cc: # 4.12+ Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Joh

[PATCH v2 07/21] lpfc: Make ktime sampling more accurate

additional sanity checks when deciding whether to accept an IO sample or not. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 34 ++- drivers/scsi/lpfc/lpfc_nvmet.c | 99 -- drivers/scsi/lpfc/lpfc_sli.c

Re: [PATCH 3/6] scsi: lpfc: Cocci spatch "pool_zalloc-simple"

On 9/20/2017 11:15 PM, Thomas Meyer wrote: Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" Signed-off-by: Thomas Meyer --- Looks good. Thanks. Signed-off-by: James Smart

[PATCH 16/19] lpfc: Ensure io aborts interlocked with the target.

from ABTS-LS. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 59 +-- 1 file changed, 34 insertions(+), 25 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c index 02ba06f364c4

[PATCH 06/19] lpfc: Make ktime sampling more accurate

additional sanity checks when deciding whether to accept an IO sample or not. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 34 ++- drivers/scsi/lpfc/lpfc_nvmet.c | 99 -- drivers/scsi/lpfc/lpfc_sli.c

[PATCH 13/19] lpfc: Disable NPIV support if NVME is enabled

Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_vport.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_vport.c b/drivers/scsi/lpfc/lpfc_vport.c index c714482bf4c5..c9d33b1268cb 100644 --- a/drivers/scsi/lpfc/lpfc_vport.c +++ b/drivers/scsi

[PATCH 18/19] lpfc: Fix oops of nvme host during driver unload.

ff-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 14 ++ drivers/scsi/lpfc/lpfc_nvmet.c | 11 +++ 2 files changed, 25 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c index e3642c1890ea..e01e67856458 100644 --- a/drivers/scsi

[PATCH 17/19] lpfc: Extend RDP support

, extend RDP support with the additional fields and send a multi-frame sequence. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index

[PATCH 19/19] lpfc: change version to 11.4.0.4

From: Dick Kennedy Change version to 11.4.0.4 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 6aa192b3e4bf

[PATCH 10/19] lpfc: Set missing abort context

Always set ctxp->state to LPFC_NVMET_STE_ABORT if ABORT op gets called Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvmet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c in

[PATCH 12/19] lpfc: Fix oops if nvmet_fc_register_targetport fails

-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvmet.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c index ee88343f3e8c..55badeace591 100644 --- a/drivers/scsi/lpfc/lpfc_nvmet.c +++ b/drivers

[PATCH 15/19] lpfc: Fix secure firmware updates

length. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hw4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hw4.h b/drivers/scsi/lpfc/lpfc_hw4.h index 1db0a38683f4..2b145966c73f 100644 --- a/drivers/scsi/lpfc

[PATCH 09/19] lpfc: Reduce log spew on controller reconnects

the admin very concerned. Convert the messages to Info. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 6 +++--- drivers/scsi/lpfc/lpfc_nvmet.c | 17 +++-- 2 files changed, 14 insertions(+), 9 deletions(-) --- drivers/scsi/lpfc

[PATCH 11/19] lpfc: Revise NVME module parameter descriptions for better clarity

: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index dc6519b2c53a..4dcd129ca901 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c

[PATCH 07/19] lpfc: Move CQ processing to a soft IRQ

moves all the real work into the workq element. As nvmet_fc upcalls are no longer in ISR context, don't set the feature flags Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 3 + drivers/scsi/lpfc/lpfc_init.c | 15 + drivers/scsi

[PATCH 14/19] lpfc: Fix crash in lpfc_nvme_fcp_io_submit during LIP

ccurs where we enter the routine as the teardown is happening in a separate thread, validate the parameters before starting the io. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi

[PATCH 00/19] lpfc updates for 11.4.0.4

This patch set provides a number of bug fixes and additions to the driver. The patches were cut against the Martin's 4.14/scsi-queue tree. There are no outside dependencies. lpfc: Fix crash in pci hot plug situations lpfc: Fix crash receiving ELS while detaching driver lpfc: Fix lpfc nvme

[PATCH 01/19] lpfc: Fix crash in pci hot plug situations

management code The sli4 remove_one handler is not stoping the timers as it starts to remove the port so that it can be swapped. Fix: Stop the timers early in the routine. Note: Fix in SLI-4 only. SLI-3 already stopped the timers properly. Signed-off-by: Dick Kennedy Signed-off-by: James Smart

[PATCH 03/19] lpfc: Fix lpfc nvme host rejecting IO with Not Ready message

lpfc_nvme_register_rport, rework the "rebind" case to break the nvme rport<->ndlp association when the ndlp already has an nrport. Then rebind the rport to the correct ndlp data and backpointers. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/

[PATCH 02/19] lpfc: Fix crash receiving ELS while detaching driver

receive an ELS and process it. When it tries to use the ndlp pointer will be NULL Change the order of the pci_remove_one vs disable interrupts so that interrupts are disabled before the ndlp's are freed. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_a

[PATCH 08/19] lpfc: Fix FCP hba_wqidx assignment

From: Dick Kennedy The driver is encountering oops in lpfc_sli_calc_ring. The driver is setting hba_wqidx for FCP based on the policy in use for NVME. The two may not be the same. Change to set the wqidx based on the FCP policy. Signed-off-by: Dick Kennedy Signed-off-by: James Smart

[PATCH 05/19] lpfc: PLOGI failures during NPIV testing

From: Dick Kennedy Local Reject/Invalid RPI errors seen during discovery. Temporary RPI cleanup was occurring regardless of SLI rev. It's only necessary on SLI-4. Adjust the test for whether cleanup is necessary. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi

[PATCH 04/19] lpfc: Fix warning messages when NVME_TARGET_FC not defined

From: Dick Kennedy Warning messages when NVME_TARGET_FC not defined on ppc builds The lpfc_nvmet_replenish_context() function is only meaningful when NVME target mode enabled. Surround the function body with ifdefs for target mode enablement. Signed-off-by: Dick Kennedy Signed-off-by: James

Re: [PATCH RESEND] lpfc: Don't return internal MBXERR_ERROR code from probe function

On 9/14/2017 6:19 PM, Martin K. Petersen wrote: James/Dick, Please review! It seemed to be changing so I was waiting for the final posting... -- james

Re: [PATCH] scsi: lpfc: remove redundant null check on eqe

ng Yep. thank you Signed-off-by: James Smart

Re: [PATCH v2] scsi: lpfc: avoid false positive gcc-8 warning

, then I'll submit that as a proper patch with your Ack. Signed-off-by: Arnd Bergmann --- a/drivers/scsi/lpfc/lpfc_debugfs.h I'm ok with either solution. I prefer less change but this is a trivial thing. Signed-off-by: James Smart -- james

[PATCH v2] scsi: lpfc: avoid false positive gcc-8 warning

ween the two so assumes eq may not a have a value. I believe, simply initializing with a NULL will solve the issue. Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_debugfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_debugfs.h b/drivers/s

[PATCH v3 20/20] lpfc: lpfc version bump 11.4.0.3

From: Dick Kennedy Update driver version to 11.4.0.3 Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers

[PATCH v3 18/20] lpfc: Add Buffer to Buffer credit recovery support

Add Buffer to buffer credit recovery support to the driver. This is a negotiated feature with the peer that allows for both sides to detect dropped RRDY's and FC Frames and recover credit. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers

[PATCH v3 05/20] lpfc: convert info messages to standard messages

From: Dick Kennedy Transitioned some informational discovery messages to now always be displayed when log_verbose is set. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_ct.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v3 12/20] lpfc: Limit amount of work processed in IRQ

: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 31 +++ drivers/scsi/lpfc/lpfc_sli4.h | 1 + 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 6569fffb8b71

[PATCH v3 06/20] lpfc: Correct return error codes to align with nvme_fc transport

o WQE state. This allows lpfc_nvme_fcp_io_submit() routine to just return whatever -E value was returned from other routines. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- v3: slight reword of patch description per review --- drivers/scsi/lpfc/lpfc_n

[PATCH v3 17/20] lpfc: remove console log clutter

Change hw queue binding messages to info - not error. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc

[PATCH v3 15/20] lpfc: Fix nvme target failure after 2nd adapter reset

by recreating the localport in the adapter reset recovery routine. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- v3: rework indentation per review comment --- drivers/scsi/lpfc/lpfc_init.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v3 19/20] scsi: lpfc: fix "integer constant too large" error on 32bit archs

From: Maurizio Lombardi cc1: warnings being treated as errors drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_get_wwpn': drivers/scsi/lpfc/lpfc_init.c:3253: error: integer constant is too large for 'long' type Signed-off-by: Maurizio Lombardi Signed-off-by: James Smart R

[PATCH v3 08/20] lpfc: Fix duplicate NVME rport entries and namespaces.

rport to sneak in as it was considered a separate device. This patch adds the fixes to Swap the nrport in each ndlp and take care of the reference counts on the ndlps similar to FCP rports. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- v3: revise co

[PATCH v3 13/20] lpfc: Fix MRQ > 1 context list handling

e can be allocated. if the condition reoccurs, it starts looking at a different cpu. Signed-off-by: Dick Kennedy Signed-off-by: James Smart -- v3: remove unnecessary typecast per review use list_splict_init per review --- drivers/scsi/lpfc/lpfc_attr.c| 11 +- drivers/scsi/lpfc/lpfc_c

[PATCH v3 14/20] lpfc: Fix relative offset error on large nvmet target ios

Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_nvmet.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c index 41abdef27909..ce871de70bf1 100644 --- a/drivers/scsi/lpfc

[PATCH v3 16/20] lpfc: Fix bad sgl reposting after 2nd adapter reset

the sgl lists - causing multiple 60s mbx timeouts. Fix by preserving all SGL lists over the fc port reset. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_nvme.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions

[PATCH v3 10/20] lpfc: Fix NVME PRLI handling during RSCN

assumption that the target always supports FC-NVME thus a PRLI is sent. It's ok for the target to reject it. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_els.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/dr

[PATCH v3 11/20] lpfc: Correct issues with FAWWN and FDISCs

nnedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 6de470e158ef..8d8fbfab0c9f 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -8

[PATCH v3 09/20] lpfc: Fix crash in lpfc nvmet when fc port is reset

recovery as well as strengthening the initialization of the bufferlist. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_init.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_init.c b

[PATCH v3 04/20] lpfc: Fix oops when NVME Target is discovered in a nonNVME environment

-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c index c18db8707fed..ce8d6bbf8148 100644 --- a/drivers/scsi/lpfc/lpfc_nvme.c +++ b/drivers/scsi/lpfc/lpfc_nvme.c @@ -2296,6 +2296,9

[PATCH v3 01/20] lpfc: Fix plogi collision that causes illegal state transition

e REGLOGIN mailbox command. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- v3: revise if test for better indentation per review removed unnecessary typecast --- drivers/scsi/lpfc/lpfc_els.c | 20 +++- 1 file changed, 19 insertions(+),

[PATCH v3 07/20] lpfc: Fix handling of FCP and NVME FC4 types in Pt2Pt topology

e protocol PRLI's are sent simultaneously. However, driver will now only state transition after both PRLI's are complete. New flags were added to aid tracking the responses from the different PRLI's. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- v3: small change to if te

[PATCH v3 03/20] lpfc: Fix rediscovery on switch blade pull

a LOGO is outstanding, it does not issue a PLOGI to the target upon link up Correct by placing the ndlp in UNUSED state When devloss happens in LOGO_ISSUE state. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_nportdisc.c | 13

[PATCH v3 00/20] lpfc updates for 11.4.0.3

essed in IRQ lpfc: Fix MRQ > 1 context list handling lpfc: Fix relative offset error on large nvmet target ios lpfc: Fix nvme target failure after 2nd adapter reset lpfc: Fix bad sgl reposting after 2nd adapter reset lpfc: lpfc version bump 11.4.0.3 James Smart (2): lpfc: remove con

[PATCH v3 02/20] lpfc: Fix loop mode target discovery

checking the topology during discovery. If it is loop, set the NLP FC4 type to FCP. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_nportdisc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/lpfc

Re: [PATCH] scsi: lpfc: avoid false-positive gcc-8 warning

), 1 deletion(-) looks good. Thanks Signed-off-by: James Smart -- james

Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test

issue was detected by Coverity and it was tested by compilation only. Notice that this code has been there since 2011. drivers/scsi/lpfc/lpfc_bsg.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) looks good. Thanks Signed-off-by: James Smart -- james

Re: [PATCH v2 12/20] lpfc: Limit amount of work processed in IRQ

On 8/7/2017 1:43 AM, Johannes Thumshirn wrote: On Fri, Aug 04, 2017 at 05:47:23PM -0700, James Smart wrote: From: Dick Kennedy Various oops being seen on being in the ISR too long and cpu lockups, when under heavy load. The amount of work being posted off of completion queues kept the ISR

Re: [PATCH v2 04/20] lpfc: Fix oops when NVME Target is discovered in a nonNVME environment

On 8/7/2017 1:00 AM, Johannes Thumshirn wrote: On Fri, Aug 04, 2017 at 05:47:15PM -0700, James Smart wrote: From: Dick Kennedy lpfc oops when it discovers a NVME target but is configured for SCSI only operation. Oops is in lpfc_nvme_register_port+0x33/0x300. Why does it even call

[PATCH v2 14/20] lpfc: Fix relative offset error on large nvmet target ios

Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvmet.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c index cd6c93a17760..40fa5dd72bfa 100644 --- a/drivers/scsi/lpfc/lpfc_nvmet.c +++ b/drivers/scsi/lpfc

[PATCH v2 17/20] lpfc: remove console log clutter

Change hw queue binding messages to info - not error. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c index 8e7cdbd5d7d3

[PATCH v2 12/20] lpfc: Limit amount of work processed in IRQ

: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 31 +++ drivers/scsi/lpfc/lpfc_sli4.h | 1 + 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index d68afec00f57

[PATCH v2 16/20] lpfc: Fix bad sgl reposting after 2nd adapter reset

the sgl lists - causing multiple 60s mbx timeouts. Fix by preserving all SGL lists over the fc port reset. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc

[PATCH v2 13/20] lpfc: Fix MRQ > 1 context list handling

e can be allocated. if the condition reoccurs, it starts looking at a different cpu. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c| 11 +- drivers/scsi/lpfc/lpfc_crtn.h| 5 +- drivers/scsi/lpfc/lpfc_debugfs.c | 11 +- drivers/scsi/lpfc/lpfc_i

[PATCH v2 09/20] lpfc: Fix crash in lpfc nvmet when fc port is reset

recovery as well as strengthening the initialization of the bufferlist. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c

[PATCH v2 10/20] lpfc: Fix NVME PRLI handling during RSCN

assumption that the target always supports FC-NVME thus a PRLI is sent. It's ok for the target to reject it. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/dr

[PATCH v2 15/20] lpfc: Fix nvme target failure after 2nd adapter reset

by recreating the localport in the adapter reset recovery routine. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc

[PATCH v2 11/20] lpfc: Correct issues with FAWWN and FDISCs

nnedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 9a8808abe61f..f97d578ea6bd 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -8

[PATCH v2 18/20] lpfc: Add Buffer to Buffer credit recovery support

Add Buffer to buffer credit recovery support to the driver. This is a negotiated feature with the peer that allows for both sides to detect dropped RRDY's and FC Frames and recover credit. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h

[PATCH v2 19/20] scsi: lpfc: fix "integer constant too large" error on 32bit archs

From: Maurizio Lombardi cc1: warnings being treated as errors drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_get_wwpn': drivers/scsi/lpfc/lpfc_init.c:3253: error: integer constant is too large for 'long' type Signed-off-by: Maurizio Lombardi Signed-off-by: James Smart

[PATCH v2 20/20] lpfc: lpfc version bump 11.4.0.3

From: Dick Kennedy Update driver version to 11.4.0.3 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index

[PATCH v2 07/20] lpfc: Fix handling of FCP and NVME FC4 types in Pt2Pt topology

e protocol PRLI's are sent simultaneously. However, driver will now only state transition after both PRLI's are complete. New flags were added to aid tracking the responses from the different PRLI's. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_di

[PATCH v2 08/20] lpfc: Fix duplicate NVME rport entries and namespaces.

rport to sneak in as it was considered a separate device. This patch adds the fixes to Swap the nrport in each ndlp and take care of the reference counts on the ndlps similar to FCP rports. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c

[PATCH v2 02/20] lpfc: Fix loop mode target discovery

checking the topology during discovery. If it is loop, set the NLP FC4 type to FCP. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nportdisc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc

[PATCH v2 03/20] lpfc: Fix rediscovery on switch blade pull

a LOGO is outstanding, it does not issue a PLOGI to the target upon link up Correct by placing the ndlp in UNUSED state When devloss happens in LOGO_ISSUE state. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nportdisc.c | 13 - 1 file changed, 8

[PATCH v2 05/20] lpfc: convert info messages to standard messages

From: Dick Kennedy Transitioned some informational discovery messages to now always be displayed when log_verbose is set. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_ct.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v2 06/20] lpfc: Correct return error codes to align with nvme_fc transport

ubmit() routine to just return whatever -E value was returned from other routines. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 9 - drivers/scsi/lpfc/lpfc_sli.c | 23 ++- 2 files changed, 18 insertions(+), 14 deletions(-) diff

[PATCH v2 01/20] lpfc: Fix plogi collision that causes illegal state transition

e REGLOGIN mailbox command. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 6d1d6f691df4..9e9aa8bb7

[PATCH v2 04/20] lpfc: Fix oops when NVME Target is discovered in a nonNVME environment

-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c index 0a0a1b92d01d..2f50df6a3dca 100644 --- a/drivers/scsi/lpfc/lpfc_nvme.c +++ b/drivers/scsi/lpfc/lpfc_nvme.c @@ -2296,6 +2296,9

[PATCH v2 00/20] lpfc updates for 11.4.0.3

Fix bad sgl reposting after 2nd adapter reset lpfc: lpfc version bump 11.4.0.3 James Smart (2): lpfc: remove console log clutter lpfc: Add Buffer to Buffer credit recovery support Maurizio Lombardi (1): scsi: lpfc: fix "integer constant too large" error on 32bit archs driver

Re: [PATCH 01/21] lpfc: Fix opps when ExpressLane is enabled

On 8/3/2017 3:43 AM, Nikola Pajkovsky wrote: James Smart writes: From: Dick Kennedy Null pointer dereference in lpfc_sli4_fof_intr_handler The driver does not set up cq->assoc_qp for sli4_hba->oas_cq Initialize cq->assoc_qp before accessing it Signed-off-by: Dick Kennedy Sign

[PATCH v2 1/2] nvmet_fc: add defer_req callback for deferment of cmd buffer return

lue must be returned to the LLDD to signify to hold off on recycling the cmd iu buffer. And later, when a job struct is allocated and the buffer copied, a new LLDD callback is introduced to notify the LLDD and allow it to recycle it's command iu buffer. Signed-off-by: James Smart --- V2

[PATCH v2 2/2] lpfc: support nvmet_fc defer_rcv callback

patch adds support for the new nvmet_fc transport defer_rcv callback and recognition of the new error code when passing commands to the transport. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- This patch is intended to enter the kernel through the nvme block tree which pulls in the

[PATCH v2 0/2] nvmet_fc: work around overalloc of queue elements

y an -EOVERFLOW status code return from nvmet_fc_rcv_fcp_req(). v2: respond to comments from Johannes. James Smart (2): nvmet_fc: add defer_req callback for deferment of cmd buffer return lpfc: support nvmet_fc defer_rcv callback drivers/nvme/target/fc.

[PATCH 20/21] lpfc: Add new adapter type 6 support

. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_debugfs.c | 20 +- drivers/scsi/lpfc/lpfc_debugfs.h | 11 +- drivers/scsi/lpfc/lpfc_hw4.h | 85 - drivers/scsi/lpfc/lpfc_init.c| 152 +-- drivers/scsi/lpfc/lpfc_nvme.c| 4 +- drivers

[PATCH 14/21] lpfc: Fix MRQ > 1 context list handling

e can be allocated. if the condition reoccurs, it starts looking at a different cpu. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c| 11 +- drivers/scsi/lpfc/lpfc_crtn.h| 5 +- drivers/scsi/lpfc/lpfc_debugfs.c | 11 +- drivers/scsi/lpfc/lpfc_i

[PATCH 07/21] lpfc: Correct return error codes to align with nvme_fc transport

ubmit() routine to just return whatever -E value was returned from other routines. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 9 - drivers/scsi/lpfc/lpfc_sli.c | 23 ++- 2 files changed, 18 insertions(+), 14 deletions(-) diff

[PATCH 02/21] lpfc: Fix plogi collision that causes illegal state transition

e REGLOGIN mailbox command. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 6d1d6f691df4..9e9aa8bb7

<    3   4   5   6   7   8   9   10   11   12   >