From: Xiang Chen <chenxian...@hisilicon.com>
Add code to prepare SSP frame and deliver it to hardware.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 208 ++
and sas address are read from the firmware,
same as platform device-based controller.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 6 ++
drivers/scsi/hisi_sas/hisi_sas_main.c | 18 +
licon.com>
Signed-off-by: John Garry <john.ga...@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c
b/drivers/scsi/hisi_sas/hisi_sas_main.c
index f720d
From: Xiang Chen <chenxian...@hisilicon.com>
Relocate get_ata_protocol() to a common location, as future hw
versions will require it.
Also rename with "hisi_sas_" prefix for consistency.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to prepare ATA frame for v3 hw
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 106 +
1
From: Xiang Chen <chenxian...@hisilicon.com>
Relocate get_ncq_tag_v2_hw() to a common location, as
future hw versions will require it.
Also rename with "hisi_sas_" prefix for consistency.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry
On 01/06/2017 06:41, Christoph Hellwig wrote:
+ case SAS_PROTOCOL_SSP:
+ {
+ unsigned char op = task->ssp_task.cmd->cmnd[0];
+
+ if (op == READ_6 || op == WRITE_6 ||
+ op == READ_10 || op == WRITE_10 ||
+ op ==
On 01/06/2017 06:41, Christoph Hellwig wrote:
> +static int interrupt_init_v3_hw(struct hisi_hba *hisi_hba)
> +{
> + struct device *dev = hisi_hba->dev;
> + struct pci_dev *pdev = hisi_hba->pci_dev;
> + int vectors, i, irq, rc;
> + int max_msi = HISI_SAS_MSI_COUNT_V3_HW;
> + int
in size, so, as a solution,
just make as an int.
Also, struct hisi_sas_device elements are re-ordered to improve
packing efficiency.
Signed-off-by: John Garry <john.ga...@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 8
drivers/scsi/hisi_sas/hisi_sas_main.c | 10 +--
m>
Signed-off-by: John Garry <john.ga...@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 9 ++---
drivers/scsi/hisi_sas/hisi_sas_main.c | 61 +++---
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 23 +
drivers/scsi/hisi_sas/his
From: Xiang Chen <chenxian...@hisilicon.com>
Relocate get_ncq_tag_v2_hw() to a common location, as
future hw versions will require it.
Also rename with "hisi_sas_" prefix for consistency.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry
From: Xiang Chen <chenxian...@hisilicon.com>
Relocate get_ata_protocol() to a common location, as future
hw versions will require it.
Also rename with "hisi_sas_" prefix for consistency.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry
it.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 6 -
drivers/scsi/hisi_sas/hisi_sas_main.c | 36 ++--
drivers/scsi/hisi_sas/hisi_sas_
Move the functionality to retrieve the fw info into
a dedicated device type-agnostic function,
hisi_sas_get_fw_info().
The reasoning is that this function will be required
for future pci-based platforms.
Also add some debug logs for failure.
Signed-off-by: John Garry <john.ga...@huawei.
licon.com>
Signed-off-by: John Garry <john.ga...@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c
b/drivers/scsi/hisi_sas/hisi_sas_main.c
index f720d
v2 hw bugs are fixed (hopefully), so workarounds are not
required
-support for device deregistration
-some interrupt modifications
-configurable max device support
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/s
From: Xiang Chen <chenxian...@hisilicon.com>
Relocate get_ata_protocol() to a common location, as future hw
versions will require it.
Also rename with "hisi_sas_" prefix for consistency.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry
From: Xiang Chen <chenxian...@hisilicon.com>
There is a change for abort dev for v3 hw: add registers to configure
unaborted iptt for a device, and then inform this to logic.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 402 -
1 file changed, 400 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to itct setup and free for v3 hw.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 114 +
1
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to prepare SSP frame and deliver it to hardware.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 208 ++
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to prepare SMP frame.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 74 ++
1 file chan
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to initialise v3 hardware.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 277 +
1
and sas address are read from the firmware,
same as platform device-based controller.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 6 ++
drivers/scsi/hisi_sas/hisi_sas_main.c | 18 +
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to prepare ATA frame for v3 hw
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 106 +
1
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to initialise interrupts and add some interrupt handlers.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to configure PHYs for v3 hw.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 127 -
1
From: Xiang Chen <chenxian...@hisilicon.com>
Add code for interface get_wideport_bitmap.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 14 ++
1 file changed, 14 i
From: Xiang Chen <chenxian...@hisilicon.com>
Add v3 cq interrupt handler slot_complete_v2_hw().
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 1 +
drivers/scsi/hisi_s
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to prepare internal abort command.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 38 ++
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to fill the interface of phy_hard_reset, phy_get_max_linkrate,
and phy enable/disable.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/his
bridge
- add comment in fatal axi error patch commit log regarding
controller reset
- eliminate hisi_sas_pci_init.c, and move functionality into
hisi_sas_v3_hw.c, eliminating one layer of indirection
John Garry (5):
scsi: hisi_sas: define hisi_sas_device.device_id as int
scsi: hisi_sas
is
On 29/05/2017 11:53, Arnd Bergmann wrote:
On Thu, May 25, 2017 at 2:04 PM, John Garry <john.ga...@huawei.com> wrote:
Move the functionality to retrieve the fw info into
a dedicated device type-agnostic function,
hisi_sas_get_fw_info().
The reasoning is that this function will be re
v2 hw bugs are fixed (hopefully), so workarounds are not
required
-support for device deregistration
-some interrupt modifications
-configurable max device support
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/s
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to configure PHYs for v3 hw.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 126 +
1
it.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 6 -
drivers/scsi/hisi_sas/hisi_sas_main.c | 36 ++--
drivers/scsi/hisi_sas/hisi_sas_
and sas address are read from the firmware,
same as platform device-based controller.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 6 ++
drivers/scsi/hisi_sas/hisi_sas_main.c | 18 +
itical regions still need to be locked in the delivery
and completion stages with hisi_hba.lock.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry <john.ga...@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 8 ++---
drivers/scsi/hisi_sas/his
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to initialise interrupts and add some interrupt handlers.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to initialise v3 hardware.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 276 +
1
Move the functionality to retrieve the fw info into
a dedicated device type-agnostic function,
hisi_sas_get_fw_info().
The reasoning is that this function will be required
for future pci-based platforms.
Also add some debug prints for failure.
Signed-off-by: John Garry <john.ga...@huawei.
From: Xiang Chen <chenxian...@hisilicon.com>
Relocate get_ncq_tag_v2_hw() to a common location, as
future hw versions will require it.
Also rename with "hisi_sas_" prefix for consistency.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to prepare SMP frame.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 74 ++
1 file chan
licon.com>
Signed-off-by: John Garry <john.ga...@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c
b/drivers/scsi/hisi_sas/hisi_sas_main.c
index f720d
From: Xiang Chen <chenxian...@hisilicon.com>
Add code for interface get_wide_port_bitmap_v3_hw().
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 13 +
1 file chan
From: Xiang Chen <chenxian...@hisilicon.com>
There is a change for abort dev for v3 hw: add registers to configure
unaborted iptt for a device, and then inform this to logic.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry <john.ga...@huawei.com>
From: Xiang Chen <chenxian...@hisilicon.com>
Relocate get_ata_protocol() to a common location, as future hw
versions will require it.
Also rename with "hisi_sas_" prefix for consistency.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to itct setup and free for v3 hw.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 115 +
1
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to fill the interface of phy_hard_reset, phy_get_max_linkrate,
and phy enable/disable.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/his
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to prepare SSP frame and deliver it to hardware.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 209 ++
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 401 -
1 file changed, 399 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw
From: Xiang Chen <chenxian...@hisilicon.com>
Relocate get_ata_protocol() to a common location, as future
hw versions will require it.
Also rename with "hisi_sas_" prefix for consistency.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry
From: Xiang Chen <chenxian...@hisilicon.com>
Add v3 cq interrupt handler slot_complete_v2_hw().
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 1 +
drivers/scsi/hisi_s
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to prepare ATA frame for v3 hw
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 106 +
1
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to prepare internal abort command.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 38 ++
of indirection
John Garry (4):
scsi: hisi_sas: add pci_dev in hisi_hba struct
scsi: hisi_sas: create hisi_sas_get_fw_info()
scsi: hisi_sas: add skeleton v3 hw driver
scsi: hisi_sas: add initialisation for v3 pci-based controller
Xiang Chen (18):
scsi: hisi_sas: fix timeout check
Hi,
There are some comments, inline.
In general, if it works, it looks ok.
Other reviews would be greatly appreciated - Hannes, Christoph,
Johannes, Dan - please.
> Libsas complete a hotplug event notified by LLDD in several works,
> for example, if libsas receive a PHYE_LOSS_OF_SIGNAL, we
ity-ID: 1373843
Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com>
Reviewed-by: John Garry <john.ga...@huawei.com>
On 22/05/2017 06:54, wangyijing wrote:
I also think for safety this should use a mempool that guarantees that
> events can continue to be processed under system memory pressure.
What I am worried about is it's would still fail if the mempool is used empty
during memory pressure.
> Also, have
Hi Arnd,
Currently there is no pci device listed in the ACPI tables.
What I am doing is declaring a fake device in the root of the System bus
tree of the ACPI tables, and in the kernel driver finding it by matching the
name. It is not the ACPI companion for the pci device.
So I think that we
On 17/05/2017 15:13, Arnd Bergmann wrote:
On Wed, May 17, 2017 at 3:37 PM, John Garry <john.ga...@huawei.com> wrote:
On 17/05/2017 13:37, Arnd Bergmann wrote:
Since this uses the _DSD information that was introduced for compatibility
between device tree and ACPI based data, why not
On 17/05/2017 13:37, Arnd Bergmann wrote:
On Wed, May 17, 2017 at 12:49 PM, John Garry <john.ga...@huawei.com> wrote:
> For a pci-based controller, retrieve the SAS address from the
> ACPI tables.
>
> The retrieval is based on the ACPI device node name. Sample is
> as
On 17/05/2017 13:33, Arnd Bergmann wrote:
On Wed, May 17, 2017 at 12:49 PM, John Garry <john.ga...@huawei.com> wrote:
> Add the code to initialise controller which is based on pci device
> in hisi_sas_pci_init.c
>
> The main functionality added is for probing
On 17/05/2017 13:27, Arnd Bergmann wrote:
On Wed, May 17, 2017 at 12:49 PM, John Garry <john.ga...@huawei.com> wrote:
> From: Xiang Chen <chenxian...@hisilicon.com>
>
> For ECC 1bit error, logic can recover it, so we only print a warning.
> For ECC multi-bit and AXI b
itical regions still need to be locked in the delivery
and completion stages with hisi_hba.lock.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry <john.ga...@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 8 ++---
drivers/scsi/hisi_sas/his
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to initialise v3 hardware.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 275 +
1
From: Xiang Chen <chenxian...@hisilicon.com>
Relocate get_ncq_tag_v2_hw() to a common location, as
future hw versions will require it.
Also rename with "hisi_sas_" prefix for consistency.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry
From: Xiang Chen <chenxian...@hisilicon.com>
Add code for itct setup and free for v3 hw.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 115 +++
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to configure PHYs for v3 hw.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 126 +
1
device support
Not yet supported:
- controller reset
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/Makefile | 1 +
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 57 +++
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to prepare SMP frame.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 74 ++
1 file chan
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to prepare SSP frame and deliver it to hardware.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 209 ++
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to initialise interrupts and add some interrupt handlers.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi
From: Xiang Chen <chenxian...@hisilicon.com>
There is a change for abort dev for v3 hw: add registers to configure
unaborted iptt for a device, and then inform this to logic.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry <john.ga...@huawei.com>
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to prepare internal abort command.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 38 ++
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to fill the interface of phy_hard_reset, phy_get_max_linkrate,
and phy enable/disable.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/his
From: Xiang Chen <chenxian...@hisilicon.com>
Add code to prepare ATA frame for v3 hw
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 106 +
1
and structures are also exported from
hisi_sas_main.c for pci init.
For platform device-based controller, controller properties - like
phy count - were read from the firmware. For pci-based controller this
information is hard-coded in the driver, in new struct hisi_sas_pci_hw.
Signed-off-by: John Garry
From: Xiang Chen <chenxian...@hisilicon.com>
Add v3 cq interrupt handler.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 1 +
drivers/scsi/hisi_sas/hisi_sas_main.c | 32
From: Xiang Chen <chenxian...@hisilicon.com>
Relocate get_ata_protocol() to a common location, as future hw
versions will require it.
Also rename with "hisi_sas_" prefix for consistency.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry
From: Xiang Chen <chenxian...@hisilicon.com>
Add code for interface get_wide_port_bitmap_v3_hw().
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 13 +
1 file chan
then we fall
back on a default address.
Signed-off-by: John Garry <john.ga...@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 2 +
drivers/scsi/hisi_sas/hisi_sas_pci_init.c | 104 ++
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c| 2 +-
3 files changed, 10
From: Xiang Chen <chenxian...@hisilicon.com>
For ECC 1bit error, logic can recover it, so we only print a warning.
For ECC multi-bit and AXI bus fatal error, we panic.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
From: Xiang Chen <chenxian...@hisilicon.com>
Relocate get_ata_protocol() to a common location, as future
hw versions will require it.
Also rename with "hisi_sas_" prefix for consistency.
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
Signed-off-by: John Garry
licon.com>
Signed-off-by: John Garry <john.ga...@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c
b/drivers/scsi/hisi_sas/hisi_sas_main.c
index d622d
it.
Signed-off-by: John Garry <john.ga...@huawei.com>
Signed-off-by: Xiang Chen <chenxian...@hisilicon.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 6 -
drivers/scsi/hisi_sas/hisi_sas_main.c | 36 ++--
drivers/scsi/hisi_sas/hisi_sas_
is added for pci
device-based controller in subsequent patches.
And then hip08 support is added in the final patches.
John Garry (4):
scsi: hisi_sas: add pci_dev in hisi_hba struct
scsi: hisi_sas: add the initialisation for pci-based controller
scsi: hisi_sas: add bare v3 hw driver
scsi: hisi_sas
On 24/04/2017 11:09, John Garry wrote:
On 21/04/2017 13:11, Johannes Thumshirn wrote:
Move scsi_remove_host call into sas_remove_host and remove it from SAS
HBA
drivers, so we don't mess up the ordering. This solves an issue with
double
deleting sysfs entries that was introduced by the change
("sysfs: make __sysfs_remove_dir() recursive").
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Suggested-by: Christoph Hellwig <h...@lst.de>
Cc: Hannes Reinecke <h...@suse.de>
Cc: James Bottomley <j...@linux.vnet.ibm.com>
Cc: Jinpu Wang <jinpu.w...@prof
On 21/04/2017 12:20, Christoph Hellwig wrote:
On Fri, Apr 21, 2017 at 09:57:37AM +0100, John Garry wrote:
On 21/04/2017 09:39, Johannes Thumshirn wrote:
wangyijing already sent an RFC for fixing this issue (mentioned above),
which was a signifiagnt rewrite of some of libsas.
I am hoping
On 21/04/2017 09:39, Johannes Thumshirn wrote:
wangyijing already sent an RFC for fixing this issue (mentioned above),
> which was a signifiagnt rewrite of some of libsas.
> I am hoping that he would retry, and that community would support/shepherd
> this activity, or at least say it will be
Thanks Johannes.
@wangyijing, can you test this patchset please (specifically 3/5)? I
know that you have the modified version of libsas which you dabbled with
upstreaming.
On 21/04/2017 09:04, Johannes Thumshirn wrote:
This series re-orders the calls to scsi_remove_host() and
mizing the flow of disabling
a PHY.
Signed-off-by: Xiaofei Tan <tanxiao...@huawei.com>
Signed-off-by: John Garry <john.ga...@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 127 -
1 file changed, 126 insertions(+), 1 deletion(-)
diff --
not
include these bugs, so it is better not pollute the driver
main layer with workarounds
This patchset also includes 2 other patches, one for a
possible NULL pointer deference and another for resetting
the controller for fatal AXI/ECC errors.
John Garry (2):
scsi: hisi_sas: add v2 hw internal abort
wei.com>
Signed-off-by: John Garry <john.ga...@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas.h | 1 +
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 60 +-
2 files changed, 60 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/driv
. Then internal abort command will
timeout.
As this issue is only in v2 hw, we deal with it in the hw layer.
Our workaround solution is:
If abort is not finished within a certain period of time, we will check
HOLD status. If HOLD has been sending, we will send break command.
Signed-off-by: John Garry
task.
Signed-off-by: John Garry <john.ga...@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 60 +++
1 file changed, 33 insertions(+), 27 deletions(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c
b/drivers/scsi/hisi_sas/hisi_sas_main.c
index a
On 29/03/2017 12:29, Johannes Thumshirn wrote:
On Wed, Mar 29, 2017 at 12:15:44PM +0100, John Garry wrote:
On 29/03/2017 10:41, Johannes Thumshirn wrote:
In the advent of an SAS device unregister we have to wait for all destruct
works to be done to not accidently delay deletion of a SAS rphy
On 29/03/2017 10:41, Johannes Thumshirn wrote:
In the advent of an SAS device unregister we have to wait for all destruct
works to be done to not accidently delay deletion of a SAS rphy or it's
children to the point when we're removing the SCSI or SAS hosts.
Signed-off-by: Johannes Thumshirn
is better.
Fixes: 7c594f0407de ("scsi: hisi_sas: add softreset function for SATA disk")
Signed-off-by: Arnd Bergmann <a...@arndb.de>
Signed-off-by: John Garry <john.ga...@huawei.com>
---
drivers/scsi/hisi_sas/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 d
301 - 400 of 790 matches
Mail list logo
