Re: [PATCH] scsi: fnic: fix msix interrupt allocation

2019-09-04 Thread John Pittman
Hi Martin, would you have a quick look at this one when you get a moment? Bugging you for selfish reasons as I'm trying to get this included in the next RHEL release. Thanks for any info. On Tue, Aug 27, 2019 at 5:20 PM Govindarajulu Varadarajan wrote: > > pci_alloc_irq_vectors() returns number

[PATCH] scsi: fnic: print port speed only at driver init or speed change

2019-08-23 Thread John Pittman
and if the speed changes. Also clean up a small typo in fnic_trace.c. Fixes: commit d948e6383ec3 ("scsi: fnic: Add port speed stat to fnic debug stats") Signed-off-by: John Pittman --- drivers/scsi/fnic/fnic_fcs.c | 14 ++ drivers/scsi/fnic/fnic_trace.c | 2 +-

[PATCH] scsi: remove reference to scsi_show_extd_sense()

2018-03-24 Thread John Pittman
In commit 2104551969e8 ("scsi: use per-cpu buffer for formatting sense"), function scsi_show_extd_sense() was removed, switching use over to scsi_format_extd_sense(). Remove last reference to scsi_show_extd_sense() in include/scsi/scsi_dbg.h. Signed-off-by: John Pittman --- in

[PATCH] scsi: scsi_dh_alua: Correct comment for alua_alloc_pg()

2018-03-14 Thread John Pittman
In the comment for function alua_alloc_pg() the argument '@h' is mistakenly referred to. Fix this by replacing it with the correct argument reference, '@tpgs', and provide a short description. Signed-off-by: John Pittman --- drivers/scsi/device_handler/scsi_dh_alua.c | 2 +

Re: [PATCH] scsi: scsi_debug: Fix pointer stying issues

2018-02-10 Thread John Pittman
Ha! Thanks for catching the typo Douglas. On Fri, Feb 9, 2018 at 9:53 PM, Douglas Gilbert wrote: > As per the subject line, I wouldn't mind putting these changes in with > the pigs :-) > > On 2018-02-09 09:12 PM, John Pittman wrote: >> >> Pointer styling issue

[PATCH] scsi: scsi_debug: Fix pointer stying issues

2018-02-09 Thread John Pittman
Pointer styling issues exposed by checkpatch.pl in scsi_debug.c: ERROR: "foo * bar" should be "foo *bar" Fixed 37 total errors reported. Signed-off-by: John Pittman --- drivers/scsi/scsi_debug.c | 72 +++ 1 file changed,

[PATCH] sd: Cleaned up comment references to @sdp argument explanation.

2017-01-12 Thread John Pittman
In sd.c there are two comment references to 'struct scsi_device *sdp' as an argument. One of the references has a typo and the other should be a reference to 'struct device *dev' instead. Fixed by correcting the typo in the first and changing the explanation in the second.

[PATCH] sd: Cleaned up comment references to @sdp argument explanation.

2017-01-12 Thread John Pittman
In sd.c there are two comment references to 'struct scsi_device *sdp' as an argument. One of the references has a typo and the other should be a reference to 'struct device *dev' instead. Fixed by correcting the typo in the first and changing the explanation in the second.