Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-09 Thread Josh Poimboeuf
On Tue, Jan 09, 2018 at 11:44:05AM -0800, Dan Williams wrote: > On Tue, Jan 9, 2018 at 11:34 AM, Jiri Kosina wrote: > > On Fri, 5 Jan 2018, Dan Williams wrote: > > > > [ ... snip ... ] > >> Andi Kleen (1): > >> x86, barrier: stop speculation for failed access_ok > >> > >> Dan Williams (13):

Re: [PATCH, RFT] byteswap: try to avoid __builtin_constant_p gcc bug

2016-04-27 Thread Josh Poimboeuf
ast there should be no downsides. > > Please test. > > Signed-off-by: Arnd Bergmann Nice patch. I can confirm it fixes the issue with gcc 5.3.1. Tested-by: Josh Poimboeuf Reviewed-by: Josh Poimboeuf > diff --git a/include/uapi/linux/swab.h b/include/uapi/linux/swab.h > index

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-25 Thread Josh Poimboeuf
James, Can you merge this patch for 4.6? On Tue, Apr 19, 2016 at 08:56:00AM -0500, Josh Poimboeuf wrote: > objtool reports [1] the following warning: > > drivers/scsi/qla2xxx/qla_attr.o: warning: objtool: > qla2x00_get_host_fabric_name() falls through to n

[PATCH] scsi: fc: force inlining of wwn conversion functions

2016-04-19 Thread Josh Poimboeuf
functions to be inlined. [1] https://lists.01.org/pipermail/kbuild-all/2016-April/019579.html [2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646 Reported-by: kbuild test robot Signed-off-by: Josh Poimboeuf --- include/scsi/scsi_transport_fc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-18 Thread Josh Poimboeuf
On Mon, Apr 18, 2016 at 04:07:51PM +0200, Arnd Bergmann wrote: > On Monday 18 April 2016 08:39:32 Josh Poimboeuf wrote: > > > > I agree. So how should we work around the bug in this case? There have > > been several suggestions: > > > > - chang

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-18 Thread Josh Poimboeuf
On Sat, Apr 16, 2016 at 11:03:32AM +0200, Ingo Molnar wrote: > > * Josh Poimboeuf wrote: > > > > I don't think we know yet if there's a reliable way to turn the bug off. > > > > > > Also, according to the gcc guys, this bug won't always resu

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-18 Thread Josh Poimboeuf
On Sat, Apr 16, 2016 at 09:42:37AM +0200, Arnd Bergmann wrote: > On Friday 15 April 2016 07:45:19 Ingo Molnar wrote: > > > > * Denys Vlasenko wrote: > > > > > > In fact, the following patch seems to fix it: > > > > > > > > diff --git a/include/scsi/scsi_transport_fc.h > > > > b/include/scsi/sc

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-15 Thread Josh Poimboeuf
On Fri, Apr 15, 2016 at 08:47:45AM -0500, Josh Poimboeuf wrote: > On Fri, Apr 15, 2016 at 07:45:19AM +0200, Ingo Molnar wrote: > > > > * Denys Vlasenko wrote: > > > > > > In fact, the following patch seems to fix it: > > > > > > > >

Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646

2016-04-15 Thread Josh Poimboeuf
On Fri, Apr 15, 2016 at 12:05:26PM -0700, James Bottomley wrote: > On Fri, 2016-04-15 at 20:56 +0200, Denys Vlasenko wrote: > > and now *many* users of qla2x00 and new-ish gcc are going to > > very much notice it, as their kernels will start crashing reliably. > > > > The commits can be reverted,

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-15 Thread Josh Poimboeuf
On Fri, Apr 15, 2016 at 07:45:19AM +0200, Ingo Molnar wrote: > > * Denys Vlasenko wrote: > > > > In fact, the following patch seems to fix it: > > > > > > diff --git a/include/scsi/scsi_transport_fc.h > > > b/include/scsi/scsi_transport_fc.h > > > index bf66ea6..56b9e81 100644 > > > --- a/incl

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-14 Thread Josh Poimboeuf
On Thu, Apr 14, 2016 at 05:29:06PM +0200, Denys Vlasenko wrote: > On 04/13/2016 07:10 PM, Josh Poimboeuf wrote: > >>>>>> From the disassembly of drivers/scsi/qla2xxx/qla_attr.o: > >>>>>> > >>>>>> 2f53 : > >>

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-13 Thread Josh Poimboeuf
On Wed, Apr 13, 2016 at 09:55:09AM -0700, James Bottomley wrote: > On Wed, 2016-04-13 at 10:15 -0500, Josh Poimboeuf wrote: > > On Wed, Apr 13, 2016 at 07:36:07AM -0500, Josh Poimboeuf wrote: > > > On Wed, Apr 13, 2016 at 02:12:25PM +0200, Denys Vlasenko wrote: > > > >

Re: [PATCH v2 6/8] tools rpmb: add RPBM access tool

2016-04-11 Thread Josh Poimboeuf
Hi Tomas, On Mon, Apr 04, 2016 at 02:11:22PM +0300, Tomas Winkler wrote: > Add simple RPMB host testing tool. It can be used > to program key, write and read data block, and retrieve > write counter. > > Signed-off-by: Tomas Winkler > --- > V2: resend > MAINTAINERS | 1 + > tools/Ma