On 09/11/2015 15:04, Hannes Reinecke wrote:
> On 11/09/2015 02:53 PM, Laurent Vivier wrote:
>> QEMU allows until 32 LUNs.
>>
>> Signed-off-by: Laurent Vivier <lviv...@redhat.com>
>> ---
>> drivers/scsi/ibmvscsi/ibmvscsi.c | 9 -
>> drive
This patch allows to define the maximum LUN numbers.
As defined in 4.6.9 of SAM-4, the encoding of LUN is
on 5 bits (max_lun=32) and the current value is only 8.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 9 -
drivers/scsi/ib
As devices with values greater than that are silently ignored,
this gives some hints to the sys admin to know why he doesn't see
his devices...
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++--
1 file changed, 6 insertions(+), 2 del
The value of the parameter is never re-read by the driver,
so a new value is ignored. Let know the user he
can't modify it by removing writable attribute.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
1 file changed, 2 insertions
As devices with values greater than that are silently ignored,
this gives some hints to the sys admin to know why he doesn't see
his devices...
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++--
1 file changed, 6 insertions(+), 2 del
QEMU allows until 32 LUNs.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 9 -
drivers/scsi/ibmvscsi/ibmvscsi.h | 1 +
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ib
ximum LUN: %d Maximum Channel: %d\n",
Laurent Vivier (3):
ibmvscsi: make parameters max_id and max_channel read-only
ibmvscsi: display default value for max_id, max_lun and max_channel.
ibmvscsi: Allow to configure maximum LUN
drivers/scsi/ibmvscsi/ibmvscsi.c | 21
On 09/11/2015 15:50, Hannes Reinecke wrote:
> On 11/09/2015 03:47 PM, Laurent Vivier wrote:
>> This patch allows to define the maximum LUN numbers.
>> As defined in 4.6.9 of SAM-4, the encoding of LUN is
>> on 5 bits (max_lun=32) and the current value is only 8.
>>
The value of the parameter is never re-read by the driver,
so a new value is ignored. Let know the user he
can't modify it by removing writable attribute.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
1 file changed, 2 insertions
long long unsigned int}' [-Wformat=]
"Maximum ID: %d Maximum LUN: %d Maximum Channel: %d\n",
Laurent Vivier (3):
ibmvscsi: make parameters max_id and max_channel read-only
ibmvscsi: display default value for max_id, max_lun and max_channel.
ibmvscsi: Allow to configure m
As devices with values greater than that are silently ignored,
this gives some hints to the sys admin to know why he doesn't see
his devices...
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++--
1 file changed, 6 insertions(+), 2 del
i/ibmvscsi/ibmvscsi.c:2298:4:
warning: format '%d' expects argument of type 'int',
but argument 4 has type 'u64 {aka long long unsigned int}' [-Wformat=]
"Maximum ID: %d Maximum LUN: %d Maximum Channel: %d\n",
Laurent Vivier (2):
ibmvscsi: display default value for max_id, max
On 09/11/2015 16:07, James Bottomley wrote:
> On Mon, 2015-11-09 at 15:47 +0100, Laurent Vivier wrote:
>> The value of the parameter is never re-read by the driver,
>> so a new value is ignored. Let know the user he
>> can't modify it by removing writable attribute.
&g
As defined in 4.6.9 of SAM-4, the encoding of LUN is
on 5 bits (max_lun=32) and the current value is only 8.
Set max_lun to IBMVSCSI_MAX_LUN (32).
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 2 +-
drivers/scsi/ibmvscsi/ibmvscsi.h | 1 +
2
On 05/11/2015 00:06, Brian King wrote:
> On 11/04/2015 07:02 AM, Hannes Reinecke wrote:
>> On 11/04/2015 12:46 PM, Laurent Vivier wrote:
>>>
>>>
>>> On 04/11/2015 12:16, Hannes Reinecke wrote:
>>>> On 11/04/2015 11:20 AM, Laurent Vivier wrote:
>
On 04/11/2015 12:16, Hannes Reinecke wrote:
> On 11/04/2015 11:20 AM, Laurent Vivier wrote:
>> QEMU allows until 32 LUNs.
>>
>> Signed-off-by: Laurent Vivier <lviv...@redhat.com>
>> ---
>> drivers/scsi/ibmvscsi/ibmvscsi.c | 5 -
>> 1 file chang
%d\n",
^
Laurent Vivier (3):
ibmvscsi: make parameters max_id and max_channel read-only
ibmvscsi: display default value for max_id, max_lun and max_channel.
ibmvscsi: Allow to configure maximum LUN
drivers/scsi/ibmvscsi/ibmvscsi.c | 17 -
1 file changed, 12 insertions(+), 5
The value of the parameter is never re-read by the driver,
so a new value is ignored. Let know the user he
can't modify it by removing writable attribute.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Acked-by: Tyrel D
QEMU allows until 32 LUNs.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 04de287..4480d3e
As devices with values greater than that are silently ignored,
this gives some hints to the sys admin to know why he doesn't see
his devices...
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Acked-by: Tyrel D
On 04/11/2015 11:20, Laurent Vivier wrote:
> QEMU allows until 32 LUNs.
>
> Signed-off-by: Laurent Vivier <lviv...@redhat.com>
I forget the:
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com>
> ---
> dri
The value of the parameter is never re-read by the driver,
so a new value is ignored. Let know the user he
can't modify it by removing writable attribute.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Acked-by: Tyrel D
As devices with values greater than that are silently ignored,
this gives some hints to the sys admin to know why he doesn't see
his devices...
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Acked-by: Tyrel D
QEMU allows until 32 LUNs.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Acked-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 5 -
1 file changed, 4 insertions(+), 1 delet
Ping ?
On 13/10/2015 23:23, Laurent Vivier wrote:
> James,
>
> this series has been reviewed and ack'ed,
> as SCSI maintainer, could you take it ?
>
> Laurent
>
> On 10/09/2015 11:23, Laurent Vivier wrote:
>> The value of the parameter is never re-read by
James,
this series has been reviewed and ack'ed,
as SCSI maintainer, could you take it ?
Laurent
On 10/09/2015 11:23, Laurent Vivier wrote:
> The value of the parameter is never re-read by the driver,
> so a new value is ignored. Let know the user he
> can't modify it by removing
Ping ?
On 10/09/2015 11:23, Laurent Vivier wrote:
> QEMU allows until 32 LUNs.
>
> Signed-off-by: Laurent Vivier <lviv...@redhat.com>
> ---
> drivers/scsi/ibmvscsi/ibmvscsi.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers
Ping ?
On 10/09/2015 11:23, Laurent Vivier wrote:
> As devices with values greater than that are silently ignored,
> this gives some hints to the sys admin to know why he doesn't see
> his devices...
>
> Signed-off-by: Laurent Vivier <lviv...@redhat.com>
> ---
> drive
Ping ?
On 10/09/2015 11:23, Laurent Vivier wrote:
> The value of the parameter is never re-read by the driver,
> so a new value is ignored. Let know the user he
> can't modify it by removing writable attribute.
>
> Signed-off-by: Laurent Vivier <lviv...@redhat.com>
> -
The value of the parameter is never re-read by the driver,
so a new value is ignored. Let know the user he
can't modify it by removing writable attribute.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
I resend this patch as James was not cc'ed.
drivers/scsi/ibmvscsi/ibmvscsi
As devices with values greater than that are silently ignored,
this gives some hints to the sys admin to know why he doesn't see
his devices...
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++--
1 file changed, 6 insertions(+), 2 del
QEMU allows until 32 LUNs.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index f9d7ec4..e5478b0
The value of the parameter is never re-read by the driver,
so a new value is ignored. Let know the user he
can't modify it by removing writable attribute.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
1 file changed, 2 insertions
33 matches
Mail list logo
