> On Jul 29, 2019, at 6:29 AM, Gustavo A. R. Silva
> wrote:
>
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings (Building: powerpc allyesconfig):
>
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function
> 'ibmvscsis_adapter_info':
> dri
> On Nov 28, 2018, at 7:01 PM, David Disseldorp wrote:
>
> In preparation for supporting user provided vendor strings, add an extra
> byte to t10_wwn.vendor which will ensure null string termination when an
> eight byte vendor string is provided by the user.
>
> Signed-off-by: David Disseldor
> On Nov 28, 2018, at 7:01 PM, David Disseldorp wrote:
>
> spc5r17.pdf specifies:
> 4.3.1 ASCII data field requirements
> ASCII data fields shall contain only ASCII printable characters (i.e.,
> code values 20h to 7Eh) and may be terminated with one or more ASCII
> null (00h) characters.
>
> On Nov 28, 2018, at 7:01 PM, David Disseldorp wrote:
>
> Use the value stored in t10_wwn.vendor, which defaults to "LIO-ORG", but
> can be reconfigured via the vendor_id ConfigFS attribute.
>
> Signed-off-by: David Disseldorp
> ---
> drivers/target/target_core_spc.c | 8 +---
> 1 file c
> On Nov 28, 2018, at 7:01 PM, David Disseldorp wrote:
>
> The vendor_id attribute will allow for the modification of the T10
> Vendor Identification string returned in inquiry responses. Its value
> can be viewed and modified via the ConfigFS path at:
> target/core/$backstore/$name/wwn/vendor
> On Nov 28, 2018, at 7:01 PM, David Disseldorp wrote:
>
> The pscsi_set_inquiry_info() and emulate_model_alias_store() codepaths
> don't currently explicitly null-terminate t10_wwn.model.
> Add an extra byte to the t10_wwn.model buffer and perform null string
> termination in all cases.
>
>
> On Nov 28, 2018, at 7:01 PM, David Disseldorp wrote:
>
> The pscsi_set_inquiry_info() codepath doesn't currently explicitly
> null-terminate t10_wwn.revision.
> Add an extra byte to the t10_wwn.model buffer and perform null string
> termination in all cases.
>
> Signed-off-by: David Disseld
From: "Bryant G. Ly"
There is currently a bug with the driver where there is never a
call to target_sess_cmd_list_set_waiting(), it only called
target_wait_for_sess_cmd(), which basically means that the
sess_wait_list would always be empty.
Thus, list_empty(&sess->sess_wait_list) = true,
(eg: no
Martin,
> On Oct 15, 2018, at 11:13 PM, Martin K. Petersen
> wrote:
>
>
> Bryant,
>
>> VMs do not remove the I_T nexus while the VM is active, so we can remove
>> the target_wait_for_sess_cmd() call.
>
> Patch forthcoming?
I can put out a patch, I’m trying to get someone at IBM to test it
> On Oct 11, 2018, at 12:56 AM, Nicholas A. Bellinger
> wrote:
>
> Hello MNC & Co,
>
> On Wed, 2018-10-10 at 11:58 -0500, Mike Christie wrote:
>> On 10/09/2018 10:23 PM, Nicholas A. Bellinger wrote:
>>> From: Nicholas Bellinger
>>>
>>> With the addition of commit 00d909a107 in v4.19-rc, it
/wait.h
> +++ b/include/linux/wait.h
> @@ -1052,10 +1052,9 @@ void __wake_up_locked_key_bookmark(struct
> wait_queue_head *wq_head,
> __ret;
> \
> })
>
>
I do not technically work for IBM anymore as
rt Van Assche
> Cc: Mike Christie
> Cc: Hannes Reinecke
> Cc: Christoph Hellwig
> Cc: Sagi Grimberg
> Cc: Bryant G. Ly
> Tested-by: Nicholas Bellinger
> Signed-off-by: Nicholas Bellinger
> ---
> drivers/target/target_core_transport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Bryant G. Ly
-Bryant
> On Sep 11, 2018, at 2:22 PM, Laura Abbott wrote:
>
> There's currently a warning about string overflow with strncat:
>
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe':
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3479:2: error: 'strncat' specified
> bound 64 equals d
13 matches
Mail list logo
