Re: [PATCH] scsi: t10-pi: Return correct ref tag when queue has no integrity profile

Hi, 在 2018/12/6 20:04, John Garry 写道: On 06/12/2018 04:17, Martin K. Petersen wrote: + Bart, Had you considered to use lower_32_bits() instead of "0x"? That would to avoid that reviewers have to count the 'f'-s to verify correctness of t10_pi_ref_tag(). I hadn't. I guess I tend

Performance improvements & regressions in storage IO tests in Linux Kernel 4.19

een as a significant improvement for most customers. An exception could be in non-customer controlled Cloud environments where the additional cycles might not be available and as such the latency improvements might not be achievable. Rajender M Performance Engineering VMware, Inc.

Re: Grant

-- I Mikhail Fridman. has selected you specially as one of my beneficiaries for my Charitable Donation, Just as I have declared on May 23, 2016 to give my fortune as charity. Check the link below for confirmation:

Re: [PATCH] scsi: ata: don't reset three times if device is offline for SAS host

Hi Tejun, 在 2018/2/28 2:19, Tejun Heo 写道: Hello, On Mon, Feb 26, 2018 at 07:45:37PM +0800, chenxiang (M) wrote: So, if there are real consequences, we can definitely add a way to short-circuit the recovery logic but let's do that by adding proper signaling rathr than testing for driver type

Re: [bug report] Don't enter SCSI error handler on kernel 4.16-rc1

在 2018/2/27 22:57, Bart Van Assche 写道: On Tue, 2018-02-27 at 15:09 +0800, chenxiang (M) wrote: 在 2018/2/26 23:25, Bart Van Assche 写道: On Mon, 2018-02-26 at 17:37 +0800, chenxiang (M) wrote: When i have a test on kernel 4.16-rc1, find a issue: running IO on SATA disk, then disable the disk

Re: [bug report] Don't enter SCSI error handler on kernel 4.16-rc1

在 2018/2/26 23:25, Bart Van Assche 写道: On Mon, 2018-02-26 at 17:37 +0800, chenxiang (M) wrote: When i have a test on kernel 4.16-rc1, find a issue: running IO on SATA disk, then disable the disk through sysfs interface(echo 0 > /sys/class/sas_phy/phy-1:0:0/enable), IO will hang and ne

Re: [PATCH] scsi: ata: don't reset three times if device is offline for SAS host

Hi Tejun, Sorry for my late reply as i have a vacation last week. 在 2018/2/13 22:27, Tejun Heo 写道: Hello, On Tue, Feb 13, 2018 at 09:44:53AM +0800, chenxiang (M) wrote: For those drivers using libsas, i think they have the same issue. It takes about 1 minute to recover but actually device

Re: [PATCH] scsi: ata: don't reset three times if device is offline for SAS host

Hi Tejun, 在 2018/2/13 0:51, Tejun Heo 写道: Hello, On Wed, Jan 24, 2018 at 09:20:25PM +0800, chenxiang wrote: In ata_eh_reset, it will reset three times at most for sata disk. For some drivers through libsas, it calls sas_ata_hard_reset at last. When device is gone, function sas_ata_hard_reset

Re: [PATCH V2 8/8] scsi: hpsa: use blk_mq to solve irq affinity issue

在 2018/2/5 23:20, Ming Lei 写道: This patch uses .force_blk_mq to drive HPSA via SCSI_MQ, meantime maps each reply queue to blk_mq's hw queue, then .queuecommand can always choose the hw queue as the reply queue. And if no any online CPU is mapped to one hw queue, request can't be submitted to

Re: [LSF/MM TOPIC] Improving Asynchronous SCSI Disk Probing

在 2018/1/18 7:24, Bart Van Assche 写道: When the SCSI scanning code discovers a SCSI device it calls the driver core function device_add() to associate a SCSI ULD with the device. The driver core invokes the probing function for the matching SCSI ULP, e.g. sd_probe(). In order to minimize the

Re: [PATCH v2 0/4] fix dma_unmap_sg() parameter in some scsi drivers

Hi, does anyone notice and review this issue? 在 2018/1/4 10:36, chenxiang 写道: According to Documentation/DMA-API.txt, all the parameters of dma_unmap_sg() must be the same as those and passed in to the scatter/gather mapping API. But in scsi drivers such as ibmscsi_tgt/iscsi/mvsas/pm8001, the

liramandoz...@gmail.com

liramandoz...@gmail.com<>

Re: [PATCH v2 4/4] scsi: pm8001: fix dma_unmap_sg() parameter

+cc Jack Wang 在 2018/1/4 10:36, chenxiang 写道: For function dma_unmap_sg(), the parameter should be number of elements in the scatterlist prior to the mapping, not after the mapping. Fix this usage. Cc: Jack Wang Cc: lindar_...@usish.com Fixes:

Re: [PATCH v1] libsas: remove private hex2bin() implementation

在 2017/12/20 1:37, Andy Shevchenko 写道: The function sas_parse_addr() could be easily substituted by hex2bin() which is in kernel library code. Cc: Christoph Hellwig Signed-off-by: Andy Shevchenko Tested-by: Xiang Chen

Re: [PATCH] scsi: fix dma_unmap_sg() parameter in some drivers

在 2018/1/2 18:51, John Garry 写道: On 21/12/2017 08:15, chenxiang wrote: For function dma_unmap_sg(), the parameter should be number of elements in the scatterlist prior to the mapping, not after the mapping. So fix this usage in ibmvscsi_tgt/isci/mvsas/pm8001. Hi chenxiang, I think that it

Re: [bug report] A race between device_resume and removing disk

Ping...Does anyone has some idea about this issue? 在 2017/11/16 11:54, chenxiang (M) 写道: Hi all, When debugging suspend and resume of hisi_sas, I find a issue: use commands (echo freeze > /sys/power/state) to suspend, after 5s system will be resumed as i enable TEST_DEVICES. But i

[bug report] A race between device_resume and removing disk

Hi all, When debugging suspend and resume of hisi_sas, I find a issue: use commands (echo freeze > /sys/power/state) to suspend, after 5s system will be resumed as i enable TEST_DEVICES. But if I plug one disks during suspend, system will be blocked all the time and it seems that there is a

Hello Dear...

Hello Dear... I know that this message will come to you as a surprise. I hoped that you will not expose or betray this trust and confident that I am about to repose on you, my name is M, Shakour Rosarita. I am 19 years old Girl, female, from Tartu Syria, (never married) 61 kg, white in complexion

Hello Dear...

Hello Dear... I know that this message will come to you as a surprise. I hoped that you will not expose or betray this trust and confident that I am about to repose on you, my name is M, Shakour Rosarita. I am 19 years old Girl, female, from Tartu Syria, (never married) 61 kg, white in complexion

RE: [PATCH v4 3/3] Rework handling of scsi_device.vpd_pg8[03]

> Introduce struct scsi_vpd for the VPD page length, data and the > RCU head that will be used to free the VPD data. Use kfree_rcu() > instead of kfree() to free VPD data. Move the VPD buffer pointer > check inside the RCU read lock in the sysfs code. Only annotate > pointers that are shared

RE: [PATCH v4 2/3] Rework the code for caching Vital Product Data (VPD)

d-by: Hannes Reinecke <h...@suse.de> > Cc: Christoph Hellwig <h...@lst.de> > Cc: Johannes Thumshirn <jthumsh...@suse.de> > Cc: Shane M Seymour <shane.seym...@hpe.com> > --- > drivers/scsi/scsi.c | 144 -- > -- >

RE: [PATCH 2/2] Rework handling of scsi_device.vpd_pg8[03]

J . > Bottomley <j...@linux.vnet.ibm.com> > Cc: linux-scsi@vger.kernel.org; Bart Van Assche <bart.vanass...@wdc.com>; > Christoph Hellwig <h...@lst.de>; Hannes Reinecke <h...@suse.de>; > Johannes Thumshirn <jthumsh...@suse.de>; Seymour, Shane M > <shane.seym...@hpe.com

RE: [PATCH 1/2] Introduce scsi_get_vpd_buf()

inux.vnet.ibm.com> > Cc: linux-scsi@vger.kernel.org; Bart Van Assche <bart.vanass...@wdc.com>; > Christoph Hellwig <h...@lst.de>; Hannes Reinecke <h...@suse.de>; > Johannes Thumshirn <jthumsh...@suse.de>; Seymour, Shane M > <shane.seym...@hpe.com&g

RE: [PATCH 07/19] Fix RCU handling of scsi_device.vpd_pg8[03]

> Hello Shane, > > You have either misinterpret my statement or the SCSI VPD handling code. If > you have a look at the SCSI VPD handling code you will see that an > rcu_read_lock() / > rcu_read_unlock() pair is sufficient to prevent that the VPD buffer > rcu_dereference() points at is being

RE: [PATCH 07/19] Fix RCU handling of scsi_device.vpd_pg8[03]

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Friday, August 25, 2017 2:54 AM > To: h...@lst.de > Cc: j...@linux.vnet.ibm.com; linux-scsi@vger.kernel.org; h...@suse.de; > jthumsh...@suse.de; martin.peter...@oracle.com; Seymour, Sha

Ahoj....

Ahoj. Dobry vecer a jak se mas? Jen rychly jedno, je tu oficialni prilezitosti bych chtel diskutovat s vami soukrome. Ocenil bych vasi rychlou reakci tady na mem osobnim soukromeho e-mailu nize pro dalsi komunikaci. S pratelskym pozdravem, Paní Ko May Leung email: kleung...@gmail.com

Ahoj....

Ahoj. Dobry vecer a jak se mas? Jen rychly jedno, je tu oficialni prilezitosti bych chtel diskutovat s vami soukrome. Ocenil bych vasi rychlou reakci tady na mem osobnim soukromeho e-mailu nize pro dalsi komunikaci. S pratelskym pozdravem, Paní Ko May Leung email: kmyln...@gmail.com

[PATCH 1/1] scsi: ufs: tc-dwc-g210 driver fix for 20-bit RMMI

The code was checking on PA_CONNECTEDRXLANES and PA_CONNECTEDTXLANES attributes to program the Lane#1 attributes. The correct attributes are PA_AVAILRXDATALANES and PA_AVAILTXDATALANES respectively. Signed-off-by: Manjunath M B <manj...@synopsys.com> --- drivers/scsi/ufs/tc-dwc-g210

RE: [PATCH] qlogicpti: Return correct error code

Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/2] scsi_transport_fc: implement 'disable_target_scan' module parameter

Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/2] scsi_transport_fc: Implement 'async_user_scan' module parameter

Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] snic: correctly check for array overrun on overly long version number

Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 0/2][RESEND] scsi_transport_fc: LUN masking

> But this has nothing to do with the patchset, right? Correct. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 0/2][RESEND] scsi_transport_fc: LUN masking

Hi Hannes, How do you know that a request for an async scan is complete (I'm assuming that you get add or change udev events)? Assuming that someone has manually started a scan on something (e.g. some newly presented devices after boot) and all scans are going to be async how do you when it is

RE: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

get your LTO drive test without my changes in to make sure you see the same issue and then if you do test with the changes I added above. That's just to double check that there's nothing wrong with my setup and the code changes are required. Thanks Shane N�r��yb�X��ǧv�^�)޺{.n�+{���"�{ay�ʇڙ�,j��f���h���z��w��� ���j:+v���w�j�mzZ+�ݢj"��!�i

RE: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

Hi Kai, > -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of "Kai Mäkisara (Kolumbus)" > Sent: Tuesday, February 02, 2016 5:43 AM > To: Seymour, Shane M > Cc: Laurence Oberman; Emmanuel Florac;

RE: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

Shane > -Original Message- > From: makisara@kai.makisara.private [mailto:makisara@kai.makisara.private] > On Behalf Of Kai Makisara > Sent: Saturday, January 30, 2016 4:22 AM > To: Seymour, Shane M > Cc: Laurence Oberman; Emmanuel Florac; Laurence Oberman; linux- &

RE: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

Hi Kai, $ pwd /sys/class/scsi_tape/st1/device $ cat scsi_level 4 Thanks Shane > -Original Message- > From: "Kai Mäkisara (Kolumbus)" [mailto:kai.makis...@kolumbus.fi] > Sent: Friday, January 29, 2016 4:04 AM > To: Seymour, Shane M > Cc: Laurence Oberman;

RE: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

Hi Laurence, > -Original Message- > From: Laurence Oberman [mailto:lober...@redhat.com] > Sent: Friday, January 29, 2016 10:25 AM > To: Seymour, Shane M > Cc: Kai Mäkisara (Kolumbus); Emmanuel Florac; Laurence Oberman; linux- > s...@vger.kernel.org > Subject: Re:

RE: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

day, January 25, 2016 8:05 AM > To: Seymour, Shane M > Cc: Laurence Oberman; Emmanuel Florac; Laurence Oberman; linux- > s...@vger.kernel.org > Subject: RE: What partition should the MTMKPART argument specify? Was: > Re: st driver doesn't seem to grok LTO partitioning > > On

RE: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

Hi Emmanuel, > Hmm in fact if we keep using MB we'll be stuck when tapes reach ~2 PB > which leaves some time to think about it, until LTO-15 circa 2036 :) There will be other issues to solve before then (by LTO-9 2 with compression or LTO-10 without compression and we're at LTO-7 now). Take tar

RE: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

Hi Kai, > -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of "Kai Mäkisara (Kolumbus)" > Sent: Friday, January 22, 2016 7:59 AM > To: Seymour, Shane M > Cc: Laurence Oberman; Emmanuel Florac;

RE: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

p being a multiple of 2x the wrap size and that there was some fixed overhead in partitioning an LTO5+ drive (2 wraps). N�r��yb�X��ǧv�^�)޺{.n�+{���"�{ay�ʇڙ�,j��f���h���z��w��� ���j:+v���w�j�mzZ+�ݢj"��!�i

RE: [PATCH] ipr: fix out-of-bounds null overwrite

> len = snprintf(fname, 99, "%s", buf); > - fname[len-1] = '\0'; Since it appears that's the only time len is actually used in that function can you please remove the variable len completely as part of the patch? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi"

RE: st driver doesn't seem to grok LTO partitioning

can either make SET CAPACITY calls on the currently mounted medium to set the sizes and then format the medium it also refers to the medium partition mode page in terms of changing the partitioning of the tape. N�r��yb�X��ǧv�^�)޺{.n�+{���"�{ay�ʇڙ�,j��f���h���z��w��� ���j:+v���w

RE: [PATCH] scsi: rescan VPD attributes

> The VPD page information might change, so we need to be able to > update it. This patch implements a VPD page rescan whenever > the 'rescan' sysfs attribute is triggered. > > Signed-off-by: Hannes Reinecke > --- Reviewed-by: Shane Seymour -- To

RE: [PATCH] scsi: rescan VPD attributes

Hi Hannes, I have one probably small nitpick about the patch. I'm not sure how likely what I've put below is likely to happen in real life though. Is there any chance at all that sdev->vpd_pg83_len could change when updated? If there's any chance of that I'd have expected that both the length

[PATCH] st: allow debug output to be enabled or disabled via sysfs

Change st driver to allow enabling or disabling debug output via sysfs file /sys/bus/scsi/drivers/st/debug_flag. Previously the only way to enable debug output was: 1. loading the driver with the module parameter debug_flag=1 2. an ioctl call (this method was also the only way to dynamically

RE: [PATCH 1/3] hpsa: convert show method snprintf usage to scnprintf

PAGE_SIZE-1 bytes regardless of which function is used. I don't mind if the patch isn't accepted but I thought I should at least explain my rationale behind the change. Thanks Shane N�r��yb�X��ǧv�^�)޺{.n�+{{ay�ʇڙ�,j��f���h���z��w��� ���j:+v���w�j�mzZ+�ݢj��!�i

[ANNOUNCE] tapestat command now part of upstream sysstat

While tape stats were being implemented in the kernel I started working on a program that would read them out and display the data to allow me to test the interface. After the changes were available in linux-next I worked with the upstream sysstat maintainer to get that code into shape so it was

[PATCH] hpsa: non-zero LUNs of multi-LUN devices missing on some Smart Arrays

A regression was introduced into the hpsa driver a while back so non-zero LUNs of multi-LUN devices may no longer be presented via a SAS based Smart Array. I have not done a bisection to discover the change that caused it. The CISS firmware specification (available on sourceforge) defines an 8

RE: [PATCH RFC 1/2] cxlflash: Base support for IBM CXL Flash Adapter

-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Matthew R. Ochs Sent: Monday, April 27, 2015 2:50 PM To: linux-scsi@vger.kernel.org; james.bottom...@hansenpartnership.com; n...@linux-iscsi.org; brk...@linux.vnet.ibm.com Cc:

[PATCH] st: null pointer dereference panic caused by use after kref_put by st_open

Two SLES11 SP3 servers encountered similar crashes simultaneously following some kind of SAN/tape target issue: ... qla2xxx [:81:00.0]-801c:3: Abort command issued nexus=3:0:2 -- 1 2002. qla2xxx [:81:00.0]-801c:3: Abort command issued nexus=3:0:2 -- 1 2002. qla2xxx

[PATCH v2] hpsa: convert DEVICE_ATTR to RO|WO|RW and show methods must not use snprintf

Changed DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WO|RW. This also forced some show/store function names to change. Changed all show method snprintf() usage to scnprintf() per Documentation/filesystems/sysfs.txt. Signed-off-by: Shane Seymour shane.seym...@hp.com --- Changes from v1: Dropped one

[PATCH 3/3] hpsa: Convert DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WR|WO

Convert DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WR|WO Changes forced some function names to change. Signed-off-by: Shane Seymour shane.seym...@hp.com --- --- a/drivers/scsi/hpsa.c 2015-06-30 16:34:01.403904650 -0500 +++ b/drivers/scsi/hpsa.c 2015-06-30 16:21:54.214954176 -0500 @@

[PATCH 2/3] hpsa: Remove unneccessary variable from raid_level_show

Remove unneccessary variable from raid_level_show Signed-off-by: Shane Seymour shane.seym...@hp.com --- Was not in previous patch. --- a/drivers/scsi/hpsa.c 2015-06-30 16:15:42.631979483 -0500 +++ b/drivers/scsi/hpsa.c 2015-06-30 16:16:45.737975186 -0500 @@ -612,7 +612,6 @@ static

[PATCH 1/3] hpsa: convert show method snprintf usage to scnprintf

Changed all show method snprintf usage to scnprintf per Documentation/filesystems/sysfs.txt. Signed-off-by: Shane Seymour shane.seym...@hp.com --- Please let me know if this is not the correct way to submit patches by separating them but keeping them logically together. --- a/drivers/scsi/hpsa.c

[PATCH] hpsa: convert DEVICE_ATTR to RO|WO|RW and show methods must use scnprintf

Changed DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WO|RW. This also forced some show/store function names to change. Changed all show method sprint/snprintf usage to scnprintf per Documentation/filesystems/sysfs.txt. Signed-off-by: Shane Seymour shane.seym...@hp.com --- --- a/drivers/scsi/hpsa.c

scsi_dh: convert __ATTR macro to DEVICE_ATTR_RW and snprintf show method cleanup

Converted dh_state to use DEVICE_ATTR_RW macro instead of __ATTR. That forced a change to the associated show/store function names and the name of the attribute. Changed usage of snprintf in show function to scnprintf per Documentation/filesystems/sysfs.txt. Signed-off-by: Shane Seymour

[PATCH] scsi_dh: convert __ATTR macro to DEVICE_ATTR_RW and snprintf show method cleanup

Converted dh_state to use DEVICE_ATTR_RW macro instead of __ATTR. That forced a change to the associated show/store function names and the name of the attribute. Changed usage of snprintf in show function to scnprintf per Documentation/filesystems/sysfs.txt. Signed-off-by: Shane Seymour

[PATCH v2] st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

Convert DRIVER_ATTR macros to DRIVER_ATTR_RO requested by Greg KH. Also switched to using scnprintf instead of snprintf per Documentation/filesystems/sysfs.txt. Suggested-by: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Shane Seymour shane.seym...@hp.com --- This patch was

[PATCH] st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

Convert DRIVER_ATTR macros to DRIVER_ATTR_RO as requested by Greg KH. Also switched to using sprintf as nothing printed should exceed PAGE_SIZE - based on feedback from Greg when implementing show functions for tape stats. Suggested-by: Greg Kroah-Hartman gre...@linuxfoundation.org

st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

Convert DRIVER_ATTR macros to DRIVER_ATTR_RO as requested by Greg KH. Also switched to using sprintf as nothing printed should exceed PAGE_SIZE - based on feedback from Greg when implementing show functions for tape stats. Suggested-by: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH] st: convert to using driver attr groups for sysfs

This patch changes the st driver to use attribute groups so driver sysfs files are created automatically. See the following for reference: http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/ Signed-off-by: Shane Seymour shane.seym...@hp.com --- --- a/drivers/scsi/st.c

RE: [patch] hpsa: fix an sprintf() overflow in the reset handler

With a size of 48 while it won't overflow since you're using snprintf the string with a maximum value in %d: echo -n cmd 2147483647 RESET FAILED, new lockup detected |wc -c 48 is 48 characters long without a null terminator on the string (and in the unlikely event that it's somehow a the

[PATCH v9] st: implement tape statistics

st: implement tape statistics This patch implements tape statistics in the st module via sysfs. Current no statistics are available for tape I/O and there is no easy way to reuse the block layer statistics for tape as tape is a character device and does not have perform I/O in sector sized

RE: [scsi:misc 114/120] drivers/scsi/st.c:4594:3: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'long long int'

My apologies for this I'm fixing it now. -Original Message- From: kbuild test robot [mailto:fengguang...@intel.com] Sent: Monday, June 01, 2015 12:36 PM To: Seymour, Shane M Cc: kbuild-...@01.org; James Bottomley; Christoph Hellwig; linux-scsi@vger.kernel.org Subject: [scsi:misc 114/120

[PATCH v7] st implement tape statistics

Signed-off-by: Shane Seymour shane.seym...@hp.com Tested-by: Shane Seymour shane.seym...@hp.com --- Changes from v6 - Removed tested by Laurence Oberman since the code has changed significantly. - Changed code to use ktime so time resolution is now in ns (Robert Elliot) for virtual tape drives

[PATCH RESEND v6] st implement tape statistics

The following patch exposes statistics for the st driver via sysfs. There is a need for companies with large numbers of tape drives numbering in the tens of thousands to track the performance of those tape drives (e.g. when a backup exceeds its window). The statistics provided should allow the

RE: [PATCH v6] st implement tape statistics

Retested with patch applied to 4.0.0-rc2-next-20150304 - all successful with no issues found. -Original Message- From: Laurence Oberman [mailto:oberma...@gmail.com] Sent: Thursday, February 26, 2015 5:47 AM To: Seymour, Shane M Cc: Greg KH; linux-scsi@vger.kernel.org; Laurence Oberman

[PATCH v6] st implement tape statistics

The following patch exposes statistics for the st driver via sysfs. There is a need for companies with large numbers of tape drives numbering in the tens of thousands to track the performance of those tape drives (e.g. when a backup exceeds its window). The statistics provided should allow the

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

On Wed, Feb 11, 2015 at 06:30:27AM +0800, Greg KH wrote: On Tue, Feb 10, 2015 at 02:27:20PM +, Bryn M. Reeves wrote: On Sat, Feb 07, 2015 at 12:07:43PM +0800, Greg KH wrote: $ cat /sys/fs/selinux/avc/cache_stats lookups hits misses allocations reclaims frees 18938916 18921707

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

On Sat, Feb 07, 2015 at 12:07:43PM +0800, Greg KH wrote: On Fri, Feb 06, 2015 at 03:41:58PM +, Bryn M. Reeves wrote: I can't speak for Shane but wouldn't spend too much time looking at the current v2 patch: it's the result of a pretty ugly compromise suggested on linux-scsi. Fair

[PATCH RESEND v5] st implement tape statistics

The following patch exposes statistics for the st driver via sysfs. There is a need for companies with large numbers of tape drives numbering in the tens of thousands to track the performance of those tape drives (e.g. when a backup exceeds its window). The statistics provided should allow the

RE: [PATCH] st implement tape statistics v3 (updated patch)

Hi Greg, Thank you for pushing me to go that little further. The statistics directory is back. Any feedback from anyone would be appreciated. Thanks Shane -- Signed-off-by: shane.seym...@hp.com Tested-by: shane.seym...@hp.com --- --- a/drivers/scsi/st.c 2015-01-11 14:46:00.243814755 -0600 +++

[PATCH RESEND] st implement tape statistics v3

The following patch exposes statistics for the st driver via sysfs. There is a need for companies with large numbers of tape drives numbering in the tens of thousands to track the performance of those tape drives (e.g. when a backup exceeds its window). The statistics provided should allow the

RE: [PATCH RESEND] st implement tape statistics v3

And you need to put below the --- line what has changed from the last version, I don't see any of my comments address here :( Doh! My appologies Greg, I'd missed your inline comments - I haven't had enough coffee this morning. -- To unsubscribe from this list: send the line unsubscribe

[PATCH] st implement tape statistics v3

Hi All, Please find attached v3 of the patch. It implements the changes requested by Greg. The statistics files aren't in a separate directory any more they're implemented directly as device attributes unless someone has objections to them being in a place like /sys/class/scsi_tape/*/.

RE: [PATCH] st: implement sysfs based tape statistics v2

from correcting it. If there's no way to export a partition number for the devices that support it I can add a new sysfs file (call it partition) to export it that way and see if I can get the correct value into mt_resid. -Original Message- From: Seymour, Shane M Sent: Monday, February

RE: [PATCH] st: implement sysfs based tape statistics v2

, Shane M Cc: linux-scsi@vger.kernel.org Subject: Re: [PATCH] st: implement sysfs based tape statistics v2 One feature of tape statistics is that they're as much about the *tape* as they are about the *drive*, which is uncommon for block devices. It might be useful to have a set of counters which

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

On Fri, Feb 06, 2015 at 12:20:53AM +, Seymour, Shane M wrote: There has been some ongoing discussion about the best way to implement tape statistics. The original method suggested a long time ago used a single file in sysfs similar to block statistics in sysfs. That lead to an impass about

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

On Fri, Feb 06, 2015 at 04:59:16AM -0800, Greg KH wrote: On Fri, Feb 06, 2015 at 12:20:53AM +, Seymour, Shane M wrote: The current patch that implements tape statistics is here: http://marc.info/?l=linux-scsim=142112067313723w=2 Aside from the do we want to do this all in a single

[RFC] implementing tape statistics single file vs multi-file in sysfs

Hello linux-api'ers There has been some ongoing discussion about the best way to implement tape statistics. The original method suggested a long time ago used a single file in sysfs similar to block statistics in sysfs. That lead to an impass about the code on the linux-scsi mailing list. The

Re: [PATCH] st: implement sysfs based tape statistics v2

On Thu, Feb 05, 2015 at 07:46:32PM +0200, Kai Mäkisara (Kolumbus) wrote: On 5.2.2015, at 19.40, Laurence Oberman lober...@redhat.com wrote: From: Kai Mäkisara (Kolumbus) kai.makis...@kolumbus.fi I still think that the tape statistics should be exported like the statistics of “real” block

Re: [PATCH] st: implement sysfs based tape statistics v2

On Thu, Feb 05, 2015 at 10:55:50AM -0800, James Bottomley wrote: OK, the sysfs bikeshedders hang out on linux-api https://www.kernel.org/doc/man-pages/linux-api-ml.html If you can convince them, we'll do the single file approach. Will do - I've got a couple of stats projects on the go at

RE: [PATCH] st: implement sysfs based tape statistics v2

I was wondering if anyone had any feedback or had any chance to review the changes? -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Seymour, Shane M Sent: Tuesday, January 13, 2015 2:43 PM To: linux-scsi@vger.kernel.org Cc

[PATCH] st: implement sysfs based tape statistics v2

Some small changes since the last version - this version removes two files from sysfs compared to the last version (read and write block counts since they're derived from the byte counts they can be calculated in user space) but that's the only change. This version has been rebased to

[RFC] Deprecate, modify, or do nothing to SCSI_IOCTL_GET_IDLUN

I'd like to ask if SCSI_IOCTL_GET_IDLUN should be deprecated? This is in response to [Bug 88591] SCSI_IOCTL_GET_IDLUN only returns 8 bits for the SCSI Target value of which has been seen on the mailing list. It only returns one byte of id, lun, channel, and host number but we have

RE: [PATCH] st: implement sysfs based tape statistics

I was wondering if anyone had a chance to review the patch? Comments are appreciated and I'm more than happy to make changes that will allow it to be accepted. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

RE: [PATCH] st: set owner in struct device_driver

I can, but at this point it will be tomorrow (11pm where I am). -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] st: implement sysfs based tape statistics

It's been a year since my last attempt at doing this as I got distracted by some other things. Comments are appreciated and any questions will be answered. The following implements sysfs based per device tape statistics files with one file per statistic and a method of trying to allow a

[PATCH] st: set owner in struct device_driver

After moving from from branch next-20141106 to next-2014 to pick up recent changes to the st driver I found that the following message was being logged by the kernel (for many other modules as well): Driver 'st' needs an owner There was a change in driver_register to check the struct

Re: dummy scsi read or scsi command periodically for external USB Hard Disk

On Sun, Jul 06, 2014 at 01:18:03AM +0800, loody wrote: hi all: we met a USB Hard Disk that will go to suspend if host stop sending scsi command over 5mins. To save the IO, kernel will keep the file in page cache as much as he can and under this circumstances, the scsi command may

Re: dummy scsi read or scsi command periodically for external USB Hard Disk

On Mon, Jul 07, 2014 at 11:39:05PM +0800, loody wrote: hi David: 2014-07-07 23:06 GMT+08:00 David Laight david.lai...@aculab.com: From: Lars Melin ... sgread is not included in BusyBox but you should have touch. Create a dummy file on the disk and let cron touch it every 4 minutes.

Re: dummy scsi read or scsi command periodically for external USB Hard Disk

On Tue, Jul 08, 2014 at 12:15:54AM +0800, loody wrote: so sg_read will not hammer on the page cache like dd without iflags=direct thanks for your kind help, The sg_read program (and other programs in sg3_utils) sends a command directly to the device using an SG_IO ioctl. This bypasses all the

[PATCH] scsi: break from queue depth adjusting loops when device found

From: Stephen M. Cameron scame...@beardog.cce.hp.com Don't loop through all the devices even after finding the one we're looking for Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com Reviewed-by: Robert Elliott elli...@hp.com --- drivers/scsi/scsi_error.c |2 ++ 1 files changed

[PATCH 0/5] hpsa a few small updates for early July 2014

Nothing very big here, just a few small updates for now. I still have a giant ball of patches waiting in the wings, but it is unfortunately not quite ready yet. --- Robert Elliott (1): hpsa: do not unconditionally copy sense data Stephen M. Cameron (4): hpsa: remove online devices

[PATCH 1/5] hpsa: remove online devices from offline device list

From: Stephen M. Cameron scame...@beardog.cce.hp.com When devices come on line, they should be removed from the list of offline devices that are monitored. Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com Reviewed-by: Scott Teel scott.t...@hp.com Reviewed-by: Joe Handzik

[PATCH 2/5] hpsa: fix bad -ENOMEM return value in hpsa_big_passthru_ioctl

From: Stephen M. Cameron scame...@beardog.cce.hp.com When copy_from_user fails, return -EFAULT, not -ENOMEM Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com Reported-by: Robert Elliott elli...@hp.com Reviewed-by: Joe Handzik joseph.t.hand...@hp.com Reviewed-by: Scott Teel scott.t

[PATCH 4/5] hpsa: fix 6-byte READ/WRITE with 0 length data xfer

From: Stephen M. Cameron scame...@beardog.cce.hp.com a 6-byte READ/WRITE CDB with a 0 block data transfer really means a 256 block data transfer. The RAID mapping code failed to handle this case. For 10/12/16 byte READ/WRITEs, 0 just means no data should be transferred, and should not trigger

  1   2   3   >