Re: [PATCH] tcmu: Fix trailing semicolon

On 01/16/2018 09:34 AM, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > It is completely stripped out by the compiler. Removing it since it doesn't do > anything. > > Signed-off-by: Luis de Bethencourt > --- > > Hi, > >

Re: [Bug 111441] New: iscsi fails to attach to targets

Can you send me your lio config? Are you running lio on the same box as the initiator so it is also changing kernel version with each test? It looks like the scsi scan code is not handling the lack of LUN 0 correctly. I think I know what patch is causing it, but cannot get my lio config to

Re: [Bug 111441] New: iscsi fails to attach to targets

> On Jan 29, 2016, at 6:04 AM, Serguei Bezverkhi (sbezverk) > wrote: > > Actually this server uses both cases: Local taregts (since it is OpenStack > server) and remote targets as it tries to mount 4 remotefile systems. > > You are correct, I always use the same box I

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

> On Nov 15, 2015, at 4:10 AM, Or Gerlitz wrote: > > On Fri, Nov 13, 2015 at 6:51 PM, Mike Christie wrote: >> On 11/13/2015 09:06 AM, Or Gerlitz wrote: The patch has caused multiple regressions, did not even compile when > sent to me, and

Re: [PATCH V2 0/7] be2iscsi driver update to 10.6.0.0

On Apr 24, 2015, at 9:46 PM, John Soni Jose sony.joh...@emulex.com wrote: The patchset updates be2iscsi driver to 10.6.0.0 version. These patches are generated aganist scsi for-next branch John Soni Jose (7): be2iscsi : Fix the retry count for boot targets be2iscsi : Fix the PCI request

Re: [PATCH 1/1] be2iscsi: add block valid bit to iBFT flag

On Jan 15, 2015, at 7:26 PM, Minh Duc Tran minhduc.t...@emulex.com wrote: -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Thursday, January 15, 2015 3:17 PM To: Minh Duc Tran; linux-scsi@vger.kernel.org Cc: Jayamohan Kallickal Subject: Re: [PATCH 1/1]

Re: [Lsf-pc] [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

On Jan 8, 2015, at 11:03 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Thu, 2015-01-08 at 15:22 -0800, James Bottomley wrote: On Thu, 2015-01-08 at 14:57 -0800, Nicholas A. Bellinger wrote: On Thu, 2015-01-08 at 14:29 -0800, James Bottomley wrote: On Thu, 2015-01-08 at 14:16

Re: iSCSI request keep rejected by microsoft iSCSI target because of write_same check

Hey Vaughan, This was the issue we worked with Microsoft on wasn’t it? You guys figured out it was fixed in their target in a recent release right? On Dec 1, 2014, at 3:01 AM, vaughan vaughan@oracle.com wrote: On 12/01/2014 03:25 PM, j...@deti74.ru wrote: I has some sproblem and only one

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

On Jun 25, 2014, at 6:35 AM, Christoph Hellwig h...@infradead.org wrote: On Wed, Jun 25, 2014 at 01:32:39PM +0300, Sagi Grimberg wrote: So I tested a bidirectional command using: $ sg_raw --infile=/root/filex --send=1024 --request=1024 --outfile=/root/filex /dev/bsg/7:0:0:0 53 00 00 00 00 00

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

On Jun 24, 2014, at 7:53 AM, Martin K. Petersen martin.peter...@oracle.com wrote: Mike == Mike Christie micha...@cs.wisc.edu writes: Mike The problem is WRITE_SAME requests are setup so that Mike req-__data_len is the value of the entire request when the setup Mike is completed but during

Re: [PATCH 1/1] be2iscsi: remove potential junk pointer free

On Jun 6, 2014, at 7:22 AM, Tomas Henzl the...@redhat.com wrote: commit 0e7c60c [SCSI] be2iscsi: fix memory leak in error path fixed an potential junk pointer free if mgmt_get_if_info() returned an error fix it on one more place Signed-off-by: Tomas Henzl the...@redhat.com --- diff

Re: CmdSN greather than MaxCmdSN protocol error in LIO Iser

On Nov 12, 2013, at 12:18 PM, Moussa Ba (moussaba) mouss...@micron.com wrote: I am attaching error codes on the inititator that seem to coincide with the timeout errors. [ 261.855254] connection6:0: pdu (op 0x65 itt 0x1) rejected. Reason code 0x4 [ 261.855266] connection6:0: pdu (op

Re: CmdSN greather than MaxCmdSN protocol error in LIO Iser

On Nov 11, 2013, at 7:31 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2013-11-11 at 16:48 -0800, Nicholas A. Bellinger wrote: On Mon, 2013-11-11 at 16:42 -0800, Nicholas A. Bellinger wrote: On Mon, 2013-11-11 at 13:17 -0800, Nicholas A. Bellinger wrote: Hi Moussa Co,

Re: CmdSN greather than MaxCmdSN protocol error in LIO Iser

On Nov 11, 2013, at 8:32 PM, Michael Christie micha...@cs.wisc.edu wrote: On Nov 11, 2013, at 7:31 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2013-11-11 at 16:48 -0800, Nicholas A. Bellinger wrote: On Mon, 2013-11-11 at 16:42 -0800, Nicholas A. Bellinger wrote

Re: [PATCH v11 6/9] Make scsi_remove_host() wait until error handling finished

On Jun 25, 2013, at 10:31 AM, Bart Van Assche bvanass...@acm.org wrote: On 06/25/13 15:45, James Bottomley wrote: On Tue, 2013-06-25 at 11:01 +0200, Bart Van Assche wrote: There is a difference though between moving the EH kthread_stop() call and the patch at the start of this thread: moving

Re: [PATCH v11 6/9] Make scsi_remove_host() wait until error handling finished

On Jun 24, 2013, at 9:26 PM, Mike Christie micha...@cs.wisc.edu wrote: On 06/24/2013 05:27 PM, James Bottomley wrote: However, what's the reasoning behind wanting to do this? In theory all necessary resources for the eh thread should only be freed in the release callback. That means they

Re: [PATCH 3/4] scsi: use 64-bit value for 'max_luns'

On Feb 19, 2013, at 2:18 AM, Hannes Reinecke h...@suse.de wrote: diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c index b44c1cf..95105c0 100644 --- a/drivers/scsi/cxgbi/libcxgbi.c +++ b/drivers/scsi/cxgbi/libcxgbi.c @@ -245,7 +245,7 @@ void cxgbi_hbas_remove(struct

Re: [PATCH] SG_SCSI_RESET ioctl: add no_escalate values

On Feb 15, 2013, at 5:32 PM, Douglas Gilbert dgilb...@interlog.com wrote: On 13-02-15 04:48 PM, Mike Christie wrote: On 02/15/2013 01:39 PM, Douglas Gilbert wrote: Further to the thread titled: [PATCH] SG_SCSI_RESET ioctl should only perform requested operation by Jeremy Linton a patch is

Re: [PATCH] SG_SCSI_RESET ioctl: add no_escalate values

On Feb 15, 2013, at 11:45 PM, Michael Christie micha...@cs.wisc.edu wrote: Some drivers rely on more invasive eh callbacks to be called if they return FAILED in a eh callbacks. If userspace sends a command that performs the non-escalting *reset to some drivers, it is going to leave them

Re: [PATCH] Use a more selective error recovery strategy based on device capabilities

On Feb 13, 2013, at 9:46 AM, Jeremy Linton jlin...@tributary.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2/13/2013 7:06 AM, Hannes Reinecke wrote: But unfortunately it failed the reality check; of my zoo of storage arrays only NetApp OnTap 8.X and HP P2000 supports the

Re: [PATCH][RFC] scsi_transport_fc: Implement I_T nexus reset

On Dec 7, 2012, at 8:51 AM, Hannes Reinecke h...@suse.de wrote: diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c index 8f92732..d6555aa 100644 --- a/drivers/scsi/bfa/bfad_im.c +++ b/drivers/scsi/bfa/bfad_im.c @@ -793,7 +793,7 @@ struct scsi_host_template

Re: [PATCH 0/7] qla4xxx: Updates for scsi misc branch

On Oct 10, 2012, at 6:24 AM, vikas.chaudh...@qlogic.com wrote: From: Vikas Chaudhary vikas.chaudh...@qlogic.com James, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Vikas. I think some of these should be common operations instead of

Re: [PATCH 07/17] be2iscsi: Fix the kernel panic in blkiopoll disable mode

On Sep 28, 2012, at 8:32 PM, John Soni Jose sony.joh...@emulex.com wrote: From: Jayamohan Kallickal jayamohan.kallic...@emulex.com Fix kernel panic issue while running IO in blk_iopoll disable mode. What was the bug exactly? Creating UNBOUND WQ for each EQ in the driver. What is the

Re: [PATCH] iscsi: Don't disable BH on BH context

-by: Ying Xue ying@windriver.com Acked-by: Michael Christie micha...@cs.wisc.edu --- drivers/scsi/iscsi_tcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c index 9220861..d763857 100644 --- a/drivers/scsi

Re: [PATCH 0/12] qla4xxx: Updates for scsi misc branch.

On Aug 22, 2012, at 6:54 AM, vikas.chaudh...@qlogic.com wrote: Vikas Chaudhary (12): qla4xxx: Update function name from 8xxx to 82xx qla4xxx: Update structure and variable names qla4xxx: Update func name from ql4_ to qla4_ qla4xxx: Rename macros from 82XX to 8XXX

Re: [PATCH] Fix a use-after-free triggered by device removal

On Sep 3, 2012, at 9:12 AM, Bart Van Assche bvanass...@acm.org wrote: If the put_device() call in scsi_request_fn() drops the sdev refcount to zero then the spin_lock() call after the put_device() call triggers a use-after-free. Avoid that by making sure that blk_cleanup_queue() can only

Re: [PATCH] scsi_dh_alua: Enable STPG for unavailable ports

On Aug 24, 2012, at 4:08 AM, Bart Van Assche bvanass...@acm.org wrote: diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c index 08d80a6..a05d469 100644 --- a/drivers/scsi/device_handler/scsi_dh_alua.c +++

Re: [PATCH] scsi: return TARGET_ERROR when a device has been disconnected

On Aug 16, 2012, at 1:40 AM, Hannes Reinecke h...@suse.de wrote: When we receive a sense code of NOT READY, LOGICAL UNIT NOT SUPPORTED the device has been disconnected and any retry on other paths would be pointless. So return TARGET_ERROR here. What target is this with? What about

Re: [PATCH] iscsi_tcp: add write permission to max_lun

On Aug 15, 2012, at 6:30 AM, Rob Evers rev...@redhat.com wrote: Add root write permission to iscsi_tcp max_lun parameter Signed-off-by: Rob Evers rev...@redhat.com --- drivers/scsi/iscsi_tcp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] increase iscsi_tcp max_lun to ~0, don't care

On Aug 15, 2012, at 5:39 PM, Rob Evers rev...@redhat.com wrote: Signed-off-by: Rob Evers rev...@redhat.com --- drivers/scsi/iscsi_tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c index 9220861..1b91ca0 100644

Re: [PATCH 1/7] Removing the iscsi_data_pdu setting.

On Aug 13, 2012, at 5:29 AM, John Soni Jose sony.joh...@emulex.com wrote: The setting of iscsi_data_pdu is not required anymore, as this was required for BE1 adapters only. Were those released and supported by the upstream kernel in previous kernels? -- To unsubscribe from this list: send

Re: [PATCH] libiscsi: avoid unnecessary multiple NULL assignments

Replacing linux-scsi list with linux-kernel. On Aug 12, 2012, at 9:15 AM, Masatake YAMATO yam...@redhat.com wrote: In iscsi_free_task, NULL is assigned to task-sc twice: before and after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded with session-lock, so multiple NULL

Re: [PATCH] scsi_lib: Set the device state from transport-offline to running

On Aug 9, 2012, at 3:51 AM, vikas.chaudh...@qlogic.com wrote: From: Vikas Chaudhary vikas.chaudh...@qlogic.com FC and iSCSI class set SCSI devices to transport-offline state after fast_io_fail/replacement_timeout has fired, but after relogin, function scsi_internal_device_unblock() is not